Re: Add better detection of if a command is not going to complete

2009-05-20 Thread Mike Christie
Mike Christie wrote: > Mike Christie wrote: >> Hey Hannes, >> >> This will not fix any hangs after the scsi eh or iscsi eh has fired, but >> I think this patch will help prevent the scsi eh from firing when we do >> not need it to like you have seen in some bugzillas. The patch was made >> over

Re: Add better detection of if a command is not going to complete

2009-05-19 Thread Mike Christie
Mike Christie wrote: > Hey Hannes, > > This will not fix any hangs after the scsi eh or iscsi eh has fired, but > I think this patch will help prevent the scsi eh from firing when we do > not need it to like you have seen in some bugzillas. The patch was made > over the my iscsi tree. It should

Re: Add better detection of if a command is not going to complete

2009-05-19 Thread Mike Christie
Mike Christie wrote: > Hey Hannes, > > This will not fix any hangs after the scsi eh or iscsi eh has fired, but > I think this patch will help prevent the scsi eh from firing when we do > not need it to like you have seen in some bugzillas. The patch was made > over the my iscsi tree. It shoul

Re: Add better detection of if a command is not going to complete

2009-05-19 Thread Mike Christie
Oh yeah, Erez, This will fix the issue we saw yesterday. Did you want me to port this for you to test? I think we will end up with the same result, because I am still making sure the transport is good before letting the scsi eh run. So if the nop still times out, we end up dropping the session