Re: bnx2i driver branches

[Mike Christie]

Mike Christie wrote:
 Hey Broadcom guys and iscsi list,
 
 I put up all my changes to the bnx2i driver in the bnx2i branches of the 
 open-iscsi git tree and linux-2.6-iscsi.
 
 It hooks bnx2i into the iscsi layers like how iser and iscsi_tcp is, 
 except that it allocates a scsi_host per net device instead of per session.
 
 The code is only compile tested, and I am sure it is very broken because 
 lot of code changed:
 
   bnx2i.h   |  272 --
   bnx2i_hwi.c   |  930 +++---
   bnx2i_init.c  |   15
   bnx2i_iscsi.c | 2365 
 +++---
   4 files changed, 947 insertions(+), 2635 deletions(-)
 
 There are also lots of TODO items in the code. Grep for TODO and/or mnc 
 for review comments mixed into the code, and check out the git commits 
 for some more todo items.
 

Oh yeah if you see todo items in the libiscsi code, do not worry about 
it. I want to do some things like merge the mtask and ctask structs and 
their xmit and init paths and then merge that with the send pdu callout, 
so there is just one transfer path and one task struct, but I have been 
wanting to do that for a long time and that cleanup does not have 
anything to do with bnx2i's inclusion - it would just make the drivers 
nicer. Just stick the bxn2i items.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---

Re: bnx2i driver branches

[Mike Christie]

Anil Veerabhadrappa wrote:
 On Thu, 2008-01-10 at 14:41 -0600, Mike Christie wrote:
 Anil Veerabhadrappa wrote:
 On Thu, 2008-01-10 at 07:22 -0600, Mike Christie wrote:
 Hey Broadcom guys and iscsi list,

 I put up all my changes to the bnx2i driver in the bnx2i branches of the 
 open-iscsi git tree and linux-2.6-iscsi.
 Thanks Mike

 It hooks bnx2i into the iscsi layers like how iser and iscsi_tcp is, 
 except that it allocates a scsi_host per net device instead of per session.

 The code is only compile tested, and I am sure it is very broken because 
 lot of code changed:
 got following error messages while trying to test this, any idea?

 - log start -

 iscsiadm: Could not read /sys/class/scsi_host/host3/proc_name rc 22.
 iscsiadm: Could not read /sys/class/scsi_host/host4/proc_name rc 22.
 iscsiadm: Could not read /sys/class/scsi_host/host5/proc_name rc 22.
 Come man, time to put on your super hero debugging cap on. When I said I 
 am sure it is broken I really meant that it is horribly broken :)
 Reported error was seen during iscsi discovery session, thought it have
 nothing to do with bnx2i related changes. iSCSI discovery  initial
 connection setup works fine with the Dec 17, 2007 snapshot of bnx2i
 branch.
 
 
 This error normally happens, when something goes completely screwy and 
 you end up with partially created or partially destroyed kernel sessions 
 or connections.
 
  iSCSI discovery session does not involve any kernel sessions or am I
 missing something?
 

Yeah, that is right.  I do not know off the top of my head.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---