[PATCH v3 27/56] scsi: fix some kernel-doc markups
Some identifiers have different names between their prototypes and the kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- drivers/scsi/iscsi_tcp.c | 4 ++-- drivers/scsi/libiscsi.c | 2 +- drivers/scsi/scsi_devinfo.c | 3 ++- drivers/scsi/scsi_lib.c | 6 +++--- drivers/scsi/scsi_transport_fc.c | 2 +- 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index df47557a02a3..a9ce6298b935 100644 --- a/drivers/scsi/iscsi_tcp.c +++ b/drivers/scsi/iscsi_tcp.c @@ -180,7 +180,7 @@ static void iscsi_sw_tcp_state_change(struct sock *sk) } /** - * iscsi_write_space - Called when more output buffer space is available + * iscsi_sw_tcp_write_space - Called when more output buffer space is available * @sk: socket space is available for **/ static void iscsi_sw_tcp_write_space(struct sock *sk) @@ -353,7 +353,7 @@ static int iscsi_sw_tcp_xmit(struct iscsi_conn *conn) } /** - * iscsi_tcp_xmit_qlen - return the number of bytes queued for xmit + * iscsi_sw_tcp_xmit_qlen - return the number of bytes queued for xmit * @conn: iscsi connection */ static inline int iscsi_sw_tcp_xmit_qlen(struct iscsi_conn *conn) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 1e9c3171fa9f..8a4552f09dfe 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -777,7 +777,7 @@ int iscsi_conn_send_pdu(struct iscsi_cls_conn *cls_conn, struct iscsi_hdr *hdr, EXPORT_SYMBOL_GPL(iscsi_conn_send_pdu); /** - * iscsi_cmd_rsp - SCSI Command Response processing + * iscsi_scsi_cmd_rsp - SCSI Command Response processing * @conn: iscsi connection * @hdr: iscsi header * @task: scsi command task diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index ba84244c1b4f..d92cec12454c 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/drivers/scsi/scsi_devinfo.c @@ -559,7 +559,8 @@ static int scsi_dev_info_list_add_str(char *dev_list) } /** - * get_device_flags - get device specific flags from the dynamic device list. + * scsi_get_device_flags - get device specific flags from the dynamic + * device list. * @sdev: &scsi_device to get flags for * @vendor:vendor name * @model: model name diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 97ff31ed2a44..f74db5160f23 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1502,7 +1502,7 @@ static void scsi_softirq_done(struct request *rq) } /** - * scsi_dispatch_command - Dispatch a command to the low-level driver. + * scsi_dispatch_cmd - Dispatch a command to the low-level driver. * @cmd: command block we are dispatching. * * Return: nonzero return request was rejected and device's queue needs to be @@ -2364,7 +2364,7 @@ scsi_device_set_state(struct scsi_device *sdev, enum scsi_device_state state) EXPORT_SYMBOL(scsi_device_set_state); /** - * sdev_evt_emit - emit a single SCSI device uevent + * scsi_evt_emit - emit a single SCSI device uevent * @sdev: associated SCSI device * @evt: event to emit * @@ -2412,7 +2412,7 @@ static void scsi_evt_emit(struct scsi_device *sdev, struct scsi_event *evt) } /** - * sdev_evt_thread - send a uevent for each scsi event + * scsi_evt_thread - send a uevent for each scsi event * @work: work struct for scsi_device * * Dispatch queued events to their associated scsi_device kobjects diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c index 2ff7f06203da..42a6dd3bd19f 100644 --- a/drivers/scsi/scsi_transport_fc.c +++ b/drivers/scsi/scsi_transport_fc.c @@ -629,7 +629,7 @@ fc_host_post_vendor_event(struct Scsi_Host *shost, u32 event_number, EXPORT_SYMBOL(fc_host_post_vendor_event); /** - * fc_host_rcv_fpin - routine to process a received FPIN. + * fc_host_fpin_rcv - routine to process a received FPIN. * @shost: host the FPIN was received on * @fpin_len: length of FPIN payload, in bytes * @fpin_buf: pointer to FPIN payload -- 2.26.2 -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/8ed7f149f25a363eea76e514c253c4e337c59379.1603469755.git.mchehab%2Bhuawei%40kernel.org.
Re: [PATCH v3 27/56] scsi: fix some kernel-doc markups
Mauro, > Some identifiers have different names between their prototypes and the > kernel-doc markup. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/yq11rhk5t7e.fsf%40ca-mkp.ca.oracle.com.
Re: RFC: Doc: FLASH DDB Management using iscsiadm
From: Mike Christie mailto:micha...@cs.wisc.edu>> Date: Friday 12 October 2012 9:28 AM To: "open-iscsi@googlegroups.com<mailto:open-iscsi@googlegroups.com>" mailto:open-iscsi@googlegroups.com>> Cc: Ravi Anand mailto:ravi.an...@qlogic.com>>, Vikas mailto:vikas.chaudh...@qlogic.com>>, Manish Rangankar mailto:manish.rangan...@qlogic.com>> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm On Oct 11, 2012, at 6:26 AM, lalit.chandiv...@qlogic.com<mailto:lalit.chandiv...@qlogic.com> wrote: On Wednesday, October 10, 2012 8:05:47 AM UTC+5:30, Mike Christie wrote: On Oct 1, 2012, at 5:31 AM, Lalit Chandivade > wrote: > > >> -Original Message- >> From: Mike Christie [mailto:mich...@cs.wisc.edu] >> Sent: Tuesday, August 07, 2012 10:25 PM >> To: open-...@googlegroups.com >> Cc: Lalit Chandivade; Ravi Anand; Vikas Chaudhary; Manish Rangankar >> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm >> >> On 08/06/2012 06:27 AM, Lalit Chandivade wrote: >>> >>> >>>> -Original Message- >>>> From: Mike Christie [mailto:mich...@cs.wisc.edu] >>>> Sent: Friday, August 03, 2012 2:03 PM >>>> To: Lalit Chandivade >>>> Cc: open-...@googlegroups.com; Ravi Anand; Vikas Chaudhary; >>>> Manish >>>> Rangankar >>>> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm >>>> >>>> On 07/12/2012 05:37 PM, Lalit Chandivade wrote: >>>>> Hi Mike, >>>>> >>>>> We want to work on this solution that would enable qla4xxx users to >>>> manage the DDBs in FLASH and migrate the entries from FLASH to user >>>> space. >>>>> >>>>> Here is our initial thought, please review and let us know your feedback. >>>>> >>>> >>>> This sounds ok to me. Just some minor comments/questions that I am >>>> guessing you just glossed over to make it easier to understand. >>>> >>>> >>>>> Add support for FLASH DDB management in iscsiadm >>>>> = >>>>> >>>>> 1. Export normal target entries to /sys/class/iscsi_session from >>>>> FLASH when the driver comes up >>>>> /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index >>>>> 1 >>>>> /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index >>>>> 2 >>>>> /sys/class/iscsi_session/session4 <- for target at index 3 in the >>>>> RAM DDB >>>>> Note: This will need changes in the driver >>>> >>>> Are you are going to add a file on the session to indicate if it's >>>> flash or not or how can we tell? >>> >>> We already have the "creator" to differentiate. >>> /sys/class/iscsi_session/session1/creator >>> >>> Also we are thinking if we should add the FLASH DDBs under >>> /sys/firmware, something like >>> >>> /sys/firmware/iscsi_offload/host0/ >>> |-->iscsi_target/tgt0 >>> |-->iscsi_target/tgt0/iqn >>> |-->iscsi_target/tgt0/ip >>> |-->iscsi_target/tgt0/port >>> >>> As this will clearly distinguish between FLASH DDBs and user created node >> records. >>> >> >> This seems ok. > > Mike, > > After doing some initial work on this we have come up with following > directory structure and iscsiadm operations to manage the targets stored in > the HBAs flash. > Please review and let us know your comments. > > Display in Sysfs: > == > /sys/firmware/iscsi_offload/host1/new > /sys/firmware/iscsi_offload/host1/delete > /sys/firmware/iscsi_offload/host1/tgt0/logout > /sys/firmware/iscsi_offload/host1/tgt0/login > /sys/firmware/iscsi_offload/host1/tgt0/apply > /sys/firmware/iscsi_offload/host1/tgt0/ > > > Example: > /sys/firmware/iscsi_offload/host7/tgt1/address > /sys/firmware/iscsi_offload/host7/tgt1/default_time2retain > /sys/firmware/iscsi_offload/host7/tgt1/default_time2wait > /sys/firmware/iscsi_offload/host7/tgt1/firmware_cmd_timeout > /sys/firmware/iscsi_offload/host7/tgt1/first_burst_length > /sys/firmware/iscsi_offload/host7/tgt1/ipaddress > /sys/firmware/iscsi_offload/host7/tgt1/ip_options > /sys/firmware/iscsi_offload/host7/tgt1/iscsi_alias > /sys/firmware/iscsi_offload/host7/tgt1/iscsi_opti
Re: RFC: Doc: FLASH DDB Management using iscsiadm
On Oct 11, 2012, at 6:26 AM, lalit.chandiv...@qlogic.com wrote: > > > On Wednesday, October 10, 2012 8:05:47 AM UTC+5:30, Mike Christie wrote: > > On Oct 1, 2012, at 5:31 AM, Lalit Chandivade wrote: > > > > > > >> -Original Message- > >> From: Mike Christie [mailto:mich...@cs.wisc.edu] > >> Sent: Tuesday, August 07, 2012 10:25 PM > >> To: open-...@googlegroups.com > >> Cc: Lalit Chandivade; Ravi Anand; Vikas Chaudhary; Manish Rangankar > >> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > >> > >> On 08/06/2012 06:27 AM, Lalit Chandivade wrote: > >>> > >>> > >>>> -Original Message- > >>>> From: Mike Christie [mailto:mich...@cs.wisc.edu] > >>>> Sent: Friday, August 03, 2012 2:03 PM > >>>> To: Lalit Chandivade > >>>> Cc: open-...@googlegroups.com; Ravi Anand; Vikas Chaudhary; Manish > >>>> Rangankar > >>>> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > >>>> > >>>> On 07/12/2012 05:37 PM, Lalit Chandivade wrote: > >>>>> Hi Mike, > >>>>> > >>>>> We want to work on this solution that would enable qla4xxx users to > >>>> manage the DDBs in FLASH and migrate the entries from FLASH to user > >>>> space. > >>>>> > >>>>> Here is our initial thought, please review and let us know your > >>>>> feedback. > >>>>> > >>>> > >>>> This sounds ok to me. Just some minor comments/questions that I am > >>>> guessing you just glossed over to make it easier to understand. > >>>> > >>>> > >>>>> Add support for FLASH DDB management in iscsiadm > >>>>> = > >>>>> > >>>>> 1. Export normal target entries to /sys/class/iscsi_session from > >>>>> FLASH when the driver comes up > >>>>> /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index > >>>>> 1 > >>>>> /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index > >>>>> 2 > >>>>> /sys/class/iscsi_session/session4 <- for target at index 3 in the > >>>>> RAM DDB > >>>>> Note: This will need changes in the driver > >>>> > >>>> Are you are going to add a file on the session to indicate if it's > >>>> flash or not or how can we tell? > >>> > >>> We already have the "creator" to differentiate. > >>> /sys/class/iscsi_session/session1/creator > >>> > >>> Also we are thinking if we should add the FLASH DDBs under > >>> /sys/firmware, something like > >>> > >>> /sys/firmware/iscsi_offload/host0/ > >>> |-->iscsi_target/tgt0 > >>> |-->iscsi_target/tgt0/iqn > >>> |-->iscsi_target/tgt0/ip > >>> |-->iscsi_target/tgt0/port > >>> > >>> As this will clearly distinguish between FLASH DDBs and user created node > >> records. > >>> > >> > >> This seems ok. > > > > Mike, > > > > After doing some initial work on this we have come up with following > > directory structure and iscsiadm operations to manage the targets stored in > > the HBAs flash. > > Please review and let us know your comments. > > > > Display in Sysfs: > > == > > /sys/firmware/iscsi_offload/host1/new > > /sys/firmware/iscsi_offload/host1/delete > > /sys/firmware/iscsi_offload/host1/tgt0/logout > > /sys/firmware/iscsi_offload/host1/tgt0/login > > /sys/firmware/iscsi_offload/host1/tgt0/apply > > /sys/firmware/iscsi_offload/host1/tgt0/ > > > > > > Example: > > /sys/firmware/iscsi_offload/host7/tgt1/address > > /sys/firmware/iscsi_offload/host7/tgt1/default_time2retain > > /sys/firmware/iscsi_offload/host7/tgt1/default_time2wait > > /sys/firmware/iscsi_offload/host7/tgt1/firmware_cmd_timeout > > /sys/firmware/iscsi_offload/host7/tgt1/first_burst_length > > /sys/firmware/iscsi_offload/host7/tgt1/ipaddress > > /sys/firmware/iscsi_offload/host7/tgt1/ip_options > >
Re: RFC: Doc: FLASH DDB Management using iscsiadm
On Wednesday, October 10, 2012 8:05:47 AM UTC+5:30, Mike Christie wrote: > > > On Oct 1, 2012, at 5:31 AM, Lalit Chandivade > > > wrote: > > > > > > >> -Original Message- > >> From: Mike Christie [mailto:mich...@cs.wisc.edu ] > >> Sent: Tuesday, August 07, 2012 10:25 PM > >> To: open-...@googlegroups.com > >> Cc: Lalit Chandivade; Ravi Anand; Vikas Chaudhary; Manish Rangankar > >> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > >> > >> On 08/06/2012 06:27 AM, Lalit Chandivade wrote: > >>> > >>> > >>>> -Original Message- > >>>> From: Mike Christie [mailto:mich...@cs.wisc.edu ] > >>>> Sent: Friday, August 03, 2012 2:03 PM > >>>> To: Lalit Chandivade > >>>> Cc: open-...@googlegroups.com ; Ravi Anand; Vikas > Chaudhary; Manish > >>>> Rangankar > >>>> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > >>>> > >>>> On 07/12/2012 05:37 PM, Lalit Chandivade wrote: > >>>>> Hi Mike, > >>>>> > >>>>> We want to work on this solution that would enable qla4xxx users to > >>>> manage the DDBs in FLASH and migrate the entries from FLASH to user > >>>> space. > >>>>> > >>>>> Here is our initial thought, please review and let us know your > feedback. > >>>>> > >>>> > >>>> This sounds ok to me. Just some minor comments/questions that I am > >>>> guessing you just glossed over to make it easier to understand. > >>>> > >>>> > >>>>> Add support for FLASH DDB management in iscsiadm > >>>>> = > >>>>> > >>>>> 1. Export normal target entries to /sys/class/iscsi_session from > >>>>> FLASH when the driver comes up > >>>>> /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index > >>>>> 1 > >>>>> /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index > >>>>> 2 > >>>>> /sys/class/iscsi_session/session4 <- for target at index 3 in the > >>>>> RAM DDB > >>>>> Note: This will need changes in the driver > >>>> > >>>> Are you are going to add a file on the session to indicate if it's > >>>> flash or not or how can we tell? > >>> > >>> We already have the "creator" to differentiate. > >>> /sys/class/iscsi_session/session1/creator > >>> > >>> Also we are thinking if we should add the FLASH DDBs under > >>> /sys/firmware, something like > >>> > >>> /sys/firmware/iscsi_offload/host0/ > >>> |-->iscsi_target/tgt0 > >>> |-->iscsi_target/tgt0/iqn > >>> |-->iscsi_target/tgt0/ip > >>> |-->iscsi_target/tgt0/port > >>> > >>> As this will clearly distinguish between FLASH DDBs and user created > node > >> records. > >>> > >> > >> This seems ok. > > > > Mike, > > > > After doing some initial work on this we have come up with following > directory structure and iscsiadm operations to manage the targets stored in > the HBAs flash. > > Please review and let us know your comments. > > > > Display in Sysfs: > > == > > /sys/firmware/iscsi_offload/host1/new > > /sys/firmware/iscsi_offload/host1/delete > > /sys/firmware/iscsi_offload/host1/tgt0/logout > > /sys/firmware/iscsi_offload/host1/tgt0/login > > /sys/firmware/iscsi_offload/host1/tgt0/apply > > /sys/firmware/iscsi_offload/host1/tgt0/ > > > > > > Example: > > /sys/firmware/iscsi_offload/host7/tgt1/address > > /sys/firmware/iscsi_offload/host7/tgt1/default_time2retain > > /sys/firmware/iscsi_offload/host7/tgt1/default_time2wait > > /sys/firmware/iscsi_offload/host7/tgt1/firmware_cmd_timeout > > /sys/firmware/iscsi_offload/host7/tgt1/first_burst_length > > /sys/firmware/iscsi_offload/host7/tgt1/ipaddress > > /sys/firmware/iscsi_offload/host7/tgt1/ip_options > > /sys/firmware/iscsi_offload/host7/tgt1/iscsi_alias > > /sys/firmware/is
Re: RFC: Doc: FLASH DDB Management using iscsiadm
On Oct 1, 2012, at 5:31 AM, Lalit Chandivade wrote: > > >> -Original Message- >> From: Mike Christie [mailto:micha...@cs.wisc.edu] >> Sent: Tuesday, August 07, 2012 10:25 PM >> To: open-iscsi@googlegroups.com >> Cc: Lalit Chandivade; Ravi Anand; Vikas Chaudhary; Manish Rangankar >> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm >> >> On 08/06/2012 06:27 AM, Lalit Chandivade wrote: >>> >>> >>>> -Original Message- >>>> From: Mike Christie [mailto:micha...@cs.wisc.edu] >>>> Sent: Friday, August 03, 2012 2:03 PM >>>> To: Lalit Chandivade >>>> Cc: open-iscsi@googlegroups.com; Ravi Anand; Vikas Chaudhary; Manish >>>> Rangankar >>>> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm >>>> >>>> On 07/12/2012 05:37 PM, Lalit Chandivade wrote: >>>>> Hi Mike, >>>>> >>>>> We want to work on this solution that would enable qla4xxx users to >>>> manage the DDBs in FLASH and migrate the entries from FLASH to user >>>> space. >>>>> >>>>> Here is our initial thought, please review and let us know your feedback. >>>>> >>>> >>>> This sounds ok to me. Just some minor comments/questions that I am >>>> guessing you just glossed over to make it easier to understand. >>>> >>>> >>>>> Add support for FLASH DDB management in iscsiadm >>>>> = >>>>> >>>>> 1. Export normal target entries to /sys/class/iscsi_session from >>>>> FLASH when the driver comes up >>>>> /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index >>>>> 1 >>>>> /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index >>>>> 2 >>>>> /sys/class/iscsi_session/session4 <- for target at index 3 in the >>>>> RAM DDB >>>>> Note: This will need changes in the driver >>>> >>>> Are you are going to add a file on the session to indicate if it's >>>> flash or not or how can we tell? >>> >>> We already have the "creator" to differentiate. >>> /sys/class/iscsi_session/session1/creator >>> >>> Also we are thinking if we should add the FLASH DDBs under >>> /sys/firmware, something like >>> >>> /sys/firmware/iscsi_offload/host0/ >>> |-->iscsi_target/tgt0 >>> |-->iscsi_target/tgt0/iqn >>> |-->iscsi_target/tgt0/ip >>> |-->iscsi_target/tgt0/port >>> >>> As this will clearly distinguish between FLASH DDBs and user created node >> records. >>> >> >> This seems ok. > > Mike, > > After doing some initial work on this we have come up with following > directory structure and iscsiadm operations to manage the targets stored in > the HBAs flash. > Please review and let us know your comments. > > Display in Sysfs: > == > /sys/firmware/iscsi_offload/host1/new > /sys/firmware/iscsi_offload/host1/delete > /sys/firmware/iscsi_offload/host1/tgt0/logout > /sys/firmware/iscsi_offload/host1/tgt0/login > /sys/firmware/iscsi_offload/host1/tgt0/apply > /sys/firmware/iscsi_offload/host1/tgt0/ > > > Example: > /sys/firmware/iscsi_offload/host7/tgt1/address > /sys/firmware/iscsi_offload/host7/tgt1/default_time2retain > /sys/firmware/iscsi_offload/host7/tgt1/default_time2wait > /sys/firmware/iscsi_offload/host7/tgt1/firmware_cmd_timeout > /sys/firmware/iscsi_offload/host7/tgt1/first_burst_length > /sys/firmware/iscsi_offload/host7/tgt1/ipaddress > /sys/firmware/iscsi_offload/host7/tgt1/ip_options > /sys/firmware/iscsi_offload/host7/tgt1/iscsi_alias > /sys/firmware/iscsi_offload/host7/tgt1/iscsi_options > /sys/firmware/iscsi_offload/host7/tgt1/isid > /sys/firmware/iscsi_offload/host7/tgt1/is_persistent > /sys/firmware/iscsi_offload/host7/tgt1/login > /sys/firmware/iscsi_offload/host7/tgt1/logout > /sys/firmware/iscsi_offload/host7/tgt1/max_burst_length > /sys/firmware/iscsi_offload/host7/tgt1/max_outstanding_r2t > /sys/firmware/iscsi_offload/host7/tgt1/max_recv_data_segment_length > /sys/firmware/iscsi_offload/host7/tgt1/max_xmit_data_segment_length > /sys/firmware/iscsi_offload/host7/tgt1/name > /sys/firmware/iscsi_offload/host7/tgt1/noop_out_interval > /sys/firmware/iscsi_offloa
RE: RFC: Doc: FLASH DDB Management using iscsiadm
> -Original Message- > From: Mike Christie [mailto:micha...@cs.wisc.edu] > Sent: Tuesday, August 07, 2012 10:25 PM > To: open-iscsi@googlegroups.com > Cc: Lalit Chandivade; Ravi Anand; Vikas Chaudhary; Manish Rangankar > Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > > On 08/06/2012 06:27 AM, Lalit Chandivade wrote: > > > > > >> -Original Message- > >> From: Mike Christie [mailto:micha...@cs.wisc.edu] > >> Sent: Friday, August 03, 2012 2:03 PM > >> To: Lalit Chandivade > >> Cc: open-iscsi@googlegroups.com; Ravi Anand; Vikas Chaudhary; Manish > >> Rangankar > >> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > >> > >> On 07/12/2012 05:37 PM, Lalit Chandivade wrote: > >>> Hi Mike, > >>> > >>> We want to work on this solution that would enable qla4xxx users to > >> manage the DDBs in FLASH and migrate the entries from FLASH to user > >> space. > >>> > >>> Here is our initial thought, please review and let us know your feedback. > >>> > >> > >> This sounds ok to me. Just some minor comments/questions that I am > >> guessing you just glossed over to make it easier to understand. > >> > >> > >>> Add support for FLASH DDB management in iscsiadm > >>> = > >>> > >>> 1. Export normal target entries to /sys/class/iscsi_session from > >>> FLASH when the driver comes up > >>> /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index > >>> 1 > >>> /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index > >>> 2 > >>> /sys/class/iscsi_session/session4 <- for target at index 3 in the > >>> RAM DDB > >>> Note: This will need changes in the driver > >> > >> Are you are going to add a file on the session to indicate if it's > >> flash or not or how can we tell? > > > > We already have the "creator" to differentiate. > > /sys/class/iscsi_session/session1/creator > > > > Also we are thinking if we should add the FLASH DDBs under > > /sys/firmware, something like > > > > /sys/firmware/iscsi_offload/host0/ > > |-->iscsi_target/tgt0 > > |-->iscsi_target/tgt0/iqn > > |-->iscsi_target/tgt0/ip > > |-->iscsi_target/tgt0/port > > > > As this will clearly distinguish between FLASH DDBs and user created node > records. > > > > This seems ok. Mike, After doing some initial work on this we have come up with following directory structure and iscsiadm operations to manage the targets stored in the HBAs flash. Please review and let us know your comments. Display in Sysfs: == /sys/firmware/iscsi_offload/host1/new /sys/firmware/iscsi_offload/host1/delete /sys/firmware/iscsi_offload/host1/tgt0/logout /sys/firmware/iscsi_offload/host1/tgt0/login /sys/firmware/iscsi_offload/host1/tgt0/apply /sys/firmware/iscsi_offload/host1/tgt0/ Example: /sys/firmware/iscsi_offload/host7/tgt1/address /sys/firmware/iscsi_offload/host7/tgt1/default_time2retain /sys/firmware/iscsi_offload/host7/tgt1/default_time2wait /sys/firmware/iscsi_offload/host7/tgt1/firmware_cmd_timeout /sys/firmware/iscsi_offload/host7/tgt1/first_burst_length /sys/firmware/iscsi_offload/host7/tgt1/ipaddress /sys/firmware/iscsi_offload/host7/tgt1/ip_options /sys/firmware/iscsi_offload/host7/tgt1/iscsi_alias /sys/firmware/iscsi_offload/host7/tgt1/iscsi_options /sys/firmware/iscsi_offload/host7/tgt1/isid /sys/firmware/iscsi_offload/host7/tgt1/is_persistent /sys/firmware/iscsi_offload/host7/tgt1/login /sys/firmware/iscsi_offload/host7/tgt1/logout /sys/firmware/iscsi_offload/host7/tgt1/max_burst_length /sys/firmware/iscsi_offload/host7/tgt1/max_outstanding_r2t /sys/firmware/iscsi_offload/host7/tgt1/max_recv_data_segment_length /sys/firmware/iscsi_offload/host7/tgt1/max_xmit_data_segment_length /sys/firmware/iscsi_offload/host7/tgt1/name /sys/firmware/iscsi_offload/host7/tgt1/noop_out_interval /sys/firmware/iscsi_offload/host7/tgt1/port /sys/firmware/iscsi_offload/host7/tgt1/target_options /sys/firmware/iscsi_offload/host7/tgt1/tcp_options /sys/firmware/iscsi_offload/host7/tgt1/tpgt /sys/firmware/iscsi_offload/host7/tgt1/tsid Operations using iscsiadm: = List all targets stored in the FLASH of the HBA # iscsiadm -m host -H hostno -C target -o show qla4xxx: [0] 192.168.1.12:3260,2 iqn.1992-04.com.emc:cx.ckm00101200392.b2 qla4xxx: [1] 192.168.1.12:3260,2 << S
Re: RFC: Doc: FLASH DDB Management using iscsiadm
On 08/06/2012 06:27 AM, Lalit Chandivade wrote: > > >> -Original Message- >> From: Mike Christie [mailto:micha...@cs.wisc.edu] >> Sent: Friday, August 03, 2012 2:03 PM >> To: Lalit Chandivade >> Cc: open-iscsi@googlegroups.com; Ravi Anand; Vikas Chaudhary; Manish >> Rangankar >> Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm >> >> On 07/12/2012 05:37 PM, Lalit Chandivade wrote: >>> Hi Mike, >>> >>> We want to work on this solution that would enable qla4xxx users to >> manage the DDBs in FLASH and migrate the entries from FLASH to user >> space. >>> >>> Here is our initial thought, please review and let us know your feedback. >>> >> >> This sounds ok to me. Just some minor comments/questions that I am >> guessing you just glossed over to make it easier to understand. >> >> >>> Add support for FLASH DDB management in iscsiadm >>> = >>> >>> 1. Export normal target entries to /sys/class/iscsi_session from FLASH >>> when the driver comes up >>> /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index 1 >>> /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index 2 >>> /sys/class/iscsi_session/session4 <- for target at index 3 in the RAM >>> DDB >>> Note: This will need changes in the driver >> >> Are you are going to add a file on the session to indicate if it's flash or >> not or >> how can we tell? > > We already have the "creator" to differentiate. > /sys/class/iscsi_session/session1/creator > > Also we are thinking if we should add the FLASH DDBs under > /sys/firmware, something like > > /sys/firmware/iscsi_offload/host0/ > |-->iscsi_target/tgt0 > |-->iscsi_target/tgt0/iqn > |-->iscsi_target/tgt0/ip > |-->iscsi_target/tgt0/port > > As this will clearly distinguish between FLASH DDBs and user created node > records. > This seems ok. >> >> >>> >>> 2. Export sendtarget entries to /sys/firmware >>> /sys/firmware/send_targets/host0 >>> /sys/firmware/send_targets/host0/target0 >> >> I would name it send_targets, but yeah seems fine. > Would or would not? > Would. I think I misread it the first time and thought it only said targets. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
RE: RFC: Doc: FLASH DDB Management using iscsiadm
> -Original Message- > From: Mike Christie [mailto:micha...@cs.wisc.edu] > Sent: Friday, August 03, 2012 2:03 PM > To: Lalit Chandivade > Cc: open-iscsi@googlegroups.com; Ravi Anand; Vikas Chaudhary; Manish > Rangankar > Subject: Re: RFC: Doc: FLASH DDB Management using iscsiadm > > On 07/12/2012 05:37 PM, Lalit Chandivade wrote: > > Hi Mike, > > > > We want to work on this solution that would enable qla4xxx users to > manage the DDBs in FLASH and migrate the entries from FLASH to user > space. > > > > Here is our initial thought, please review and let us know your feedback. > > > > This sounds ok to me. Just some minor comments/questions that I am > guessing you just glossed over to make it easier to understand. > > > > Add support for FLASH DDB management in iscsiadm > > = > > > > 1. Export normal target entries to /sys/class/iscsi_session from FLASH > > when the driver comes up > > /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index 1 > > /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index 2 > > /sys/class/iscsi_session/session4 <- for target at index 3 in the RAM > > DDB > > Note: This will need changes in the driver > > Are you are going to add a file on the session to indicate if it's flash or > not or > how can we tell? We already have the "creator" to differentiate. /sys/class/iscsi_session/session1/creator Also we are thinking if we should add the FLASH DDBs under /sys/firmware, something like /sys/firmware/iscsi_offload/host0/ |-->iscsi_target/tgt0 |-->iscsi_target/tgt0/iqn |-->iscsi_target/tgt0/ip |-->iscsi_target/tgt0/port As this will clearly distinguish between FLASH DDBs and user created node records. > > > > > > 2. Export sendtarget entries to /sys/firmware > > /sys/firmware/send_targets/host0 > > /sys/firmware/send_targets/host0/target0 > > I would name it send_targets, but yeah seems fine. Would or would not? This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: RFC: Doc: FLASH DDB Management using iscsiadm
On 07/12/2012 05:37 PM, Lalit Chandivade wrote: > Hi Mike, > > We want to work on this solution that would enable qla4xxx users to manage > the DDBs in FLASH and migrate the entries from FLASH to user space. > > Here is our initial thought, please review and let us know your feedback. > This sounds ok to me. Just some minor comments/questions that I am guessing you just glossed over to make it easier to understand. > Add support for FLASH DDB management in iscsiadm > = > > 1. Export normal target entries to /sys/class/iscsi_session from FLASH when > the driver comes up > /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index 1 > /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index 2 > /sys/class/iscsi_session/session4 <- for target at index 3 in the RAM DDB > Note: This will need changes in the driver Are you are going to add a file on the session to indicate if it's flash or not or how can we tell? > > 2. Export sendtarget entries to /sys/firmware > /sys/firmware/send_targets/host0 > /sys/firmware/send_targets/host0/target0 I would name it send_targets, but yeah seems fine. > /sys/firmware/send_targets/host0/target0/ip_address > /sys/firmware/send_targets/host0/target0/port > /sys/firmware/send_targets/host0/target0/ > Note: This will need changes in the driver > > 3. Now in user space tools we will have to travers the /sys directories when > user wants to display the node records or discoverydb records. On running the > command actual node records or discovery db records will also get created in > user space. > > # iscsiadm -m node (for offload iface, need to go through syfs sessions ) > qla4xxx: [106] 192.168.1.11:3260,1 iqn.1992-04.com.emc:cx.ckm00101200392.a2 > (Flash) > qla4xxx: [107] 192.168.1.8:3260,3 iqn.1992-04.com.emc:cx.ckm00101200392.a3 > (Flash) > qla4xxx: [108] 192.168.1.12:3260,2 iqn.1992-04.com.emc:cx.ckm00101200392.b2 > qla4xxx: [109] 192.168.1.9:3260,4 iqn.1992-04.com.emc:cx.ckm00101200392.b3 > > Note, we will append the node listing with "(Flash)" if its from the FLASH > DDB. > > # iscsiadm -m discoverydb > 192.168.1.11:3260 via sendtargets (Flash) > 192.168.1.175:3260 via sendtargets > > Now since we have the node records and discovery records equivalent to the > entries in FLASH user can use iscsiadm command to do login, logout and > discovery to records in FLASH. > > 4. To update a node record user can update the user space node record and > then commit it to the FLASH > # iscsiadm -m node -o update > # iscsiadm -m node -o apply (commit to flash, valid for > offload node) > > 5. We can also introduce new options to iscsiadm to migrate the FLASH records > to open-iscsi database > # iscsiadm -m node -o [migrate | migrateall] offload node> > # iscsiadm -m discoverydb -o [migrate | migrateall] for offload discoverydb> > Seems ok. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
RFC: Doc: FLASH DDB Management using iscsiadm
Hi Mike, We want to work on this solution that would enable qla4xxx users to manage the DDBs in FLASH and migrate the entries from FLASH to user space. Here is our initial thought, please review and let us know your feedback. Add support for FLASH DDB management in iscsiadm 1. Export normal target entries to /sys/class/iscsi_session from FLASH when the driver comes up /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index 1 /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index 2 /sys/class/iscsi_session/session4 <- for target at index 3 in the RAM DDB Note: This will need changes in the driver 2. Export sendtarget entries to /sys/firmware /sys/firmware/send_targets/host0 /sys/firmware/send_targets/host0/target0 /sys/firmware/send_targets/host0/target0/ip_address /sys/firmware/send_targets/host0/target0/port /sys/firmware/send_targets/host0/target0/ Note: This will need changes in the driver 3. Now in user space tools we will have to travers the /sys directories when user wants to display the node records or discoverydb records. On running the command actual node records or discovery db records will also get created in user space. # iscsiadm –m node (for offload iface, need to go through syfs sessions ) qla4xxx: [106] 192.168.1.11:3260,1 iqn.1992-04.com.emc:cx.ckm00101200392.a2 (Flash) qla4xxx: [107] 192.168.1.8:3260,3 iqn.1992-04.com.emc:cx.ckm00101200392.a3 (Flash) qla4xxx: [108] 192.168.1.12:3260,2 iqn.1992-04.com.emc:cx.ckm00101200392.b2 qla4xxx: [109] 192.168.1.9:3260,4 iqn.1992-04.com.emc:cx.ckm00101200392.b3 Note, we will append the node listing with "(Flash)" if its from the FLASH DDB. # iscsiadm –m discoverydb 192.168.1.11:3260 via sendtargets (Flash) 192.168.1.175:3260 via sendtargets Now since we have the node records and discovery records equivalent to the entries in FLASH user can use iscsiadm command to do login, logout and discovery to records in FLASH. 4. To update a node record user can update the user space node record and then commit it to the FLASH # iscsiadm –m node -o update # iscsiadm –m node -o apply (commit to flash, valid for offload node) 5. We can also introduce new options to iscsiadm to migrate the FLASH records to open-iscsi database # iscsiadm –m node -o [migrate | migrateall] # iscsiadm –m discoverydb -o [migrate | migrateall] Thanks, Lalit. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To view this discussion on the web visit https://groups.google.com/d/msg/open-iscsi/-/zEdMEt6cD-UJ. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
RFC: Doc: FLASH DDB Management using iscsiadm
Hi Mike, We want to work on this solution that would enable qla4xxx users to manage the DDBs in FLASH and migrate the entries from FLASH to user space. Here is our initial thought, please review and let us know your feedback. Add support for FLASH DDB management in iscsiadm = 1. Export normal target entries to /sys/class/iscsi_session from FLASH when the driver comes up /sys/class/iscsi_session/session2 <- for the DDB at Flash DDB index 1 /sys/class/iscsi_session/session3 <- for the DDB at Flash DDB index 2 /sys/class/iscsi_session/session4 <- for target at index 3 in the RAM DDB Note: This will need changes in the driver 2. Export sendtarget entries to /sys/firmware /sys/firmware/send_targets/host0 /sys/firmware/send_targets/host0/target0 /sys/firmware/send_targets/host0/target0/ip_address /sys/firmware/send_targets/host0/target0/port /sys/firmware/send_targets/host0/target0/ Note: This will need changes in the driver 3. Now in user space tools we will have to travers the /sys directories when user wants to display the node records or discoverydb records. On running the command actual node records or discovery db records will also get created in user space. # iscsiadm -m node (for offload iface, need to go through syfs sessions ) qla4xxx: [106] 192.168.1.11:3260,1 iqn.1992-04.com.emc:cx.ckm00101200392.a2 (Flash) qla4xxx: [107] 192.168.1.8:3260,3 iqn.1992-04.com.emc:cx.ckm00101200392.a3 (Flash) qla4xxx: [108] 192.168.1.12:3260,2 iqn.1992-04.com.emc:cx.ckm00101200392.b2 qla4xxx: [109] 192.168.1.9:3260,4 iqn.1992-04.com.emc:cx.ckm00101200392.b3 Note, we will append the node listing with "(Flash)" if its from the FLASH DDB. # iscsiadm -m discoverydb 192.168.1.11:3260 via sendtargets (Flash) 192.168.1.175:3260 via sendtargets Now since we have the node records and discovery records equivalent to the entries in FLASH user can use iscsiadm command to do login, logout and discovery to records in FLASH. 4. To update a node record user can update the user space node record and then commit it to the FLASH # iscsiadm -m node -o update # iscsiadm -m node -o apply (commit to flash, valid for offload node) 5. We can also introduce new options to iscsiadm to migrate the FLASH records to open-iscsi database # iscsiadm -m node -o [migrate | migrateall] # iscsiadm -m discoverydb -o [migrate | migrateall] Thanks, Lalit. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: doc
on 16:37 Mon 07 Feb, joking (johannes.kin...@gmail.com) wrote: > Where is the doc describing the content of /etc/conf.d/iôpen-iscsi ? What OS/distro are you using? That would appear to be a Gentooism, in which case use of the Gentoo systems documentation would be appropriate. >From what I can find, files under /etc/conf.d/ are name-value assignment pairs, likely sourced by SysV init files at startup. http://www.gentoo.org/doc/en/handbook/handbook-x86.xml?part=2&chap=4 That said: I've not played with Gentoo other than trivially. -- Dr. Ed Morbius, Chief Scientist /| Robot Wrangler / Staff Psychologist| When you seek unlimited power Krell Power Systems Unlimited| Go to Krell! -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: doc
On 02/07/2011 06:37 PM, joking wrote: Where is the doc describing the content of /etc/conf.d/iôpen-iscsi ? There is no file like that from the upstream open-iscsi.org package, so it might be distro specific or a open-iscsi.org file moved. Attach the file and I can tell if it is ours. And let is know what distro this is. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
doc
Where is the doc describing the content of /etc/conf.d/iôpen-iscsi ? -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
