[jira] Commented: (OPENJPA-182) db2 update lock syntax WITH USE AND KEEP UPDATE LOCKS

2007-04-04 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486812 ] Craig Russell commented on OPENJPA-182: --- A use-case for the isolation level is to support different locking se

[jira] Commented: (OPENJPA-182) db2 update lock syntax WITH USE AND KEEP UPDATE LOCKS

2007-04-05 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486997 ] Craig Russell commented on OPENJPA-182: --- Hopefully, this will be useful for applications where there are "hot"

[jira] Commented: (OPENJPA-182) db2 update lock syntax WITH USE AND KEEP UPDATE LOCKS

2007-04-05 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487082 ] Craig Russell commented on OPENJPA-182: --- I know that Oracle allows you to add a FOR UPDATE clause to a query,

[jira] Created: (OPENJPA-233) Top level POM declares a compile-time dependency on JUnit

2007-05-02 Thread Craig Russell (JIRA)
Top level POM declares a compile-time dependency on JUnit - Key: OPENJPA-233 URL: https://issues.apache.org/jira/browse/OPENJPA-233 Project: OpenJPA Issue Type: Bug Components

[jira] Commented: (OPENJPA-233) Top level POM declares a compile-time dependency on JUnit

2007-05-02 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493116 ] Craig Russell commented on OPENJPA-233: --- This patch changes the dependency from compile to test. Index: pom.x

[jira] Commented: (OPENJPA-233) Top level POM declares a compile-time dependency on JUnit

2007-05-02 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493122 ] Craig Russell commented on OPENJPA-233: --- > Why not move on up to the 4.1 junit suite as well while we are at i

[jira] Commented: (OPENJPA-148) Parsing exception while using an "exploded" archive

2007-05-04 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493736 ] Craig Russell commented on OPENJPA-148: --- Just thinking a bit outside the box here. Is it possibly a bug that t

[jira] Commented: (OPENJPA-194) Correct suffixes of build artifacts to elimiate '-all' and '-project'

2007-05-06 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493954 ] Craig Russell commented on OPENJPA-194: --- I like the direction, just have a couple of questions. The patch cha

[jira] Resolved: (OPENJPA-233) Top level POM declares a compile-time dependency on JUnit

2007-05-16 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell resolved OPENJPA-233. --- Resolution: Fixed Assignee: Craig Russell checked in patch. > Top level POM declares

[jira] Commented: (OPENJPA-242) JCache (JSR 107) support in the OpenJPA DataCache

2007-05-24 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498741 ] Craig Russell commented on OPENJPA-242: --- I'd like to see OpenJPA support a variety of caching implementations,

[jira] Created: (OPENJPA-7) Link to wiki is incorrect in site

2006-08-04 Thread Craig Russell (JIRA)
Link to wiki is incorrect in site - Key: OPENJPA-7 URL: http://issues.apache.org/jira/browse/OPENJPA-7 Project: OpenJPA Issue Type: Bug Reporter: Craig Russell Priority: Minor The wik

[jira] Assigned: (OPENJPA-7) Link to wiki is incorrect in site

2006-08-04 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-7?page=all ] Craig Russell reassigned OPENJPA-7: --- Assignee: Craig Russell > Link to wiki is incorrect in site > - > > Key: OPENJPA-7 > URL: h

[jira] Commented: (OPENJPA-7) Link to wiki is incorrect in site

2006-08-04 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-7?page=comments#action_12425925 ] Craig Russell commented on OPENJPA-7: - The site was updated. Waiting for rsync to resolve/close this issue. > Link to wiki is incorrect in site > --

[jira] Resolved: (OPENJPA-7) Link to wiki is incorrect in site

2006-08-04 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-7?page=all ] Craig Russell resolved OPENJPA-7. - Resolution: Fixed svn commit -m "OPENJPA-7 Fixed broken link to wiki" Sendingsite/docs/index.html Sendingsite/xdocs/index.xml Transmitting file

[jira] Commented: (OPENJPA-29) Create aggregate jars of OpenJPA

2006-08-25 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-29?page=comments#action_12430689 ] Craig Russell commented on OPENJPA-29: -- > Do you have your descriptions backwards or am I misunderstanding what you're > saying? Seems like 'nodep' would mean

[jira] Commented: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification

2006-08-25 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-15?page=comments#action_12430697 ] Craig Russell commented on OPENJPA-15: -- Thanks very much for contributing this patch. My review is a style and readability code review, not necessarily a con

[jira] Commented: (OPENJPA-30) Need some OpenJPA jars for maven 2 projects

2006-08-26 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-30?page=comments#action_12430771 ] Craig Russell commented on OPENJPA-30: -- I notice that the result jar files do not contain -incubating- in their names, which is a requirement for incubating p

[jira] Commented: (OPENJPA-30) Need some OpenJPA jars for maven 2 projects

2006-08-26 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-30?page=comments#action_12430791 ] Craig Russell commented on OPENJPA-30: -- The podling release naming guidelines are at http://incubator.apache.org/incubation/Incubation_Policy.html#Releases E

[jira] Commented: (OPENJPA-36) Add cwiki url to incubator status page

2006-08-29 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-36?page=comments#action_12431359 ] Craig Russell commented on OPENJPA-36: -- There are currently two wikis set up for this project, which I personally think is one too many. Pending resolution o

[jira] Resolved: (OPENJPA-11) No Javadoc available on the website

2006-10-14 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-11?page=all ] Craig Russell resolved OPENJPA-11. -- Resolution: Fixed Assignee: Craig Russell Thanks for the patch. I've applied it to the site. > No Javadoc available on the website > ---

[jira] Commented: (OPENJPA-81) Bad error message when trying to query a Collection relation using dot notation

2006-11-14 Thread Craig Russell (JIRA)
[ http://issues.apache.org/jira/browse/OPENJPA-81?page=comments#action_12449748 ] Craig Russell commented on OPENJPA-81: -- Yes, it's illegal and pending a change to the specification (which is unlikely), you should rewrite the query. Craig

[jira] Created: (OPENJPA-99) Enhanced pcNewInstance redundantly clears fields

2007-01-10 Thread Craig Russell (JIRA)
Enhanced pcNewInstance redundantly clears fields - Key: OPENJPA-99 URL: https://issues.apache.org/jira/browse/OPENJPA-99 Project: OpenJPA Issue Type: Bug Components: kernel

[jira] Commented: (OPENJPA-115) Bottleneck(s) with using OpenJPA in a Container-managed environment

2007-01-29 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468408 ] Craig Russell commented on OPENJPA-115: --- Kevin opined: Within a Container-managed environment, the Container t

[jira] Created: (OPENJPA-122) EntityManager does not throw exceptions after close() in required cases

2007-01-31 Thread Craig Russell (JIRA)
EntityManager does not throw exceptions after close() in required cases --- Key: OPENJPA-122 URL: https://issues.apache.org/jira/browse/OPENJPA-122 Project: OpenJPA Issue Ty

[jira] Updated: (OPENJPA-122) EntityManager does not throw exceptions after close() in required cases

2007-01-31 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell updated OPENJPA-122: -- Attachment: TestEntityManagerMethodsThrowAfterClose.java This test cannot be checked in until

[jira] Updated: (OPENJPA-122) EntityManager does not throw exceptions after close() in required cases

2007-01-31 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell updated OPENJPA-122: -- Attachment: EntityManagerImpl.patch.txt Please review this patch. This patch fixes the issue

[jira] Resolved: (OPENJPA-122) EntityManager does not throw exceptions after close() in required cases

2007-02-01 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell resolved OPENJPA-122. --- Resolution: Fixed Assignee: Craig Russell svn commit -m "OPENJPA-122 Added check for m

[jira] Commented: (OPENJPA-115) Bottleneck(s) with using OpenJPA in a Container-managed environment

2007-02-01 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469604 ] Craig Russell commented on OPENJPA-115: --- Yes, null checking is an expected requirement when dealing with weak

[jira] Commented: (OPENJPA-117) Collection of TransactionListeners registered to a Broker should be available as unmodifiable collection

2007-02-05 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470294 ] Craig Russell commented on OPENJPA-117: --- Maybe this case would best be handled by having the TransactionListen

[jira] Commented: (OPENJPA-135) join fetch not returning duplicate references which not conforming to ejb3.0 spec

2007-02-08 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471518 ] Craig Russell commented on OPENJPA-135: --- Would it be possible for you to attach a simple test case to this iss

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-12 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472478 ] Craig Russell commented on OPENJPA-141: --- Abe opined: 1. Each BrokerFactory has a ManagedRuntime. You can have

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-12 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472510 ] Craig Russell commented on OPENJPA-141: --- >> Craig thinks: Weak references are supposed to be cleaned up if the

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-13 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472795 ] Craig Russell commented on OPENJPA-141: --- Nice work, Kevin and Abe. Just a reminder. Please attach an svn patc

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-13 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472829 ] Craig Russell commented on OPENJPA-141: --- Given the number of iterations already documented on this issue, woul

[jira] Commented: (OPENJPA-147) T OpenJPAEntityManager.createInstance(Class cls) fails when T is interface

2007-02-14 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473224 ] Craig Russell commented on OPENJPA-147: --- >Firstly, how to specify metadata for a interface that has bean-style

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-14 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473231 ] Craig Russell commented on OPENJPA-141: --- 1. The original functionality of isAssignable(Class a, Class b) is to

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-14 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473285 ] Craig Russell commented on OPENJPA-141: --- >> If we want a "hard cache that drops entries for classes that are

[jira] Commented: (OPENJPA-141) More performance improvements (in response to changes for OPENJPA-138)

2007-02-15 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473527 ] Craig Russell commented on OPENJPA-141: --- >Just posted another version of the performance patch for openjpa-141

[jira] Commented: (OPENJPA-147) T OpenJPAEntityManager.createInstance(Class cls) fails when T is interface

2007-02-15 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473536 ] Craig Russell commented on OPENJPA-147: --- Could you please attach the java definition of test.IPerson and the c

[jira] Commented: (OPENJPA-151) Added field in enhanced vesrion of a class is not serialized. Hence the change in detached+serialized instances is not registered under certain conditions.

2007-02-22 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475190 ] Craig Russell commented on OPENJPA-151: --- I'd avoid the method name getEnhancementContractVersion because this

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-22 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475238 ] Craig Russell commented on OPENJPA-160: --- I think it's great that profiling EntityManager creation resulted in

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-23 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475507 ] Craig Russell commented on OPENJPA-160: --- >We ran some more performance tests with the latest OpenJPA code and

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-23 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475511 ] Craig Russell commented on OPENJPA-160: --- Great screen shot, but when I click on the frypan next to newInstance

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476219 ] Craig Russell commented on OPENJPA-160: --- Sweet. The ObjectValue.InstanceFactory is the technique I was going t

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476225 ] Craig Russell commented on OPENJPA-160: --- As you've coded it, each instance of ObjectValue gets its own Map. Do

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476295 ] Craig Russell commented on OPENJPA-160: --- >I put a Map in place to get around any ClassLoader issues. In the co

[jira] Assigned: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell reassigned OPENJPA-160: - Assignee: Patrick Linskey > Reuse BrokerImpl objects > > >

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476321 ] Craig Russell commented on OPENJPA-160: --- For the record, the new patch changes a couple of things. The factory

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476353 ] Craig Russell commented on OPENJPA-160: --- The real cost according to the trace is in the dynamically created cl

[jira] Updated: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Russell updated OPENJPA-160: -- Attachment: openjpa-160-patch.txt This patch uses a regular class instead of an anonymous inne

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476433 ] Craig Russell commented on OPENJPA-160: --- Rob -- thanks, our coding passed in the mail. All -- WTF? > Reuse B

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-27 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476470 ] Craig Russell commented on OPENJPA-160: --- A few questions and a comment. 1. Is the profiling capturing CPU tim

[jira] Commented: (OPENJPA-160) Reuse BrokerImpl objects

2007-02-28 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476731 ] Craig Russell commented on OPENJPA-160: --- >K... IMO, we should get rid of the finalizer in the default config,

[jira] Commented: (OPENJPA-35) In-memory Delete operation fails with active DataCache

2007-02-28 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476808 ] Craig Russell commented on OPENJPA-35: -- I agree this bug is worth fixing and pending the fix, worth documenting

[jira] Commented: (OPENJPA-20) Query can return embeddable class

2007-03-01 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477043 ] Craig Russell commented on OPENJPA-20: -- I agree with Marc that it's a bug in the doc. The doc could also be rewo

[jira] Commented: (OPENJPA-176) Exception prefixes should be human-readable

2007-03-24 Thread Craig Russell (JIRA)
[ https://issues.apache.org/jira/browse/OPENJPA-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483850 ] Craig Russell commented on OPENJPA-176: --- I like it. What if the type is not one of the expected types? Perha