[ 
https://issues.apache.org/jira/browse/OPENJPA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493954
 ] 

Craig Russell commented on OPENJPA-194:
---------------------------------------

I like the direction, just have a couple of questions.

The patch changes the parent from openjpa to openjpa-parent. From your 
description, this doesn't really affect anything else (except for freeing up 
the openjpa name for another purpose.

Nice change to use the scm.dir location in other poms. This is the variable 
that we'll have to change once we graduate. While we're at is, is there any way 
to do the same refactoring to 
<url>http://incubator.apache.org/projects/openjpa</url> which appears in lots 
of places?

> Patch that changes artifact names so that the openjpa aggregate jar is named 
> "openjpa-VERSION.jar", 

So this changes openjpa-all-VERSION.jar to openjpa-VERSION.jar. This is great. 

> the dependency is named "openjpa", 

I think you are talking about the artifactId in the dependency section of 
projects that use OpenJPA. If so, great.

>and the assembly is named "apache-openjpa-VERSION.zip".

So that's the non-maven artifact. Aren't there binary and source versions of 
this artifact? And .zip and .tar.gz versions of those? The name is pretty 
arbitrary, and while I don't like openjpa-project, I don't really like 
apache-openjpa either, because it doesn't imply a bundle or distribution. How 
about openjpa-distribution or openjpa-bundle? Or simply openjpa-src-0.9.7.zip 
and openjpa-binary-0.9.7.zip? I guess that would imply a different maven 
project for the source and binary distributions...




> Correct suffixes of build artifacts to elimiate '-all' and '-project'
> ---------------------------------------------------------------------
>
>                 Key: OPENJPA-194
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-194
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: build / infrastructure
>    Affects Versions: 0.9.0, 0.9.6
>            Reporter: Marc Prud'hommeaux
>         Assigned To: Marc Prud'hommeaux
>            Priority: Minor
>             Fix For: 0.9.8
>
>         Attachments: OpenJPA-194-1.patch.txt, OPENJPA-194.patch
>
>
> The aggregate jar that is built with OpenJPA is currently named 
> "openjpa-all-0.9.7-VERSION.jar". It would be nice to change this to be just 
> "openjpa-0.9.7-VERSION.jar".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to