Re: [Open64-devel] Code review request for fixing some operator priority problem

2011-04-27 Thread Sun Chan
I already read through the code. Your comments are on top of what I reviewed already. E.g. the splitting (cleanup) of gcm is due to my input Sun On Wed, Apr 27, 2011 at 5:12 PM, Jian-Xin Lai wrote: > This patch looks fine to me. But since it's in the common code and may > affect all targets, coul

Re: [Open64-devel] Code review request for fixing some operator priority problem

2011-04-27 Thread Jian-Xin Lai
This patch looks fine to me. But since it's in the common code and may affect all targets, could a global keeper review and approve this patch? Thanks. 2011/4/26 Hui Shi > > Would gatekeeper help review this patch? > > The priorty of bitwise operator is lower than relational operaotr. > So follo

[Open64-devel] Code review request for fixing some operator priority problem

2011-04-26 Thread Hui Shi
Would gatekeeper help review this patch? The priorty of bitwise operator is lower than relational operaotr. So following code has potential problem. In Check_TCON ( TCON *tc ) Is_True ( TCON_v1(*tc)|TCON_v2(*tc)|TCON_v3(*tc) == 0, ("High order word of %s TCON non zero %x",