> -Original Message-
> From: David Coakley [mailto:dcoak...@gmail.com]
> Sent: Sunday, August 26, 2012 8:37 PM
> To: Gilmore, Doug
> Cc: open64-devel
> Subject: Re: [Open64-devel] review request for changes to libhugetlbfs
>
> Hi Doug,
>
> I reviewed the
Hi Doug,
I reviewed the changes. Here are my comments/questions:
The formatting (spaces vs. tabs) seems inconsistent, but it's already
that way in the project. It would be nice to clean it up in a
separate update.
Do you run the tests in the 'tests' subdirectory? Are there any new
tests that
On 08/24/12 08:00 AM, Gilmore, Doug wrote:
>> -Original Message-
>> From: "C. Bergström" [mailto:cbergst...@pathscale.com]
>> Sent: Thursday, August 23, 2012 3:15 PM
>> To: Gilmore, Doug
>> Cc: open64-devel
>> Subject: Re: [Open64-devel] revie
> -Original Message-
> From: "C. Bergström" [mailto:cbergst...@pathscale.com]
> Sent: Thursday, August 23, 2012 3:15 PM
> To: Gilmore, Doug
> Cc: open64-devel
> Subject: Re: [Open64-devel] review request for changes to libhugetlbfs
>
> On 08/24/12 05:13 A
On 08/24/12 05:13 AM, Gilmore, Doug wrote:
> I have two changes to libhugetlbfs that I would like to have reviewed.
Do you have any intention to push this upstream as well? Is there any
plans to sync with upstream or at least cherry-pick some of their changes?
http://sourceforge.net/p/libhugetlb
I have two changes to libhugetlbfs that I would like to have reviewed.
The first is just a fix to eliminate a compiler warning.
The second is a change to the library to handle situations where a
huge page mapping would exhaust the huge page limit. Previously no
huge pages would be allocated (whe
