Hello All:
A gentle reminder for review of bug fix ID 784.
Thanks & Regards
Ajit
From: Agarwal, Ajit
Sent: Friday, October 14, 2011 5:08 PM
To: 'Open64-devel@lists.sourceforge.net'
Cc: Lai, Michael
Subject: Code review for bug fix 784
Hello All:
Could gatekeepers approve this patch for the fix
Hi Rao, Shivarama,
It seems your checkin caused SPEC/SPECfp2006/465.tonto Ofast compile
fail, please have a look. More detailed see bug882.
Thanks
zhuqing
2011/10/16 :
> Author: shivaram
> Date: 2011-10-16 06:12:14 -0400 (Sun, 16 Oct 2011)
> New Revision: 3764
>
> Modified:
> trunk/osprey/be/o
This is strange. Must be a regression from elsewhere. I am sure the identity
stmt had been removable without your change before. Is this fix the right
fix?
Fred, your comment?
Sun
On Sun, Oct 16, 2011 at 6:12 PM, wrote:
> Author: shivaram
> Date: 2011-10-16 06:12:14 -0400 (Sun, 16 Oct 2011)
> Ne
I'll double check on this, there is only one checkin between two days result.
zhuqing
2011/10/18 Sun Chan :
> This is strange. Must be a regression from elsewhere. I am sure the identity
> stmt had been removable without your change before. Is this fix the right
> fix?
> Fred, your comment?
> Sun
you meant 2 checkins that showed diff between the stmt got dce'd or not?
Sun
On Tue, Oct 18, 2011 at 4:35 PM, 朱庆 wrote:
> I'll double check on this, there is only one checkin between two days
> result.
>
> zhuqing
> 2011/10/18 Sun Chan :
> > This is strange. Must be a regression from elsewhere.
Double checked on this, I can confirm it is r3764 that caused the failure.
there is another small case also fail with the same err. see bug882.
zhuqing
2011/10/18 Sun Chan :
> you meant 2 checkins that showed diff between the stmt got dce'd or not?
> Sun
>
> On Tue, Oct 18, 2011 at 4:35 PM, 朱庆 wr
Hi Zhuqing,
Thanks for the small testcase. I am looking into this.
Regards,
Shivaram
-Original Message-
From: 朱庆 [mailto:zqing1...@gmail.com]
Sent: Tuesday, October 18, 2011 4:27 PM
To: Sun Chan
Cc: open64-devel@lists.sourceforge.net
Subject: Re: [Open64-devel] r3764 - trunk/osprey/b
For now, may be backout the fix until the regression is resolved?
Sun
On 10/18/11, Rao, Shivarama wrote:
> Hi Zhuqing,
>
> Thanks for the small testcase. I am looking into this.
>
> Regards,
> Shivaram
>
>
> -Original Message-
> From: 朱庆 [mailto:zqing1...@gmail.com]
> Sent: Tuesday, Oct
Author: shivaram
Date: 2011-10-18 10:22:33 -0400 (Tue, 18 Oct 2011)
New Revision: 3768
Modified:
trunk/osprey/be/opt/opt_dce.cxx
Log:
#bug882 fix: regression in tonto build in rev 3467
reverting back the changes done to fix bug#787
Modified: trunk/osprey/be/opt/opt_dce.cxx
===
Some background from my interaction with Shivaram:
X8664 disables copy prop of identity assignments for assembly inputs (with
unknown reasons), but DCE appears to assume that copy prop can always happen
on identify assignments and therefore they are removable, which leads to
downstream assertio
I noticed tons of warnings associated with CGTARG_Is_Right_Shift_Op()
when I compiled a source file in CG with "-Wall -O2".
The patch cleans up the warnings.
Note that the only use for CGTARG_Is_Right_Shift_Op() is the following
code in cgemit.cxx:
if (CGTARG_Is_Right_Shift_Op (op)) {
11 matches
Mail list logo
