[OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Andrew Deason
On Tue, 16 Apr 2013 19:27:33 + Jakub Moscicki wrote: > I am not sure, but if the uniquifier is just to uniquify the > potentialy reused vnode id, then the risk of collisions is really low > even without this check, right? One would have to have the uniquifier > wrapped around 32bits in betwee

Re: [OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Jakub Moscicki
Hello, Sorry for late reply - at this side of the pond we are off at home by now ;-) Yes, the issue seems to be the overflowing 32bit uniquifier counter which we suspected and which was later confirmed by Derrick. In any case for now I took out the "check for less then the max" to restore acce

[OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Andrew Deason
On Tue, 16 Apr 2013 14:27:12 -0400 Derrick Brashear wrote: > > contents for caching purposes anyway. In option (2) you can have a > > collision by just removing a file and creating one. Maybe those > > aren't _so_ different, but that's my impression. > > It's pretty easy to avoid the condition y

Re: [OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Derrick Brashear
On Tue, Apr 16, 2013 at 2:07 PM, Andrew Deason wrote: > On Tue, 16 Apr 2013 13:34:18 -0400 > Derrick Brashear wrote: > > > The problem he's having (apparently I replied without replying all) is > > he's wrapping uniquifiers, and currently the volume package deals > > poorly, since ~1300 from maxu

[OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Andrew Deason
On Tue, 16 Apr 2013 13:34:18 -0400 Derrick Brashear wrote: > The problem he's having (apparently I replied without replying all) is > he's wrapping uniquifiers, and currently the volume package deals > poorly, since ~1300 from maxuint plus 2000 plus 1 results in a number > "less than the max uniq

Re: [OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Derrick Brashear
The problem he's having (apparently I replied without replying all) is he's wrapping uniquifiers, and currently the volume package deals poorly, since ~1300 from maxuint plus 2000 plus 1 results in a number "less than the max uniquifier" We need to decide whether OpenAFS should 1) compact the uniq

[OpenAFS] Re: volume offline due to too low uniquifier (and salvage cannot fix it)

2013-04-16 Thread Andrew Deason
On Tue, 16 Apr 2013 10:57:13 + Jakub Moscicki wrote: > The salvage subsequently says that it fixed it but in reality nothing > changes. Here is the salvage output: "nothing changes" as in, the volinfo output doesn't change at all? Or it's just that the problem doesn't go away? > == > >>