Re: [Openais] [PATCH]: openais/trunk: Add pid to saMsg service get/cancel operations

2009-05-04 Thread Steven Dake
good for merge - Original Message - From: Ryan O'Hara roh...@redhat.com To: open...@lists.osdl.org Sent: Thursday, April 30, 2009 8:12:47 PM GMT -07:00 U.S. Mountain Time (Arizona) Subject: [Openais] [PATCH]: openais/trunk: Add pid to saMsg service get/cancel operations This patch

Re: [Openais] [PATCH corosync/trunk] add NTF_SERVICE to the service list

2009-05-04 Thread Angus Anna Salkeld
committed as 2167. -Angus On Mon, May 4, 2009 at 4:31 PM, Steven Dake steven.d...@gmail.com wrote: good for merge The tabbing looks weird in this code segment.  Can you fix it? Regards -steve On Sat, May 2, 2009 at 12:01 AM, Angus Anna Salkeld ahsalk...@gmail.com wrote: diff --git

[Openais] [PATCH: corosync] avoid new warnings

2009-05-04 Thread Jim Meyering
There were some new warnings due to const mismatches and one unused static declaration. This fixes the offenders. From 3cff529156719f6a7557a7133403aa80dabbc1c0 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 4 May 2009 10:35:59 +0200 Subject: [PATCH] avoid new warnings

[Openais] [PATCH] fix missing-dependency bug, so as not to install bogus .pc files

2009-05-04 Thread Jim Meyering
I configured corosync with one prefix, then reran configure with the proper --prefix=DIR option, but the prior, bogus value stuck and ended up being installed. That made it so a subsequent attempt to build openais failed, due to using an invalid -I/bogus/prefix option when compiling. Here's the

Re: [Openais] [PATCH: corosync] avoid new warnings

2009-05-04 Thread Jim Meyering
Jim Meyering wrote: There were some new warnings due to const mismatches and one unused static declaration. This fixes the offenders. From 3cff529156719f6a7557a7133403aa80dabbc1c0 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 4 May 2009 10:35:59 +0200 Subject:

Re: [Openais] [openais trunk] evt.c - Remove warnings

2009-05-04 Thread Jan Friesse
Iovectorized version of previous patch. Alloca + memcpy is still there, but only for lib_event_data structure, not for led_body. Regards, Honza Steven Dake wrote: This patch looks pretty good but it copies via alloca+memcpy the entire event data buffer which doesn't change. Is it possible

Re: [Openais] [PATCH]: openais/trunk: Fix saMsg library code to handle saMsgSendReceive correctly

2009-05-04 Thread Steven Dake
good for merge regards -steve On Mon, 2009-05-04 at 16:16 -0500, Ryan O'Hara wrote: This patch fixes the library code for the saMsgSendReceive call. This call can block, and therefore we need to create a new ipc connection in the library. Also fixed the ipc_msg.h file such that the

[Openais] [PATCH]: openais/trunk: Fix ipc leak in saMsg library code

2009-05-04 Thread Ryan O'Hara
This patch fixes a leak of ipc connections (shared memory) in the saMsg service library code. In saMsgMessageGet and saMsgMessageSendReceive, if the response from the exec indicated that there was an error, the library code would call disconnect without first doing a put. This could easily be