Re: [Openais] [corosync] [rfe] - Implementation of cpg_iteration functions

2009-08-19 Thread Fabio M. Di Nitto
On Wed, 2009-08-19 at 21:57 -0700, Steven Dake wrote: > On Thu, 2009-08-20 at 06:39 +0200, Fabio M. Di Nitto wrote: > > This change the API and ABI for cpg. > > > > Before this change can go anywhere, it needs proper Makefile.am love or > > even easier queue it after libtool changes that makes sli

Re: [Openais] [corosync] [rfe] - Implementation of cpg_iteration functions

2009-08-19 Thread Steven Dake
On Thu, 2009-08-20 at 06:39 +0200, Fabio M. Di Nitto wrote: > This change the API and ABI for cpg. > > Before this change can go anywhere, it needs proper Makefile.am love or > even easier queue it after libtool changes that makes slightly easier to > have per library API and ABI versioning. > >

Re: [Openais] [corosync] [rfe] - Implementation of cpg_iteration functions

2009-08-19 Thread Fabio M. Di Nitto
This change the API and ABI for cpg. Before this change can go anywhere, it needs proper Makefile.am love or even easier queue it after libtool changes that makes slightly easier to have per library API and ABI versioning. Let's try, as a general rule, to avoid the same nightmare we had between w

Re: [Openais] [corosync] [rfe] - Implementation of cpg_iteration functions

2009-08-19 Thread Steven Dake
comments inline. Looks pretty good though. Regards -steve On Wed, 2009-08-19 at 16:31 +0200, Jan Friesse wrote: > Implementation of DRAFT API. Look like there are no leaks, valgrind > problems, ... > > Regards, > Honza > plain text document attachment > (0001-Implementation-of-cpg_iteration-f

Re: [Openais] [corosync] [patch?] - Handle NULL callbacks in cpg, confdb, evs services

2009-08-19 Thread Steven Dake
On Wed, 2009-08-19 at 15:55 +0200, Jan Friesse wrote: > Attached patches handle NULL callbacks in [cpg|evs|confdb]_initialize > and *_dispatch. Handling is same as in cfg service (and SIMILAR (see > bellow) as in quorum and votequorum), so if callback is NULL -> no > memcpy -> instance callbacks wi

[Openais] [corosync] [rfe] - Implementation of cpg_iteration functions

2009-08-19 Thread Jan Friesse
Implementation of DRAFT API. Look like there are no leaks, valgrind problems, ... Regards, Honza >From 02a9fbad2db3ee019c735422dc064fed0179e103 Mon Sep 17 00:00:00 2001 From: Jan Friesse Date: Wed, 19 Aug 2009 15:17:27 +0200 Subject: [PATCH] Implementation of cpg_iteration functions --- trunk

Re: [Openais] [corosync] [rfe] - cpg_iteration_* API draft

2009-08-19 Thread Jan Friesse
David David Teigland wrote: > On Tue, Aug 18, 2009 at 06:09:38PM +0200, Jan Friesse wrote: >> This feature should allow app to get cpg groups and members. It's >> modeled like ckpt section iteration, so: > > Thanks! I've been waiting a long time for this (the same is needed for various > other th

[Openais] [corosync] [patch?] - Handle NULL callbacks in cpg, confdb, evs services

2009-08-19 Thread Jan Friesse
Attached patches handle NULL callbacks in [cpg|evs|confdb]_initialize and *_dispatch. Handling is same as in cfg service (and SIMILAR (see bellow) as in quorum and votequorum), so if callback is NULL -> no memcpy -> instance callbacks will have all items set to NULL. In *_dispatch, if callbacks.$C

Re: [Openais] [corosync] [patch] - set found_service_ver to NULL

2009-08-19 Thread Jan Friesse
Committed revision 2391. Steven Dake wrote: > good for merge > > regards > -steve > > On Tue, 2009-08-18 at 17:54 +0200, Jan Friesse wrote: >> This patch set found_service_ver to NULL (exec/service.c >> corosync_service_defaults_link_and_init) so if we don't find ver in >> objdb, we don't read f

Re: [Openais] [corosync] [patch] - Fix semaphores on systems without POSIX_THREAD_PROCESS_SHARED

2009-08-19 Thread Jan Friesse
Committed revision 2390. Steven Dake wrote: > pls merge > > regards > -steve > > On Tue, 2009-08-18 at 17:52 +0200, Jan Friesse wrote: >> This fix one sem_num, so it's now possible to run more then once ipc. >> >> Regards, >> Honza >> plain text document attachment >> (coroipcs-system-without-