[Openais] corosync: remove 2 seconds delay in library on normal corosync shutdown

$SUBJ$ Regards, Honza commit 5b92559e1a80c997d32c1ec96a8768ab4aea9917 Author: Jan Friesse jfrie...@redhat.com Date: Tue Sep 7 17:49:21 2010 +0200 Remove delay in library on corosync shutdown Patch removes 2 seconds delay in library on normal corosync shutdown. Delay is still

Re: [Openais] Rgding Corosync 1.2.8 installation on freebsd

Hi Ranjith, Ranjith napsal(a): Hi, I am trying to install Corosync 1.2.8 on freebsd 6.3 (Corosync 1.2.8 tar ball) I am getting the following the error when i do ./configure configure: error: you don't seem to have GNU make; it is required I'm pretty sure that make from ports is new

Re: [Openais] [PATCH 07/13] SAM Confdb integration

Committed revision 3050. Angus Salkeld napsal(a): Hi Honza Can you commit this please. Thanks Angus ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

Re: [Openais] [PATCH] Display warning when not possible to form cluster

Committed as b9df4424b1ea91b98c98c208c295f4323be3204d Regards, Honza Steven Dake napsal(a): Honza, Great work Make sure to add a Reviewed-by me line to the checkin. Regards -steve On 12/02/2010 07:05 AM, Jan Friesse wrote: This may typically happen if local firewall is enabled

Re: [Openais] packet dissectors for totempg, cman, clvmd, rgmanager, cpg,

Masatake, I'm pretty sure that biggest problem of your code was that it was licensed under BSD (three clause, same as Corosync has) license. Wireshark is licensed under GPL and even I like BSD licenses much more, I would recommend you to try to relicense code under GPL and send them this code.

Re: [Openais] packet dissectors for totempg, cman, clvmd, rgmanager, cpg,

Masatake, Masatake YAMATO napsal(a): I'd like to your advice more detail seriously. I've been developing this code for three years. I don't want to make this code garbage. Masatake, I'm pretty sure that biggest problem of your code was that it was licensed under BSD (three clause, same as

Re: [Openais] packet dissectors for totempg, cman, clvmd, rgmanager, cpg,

Steven Dake napsal(a): On 12/14/2010 07:51 AM, Jan Friesse wrote: Masatake, Thank you. Regards, Honza I am not changing corosync license to GPL. I think the separate plugin works fine, and we can even take up packaging of it in fedora and Red Hat variants

[Openais] [PATCH 1/1] Add objdb firewall_enabled_or_nic_failure

New objdb var runtime.totem.pg.mrp.srp.firewall_enabled_or_nic_failure is set to 1 if continuous_gather is larger then MAX_NO_CONT_GATHER. Under normal conditions, value of variable is 0. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/main.c |9 + 1 files changed, 9

[Openais] [PATCH] Handle nocluster kernel parameter in init script

Init script checks kernel parameters and refuses to start corosync if nocluster parameter exist on boot time. The init script will continue to work as expected from console/tty after boot. Signed-off-by: Jan Friesse jfrie...@redhat.com --- init/generic.in | 13 + 1 files changed

[Openais] [PATCH 1/4] logsys: Don't leak fd on successful fdata dump

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/logsys.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/exec/logsys.c b/exec/logsys.c index 72d3f68..cbcfb0c 100644 --- a/exec/logsys.c +++ b/exec/logsys.c @@ -1642,7 +1642,8 @@ int logsys_log_rec_store (const

[Openais] [PATCH 3/4] corosync-fplay: replace bit-shift with multiply

Size of unsigned int is not strictly defined to be 4 bytes. Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-fplay.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c index f6f3bae..2ecc06a 100644

[Openais] [PATCH 2/4] logsys: Properly lock flt data before dump

Data needs to be locked, otherwise resulting fdata file may be incorrect. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/logsys.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec/logsys.c b/exec/logsys.c index cbcfb0c..c678689 100644 --- a/exec/logsys.c

[Openais] [PATCH 4/4] corosync-fplay: handle too large rec_size

Corrupted files may contain items with rec_size larger then g_record buffer and/or flt_data_size. Also g_record array size is now defined as constant. Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-fplay.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions

Re: [Openais] [PATCH 4/4] corosync-fplay: handle too large rec_size

Russell Bryant wrote: On Mon, Feb 21, 2011 at 9:41 AM, Jan Friesse jfrie...@redhat.com wrote: Corrupted files may contain items with rec_size larger then g_record buffer and/or flt_data_size. Also g_record array size is now defined as constant. Signed-off-by: Jan Friesse jfrie...@redhat.com

[Openais] [PATCH 1/2] corosync-fplay: Use size_t length mod in printf

Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-fplay.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c index 57e6f97..a1aedd9 100644 --- a/tools/corosync-fplay.c +++ b/tools/corosync-fplay.c @@ -502,8

[Openais] [PATCH 2/2] corosync-fplay: use uint32_t and remove bit-shift

The flight recorder records all data in 32 bit words. Use uint32_t type rather then unsigned int. Also remove bit-shift with multiply by sizeof uint32_t. Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-fplay.c | 30 +++--- 1 files changed, 15

[Openais] [PATCH 1/1] Iterate all items in object_reload_notification

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/objdb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/objdb.c b/exec/objdb.c index dc36236..884263b 100644 --- a/exec/objdb.c +++ b/exec/objdb.c @@ -342,7 +342,7 @@ static void object_reload_notification(int

Re: [Openais] [PATCH 1/2] corosync-fplay: Use size_t length mod in printf

Steven Dake wrote: On 02/22/2011 02:52 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-fplay.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c index 57e6f97..a1aedd9 100644

Re: [Openais] [PATCH 1/1] Iterate all items in object_reload_notification

=677975 :) Fabio Thanks -steve On 02/22/2011 06:42 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/objdb.c |2 +- ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org

[Openais] [PATCH 1/1] objdb: destroy all handles in _clear_object

Patch replaces free for object_instance with handle_destroy to remove leaks in handles (and also memory leak). Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/objdb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/objdb.c b/exec/objdb.c index 884263b

[Openais] [PATCH] Fix abort when token is lost in RECOVERY state

A commit token should be rejected when a token is lost in the recovery state. This occurs naturally because the ring id increases by 4 for every new ring. Prior to this patch, if the token was lost, the old ring id information was restored, causing a commit token to be accepted when it should be

[Openais] [PATCH 1/3] cfg_get_node_addrs: Return correct addresses

to char. Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/cfg.c|9 ++--- lib/libcfg.verso |2 +- services/cfg.c |6 -- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/lib/cfg.c b/lib/cfg.c index 054dc43..a3aee9c 100644 --- a/lib/cfg.c +++ b/lib/cfg.c

[Openais] [PATCH 3/3] cfgtool: print list of IP with space between items

Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-cfgtool.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/corosync-cfgtool.c b/tools/corosync-cfgtool.c index 8237fe3..e0b4d1c 100644 --- a/tools/corosync-cfgtool.c +++ b/tools/corosync-cfgtool.c

[Openais] [PATCH 2/3] cpgtool: print list of IP with space between items

Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-cpgtool.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/corosync-cpgtool.c b/tools/corosync-cpgtool.c index 30d5bd9..8eb487d 100644 --- a/tools/corosync-cpgtool.c +++ b/tools/corosync-cpgtool.c

Re: [Openais] [PATCH] totemsrp: Remove recv_flush code

Reviewed-by: Jan Friesse jfrie...@redhat.com Steven Dake wrote: The recv_flush code is no longer necessary because of the miss_count_count addition. It can in some cases lead to register corruption because of interactions with -fstack-protector, the recursive nature of how this code works

Re: [Openais] [PATCH] totemsrp: Only restore old ring id information one time

Reviewed-by: Jan Friesse jfrie...@redhat.com Steven Dake wrote: The current code stores the current ring information every time a commit token is generated. This causes the old ring id used for comparison purposes to increase if a token is lost in commit or recovery, resulting in failure

Re: [Openais] [PATCH] totemsrp: free messages originated in recovery rather then rely on messages_free

Reviewed-by: Jan Friesse jfrie...@redhat.com Steven Dake wrote: Relying on messages_free may seem like it should work, but it leads to a situation where every node has released the messages, yet some nodes think messages are missing. The output then looks like Retransmit: # in repitition

Re: [Openais] [PATCH 3/3] STATS: add the service name to the connection name.

Angus, I would rather then switch see statically defined and initialized array. It's shorter, nicer and easier to maintain. Honza Angus Salkeld napsal(a): This helps to quickly identify what service the application is connected to. The object will now look like:

[Openais] [PATCH 3/4] totemsrp: Only restore old ring id information one time

. This patch changes the behavior to only store the old ring id one time when the commit token is received, and then further commit token ring id saves are not done until OPERATIONAL is reached. Signed-off-by: Jan Friesse jfrie...@redhat.com --- branches/whitetank/exec/totemsrp.c | 19

[Openais] [PATCH 1/4] Resolve abort during simulatenous stopping of atleast 4 nodes

this scenario. That solution entails rejecting the regular token in the above condition. Since the ring id is also used to make decisions for commit token acceptance, we must also take care to reject the regular token in all cases after transitioning from OPERATIONAL. Signed-off-by: Jan Friesse jfrie

[Openais] [PATCH 1/1] coroipcs: Deny connect to service without initfn

If library connect to service with no init function, coroipcs will try to dereference NULL pointer. Now we correctly return error code CS_ERR_NOT_EXIST. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/coroipcs.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Openais] [PATCH 3/4] totemsrp: Only restore old ring id information one time

Huh, typo :) New patch included. Regards, Honza Steven Dake wrote: This patch is missing: instance-old_ring_state_saved = 1; in the if statement After that is fixed, good for merge. Reviewed-by: Steven Dake sd...@redhat.com On 03/29/2011 02:55 AM, Jan Friesse wrote

Re: [Openais] [openais-whitetank PATCH 1/2] IPC: handle maximum use of file descriptors gracefully.

Reviewed-by: Jan Friesse jfrie...@redhat.com Angus Salkeld napsal(a): If we get EMFILE from accept() then withdraw the published server listening socket. Then when a connection closes see if we need to re-publish the server sockect. Signed-off-by: Angus Salkeld asalk...@redhat.com

[Openais] [PATCH] totemsrp: Enhance mcast failure detection

memb_state_gather_enter increase stats.continuous_gather only if previous state was gather also. This should happen only if multicast is not working properly (local firewall in most cases) and not if many nodes joins at one time. --- exec/totemsrp.c |8 +++- 1 files changed, 7

[Openais] [PATCH 1/2] Store cpg process information in objdb

Information about processes using cpg are now stored in objdb. Each process info is object stored in cpg object, with nodeid, pid and group name keys. --- services/cpg.c | 124 1 files changed, 124 insertions(+), 0 deletions(-) diff --git

[Openais] [PATCH 2/2] corosync-objctl: Option to display binary data

--- man/corosync-objctl.8 |5 - tools/corosync-objctl.c | 37 + 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/man/corosync-objctl.8 b/man/corosync-objctl.8 index b83e172..2b3a7b6 100644 --- a/man/corosync-objctl.8 +++

[Openais] [PATCH] Store cpg process information in objdb

Information about processes using cpg are now stored in objdb. Each process info is object stored in cpg object, with nodeid, pid and group name keys. --- services/cpg.c | 136 1 files changed, 136 insertions(+), 0 deletions(-) diff --git

Re: [Openais] [PATCH] Resolve some compiler warnings.

Generally I would rather see proper checking of return codes rather then simply ignore them. For some of them, assert may be good enough check. Comments inside: Russell Bryant napsal(a): Resolve compiler warnings emitted by gcc 4.6.0. Specifically, the warnings addressed here are for when a

Re: [Openais] [PATCH] logsys.c: Use snprintf() instead of sprintf().

Reviewed-by: Jan Friesse jfrie...@redhat.com Russell Bryant napsal(a): Change a couple of string functions to use the the output length limiting counterpart. Signed-off-by: Russell Bryant russ...@russellbryant.net --- exec/logsys.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [Openais] [PATCH] Corosync: Fix BSD build when done with --enable-fatal-warnings

Jerome Flesch wrote: --- exec/coroipcs.c|2 +- exec/totemconfig.c |4 ++-- exec/tsafe.c | 12 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index a58c269..4c18c10 100644 --- a/exec/coroipcs.c +++

Re: [Openais] [PATCH] Openais: Fix BSD build when done with --enable-fatal-warnings

Reviewed-by: Jan Friesse jfrie...@redhat.com Jerome Flesch wrote: --- include/mar_ckpt.h |2 +- include/mar_msg.h |6 +++--- test/testckpt.c|2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/mar_ckpt.h b/include/mar_ckpt.h index ba293aa

[Openais] [PATCH] iazc: Reduce number of mem alloc and memcpy

X86 processors are able to handle unaligned memory access. Improve performance by using that feature on i386 and x86_64 compatible processors, and use old aligning code on different processors. --- exec/totempg.c | 35 ++- 1 files changed, 26 insertions(+), 9

Re: [Openais] [PATCH] iazc: Reduce number of mem alloc and memcpy

showed in top, but numbers from oprofile was same. Regards -steve On 05/18/2011 07:38 AM, Jan Friesse wrote: X86 processors are able to handle unaligned memory access. Improve performance by using that feature on i386 and x86_64 compatible processors, and use old aligning code on different

Re: [Openais] [PATCH] coroipcs_handler_dispatch(): Fix conn_info-service security value: -1 is not a good security value since it's equal to SOCKET_SERVICE_INIT

Reviewed-by: Jan Friesse jfrie...@redhat.com Jerome Flesch napsal(a): Signed-off-by: Jerome Flesch jerome.fle...@netasq.com --- exec/coroipcs.c|2 +- include/corosync/coroipc_ipc.h |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec

Re: [Openais] [PATCH] coroipcc_dispatch_get(): Fix --enable-small-memory-footprint support

Please add signed-by, then Reviewed-by: Jan Friesse jfrie...@redhat.com Jerome Flesch napsal(a): From: Jerome Flesch jfle...@gmail.com --- lib/coroipcc.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/lib/coroipcc.c b/lib/coroipcc.c index 34db980

[Openais] [PATCH 01/20] totemudpu: Remove unused flag variable

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemudpu.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/exec/totemudpu.c b/exec/totemudpu.c index e4ea431..e6beb6b 100644 --- a/exec/totemudpu.c +++ b/exec/totemudpu.c @@ -1304,7 +1304,6 @@ static int

[Openais] [PATCH 00/20] Flatiron - coverity

in HASH_PROCESS macro. This needs to be checked (at least) twice. Angus Salkeld (2): remove unused function declaration testcpg: fix a format string compile warning. Jan Friesse (17): totemudpu: Remove unused flag variable libquorum: memset/memcpy proper size of callbacks coroipcc: proper path

[Openais] [PATCH 04/20] libquorum: memset/memcpy proper size of callbacks

Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/quorum.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/quorum.c b/lib/quorum.c index a3453fa..136c563 100644 --- a/lib/quorum.c +++ b/lib/quorum.c @@ -93,9 +93,9 @@ cs_error_t quorum_initialize

[Openais] [PATCH 05/20] coroipcc: proper path size in coroipcc_zcb_alloc

memory_map function internally limits maximum path size to PATH_MAX but coroipcc_zcb_alloc passed smaller buffer. Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/coroipcc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/coroipcc.c b/lib/coroipcc.c index

[Openais] [PATCH 06/20] totemconfig: discard check of objdb_get_string ret

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemconfig.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index 0b9732b..c18c272 100644 --- a/exec/totemconfig.c +++ b/exec/totemconfig.c @@ -217,7 +217,7 @@ static

[Openais] [PATCH 02/20] remove unused function declaration

From: Angus Salkeld asalk...@redhat.com Signed-off-by: Angus Salkeld asalk...@redhat.com Reviewed-by: Steven Dake sd...@redhat.com (cherry picked from commit 20d545e9461eba0d62e2453694acada57cf2999e) --- tools/corosync-objctl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

[Openais] [PATCH 03/20] testcpg: fix a format string compile warning.

From: Angus Salkeld asalk...@redhat.com git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2805 fd59a12c-fef9-0310-b244-a6a79926bd2f (cherry picked from commit 1df867599566c6a667d6a053a00801785ddefc8a) --- test/testcpg.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)

[Openais] [PATCH 18/20] cpg: do_proc_join change list_slice to list_add

In this concrete case result is equivalent but makes coverity happy. Signed-off-by: Jan Friesse jfrie...@redhat.com --- services/cpg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/services/cpg.c b/services/cpg.c index a0336ed..cb1102f 100644 --- a/services/cpg.c

[Openais] [PATCH 14/20] coroipcs: init buf in coroipcs_handler_dispatch

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/coroipcs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 80df360..c6f62c4 100644 --- a/exec/coroipcs.c +++ b/exec/coroipcs.c @@ -1598,7 +1598,7 @@ int

[Openais] [PATCH 17/20] votequorum: free newly allocated node if nodeid==0

Signed-off-by: Jan Friesse jfrie...@redhat.com --- services/votequorum.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/services/votequorum.c b/services/votequorum.c index 5b89359..291da4b 100644 --- a/services/votequorum.c +++ b/services/votequorum.c @@ -1052,6

[Openais] [PATCH 07/20] Corosync: Fix build when done with --enable-fatal-warnings

From: Jerome Flesch jerome.fle...@netasq.com Backport Signed-off-by: Jerome Flesch jerome.fle...@netasq.com Reviewed-by: Jan Friessejfrie...@redhat.com --- exec/coroipcs.c |2 +- exec/coropoll.c |8 ++-- exec/main.c | 17 ++---

[Openais] [PATCH 08/20] mainconfig: Check retval of logsys_format_set

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/mainconfig.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/exec/mainconfig.c b/exec/mainconfig.c index 44bd47a..c7df8c6 100644 --- a/exec/mainconfig.c +++ b/exec/mainconfig.c @@ -614,7 +614,9 @@ static void

[Openais] [PATCH 10/20] logsys: _logsys_wthread_create never returns != 0

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/logsys.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/logsys.c b/exec/logsys.c index 72d3f68..15198a3 100644 --- a/exec/logsys.c +++ b/exec/logsys.c @@ -1338,7 +1338,7 @@ int _logsys_config_subsys_get (const

[Openais] [PATCH 12/20] coroipcc: Test _SC_PAGESIZE result

Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/coroipcc.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/lib/coroipcc.c b/lib/coroipcc.c index 1adce0e..862047d 100644 --- a/lib/coroipcc.c +++ b/lib/coroipcc.c @@ -311,6 +311,10 @@ circular_memory_map (char

[Openais] [PATCH 16/20] totemudp: memset of proper size

In totemudp_mcast_thread_state_constructor memset to sizeof(struct totemudp_mcast_thread_state) instead of size of pointer. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemudp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/totemudp.c b/exec

[Openais] [PATCH 20/20] crypto: handle overflow in HASH_PROCESS macro

md-state_var.curlen theoretically could be sizeof(buf) so overflow could happen. Need REALLY proper review. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/crypto.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/exec/crypto.c b/exec/crypto.c index 901797a

[Openais] [PATCH 09/20] notifyd: Check retval of corosync_cfg_initialize

Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-notifyd.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index 5ac2b83..cdb6dcd 100644 --- a/tools/corosync-notifyd.c +++ b/tools/corosync

[Openais] [PATCH 13/20] coroparse: don't leak dirent

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/coroparse.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/exec/coroparse.c b/exec/coroparse.c index a42dbb3..488e1e9 100644 --- a/exec/coroparse.c +++ b/exec/coroparse.c @@ -254,7 +254,8 @@ static int

[Openais] [PATCH 15/20] testcpgzc: fgets buffer to really allocated size

Signed-off-by: Jan Friesse jfrie...@redhat.com --- test/testcpgzc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/testcpgzc.c b/test/testcpgzc.c index 5b496a8..14f621d 100644 --- a/test/testcpgzc.c +++ b/test/testcpgzc.c @@ -218,7 +218,7 @@ int main (int argc

[Openais] [PATCH 11/20] libcpg: Remove dead code in cpg_model_initialize

Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/cpg.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/lib/cpg.c b/lib/cpg.c index f61efde..7cf862b 100644 --- a/lib/cpg.c +++ b/lib/cpg.c @@ -178,10 +178,6 @@ cs_error_t cpg_model_initialize

[Openais] [PATCH 19/20] crypto: rng_make_prng prevent buf overflow

with bits set to 1023, buf of 256 bytes was filled by rng_get_bytes up to 257 bytes. Buf is now 258 bytes so it's no longer problem. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/crypto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/crypto.c b/exec

Re: [Openais] [PATCH 18/20] cpg: do_proc_join change list_slice to list_add

Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: In this concrete case result is equivalent but makes coverity happy. Signed-off-by: Jan Friesse jfrie...@redhat.com --- services/cpg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/services/cpg.c b

Re: [Openais] [PATCH 17/20] votequorum: free newly allocated node if nodeid==0

Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- services/votequorum.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/services/votequorum.c b/services/votequorum.c index 5b89359..291da4b 100644

Re: [Openais] [PATCH 12/20] coroipcc: Test _SC_PAGESIZE result

Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/coroipcc.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/lib/coroipcc.c b/lib/coroipcc.c index 1adce0e..862047d 100644 --- a/lib

Re: [Openais] [PATCH 09/20] notifyd: Check retval of corosync_cfg_initialize

Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- tools/corosync-notifyd.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index 5ac2b83

Re: [Openais] [PATCH 08/20] mainconfig: Check retval of logsys_format_set

Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/mainconfig.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/exec/mainconfig.c b/exec/mainconfig.c index 44bd47a..c7df8c6 100644 --- a/exec

Re: [Openais] [PATCH 15/20] testcpgzc: fgets buffer to really allocated size

Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- test/testcpgzc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/testcpgzc.c b/test/testcpgzc.c index 5b496a8..14f621d 100644 --- a/test

Re: [Openais] [PATCH 08/20] mainconfig: Check retval of logsys_format_set

Better patch included Honza Steven Dake napsal(a): On 06/02/2011 12:19 AM, Jan Friesse wrote: Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/mainconfig.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions

[Openais] [PATCH 1/3] confdb: Properly check result of object_find_create

in confdb_object_iter result of object_find_create is now properly checked. object_find_create can return -1 if object doesn't exists. Without this check, incorrect handle (memory garbage) was directly passed to object_find_next. Signed-off-by: Jan Friesse jfrie...@redhat.com --- services

[Openais] [PATCH 2/3] coroipcc: check recvmsg result in socket_recv

According specification recvmsg can return 0, which means that connection is closed. We had this check, but limited only for systems other then Linux. recvmsg can return 0 even on Linux, so check is now applied on all systems. Signed-off-by: Jan Friesse jfrie...@redhat.com --- lib/coroipcc.c

[Openais] [PATCH 3/3] objdb: save copy of handles in object_find_create

object_find_create creates array of matching object handlers and object_find_next uses that array together with check for name. This prevents situation where between steps 2 and 3 new object is created with different name but sadly with same handler. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec

[Openais] [PATCH 2/2] CTS: Test for confdb dispatch deadlock

Test is disabled by default because it depends on SMP and about 2GB RAM. It's also testing race, so test is unreliable. Signed-off-by: Jan Friesse jfrie...@redhat.com --- cts/agents/Makefile.am |4 +- cts/agents/confdb-dispatch-deadlock.sh | 57

Re: [Openais] [PATCH 1/2] confdb: Resolve dispatch deadlock

Steven Dake napsal(a): Looks really good. one point below about error handling when writing to full pipe. Regards -steve On 06/16/2011 08:18 AM, Jan Friesse wrote: Following situation could happen: - one thread is waiting for finish write operation (line 853), objdb is locked - flush

[Openais] [PATCH 1/2] configure.ac: add --enable-spinlocks option

Spinlocks are now by default disabled, because even spinlock can improve speed is some special cases, in most cases it makes corosync CPU usage much more intensive and less responsive then if only mutexes are used. Signed-off-by: Jan Friesse jfrie...@redhat.com --- configure.ac | 13

[Openais] [PATCH 2/2] configure.ac: Align --enable-* options description

Signed-off-by: Jan Friesse jfrie...@redhat.com --- configure.ac | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index a01c90c..76afc9b 100644 --- a/configure.ac +++ b/configure.ac @@ -229,7 +229,7 @@ AC_ARG_ENABLE([debug

[Openais] [PATCH] configure.ac: change edefault to default

Signed-off-by: Jan Friesse jfrie...@redhat.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index fee8629..41dfeaf 100644 --- a/configure.ac +++ b/configure.ac @@ -264,7 +264,7 @@ AM_CONDITIONAL(BUILD_MONITORING, test x

[Openais] [PATCH] configure.ac: add --enable-spinlocks option

Spinlocks are now by default disabled, because even spinlock can improve speed is some special cases, in most cases it makes corosync CPU usage much more intensive and less responsive then if only mutexes are used. Signed-off-by: Jan Friesse jfrie...@redhat.com --- configure.ac | 13

Re: [Openais] [PATCH] configure.ac: add --enable-spinlocks option

On 06/21/2011 03:55 AM, Jan Friesse wrote: Spinlocks are now by default disabled, because even spinlock can improve speed is some special cases, in most cases it makes corosync CPU usage much more intensive and less responsive then if only mutexes are used. Signed-off-by: Jan Friesse jfrie

Re: [Openais] [PATCH V2] Implementation of automatic redundant ring recovery

Jiaju, thanks for your work. Patch looks pretty good and seems to resolve all issues Steve had. Few notes: - There are trailing whitespaces, please remove them (git diff with color output helps you) - at least encapsulated field in message_header is unitialized. Please initialize it (even by

Re: [Openais] [PATCH V2] Implementation of automatic redundant ring recovery

Jiaju Zhang wrote: On Mon, Jun 27, 2011 at 03:33:00PM +0200, Jan Friesse wrote: Jiaju, thanks for your work. Patch looks pretty good and seems to resolve all issues Steve had. Few notes: - There are trailing whitespaces, please remove them (git diff with color output helps you) OK, I've

Re: [Openais] [PATCH 12/20] coroipcc: Test _SC_PAGESIZE result

Coverity doesn't complain even with testing to -1, so better patch included. Regards, Honza Jan Friesse wrote: Steven Dake wrote: On 06/01/2011 09:14 AM, Jan Friesse wrote: Signed-off-by: Jan Friesse jfrie...@redhat.com Prefer a direct comparison for the error condition ie

[Openais] [PATCH] logsys: properly check sysconf _SC_PAGESIZE result

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/logsys.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/exec/logsys.c b/exec/logsys.c index cef745c..1ba2c11 100644 --- a/exec/logsys.c +++ b/exec/logsys.c @@ -1032,6 +1032,7 @@ int

Re: [Openais] [PATCH V4] Implementation of automatic redundant ring recovery

Hi Juaju, patch looks good so Reviewed-by: Jan Friesse jfrie...@redhat.com but I would like to have also Steve reviewed-by. So Steve, can you please review patch so ether I or you can commit that? Regards, Honza Jiaju Zhang napsal(a): This is the V4 version of the implementation

Re: [Openais] Compilation error in HEAD

Andrew, you are right in the fact that coroipcs uses functions defined in utils.c which are not linked to coroipcs itself. On the other hand, libcoroipcs is always used only with corosync and corosync executable contains this symbols, so there shouldn't be any problem. What compiler + OS +

[Openais] [PATCH] flatiron: enable compile with --enable-fatal-warnings

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemudpu.c|1 - test/testcpg.c |3 ++- tools/corosync-objctl.c |1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/exec/totemudpu.c b/exec/totemudpu.c index 9281057..a036b38 100644 --- a/exec

[Openais] [PATCH] totemiba: free send_buf on ibv_reg_mr failure

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemiba.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/exec/totemiba.c b/exec/totemiba.c index ec4ccfc..0b2d2ca 100644 --- a/exec/totemiba.c +++ b/exec/totemiba.c @@ -271,6 +271,7 @@ static inline struct

[Openais] Announcing Corosync 1.3.2 available at ftp.corosync.org!

(cherry picked from commit ba107f0a33fd5e6ef4073b9cc5539740e6ae3c12) 2011-07-07 Jan Friesse jfrie...@redhat.com flatiron: enable compile with --enable-fatal-warnings Reviewed-by: Steven Dake sd...@redhat.com 2011-07-04 Masatake YAMATO yam...@redhat.com

Re: [Openais] [PATCH] Correct missing poll funtions from service handler struct needed for confdb APIs.

Reviewed-by: Jan Friesse jfrie...@redhat.com Steven Dake napsal(a): Signed-off-by: Steven Dake sd...@redhat.com --- exec/apidef.c |4 +++- include/corosync/engine/coroapi.h | 17 - services/confdb.c |4 ++-- 3 files changed, 21

Re: [Openais] Announcing Corosync 1.3.2 available at ftp.corosync.org!

Proskurin Kirill napsal(a): On 07/07/2011 07:13 PM, Jan Friesse wrote: I am pleased to announce the latest maintenance release of Corosync 1.3.2 available immediately from our website at http://www.corosync.org. Could you tell - if 1.3.x is stable and recommended for production use? I`m

Re: [Openais] is UDPU better and effective than mcast/bcast?

Hi Xin, UDPU means UDP unicast. In other words, if you have 6 nodes, each message must be send 5 times (to each other node), instead of 1 time as in mcast/bcast (switch/hub will take care to deliver message to all other 5 nodes). So UDPU is definitively less effective then mcast/bcast. I'm not

[Openais] [PATCH 2/2] rrp: Handle rollower in passive rrp properly

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemrrp.c | 175 +++ 1 files changed, 112 insertions(+), 63 deletions(-) diff --git a/exec/totemrrp.c b/exec/totemrrp.c index 0445be2..6bfacd9 100644 --- a/exec/totemrrp.c +++ b/exec

[Openais] [PATCH 1/2] rrp: handle rollover in active rrp properly

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemrrp.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/exec/totemrrp.c b/exec/totemrrp.c index 6fb5772..0445be2 100644 --- a/exec/totemrrp.c +++ b/exec/totemrrp.c @@ -468,6 +468,22

[Openais] [PATCH] totemconfig: Change default FAIL_TO_RECV_CONST

. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemconfig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index 5135672..80ca182 100644 --- a/exec/totemconfig.c +++ b/exec/totemconfig.c @@ -73,7 +73,7 @@ #define

[Openais] [PATCH] totemconfig: Change default FAIL_TO_RECV_CONST

. Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemconfig.c |2 +- man/corosync.conf.5 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index 5135672..80ca182 100644 --- a/exec/totemconfig.c +++ b/exec/totemconfig.c

[Openais] [PATCH] rrp: handle rollover in active rrp properly

Signed-off-by: Jan Friesse jfrie...@redhat.com --- exec/totemrrp.c | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/exec/totemrrp.c b/exec/totemrrp.c index 6fb5772..eb9b788 100644 --- a/exec/totemrrp.c +++ b/exec/totemrrp.c @@ -468,6 +468,22

<    1   2   3   4   >