Re: [OpenBabel-Devel] Proposal to require test cases

2018-04-03 Thread Noel O'Boyle
Noted. We will do this. In fact, I commit to doing this whether or not this proposal goes ahead. - Noel On 3 April 2018 at 11:54, David Hall wrote: > I mostly agree, but I’ll mention the big hurdle I came across the first > time I wrote a test for openbabel. > > Many

[OpenBabel-Devel] Proposal to require test cases

2018-04-03 Thread Noel O'Boyle
Hi all, Very few PRs come with test cases. Basically, we just don't know if any of them do what they say, and even if they do, they probably will bit rot at a future date due to other PRs. The irony is that the person who wrote the code clearly tested it (one would assume) - but just didn't check