Re: [OpenBabel-Devel] Plugin loading patch

2011-10-18 Thread My Th
O , 2011-10-18 15:57 -0700, Craig A. James rakstīja: > On 10/18/11 3:30 PM, My Th wrote: > > O , 2011-10-18 22:40 +0100, Chris Morley rakstÄ«ja: > >> On 18/10/2011 20:18, My Th wrote: > >>> Hi! > >>> > >>> I have problems with your version of the patch. I'm using Gentoo Linux > >>> with gcc 4.6.1.

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-18 Thread Craig A. James
On 10/18/11 3:30 PM, My Th wrote: > O , 2011-10-18 22:40 +0100, Chris Morley rakstīja: >> On 18/10/2011 20:18, My Th wrote: >>> Hi! >>> >>> I have problems with your version of the patch. I'm using Gentoo Linux >>> with gcc 4.6.1. >>> >>> Running the test program I get this: >>> Try finding a forc

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-18 Thread My Th
O , 2011-10-18 22:40 +0100, Chris Morley rakstīja: > On 18/10/2011 20:18, My Th wrote: > > Hi! > > > > I have problems with your version of the patch. I'm using Gentoo Linux > > with gcc 4.6.1. > > > > Running the test program I get this: > > Try finding a forcefield in blank state.. > > terminate

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-18 Thread Chris Morley
On 18/10/2011 20:18, My Th wrote: > O , 2011-10-18 17:54 +0100, Chris Morley rakstīja: >> On 12/10/2011 00:15, My Th wrote: >>> Sv, 2011-10-09 23:48 +0300, My Th rakstīja: S , 2011-10-08 21:13 +0100, Chris Morley rakstīja: > On 08/10/2011 20:02, My Th wrote: >> It might be that the cha

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-18 Thread My Th
O , 2011-10-18 17:54 +0100, Chris Morley rakstīja: > On 12/10/2011 00:15, My Th wrote: > > Sv, 2011-10-09 23:48 +0300, My Th rakstīja: > >> S , 2011-10-08 21:13 +0100, Chris Morley rakstīja: > >>> On 08/10/2011 20:02, My Th wrote: > It might be that the changes could be implemented in other pl

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-18 Thread Chris Morley
On 12/10/2011 00:15, My Th wrote: Sv, 2011-10-09 23:48 +0300, My Th rakstīja: S , 2011-10-08 21:13 +0100, Chris Morley rakstīja: On 08/10/2011 20:02, My Th wrote: It might be that the changes could be implemented in other place which would shrink the patch size, but I don't know the OB code th

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-11 Thread My Th
Sv, 2011-10-09 23:48 +0300, My Th rakstīja: > S , 2011-10-08 21:13 +0100, Chris Morley rakstīja: > > On 08/10/2011 20:02, My Th wrote: > > > It might be that the changes could be implemented in other place which > > > would shrink the patch size, but I don't know the OB code that well, so > > > I w

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-09 Thread My Th
S , 2011-10-08 21:13 +0100, Chris Morley rakstīja: > On 08/10/2011 20:02, My Th wrote: > > It might be that the changes could be implemented in other place which > > would shrink the patch size, but I don't know the OB code that well, so > > I went for the most straightforward solution. > > Could

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-08 Thread My Th
S , 2011-10-08 21:13 +0100, Chris Morley rakstīja: > On 08/10/2011 20:02, My Th wrote: > > I have no idea how Windows dll loading works, but the code I touched > > should be above the platform specific bits. I used the same semantics as > > the old code had, only moved it to a place trough which go

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-08 Thread Chris Morley
On 08/10/2011 20:02, My Th wrote: > S , 2011-10-08 14:26 -0400, Geoff Hutchison rakstīja: >>> As far as I know it should not break binary compatibility, but I >> might> be wrong.> > I hope this change gets in eventually in one form >> or another. >> >> The change is a good one and it will eventu

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-08 Thread My Th
S , 2011-10-08 14:26 -0400, Geoff Hutchison rakstīja: > > As far as I know it should not break binary compatibility, but I > might > be wrong. > > I hope this change gets in eventually in one form > or another. > > The change is a good one and it will eventually go in -- I'd be OK to > apply it to

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-08 Thread Geoff Hutchison
> As far as I know it should not break binary compatibility, but I might > be wrong. > > I hope this change gets in eventually in one form or another. The change is a good one and it will eventually go in -- I'd be OK to apply it to SVN trunk when Chris has a chance to look at it. (The loading o

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-08 Thread My Th
S , 2011-10-08 17:45 +0100, Chris Morley rakstīja: > On 08/10/2011 17:07, My Th wrote: > > Hi! > > > > I have posted a patch (3411037) in tracker for plugin loading which > > moves the plugin loading away from OBConversion constructor and loads > > them instead on first access. I would like to get

Re: [OpenBabel-Devel] Plugin loading patch

2011-10-08 Thread Chris Morley
On 08/10/2011 17:07, My Th wrote: > Hi! > > I have posted a patch (3411037) in tracker for plugin loading which > moves the plugin loading away from OBConversion constructor and loads > them instead on first access. I would like to get some feedback on it. > > The use case for this is when the mole