Re: [OE-core] [PATCH pseudo 4/4] Do not return address of local variable - unverified

2021-07-29 Thread Damian Wrobel
On Wed, 28 Jul 2021 22:16:41 +0200 Seebs wrote > On Wed, 28 Jul 2021 11:36:22 +0200 > "Damian Wrobel" wrote: > > > Do I correctly assume that pseudo_client_op() has to be fully > > reentrant? > > No. It's never been even a tiny bit ree

Re: [OE-core] [PATCH pseudo 4/4] Do not return address of local variable

2021-07-28 Thread Damian Wrobel
On Tue, 27 Jul 2021 18:52:46 +0200 Seebs wrote > On Tue, 27 Jul 2021 18:30:33 +0200 > Damian Wrobel wrote: > > > The returned pointer has to be freed by the caller not by the callee > > function itself. > > So, this predates the p

Re: [OE-core] [PATCH pseudo 4/4] Do not return address of local variable

2021-07-27 Thread Damian Wrobel
On Tue, 27 Jul 2021 17:47:12 +0200 Seebs wrote > On Tue, 27 Jul 2021 13:49:06 +0200 > "Damian Wrobel" wrote: > > > Fixes the following warning: > > pseudo_client.c: In function ‘pseudo_client_op’: > > cc1: warning: function

Re: [OE-core] [PATCH pseudo 1/4] Remove -fno-strict-aliasing and -Wno-deprecated-declarations

2021-07-27 Thread Damian Wrobel
On Tue, 27 Jul 2021 17:49:27 +0200 Seebs wrote > On Tue, 27 Jul 2021 13:49:03 +0200 > "Damian Wrobel" wrote: > > > -# no-strict-aliasing is needed for the function pointer trickery. > > pseudo_wrappers.o: $(GUTS) pseudo_wrappers.c pseudo_wrap

[OE-core] [PATCH pseudo 2/4] Do not pass null argument to pseudo_diag()

2021-07-27 Thread Damian Wrobel
s'.\n", | ^~ 849 | path); | ~ Signed-off-by: Damian Wrobel --- pseudo_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pseudo_client.c b/pseudo_client.c index 579db3

[OE-core] [PATCH pseudo 4/4] Do not return address of local variable

2021-07-27 Thread Damian Wrobel
}; | ^~~ Signed-off-by: Damian Wrobel --- pseudo_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pseudo_client.c b/pseudo_client.c index 2583bca..f1d09ff 100644 --- a/pseudo_client.c +++ b/pseudo_client.c @@ -1889,7 +1889,7 @@ pseudo_client_op(pseudo_op_t op, int

[OE-core] [PATCH pseudo 1/4] Remove -fno-strict-aliasing and -Wno-deprecated-declarations

2021-07-27 Thread Damian Wrobel
They seems to be no longer needed. Tested on: $ gcc --version gcc (GCC) 11.1.1 20210531 (Red Hat 11.1.1-3) Signed-off-by: Damian Wrobel --- Makefile.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile.in b/Makefile.in index 10441ef..1ad8836 100644

[OE-core] [PATCH pseudo 3/4] Use -pthread instead of -lpthread

2021-07-27 Thread Damian Wrobel
Signed-off-by: Damian Wrobel --- Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 1ad8836..162e729 100644 --- a/Makefile.in +++ b/Makefile.in @@ -61,8 +61,8 @@ DBOBJS=pseudo_db.o WRAPOBJS=pseudo_wrappers.o # needed

[OE-core] [PATCH v3] rootfs: remove ldconfig auxiliary cache where appropriate

2021-07-27 Thread Damian Wrobel
Removes the /var/cache/ldconfig auxiliary cache directory from the rootfs when: - read-only-rootfs is in IMAGE_FEATURES, - ldconfig is not in DISTRO_FEATURES. In both cases the /var/cache/ldconfig/aux-cache is useless. Signed-off-by: Damian Wrobel --- meta/lib/oe/rootfs.py | 10 ++ 1

Re: [OE-core] [PATCH v2] rootfs: remove ldconfig auxiliary cache where appropriate

2021-07-27 Thread Damian Wrobel
On Fri, 23 Jul 2021 20:21:28 +0200 Andre McCurdy wrote > On Fri, Jul 23, 2021 at 2:22 AM Damian Wrobel > wrote: > > > > Removes the /var/cache/ldconfig auxiliary cache directory from > > the rootfs when: > > - read-only-rootfs is in DIS

[OE-core] [PATCH v2] rootfs: remove ldconfig auxiliary cache where appropriate

2021-07-23 Thread Damian Wrobel
Removes the /var/cache/ldconfig auxiliary cache directory from the rootfs when: - read-only-rootfs is in DISTRO_FEATURES, - ldconfig is not in DISTRO_FEATURES. In both cases the /var/cache/ldconfig/aux-cache is useless. Signed-off-by: Damian Wrobel --- meta/lib/oe/rootfs.py | 10

Re: [OE-core] [PATCH] rootfs: remove ldconfig auxiliary cache where appropriate

2021-07-23 Thread Damian Wrobel
On Fri, 23 Jul 2021 00:37:08 +0200 Alexandre Belloni wrote > On 22/07/2021 11:48:22+0200, Damian Wrobel wrote: > > Removes the /var/cache/ldconfig auxiliary cache directory from > > the rootfs when: > > - read-only-rootfs is in DISTRO_FEATU

Re: [OE-core] [PATCH] rootfs: remove ldconfig auxiliary cache where appropriate

2021-07-23 Thread Damian Wrobel
On Thu, 22 Jul 2021 21:00:15 +0200 Andre McCurdy wrote > On Thu, Jul 22, 2021 at 2:48 AM Damian Wrobel > wrote: > > > > Removes the /var/cache/ldconfig auxiliary cache directory from > > the rootfs when: > > - read-only-rootfs is in DIS

[OE-core] [PATCH] rootfs: remove ldconfig auxiliary cache where appropriate

2021-07-22 Thread Damian Wrobel
Removes the /var/cache/ldconfig auxiliary cache directory from the rootfs when: - read-only-rootfs is in DISTRO_FEATURES, - ldconfig is not in DISTRO_FEATURES. In both cases the /var/cache/ldconfig/aux-cache is useless. Signed-off-by: Damian Wrobel --- meta/lib/oe/rootfs.py | 9 + 1

[OE-core] [PATCH] report-error: Mask AWS credentials to avoid leaking them

2021-07-13 Thread Damian Wrobel
From: Adam Romanek Removes potentially presonal information from error reports. Signed-off-by: Adam Romanek Signed-off-by: Damian Wrobel --- meta/classes/report-error.bbclass | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/meta/classes/report

[OE-core] [PATCH] own-mirrors: Add support for s3:// scheme in SOURCE_MIRROR_URL

2021-07-13 Thread Damian Wrobel
From: Adam Romanek Signed-off-by: Adam Romanek Signed-off-by: Damian Wrobel --- meta/classes/own-mirrors.bbclass | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/classes/own-mirrors.bbclass b/meta/classes/own-mirrors.bbclass index a777835138..d58a61fe0a 100644 --- a/meta/classes/own

[OE-core] [PATCH] gobject-introspection: Fix the license (add MIT)

2021-07-12 Thread Damian Wrobel
on/-/blob/master/COPYING#L8 [2] https://src.fedoraproject.org/rpms/gobject-introspection/c/6db290968fa1f92967851dc60115dfb3ea173cf7?branch=rawhide Signed-off-by: Damian Wrobel --- .../gobject-introspection/gobject-introspection_1.68.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [OE-core] curious about weirdness in some FILES_${PN} settings

2021-03-23 Thread Damian Wrobel
On Mon, 22 Mar 2021 20:27:42 +0100 Andre McCurdy wrote > On Mon, Mar 22, 2021 at 11:43 AM Robert P. J. Day > wrote: > > (warning: i've just been handed an existing OE code base, and i'm > > going to ask some questions about some head-scratching things i'm > > finding in

Re: [OE-core] [PATCH] base.bbclass: Honor PATH when selecting hosttools

2021-03-18 Thread Damian Wrobel
On Thu, 18 Mar 2021 15:31:02 +0100 Richard Purdie wrote > On Thu, 2021-03-18 at 15:23 +0100, Damian Wrobel wrote: > > Honors the PATH[1] and other user settings like > > system wide ccache when selecting hosttools. > > > > Fixes the following compi

[OE-core] [PATCH] base.bbclass: Honor PATH when selecting hosttools

2021-03-18 Thread Damian Wrobel
://www.softwarecollections.org/en/scls/rhscl/devtoolset-7/ Signed-off-by: Damian Wrobel --- meta/classes/base.bbclass | 6 -- 1 file changed, 6 deletions(-) diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass index b4160402f0..67b0fa1497 100644 --- a/meta/classes/base.bbclass +++ b/meta/classes

[OE-core] [PATCH] rootfs: do not let ldconfig to create symlinks

2020-07-02 Thread Damian Wrobel
link will remain on the filesystem. Not to mention that such a symlink is orphaned (e.g. rpm -qf will not show the package the symlink is part of). It also align the behaviour with libc-musl where the ldconfig is not invoked by default. Signed-off-by: Damian Wrobel --- meta/lib/oe/rootfs.py | 4