[OE-core] [PATCH 1/1] externalsrc: Don't wipe out src dir when EXPORT_FUNCTIONS is used.

2022-09-08 Thread Kristian Amlie via lists.openembedded.org
Signed-off-by: Kristian Amlie --- meta/classes-recipe/externalsrc.bbclass | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/meta/classes-recipe/externalsrc.bbclass b/meta/classes-recipe/externalsrc.bbclass index 51dbe9ea5a..ce753fce76 100644 --- a/meta/clas

Re: [OE-core] externalsrc wiping out external source directory

2022-07-05 Thread Kristian Amlie via lists.openembedded.org
On 20/06/2022 17:35, Richard Purdie wrote: On Mon, 2022-06-20 at 13:56 +0200, Kristian Amlie wrote: Just for the record, and for any people googling this: Until this is fixed, just reverting the above commit works to fix this problem. Richard, correct me if I'm wrong, but I have not yet seen

Re: [OE-core] externalsrc wiping out external source directory

2022-06-20 Thread Kristian Amlie via lists.openembedded.org
On 30/05/2022 14:32, Kristian Amlie wrote: On 30/05/2022 13:48, richard.pur...@linuxfoundation.org wrote: On Mon, 2022-05-30 at 13:46 +0200, Kristian Amlie wrote: On 27/05/2022 16:19, richard.pur...@linuxfoundation.org wrote: On Fri, 2022-05-27 at 14:07 +0200, Kristian Amlie via

Re: [OE-core] externalsrc wiping out external source directory

2022-05-30 Thread Kristian Amlie via lists.openembedded.org
On 30/05/2022 13:48, richard.pur...@linuxfoundation.org wrote: On Mon, 2022-05-30 at 13:46 +0200, Kristian Amlie wrote: On 27/05/2022 16:19, richard.pur...@linuxfoundation.org wrote: On Fri, 2022-05-27 at 14:07 +0200, Kristian Amlie via lists.openembedded.org wrote: Hey all, I have a problem

Re: [OE-core] externalsrc wiping out external source directory

2022-05-30 Thread Kristian Amlie via lists.openembedded.org
On 27/05/2022 16:19, richard.pur...@linuxfoundation.org wrote: On Fri, 2022-05-27 at 14:07 +0200, Kristian Amlie via lists.openembedded.org wrote: Hey all, I have a problem on kirkstone where using the "externalsrc" class wipes out the directory mentioned in EXTERNALSRC, in othe

Re: [OE-core] externalsrc wiping out external source directory

2022-05-27 Thread Kristian Amlie via lists.openembedded.org
On 27/05/2022 16:19, richard.pur...@linuxfoundation.org wrote: On Fri, 2022-05-27 at 14:07 +0200, Kristian Amlie via lists.openembedded.org wrote: Hey all, I have a problem on kirkstone where using the "externalsrc" class wipes out the directory mentioned in EXTERNALSRC, in othe

[OE-core] externalsrc wiping out external source directory

2022-05-27 Thread Kristian Amlie via lists.openembedded.org
Hey all, I have a problem on kirkstone where using the "externalsrc" class wipes out the directory mentioned in EXTERNALSRC, in other words my personal development repository. I have traced it down to the "do_unpack[cleandirs]" variable flag. This flag is supposed to be removed here [1]

[OE-core] [PATCH 1/1] grub-efi: Provide target architecture for 32-bit ARM.

2018-07-10 Thread Kristian Amlie
Signed-off-by: Kristian Amlie --- meta/recipes-bsp/grub/grub-efi_2.02.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-bsp/grub/grub-efi_2.02.bb b/meta/recipes-bsp/grub/grub-efi_2.02.bb index 7bfc8ee..14fce97 100644 --- a/meta/recipes-bsp/grub/grub-efi_2.02.bb +++ b/meta

Re: [OE-core] [PATCH v7] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2018-03-15 Thread Kristian Amlie
On 13/02/18 02:29, Cal Sullivan wrote: >> ... >> + >> +    if path.endswith(os.sep): > We need to check if full_path exists here, else it may try modifying > things that don't exist. E.g., if I have IMAGE_ROOTFS_EXCLUDE_PATH = > "boot" in local.conf and do 'bitbake

Re: [OE-core] [PATCH] systemd: Make sure that resolv.conf points to writable area in R/O rootfs.

2018-01-26 Thread Kristian Amlie
Amlie wrote: > Normally we want systemd to populate it at runtime, but when we have a > read-only root filesystem we can't, so do it during the build. > > Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> > Signed-off-by: Marcin Pasinski <marcin.pasin...@mender.io>

[OE-core] [PATCH] systemd: Make sure that resolv.conf points to writable area in R/O rootfs.

2018-01-26 Thread Kristian Amlie
Normally we want systemd to populate it at runtime, but when we have a read-only root filesystem we can't, so do it during the build. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> Signed-off-by: Marcin Pasinski <marcin.pasin...@mender.io> --- meta/recipes-core/systemd

Re: [OE-core] [PATCH v7] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2018-01-26 Thread Kristian Amlie
On 25/01/18 11:58, Martin Hundebøll wrote: > Hi Kristian, > > Thanks for your work on this! > > On 2018-01-25 11:33, Kristian Amlie wrote: >> This is a direct followup from the earlier 6602392db3d39 commit in >> wic. It works more or less the same way: Th

[OE-core] [PATCH v8] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2018-01-26 Thread Kristian Amlie
images. These can turn the feature off locally by defining: do_image_myfs[respect_exclude_path] = "0" Specifically, "wic" and "multiubi" come with the feature disabled. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- meta/

Re: [OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2018-01-25 Thread Kristian Amlie
>>> Bear with the pre-release freeze period please; once rocko is out >>> patches will start flowing to master again. >> >> So now that rocko has been out for a while, can we get this in please? >> Already reviewed, and rebased patch is included. > > Please do pay attention to what the recent

[OE-core] [PATCH v7] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2018-01-25 Thread Kristian Amlie
images. These can turn the feature off locally by defining: do_image_myfs[respect_exclude_path] = "0" Specifically, "wic" and "multiubi" come with the feature disabled. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- meta/

[OE-core] [PATCH v4] u-boot-fw-utils: Fix broken makefile in v2017.11.

2017-12-15 Thread Kristian Amlie
See the patch for details. This patch has already been applied upstream, but we need it for v2017.11. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- .../u-boot/files/v2017.11-fw-utils-build-fix.patch | 41 ++ meta/recipes-bsp/u-boot/u-boot-common_2017.

Re: [OE-core] [PATCH v3] u-boot-fw-utils: Fix broken makefile in v2017.11.

2017-12-15 Thread Kristian Amlie
>> Isn't it "Upstream-Status: Backport [URL]"? >> >> Also, what were the changes in v2 and v3 of this patch? > > Yes, it should be backport and the header is to be included in the > patch file, not on the commit log Sorry, I thought it was Accepted because there is not (yet) any official

[OE-core] [PATCH v3] u-boot-fw-utils: Fix broken makefile in v2017.11.

2017-12-13 Thread Kristian Amlie
See the patch for details. This patch has already been applied upstream, but we need it for v2017.11. Upstream-Status: Accepted [http://git.denx.de/?p=u-boot.git;a=commit;h=ded84f90a1066eef5f34daa4539273de64f7b811] Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- .../

[OE-core] [PATCH v2] u-boot-fw-utils: Fix broken makefile in v2017.11.

2017-12-13 Thread Kristian Amlie
See the patch for details. This patch has already been applied upstream, but we need it for v2017.11. Upstream-Status: Accepted [http://git.denx.de/?p=u-boot.git;a=commit;h=ded84f90a1066eef5f34daa4539273de64f7b811] Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- .../

[OE-core] [PATCH] u-boot-fw-utils: Fix broken makefile in v2017.11.

2017-12-13 Thread Kristian Amlie
See the patch for details. This patch has already been applied upstream, but we need it for v2017.11. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- .../u-boot/files/v2017.11-fw-utils-build-fix.patch | 37 ++ meta/recipes-bsp/u-boot/u-boot-common_2017.

Re: [OE-core] [PATCH v1] systemd: Avoid fsck because time is out of sync on first boot.

2017-11-23 Thread Kristian Amlie
uild time? -- Kristian > On 22 November 2017 at 13:30, Kristian Amlie > <kristian.am...@northern.tech <mailto:kristian.am...@northern.tech>> wrote: > > By default, systemd uses its build time as the epoch. When systemd is > launched on a system without a real time clo

Re: [OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-11-22 Thread Kristian Amlie
On 22/11/17 14:31, Alexander Kanavin wrote: > On 11/22/2017 03:13 PM, Kristian Amlie wrote: > >>> Bear with the pre-release freeze period please; once rocko is out >>> patches will start flowing to master again. >> >> So now that rocko has been out fo

[OE-core] [PATCH v1] systemd: Avoid fsck because time is out of sync on first boot.

2017-11-22 Thread Kristian Amlie
will be skipped. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- meta/recipes-core/systemd/systemd_234.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-core/systemd/systemd_234.bb b/meta/recipes-core/systemd/systemd_234.bb index 6b8745b..86c04fe 100644 ---

[OE-core] [PATCH v7] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-11-22 Thread Kristian Amlie
images. These can turn the feature off locally by defining: do_image_myfs[respect_exclude_path] = "0" Specifically, "wic" and "multiubi" come with the feature disabled. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- meta/

Re: [OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-11-22 Thread Kristian Amlie
On 13/10/17 12:37, Alexander Kanavin wrote: >> ... > > Bear with the pre-release freeze period please; once rocko is out > patches will start flowing to master again. So now that rocko has been out for a while, can we get this in please? Already reviewed, and rebased patch is included. --

Re: [OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-10-13 Thread Kristian Amlie
On 13/10/17 12:37, Alexander Kanavin wrote: > On 10/13/2017 12:08 PM, Kristian Amlie wrote: >> Rebased again. >> >> Can we get this in please? It has been reviewed and rebased several times >> already, and has lingered on the list for a long time. > > Bear w

[OE-core] [PATCH v7] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-10-13 Thread Kristian Amlie
images. These can turn the feature off locally by defining: do_image_myfs[respect_exclude_path] = "0" Specifically, "wic" and "multiubi" come with the feature disabled. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- meta/

Re: [OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-10-13 Thread Kristian Amlie
Rebased again. Can we get this in please? It has been reviewed and rebased several times already, and has lingered on the list for a long time. Regards Kristian Amlie -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http

Re: [OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-09-18 Thread Kristian Amlie
Ping. Anything missing here? -- Kristian On 28/08/17 17:47, Kristian Amlie wrote: > This is a direct followup from the earlier 6602392db3d39 commit in > wic. It works more or less the same way: The variable specifies a list > of directories relative to the root of t

[OE-core] [PATCH v6] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-28 Thread Kristian Amlie
images. These can turn the feature off locally by defining: do_image_myfs[respect_exclude_path] = "0" Specifically, "wic" and "multiubi" come with the feature disabled. Signed-off-by: Kristian Amlie <kristian.am...@northern.tech> --- meta/

Re: [OE-core] [PATCH v5] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-28 Thread Kristian Amlie
On 23/08/17 15:19, Kristian Amlie wrote: > On 23/08/17 14:47, Richard Purdie wrote: >> On Wed, 2017-08-23 at 14:39 +0200, Kristian Amlie wrote: >>> From: Kristian Amlie <kristian.am...@mender.io> >>> >>> This is a direct followup from the earlier f6a06

Re: [OE-core] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
On 23/08/17 14:46, Richard Purdie wrote: > On Wed, 2017-08-23 at 14:39 +0200, Kristian Amlie wrote: >> I don't understand why I'm getting patch failures. This is rebased to >> cutting edge master. Trying one more time... > > Its because you're patching documentatio

Re: [OE-core] [PATCH v5] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
On 23/08/17 14:47, Richard Purdie wrote: > On Wed, 2017-08-23 at 14:39 +0200, Kristian Amlie wrote: >> From: Kristian Amlie <kristian.am...@mender.io> >> >> This is a direct followup from the earlier f6a064d969f414 commit in >> wic. It works more or less the

Re: [OE-core] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
I don't understand why I'm getting patch failures. This is rebased to cutting edge master. Trying one more time... -- Kristian -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org

[OE-core] [PATCH v5] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
From: Kristian Amlie <kristian.am...@mender.io> This is a direct followup from the earlier f6a064d969f414 commit in wic. It works more or less the same way: The variable specifies a list of directories relative to the root of the rootfs, and these directories will be excluded from the res

[OE-core] [PATCH v4] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
From: Kristian Amlie <kristian.am...@mender.io> This is a direct followup from the earlier f6a064d969f414 commit in wic. It works more or less the same way: The variable specifies a list of directories relative to the root of the rootfs, and these directories will be excluded from the res

Re: [OE-core] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
Ping, third rebase now! This is related to https://bugzilla.yoctoproject.org/show_bug.cgi?id=11688. -- Kristian -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org

[OE-core] [PATCH v4] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-08-23 Thread Kristian Amlie
From: Kristian Amlie <kristian.am...@mender.io> This is a direct followup from the earlier f6a064d969f414 commit in wic. It works more or less the same way: The variable specifies a list of directories relative to the root of the rootfs, and these directories will be excluded from the res

[OE-core] [PATCH v3] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-06-19 Thread Kristian Amlie
while others have. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- documentation/ref-manual/ref-variables.xml | 35 + meta/classes/image.bbclass | 83 -- meta/classes/image_types.bbclass | 13 + 3 files changed, 128

Re: [OE-core] [PATCH v2] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-06-19 Thread Kristian Amlie
Turns out this needed a rebase. Here you go. -- Kristian -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-06-19 Thread Kristian Amlie
Ping. I created https://bugzilla.yoctoproject.org/show_bug.cgi?id=11688 to help track this. -- Kristian On 30/05/17 09:46, Kristian Amlie wrote: > This is a direct followup from the earlier f6a064d969f414 commit in > wic. It works more or less the same way: The variable specifies

[OE-core] [PATCH] wic: Remove obsolete reference to msger logger.

2017-05-30 Thread Kristian Amlie
This was overlooked when msger was removed in 28014087b8091. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/plugins/source/rootfs.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scrip

Re: [OE-core] do_image: Adding support for IMAGE_ROOTFS_EXCLUDE_PATH.

2017-05-30 Thread Kristian Amlie
Updated the patch and included documentation. It wasn't clear to me how to write a test for this. I couldn't spot any tests for the surrounding variables, but I might be missing something. If this is important, please let me know where I should add them. -- Kristian --

[OE-core] [PATCH v2] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-05-30 Thread Kristian Amlie
while others have. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- documentation/ref-manual/ref-variables.xml | 35 + meta/classes/image.bbclass | 83 -- meta/classes/image_types.bbclass | 13 + 3 files changed, 128

Re: [OE-core] do_image: Adding support for IMAGE_ROOTFS_EXCLUDE_PATH.

2017-05-22 Thread Kristian Amlie
On 22/05/17 10:46, Ed Bartosh wrote: > On Mon, May 22, 2017 at 09:08:41AM +0200, Kristian Amlie wrote: >> Ping. Would be great to get some feedback so I can continue working on this. >> > I like the idea. > > Lately I was working on generic EFI implementation > and th

Re: [OE-core] do_image: Adding support for IMAGE_ROOTFS_EXCLUDE_PATH.

2017-05-22 Thread Kristian Amlie
Ping. Would be great to get some feedback so I can continue working on this. -- Kristian On 26/04/17 17:03, Kristian Amlie wrote: > This is a direct followup from the earlier f6a064d969f414 commit in wic. It > works more or less the same way: The variable specifies a list of direc

Re: [OE-core] volatile-binds and DNS

2017-05-18 Thread Kristian Amlie
On 18/05/17 14:30, Andrea Galbusera wrote: > On Thu, May 18, 2017 at 9:16 AM, Kristian Amlie > <kristian.am...@mender.io <mailto:kristian.am...@mender.io>> wrote: > > We've discovered that one of the recent commits to poky has broken DNS > resolution in our ima

[OE-core] volatile-binds and DNS

2017-05-18 Thread Kristian Amlie
We've discovered that one of the recent commits to poky has broken DNS resolution in our image. The commit in questions is this one: --- commit fcd48092d7bcab0cad2606e65332da62420935ad Author: Joe Slater Date: Fri Mar 31 03:06:33 2017 volatile-binds:

[OE-core] do_image: Adding support for IMAGE_ROOTFS_EXCLUDE_PATH.

2017-04-26 Thread Kristian Amlie
This is a direct followup from the earlier f6a064d969f414 commit in wic. It works more or less the same way: The variable specifies a list of directories relative to the root of the rootfs, and these directories will be excluded from the resulting rootfs image. If an entry ends with a slash, only

[OE-core] [PATCH] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature.

2017-04-26 Thread Kristian Amlie
the contents are omitted, not the directory itself. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/classes/image.bbclass | 73 -- 1 file changed, 71 insertions(+), 2 deletions(-) diff --git a/meta/classes/image.bbclass b/meta/c

[OE-core] [PATCH] wic: Fix typo in help screen.

2017-04-26 Thread Kristian Amlie
This was overlooked when f6a064d969f4149b was merged. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/help.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib/wic/help.py b/scripts/lib/wic/help.py index aee2451..d6e027d

Re: [OE-core] go-bootstrap / go-native conflict during do_rootfs

2017-03-21 Thread Kristian Amlie
>>>> On Mon, Mar 20, 2017 at 6:47 AM, Kristian Amlie >>>> <kristian.am...@mender.io> wrote: >>>>> >>>>> -- >>>>> >>>>> Additionally, in the logs I found t

[OE-core] go-bootstrap / go-native conflict during do_rootfs

2017-03-20 Thread Kristian Amlie
First of all, kudos to Khem Raj for the hard work on the go compiler support, this will help a lot! However, I have one problem when my project reaches do_rootfs: -- ERROR: core-image-full-cmdline-1.0-r0 do_rootfs: Error executing a python function in

Re: [OE-core] [PATCH V7] go: Add recipes for golang compilers and tools

2017-03-13 Thread Kristian Amlie
On 09/03/17 08:27, Khem Raj wrote: > On Wed, Mar 8, 2017 at 11:03 PM, Kristian Amlie > <kristian.am...@mender.io> wrote: >> On 08/03/17 23:19, Khem Raj wrote: >>>> ... >>>> For the following go-1.4 recipes: >>>> >>>>

Re: [OE-core] [PATCH] wic: selftest: account for occasional newline in debugfs file names

2017-03-13 Thread Kristian Amlie
On 13/03/17 11:19, Maciej Borzecki wrote: > Debugfs output may contain a newline in file names in 'ls -p' output. Make > sure > that output is correctly split into lines by matching '/\n' and newlines are > removed from file names. > > Fixes the following error appearing in AB tests: > >

[OE-core] [PATCH v3] wic/partionedfs: Avoid reserving space for non-existing ext. partition

2017-03-10 Thread Kristian Amlie
We don't need the gap that the extended partition occupies if we already know that we have less than five partitions. Saves up to one full alignment of space. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/plugins/imager/direct.py | 8 ++-- 1 file chan

Re: [OE-core] [PATCH] wic/partionedfs: Avoid reserving space for non-existing ext. partition

2017-03-10 Thread Kristian Amlie
Alright, finally got around to this again. Patch rebased, and passing tests. -- Kristian -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2] wic/direct.py: Avoid exception if using multiple rawcopy/no-table entries.

2017-03-09 Thread Kristian Amlie
once. [1] Although they reuse the same file, the resulting output is correct, so it appears the file is accessed in properly sequential order. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/plugins/imager/direct.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[OE-core] [PATCH] wic/direct.py: Avoid exception if using multiple rawcopy/no-table entries.

2017-03-08 Thread Kristian Amlie
e doesn't exist. [1] Although they reuse the same file, the resulting output is correct, so it appears the file is accessed in properly sequential order. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/plugins/imager/direct.py | 5 - 1 file changed, 4

Re: [OE-core] [PATCH V7] go: Add recipes for golang compilers and tools

2017-03-08 Thread Kristian Amlie
On 08/03/17 23:19, Khem Raj wrote: >> ... >> For the following go-1.4 recipes: >> >> I wouldn't recommend fixing go-native at version 1.4, which is now >> postiviely ancient. >> Instead, add go1.4.3's SRC_URI into the go-native recipe, loading it >> in the right place so >> that make.bash finds

Re: [OE-core] Recipe specific sysroots: New failure to compile Go

2017-03-07 Thread Kristian Amlie
On 28/02/17 19:59, Khem Raj wrote: > On Tue, Jan 24, 2017 at 3:34 AM, Kristian Amlie > <kristian.am...@mender.io> wrote: >> On 24/01/17 11:17, Jussi Kukkonen wrote: >>> On 24 January 2017 at 11:36, Kristian Amlie <kristian.am...@mender.io >>> <mailto:k

Re: [OE-core] [PATCH] wic/partionedfs: Avoid reserving space for non-existing ext. partition

2017-02-16 Thread Kristian Amlie
On 16/02/17 12:40, Ed Bartosh wrote: > Hi Kristian, > > Thank you for the patch. It looks good to me. Just one thing needs to be > changed. See my comment below. > > On Thu, Feb 16, 2017 at 11:30:12AM +0100, Kristian Amlie wrote: >> We don't need the gap that the ext

[OE-core] [PATCH] wic/partionedfs: Avoid reserving space for non-existing ext. partition

2017-02-16 Thread Kristian Amlie
We don't need the gap that the extended partition occupies if we already know that we have less than five partitions. Saves up to one full alignment of space. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/plugins/imager/direct.py | 8 ++-- 1 file chan

Re: [OE-core] [PATCH] wic/partionedfs: Avoid reserving space for non-existing ext. partition

2017-02-14 Thread Kristian Amlie
Ping. Patch still applies, should be a very easy change. -- Kristian On 27/01/17 07:51, Kristian Amlie wrote: > We don't need the gap that the extended partition occupies if we > already know that we have less than five partitions. Saves up to one > full alignment of space. >

Re: [OE-core] ✗ patchtest: failure for wic: Add --exclude-path option to rootfs source plugin. (rev11)

2017-02-06 Thread Kristian Amlie
Is this old? The patch it mentions is not part of the patchset anymore. I noticed I forgot to add the 'v5' tag to the patches I posted yesterday. Maybe that's why? -- Kristian On 06/02/17 17:29, Patchwork wrote: > == Series Details == > > Series: wic: Add --exclude-path option to rootfs

Re: [OE-core] [PATCH v4 2/2] selftest/wic: Add tests for --exclude-dir option.

2017-02-06 Thread Kristian Amlie
Rebased and reran tests. Changes since last patchset: - Because of recipe specific sysroots we now need to import the PATH used by wic-tools into the test in order to use its tools. - Add specific '-o' parameter while testing wic so that we write into resultdir. - Several unrelated changes

[OE-core] [PATCH 2/2] selftest/wic: Add tests for --exclude-dir option.

2017-02-06 Thread Kristian Amlie
Based partially on an earlier patch by Maciej Borzecki. Note that because tools now reside in recipe specific sysroots, we need to import the path from bitbake and apply it during the test. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/lib/oeqa/selftest/wic.py

[OE-core] [PATCH 1/2] wic: Add --exclude-path option to rootfs source plugin.

2017-02-06 Thread Kristian Amlie
from it. Since we want to use the copyhardlinktree() function, we need to put the generic oe lib in the module search path. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/help.py | 6 + scripts/lib/wic/ksparser.py | 1 + s

[OE-core] [PATCH] wic-tools: Do not remove sysroot with rm_work, because wic needs it.

2017-01-30 Thread Kristian Amlie
The sysroot of wic-tools is needed for wic, but if rm_work is enabled, it will be removed before wic has a chance to use it, hence this fix. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/recipes-core/meta/wic-tools.bb | 4 1 file changed, 4 insertions(+) diff

Re: [OE-core] sysroots, wic-tools and rm_work

2017-01-27 Thread Kristian Amlie
On 27/01/17 13:05, Patrick Ohly wrote: > On Thu, 2017-01-26 at 16:39 +0100, Kristian Amlie wrote: >> It seems like wic doesn't work together with rm_work, because of its >> dependency on wic-tools. The reason is that building wic-tools will >> result in rm_work removing the

[OE-core] [PATCH] wic/partionedfs: Avoid reserving space for non-existing ext. partition

2017-01-26 Thread Kristian Amlie
We don't need the gap that the extended partition occupies if we already know that we have less than five partitions. Saves up to one full alignment of space. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/utils/partitionedfs.py | 8 ++-- 1 file chan

[OE-core] sysroots, wic-tools and rm_work

2017-01-26 Thread Kristian Amlie
It seems like wic doesn't work together with rm_work, because of its dependency on wic-tools. The reason is that building wic-tools will result in rm_work removing the very sysroot that wic needs. It's easy to fix locally by adding RM_WORK_EXCLUDE = "wic-tools" however, I think this deserves

[OE-core] [PATCH] sstate: Make SSTATE_SCAN_CMD vars configurable using weak defaults.

2017-01-25 Thread Kristian Amlie
. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/classes/cross.bbclass| 4 meta/classes/crosssdk.bbclass | 4 meta/classes/native.bbclass | 4 meta/classes/sstate.bbclass | 9 ++--- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git

Re: [OE-core] ✗ patchtest: failure for Make SSTATE_SCAN_CMD vars configurable using weak defaults.

2017-01-25 Thread Kristian Amlie
Sorry I forgot the right patch format, but let me know if you agree with the patch first, and I'll repost. -- Kristian On 25/01/17 15:23, Patchwork wrote: > == Series Details == > > Series: Make SSTATE_SCAN_CMD vars configurable using weak defaults. > Revision: 1 > URL :

Re: [OE-core] Overriding fixmepath

2017-01-25 Thread Kristian Amlie
>> Take a look at the attached file, to me the inclusion of .a files in >> the >> fixmepath file seems wrong, so I can start with that, unless you have >> better idea. > > I think this is a very good lead. The code searches for replacements to > make with: "grep -Irl" (see sstate.bbclass) and it

[OE-core] [PATCH] Make SSTATE_SCAN_CMD vars configurable using weak defaults.

2017-01-25 Thread Kristian Amlie
. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/classes/cross.bbclass| 4 meta/classes/crosssdk.bbclass | 4 meta/classes/native.bbclass | 4 meta/classes/sstate.bbclass | 9 ++--- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git

Re: [OE-core] Overriding fixmepath

2017-01-25 Thread Kristian Amlie
On 25/01/17 12:24, Richard Purdie wrote: > On Wed, 2017-01-25 at 11:43 +0100, Kristian Amlie wrote: >> After the new recipe sysroots were introduced we've been having >> trouble >> compiling Go. I've narrowed it down to the path replacement mechanism >> t

[OE-core] Overriding fixmepath

2017-01-25 Thread Kristian Amlie
After the new recipe sysroots were introduced we've been having trouble compiling Go. I've narrowed it down to the path replacement mechanism that goes on using fixmepath. For example, this does not work: bitbake -c cleansstate go-cross bitbake go-cross But this does: bitbake -c

Re: [OE-core] Recipe specific sysroots: New failure to compile Go

2017-01-24 Thread Kristian Amlie
On 24/01/17 11:17, Jussi Kukkonen wrote: > On 24 January 2017 at 11:36, Kristian Amlie <kristian.am...@mender.io > <mailto:kristian.am...@mender.io>> wrote: > [snip] > > > /home/jenkins/workspace/yoctobuild/build-qemu/tmp/work/x86_64-linux/go-native/1.7.4-r0/re

[OE-core] Recipe specific sysroots: New failure to compile Go

2017-01-24 Thread Kristian Amlie
After the new feature, recipe specific sysroots, was added, I'm facing the following compile error when compiling Go: --- ERROR: go-native-1.7.4-r0 do_compile: Function failed: do_compile (log file is located at

Re: [OE-core] [PATCH v4 2/2] selftest/wic: Add tests for --exclude-dir option.

2017-01-16 Thread Kristian Amlie
On 29/12/16 15:03, Kristian Amlie wrote: > Rebased patchset, otherwise identical to the last one: > > * Removed e2tools recipe. > * Switched to using 'debugfs' instead of 'e2ls' in selftest. Is anything missing here? Would be nice to get this done so I can start on the d

[OE-core] [PATCH v5 1/2] wic: Add --exclude-path option to rootfs source plugin.

2016-12-29 Thread Kristian Amlie
from it. Since we want to use the copyhardlinktree() function, we need to put the generic oe lib in the module search path. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/help.py | 6 + scripts/lib/wic/ksparser.py | 1 + s

[OE-core] [PATCH v5 2/2] selftest/wic: Add tests for --exclude-dir option.

2016-12-29 Thread Kristian Amlie
Based partially on an earlier patch by Maciej Borzecki. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/lib/oeqa/selftest/wic.py | 97 +++ 1 file changed, 97 insertions(+) diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/li

Re: [OE-core] [PATCH v4 2/2] selftest/wic: Add tests for --exclude-dir option.

2016-12-29 Thread Kristian Amlie
Rebased patchset, otherwise identical to the last one: * Removed e2tools recipe. * Switched to using 'debugfs' instead of 'e2ls' in selftest. -- Kristian -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org

Re: [OE-core] [PATCH v4 2/2] selftest/wic: Add tests for --exclude-dir option.

2016-12-29 Thread Kristian Amlie
Sorry, I forgot to rebase, I will repost. -- Kristian On 29/12/16 11:05, Kristian Amlie wrote: > Based partially on an earlier patch by Maciej Borzecki. > > Signed-off-by: Kristian Amlie <kristian.am...@mender.io> > --- > meta/lib/oeqa

[OE-core] [PATCH v4 1/2] wic: Add --exclude-path option to rootfs source plugin.

2016-12-29 Thread Kristian Amlie
from it. Since we want to use the copyhardlinktree() function, we need to put the generic oe lib in the module search path. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/help.py | 6 + scripts/lib/wic/ksparser.py | 1 + s

[OE-core] [PATCH v4 2/2] selftest/wic: Add tests for --exclude-dir option.

2016-12-29 Thread Kristian Amlie
Based partially on an earlier patch by Maciej Borzecki. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/lib/oeqa/selftest/wic.py | 97 +++ 1 file changed, 97 insertions(+) diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/li

Re: [OE-core] [PATCH v3 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-29 Thread Kristian Amlie
Ok, new patchset: * Removed e2tools recipe. * Switched to using 'debugfs' instead of 'e2ls' in selftest. -- Kristian -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org

Re: [OE-core] [PATCH v3 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-20 Thread Kristian Amlie
On 19/12/16 21:49, Burton, Ross wrote: > > On 19 December 2016 at 09:09, Kristian Amlie <kristian.am...@mender.io > <mailto:kristian.am...@mender.io>> wrote: > > +res = runCmd("e2ls %s" % os.path.join(self.resultdir, > "selftest

[OE-core] [PATCH v3 2/3] Add e2tools recipe, in order to test contents of images.

2016-12-19 Thread Kristian Amlie
Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/recipes-devtools/e2tools/e2tools-native_0.0.16.bb | 17 + 1 file changed, 17 insertions(+) create mode 100644 meta/recipes-devtools/e2tools/e2tools-native_0.0.16.bb diff --git a/meta/recipes-devtools/e

[OE-core] [PATCH v2 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-19 Thread Kristian Amlie
>> +def test_exclude_path(self): >> +"""Test --exclude-path wks option.""" >> + >> +# For using 'e2ls'. >> +old_path = os.environ['PATH'] >> +os.environ['PATH'] = get_bb_var('PATH', 'core-image-minimal') >> + >> +wks_file = 'temp.wks' >> +ks =

[OE-core] [PATCH v3 1/3] wic: Add --exclude-path option to rootfs source plugin.

2016-12-19 Thread Kristian Amlie
from it. Since we want to use the copyhardlinktree() function, we need to put the generic oe lib in the module search path. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/help.py | 6 + scripts/lib/wic/ksparser.py | 1 + s

[OE-core] [PATCH v3 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-19 Thread Kristian Amlie
Based partially on an earlier patch by Maciej Borzecki. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/lib/oeqa/selftest/wic.py | 103 +- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/wic.py

[OE-core] [PATCH v2 1/3] wic: Add --exclude-path option to rootfs source plugin.

2016-12-14 Thread Kristian Amlie
from it. Since we want to use the copyhardlinktree() function, we need to put the generic oe lib in the module search path. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- scripts/lib/wic/help.py | 6 + scripts/lib/wic/ksparser.py | 1 + s

[OE-core] [PATCH v2 2/3] Add e2tools recipe, in order to test contents of images.

2016-12-14 Thread Kristian Amlie
Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/recipes-devtools/e2tools/e2tools-native_0.0.16.bb | 17 + 1 file changed, 17 insertions(+) create mode 100644 meta/recipes-devtools/e2tools/e2tools-native_0.0.16.bb diff --git a/meta/recipes-devtools/e

[OE-core] [PATCH v2] wic: Add --exclude-path option to rootfs source plugin.

2016-12-14 Thread Kristian Amlie
Alright, this took a bit longer than I expected, I had to learn a bit about the test framework in OpenEmbedded. But here is the updated patch with additional patches enabling tests. Two things I'm a bit unsure about: I had to add a path to the wic python script in order to use the

[OE-core] [PATCH v2 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-14 Thread Kristian Amlie
Based partially on an earlier patch by Maciej Borzecki. Signed-off-by: Kristian Amlie <kristian.am...@mender.io> --- meta/lib/oeqa/selftest/wic.py | 106 +- 1 file changed, 105 insertions(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/wic.py

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-12-05 Thread Kristian Amlie
On 02/12/16 16:05, Ed Bartosh wrote: > On Fri, Dec 02, 2016 at 03:36:47PM +0100, Kristian Amlie wrote: >> What are the thoughts on having a similar --exclude-path mechanism for >> the standard rootfs building? IOW, the do_image_ext4 and friends? > > That's a great idea! If so

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-12-02 Thread Kristian Amlie
On 30/11/16 16:29, Ed Bartosh wrote: >> ... > > You're right. oe-selftest requires qemux86-64 target. > > Even if you usually work in different environment it makes sense to run > oe-selftest to ensure that your changes don't breake it. > This is because our maintainers use oe-selftest results

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-30 Thread Kristian Amlie
On 28/11/16 12:18, Ed Bartosh wrote: > I'd appreciate if you also do the following before sending v2: > - check that your code doesn't regress pylint checks Is there an official process here? Sorry, it's not very well documented. Just running pylint3 manually on the scripts/lib/wic folder gives

  1   2   >