1
> > To: OE Core mailing list
> > Subject: [OE-core] [PATCH] classes: Standardize strings tests, and join
> > some if/then/while/do lines
> >
> >
> > For better or worse, two types of cleanup in meta/classes directory:
> >
> > * Replace old
> -Original Message-
> From: openembedded-core-boun...@lists.openembedded.org
> [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of
> Robert P. J. Day
> Sent: den 28 mars 2017 12:51
> To: OE Core mailing list
> Subject: [OE-core] [PATCH] classes
On 28 March 2017 at 13:18, Robert P. J. Day wrote:
> ok, i thought i knew what you meant but now, i'm just drawing a
> blank. in what way is that not testing for a non-empty string as the
> value of D? what painfully obvious clue am i missing?
>
The gconf_postinst is
On Tue, 28 Mar 2017, Burton, Ross wrote:
>
> On 28 March 2017 at 11:50, Robert P. J. Day wrote:
> gconf_postinst() {
> -if [ "x$D" != "x" ]; then
> +if [ -n "${D}" ]; then
>
>
> This totally changes how the postinst behaves. I'll leave
> understanding
On Tue, 28 Mar 2017, Burton, Ross wrote:
>
> On 28 March 2017 at 11:50, Robert P. J. Day wrote:
> gconf_postinst() {
> -if [ "x$D" != "x" ]; then
> +if [ -n "${D}" ]; then
>
>
> This totally changes how the postinst behaves. I'll leave
> understanding
On 28 March 2017 at 11:50, Robert P. J. Day wrote:
> gconf_postinst() {
> -if [ "x$D" != "x" ]; then
> +if [ -n "${D}" ]; then
>
This totally changes how the postinst behaves. I'll leave understanding
how as an exercise to the reader. :)
Ross
--
For better or worse, two types of cleanup in meta/classes directory:
* Replace old-style 'x${VAR} = x' tests with -n/-z string tests
* Unsplit lines to keep if/then, while/do on same line
Signed-off-by: Robert P. J. Day
---
i realize there are two types of tidying