Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-12-06 Thread Alexander Kanavin
On Wed, 6 Dec 2023 at 03:39, Changqing Li wrote: > The review comments that led to the revert are still valid, and this > message does not address them. The concern was that the removal via > rootfs postprocess is too late. If dnf leaves lock files around, they > should be removed just after the

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-12-05 Thread Changqing Li
On 12/5/23 17:55, Alexander Kanavin wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. On Tue, 5 Dec 2023 at 06:46, Changqing Li wrote: So I add this patch

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-12-05 Thread Alexander Kanavin
On Tue, 5 Dec 2023 at 06:46, Changqing Li wrote: > So I add this patch > https://git.openembedded.org/openembedded-core/commit/?id=406a72a9a47c2735b7e18cefc682b1df00d5a9aa > to remove the lock file in rootfs. > > Since for dnf-native, it will not have reboot process, so it is better > to

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-12-04 Thread Changqing Li
On 7/18/23 04:22, Alexander Kanavin wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. This merged to master and it should not have happened. I'm sending a revert. Alex

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-07-17 Thread Alexander Kanavin
This merged to master and it should not have happened. I'm sending a revert. Alex On Tue, 11 Jul 2023 at 10:34, Changqing Li wrote: > > > On 7/4/23 19:11, Ross Burton wrote: > > CAUTION: This email comes from a non Wind River email account! > > Do not click links or open attachments unless you

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-07-11 Thread Changqing Li
On 7/4/23 19:11, Ross Burton wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. On 30 Jun 2023, at 16:07, Alexander Kanavin via lists.openembedded.org wrote: On Fri, 30

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-07-04 Thread Ross Burton
On 30 Jun 2023, at 16:07, Alexander Kanavin via lists.openembedded.org wrote: > > On Fri, 30 Jun 2023 at 11:14, Changqing Li > wrote: >> Remove log_lock.pid which maybe created during do_rootfs. In commit >> [dnf: only write the log lock to root for native dnf], >> native dnf changed to write

Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-06-30 Thread Alexander Kanavin
On Fri, 30 Jun 2023 at 11:14, Changqing Li wrote: > Remove log_lock.pid which maybe created during do_rootfs. In commit > [dnf: only write the log lock to root for native dnf], > native dnf changed to write log lock to root, and target dnf still > use /var/log, so log_lock.pid need to be removed

[OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock

2023-06-30 Thread Changqing Li
From: Changqing Li Remove log_lock.pid which maybe created during do_rootfs. In commit [dnf: only write the log lock to root for native dnf], native dnf changed to write log lock to root, and target dnf still use /var/log, so log_lock.pid need to be removed post do_rootfs. Signed-off-by: