Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-17 Thread Robert Berger
Hi, Please see my comments in-line. On 16/09/2020 16:38, Jon Mason wrote: [1] https://yoctoproject.blogspot.com/2020/09/compiler-tunes-benchmarks-with-yocto.html Should we expect so see differences? There are more things at play here than simply performance. Hmm interesting. This did

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Richard Purdie
On Wed, 2020-09-16 at 10:25 -0400, Jon Mason wrote: > On Wed, Sep 16, 2020 at 9:49 AM Richard Purdie > wrote: > > On Wed, 2020-09-16 at 09:45 -0400, Jon Mason wrote: > > > On Wed, Sep 16, 2020 at 9:26 AM Richard Purdie > > > wrote: > > > > On Mon, 2020-09-14 at 11:13 -0400, Jon Mason wrote: > >

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Martin Jansa
On Wed, Sep 16, 2020 at 10:25:49AM -0400, Jon Mason wrote: > On Wed, Sep 16, 2020 at 9:49 AM Richard Purdie > wrote: > > > > On Wed, 2020-09-16 at 09:45 -0400, Jon Mason wrote: > > > On Wed, Sep 16, 2020 at 9:26 AM Richard Purdie > > > wrote: > > > > On Mon, 2020-09-14 at 11:13 -0400, Jon Mason

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Jon Mason
On Wed, Sep 16, 2020 at 9:49 AM Richard Purdie wrote: > > On Wed, 2020-09-16 at 09:45 -0400, Jon Mason wrote: > > On Wed, Sep 16, 2020 at 9:26 AM Richard Purdie > > wrote: > > > On Mon, 2020-09-14 at 11:13 -0400, Jon Mason wrote: > > > > There is a large number of Arm Tune files located in > > >

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Richard Purdie
On Wed, 2020-09-16 at 09:45 -0400, Jon Mason wrote: > On Wed, Sep 16, 2020 at 9:26 AM Richard Purdie > wrote: > > On Mon, 2020-09-14 at 11:13 -0400, Jon Mason wrote: > > > There is a large number of Arm Tune files located in > > > meta/conf/machine/include/, and to support the current and > > >

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Jon Mason
On Wed, Sep 16, 2020 at 9:26 AM Richard Purdie wrote: > > On Mon, 2020-09-14 at 11:13 -0400, Jon Mason wrote: > > There is a large number of Arm Tune files located in > > meta/conf/machine/include/, and to support the current and upcoming Arm > > cores, more are needed. Adding more files is

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Jon Mason
On Tue, Sep 15, 2020 at 3:09 AM Robert Berger wrote: > > Hi Jon, > > That's not really a comment on the reorganization of compiler tunes, but > more like "Do they actually do something meaningful?" > > I posted here[1] some benchmarks and at least with the benchmarks I > tried on the chips I

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-16 Thread Richard Purdie
On Mon, 2020-09-14 at 11:13 -0400, Jon Mason wrote: > There is a large number of Arm Tune files located in > meta/conf/machine/include/, and to support the current and upcoming Arm > cores, more are needed. Adding more files is simply going to make it > harder to find the relevant ones for an

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-15 Thread Mark Hatle
On 9/15/20 9:38 AM, Martin Jansa wrote: > On Mon, Sep 14, 2020 at 06:54:14PM -0400, Jon Mason wrote: >> On Mon, Sep 14, 2020 at 11:32 AM Martin Jansa wrote: >>> This reduces the number of files from 12 to 2 for ARMv8a, and that is excluding the 13 I am adding in this series that

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-15 Thread Martin Jansa
On Mon, Sep 14, 2020 at 06:54:14PM -0400, Jon Mason wrote: > On Mon, Sep 14, 2020 at 11:32 AM Martin Jansa wrote: > > > > > This reduces the number of files from 12 to 2 for ARMv8a, and that is > > > excluding the 13 I am adding in this series that would otherwise be > > > unique files. > > > >

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-15 Thread Robert Berger
Hi Jon, That's not really a comment on the reorganization of compiler tunes, but more like "Do they actually do something meaningful?" I posted here[1] some benchmarks and at least with the benchmarks I tried on the chips I tried there is no obvious impact. i.mx6q: TUNE_FEATURES=

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-14 Thread Jon Mason
On Mon, Sep 14, 2020 at 11:32 AM Martin Jansa wrote: > > > This reduces the number of files from 12 to 2 for ARMv8a, and that is > > excluding the 13 I am adding in this series that would otherwise be unique > > files. > > I don't have a strong opinion on this anymore, but is the number of the

Re: [OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-14 Thread Martin Jansa
> This reduces the number of files from 12 to 2 for ARMv8a, and that is excluding the 13 I am adding in this series that would otherwise be unique files. I don't have a strong opinion on this anymore, but is the number of the include files the issue here? I think the issue is the number of

[OE-core] [meta-oe][PATCH 0/5] ARMv8 Tune reorg

2020-09-14 Thread Jon Mason
There is a large number of Arm Tune files located in meta/conf/machine/include/, and to support the current and upcoming Arm cores, more are needed. Adding more files is simply going to make it harder to find the relevant ones for an OE/YP developer/user. Also, there are problems with stale and