Re: [OE-core] [PATCH 1/9] nativesdk: ensure features don't get backfilled

2023-12-13 Thread Alexandre Belloni via lists.openembedded.org
Hello Ross,

Not obvious but this is the cause of:

https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/8697

On 12/12/2023 14:08:12+, Ross Burton wrote:
> From: Ross Burton 
> 
> nativesdk aims to run in a slightly different environment than the
> target build, so it unsets MACHINE_FEATURES and lets DISTRO_FEATURES be
> filtered by DISTRO_FEATURES_NATIVESDK (in bitbake.conf).
> 
> However, feature backfill happens _after_ these operations:
> 
>  $ bitbake-getvar -r nativesdk-glib-2.0 MACHINE_FEATURES
>  #
>  # $MACHINE_FEATURES [5 operations]
>  #   set /home/ross/Yocto/poky/meta/conf/machine/include/qemu.inc:14
>  # "alsa bluetooth usbgadget screen vfat"
>  #   set /home/ross/Yocto/poky/meta/conf/documentation.conf:284
>  # [doc] "Specifies the list of hardware features the MACHINE supports."
>  #   set? /home/ross/Yocto/poky/meta/conf/bitbake.conf:893
>  # ""
>  #   set /home/ross/Yocto/poky/meta/classes-recipe/nativesdk.bbclass:18
>  # ""
>  #   append utils.py:132 [features_backfill]
>  # " rtc qemu-usermode"
>  # pre-expansion value:
>  #   " rtc qemu-usermode"
>  MACHINE_FEATURES=" rtc qemu-usermode"
> 
> I don't believe this is intentional or desired as the machine features
> are unrelated to the nativesdk environment.  Specifically, this means
> that recipes that look for the qemu-usermode machine feature will fail
> in nativesdk as there may not actually be qemu-user support for the
> nativesdk environment.
> 
> Signed-off-by: Ross Burton 
> ---
>  meta/classes-recipe/nativesdk.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/classes-recipe/nativesdk.bbclass 
> b/meta/classes-recipe/nativesdk.bbclass
> index 08288fdb733..ccaf411f0d7 100644
> --- a/meta/classes-recipe/nativesdk.bbclass
> +++ b/meta/classes-recipe/nativesdk.bbclass
> @@ -15,7 +15,10 @@ NATIVESDKLIBC ?= "libc-glibc"
>  LIBCOVERRIDE = ":${NATIVESDKLIBC}"
>  CLASSOVERRIDE = "class-nativesdk"
>  MACHINEOVERRIDES = ""
> +
>  MACHINE_FEATURES = ""
> +DISTRO_FEATURES_BACKFILL = ""
> +MACHINE_FEATURES_BACKFILL = ""
>  
>  MULTILIBS = ""
>  
> -- 
> 2.34.1
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192336): 
https://lists.openembedded.org/g/openembedded-core/message/192336
Mute This Topic: https://lists.openembedded.org/mt/103129922/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] python3-license-expression: Fix the ptest failure

2023-12-13 Thread Yu, Mingli
Hi Alex,

The single command is enough to indicate the build failure such as:
 root@qemux86-64:/usr/lib64/python3-license-expression/ptest# ./run-ptest
[snip]
PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_empty_input
PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_or_relationship
PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_regular
FAIL: tests/test_skeleton_codestyle.py::BaseTests::test_skeleton_codestyle

=== FAILURES ===
__ BaseTests.test_skeleton_codestyle ___

self = 

def test_skeleton_codestyle(self):
"""
This test shouldn't run in proliferated repositories.
"""
setup_cfg = configparser.ConfigParser()
setup_cfg.read("setup.cfg")
>   if setup_cfg["metadata"]["name"] != "skeleton":

tests/test_skeleton_codestyle.py:22:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = , key = 'metadata'

def __getitem__(self, key):
if key != self.default_section and not self.has_section(key):
>   raise KeyError(key)
E   KeyError: 'metadata'

../../python3.11/configparser.py:979: KeyError
=== short test summary info 
FAIL tests/test_skeleton_codestyle.py::BaseTests::test_skeleton_codestyle
 1 failed, 174 passed in 7.08s =

Thanks,

From: Alexander Kanavin 
Sent: Thursday, December 14, 2023 00:39
To: Yu, Mingli 
Cc: openembedded-core@lists.openembedded.org 

Subject: Re: [OE-core] [PATCH] python3-license-expression: Fix the ptest failure

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know 
the content is safe.

I see that run-ptest consists of a single pytest command; does that
command return a zero exit code even it fails?

Alex

On Wed, 13 Dec 2023 at 17:38, Alexander Kanavin  wrote:
>
> Why isn't the ptest failure reported by the autobuilder? Shouldn't we
> first fix the ptest so that the failure is reported correctly, if it
> starts occurring again?
>
> Alex
>
> On Wed, 13 Dec 2023 at 11:21, Yu, Mingli  wrote:
> >
> > From: Mingli Yu 
> >
> > Fix the below ptest failure:
> >  self =  > testMethod=test_skeleton_codestyle>
> >  def test_skeleton_codestyle(self):
> >  """
> >  This test shouldn't run in proliferated repositories.
> >  """
> >  setup_cfg = configparser.ConfigParser()
> >  setup_cfg.read("setup.cfg")
> >  > if setup_cfg["metadata"]["name"] != "skeleton":
> >  tests/test_skeleton_codestyle.py:22:
> >  self = , key = 
> > 'metadata'
> >  def _getitem_(self, key):
> >  if key != self.default_section and not self.has_section(key):
> >  > raise KeyError(key)
> >  E KeyError: 'metadata'
> >
> > After the patch:
> >  # ./run-ptest
> >  [snip]
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_bad_syntax
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_as_regular_key
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_with_choice
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception_strict_false
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_key
> >  PASS: tests/test_license_expression.py::UtilTest::test_build_licensing
> >  PASS: tests/test_license_expression.py::UtilTest::test_build_spdx_licensing
> >  PASS: tests/test_license_expression.py::UtilTest::test_get_license_key_info
> >  PASS: 
> > tests/test_license_expression.py::UtilTest::test_get_license_key_info_vendored
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_duplicated_elements
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_empty_input
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_or_relationship
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_regular
> >  PASS: tests/test_skeleton_codestyle.py::BaseTests::test_skeleton_codestyle
> >
> >  = 175 passed in 10.36s 
> > =
> >
> > Signed-off-by: Mingli Yu 
> > ---
> >  .../python/python3-license-expression/run-ptest | 2 +-
> >  .../python/python3-license-expression_30.1.1.bb | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git 
> > 

Re: [OE-core][PATCH] lttng-tools: add a flag to test the userspace only

2023-12-13 Thread Xiangyu Chen

Hi Ross,


On 12/13/23 18:56, Ross Burton wrote:

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know 
the content is safe.

On 1 Dec 2023, at 14:04, Xiangyu Chen via lists.openembedded.org 
 wrote:

If running the userspace test, just raise an environment variant
"export SKIP_KERNEL_TEST=1" before running the ptest, it would skip
lttng modules related test. Without SKIP_KERNEL_TEST=1, the ptest
would run all test cases.

Is this something we want to automatically do?  Checking if the module can be 
loaded before running the ptest, or something.


How about make the kernel module detection as an function encapsulation 
in testing script instead of


export environment variant by manual? Calling the kernel module detector 
function before


testing kernel related features in test scripts, if kernel module is 
normal run the test, otherwise, skip it.


That can keep ptest automatically to test both all cases and userspace 
cases only.



Thanks,

Xiangyu




Cheers,
Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192334): 
https://lists.openembedded.org/g/openembedded-core/message/192334
Mute This Topic: https://lists.openembedded.org/mt/102914659/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 4/6] recipetool: add python_maturin support

2023-12-13 Thread Tim Orling
On Sat, Dec 9, 2023 at 3:59 AM Alexandre Belloni <
alexandre.bell...@bootlin.com> wrote:

> On 09/12/2023 12:29:50+0100, Alexandre Belloni via lists.openembedded.org
> wrote:
> > Hello,
> >
> > maturin is not reproducible:
> >
> >
> https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20231208-rfbproj4/packages/diff-html/
>
>
> Probably related:
>
> WARNING: python3-maturin-1.3.2-r0 do_package_qa: QA Issue: File
> /usr/bin/.debug/maturin in package python3-maturin-dbg contains reference
> to TMPDIR
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/8267/steps/14/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6018/steps/12/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/8141/steps/11/logs/stdio
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/5453/steps/11/logs/stdio
>
> I think at least this part is sorted:
https://github.com/alexcrichton/bzip2-rs/pull/101

Thank you to khem for making me realize the options passed to the ‘cc’
crate were the issue in this case. (The Makefile is not used, nor are
CFLAGS from the environment)

The reordering bits might be a different problem. If anybody has any
thoughts on that I’m all ears.

>
> >
> > On 08/12/2023 18:02:24-0800, Tim Orling wrote:
> > > Add the new python_maturin PEP-517 backend
> > >
> > > Add selftest for 'pydantic-core' pypi package.
> > >
> > > Signed-off-by: Tim Orling 
> > > ---
> > > Changes in v2:
> > >  - drop all SRC_URI checksums except sha256sum (Peter's change)
> > >* requires "[PATCH v2] recipetool: pypi: do not clobber SRC_URI
> checksums"
> > >  - drop SRC_URI (Julien's change)
> > >  - add "inherit pypi" (Julien's change)
> > >
> > >  meta/lib/oeqa/selftest/cases/recipetool.py| 29 +++
> > >  .../lib/recipetool/create_buildsys_python.py  |  1 +
> > >  2 files changed, 30 insertions(+)
> > >
> > > diff --git a/meta/lib/oeqa/selftest/cases/recipetool.py
> b/meta/lib/oeqa/selftest/cases/recipetool.py
> > > index d10d61bc5b0..8d39f639acf 100644
> > > --- a/meta/lib/oeqa/selftest/cases/recipetool.py
> > > +++ b/meta/lib/oeqa/selftest/cases/recipetool.py
> > > @@ -663,6 +663,35 @@ class RecipetoolCreateTests(RecipetoolBase):
> > >
> > >  self._test_recipe_contents(recipefile, checkvars, inherits)
> > >
> > > +def test_recipetool_create_python3_pep517_maturin(self):
> > > +# This test require python 3.11 or above for the tomllib
> module
> > > +# or tomli module to be installed
> > > +try:
> > > +import tomllib
> > > +except ImportError:
> > > +try:
> > > +import tomli
> > > +except ImportError:
> > > +self.skipTest('Test requires python 3.11 or above for
> tomllib module or tomli module')
> > > +
> > > +# Test creating python3 package from tarball (using maturin
> class)
> > > +temprecipe = os.path.join(self.tempdir, 'recipe')
> > > +os.makedirs(temprecipe)
> > > +pn = 'pydantic-core'
> > > +pv = '2.14.5'
> > > +recipefile = os.path.join(temprecipe, 'python3-%s_%s.bb' %
> (pn, pv))
> > > +srcuri = '
> https://files.pythonhosted.org/packages/64/26/cffb93fe9c6b5a91c497f37fae14a4b073ecbc47fc36a9979c7aa888b245/pydantic_core-%s.tar.gz'
> % pv
> > > +result = runCmd('recipetool create -o %s %s' % (temprecipe,
> srcuri))
> > > +self.assertTrue(os.path.isfile(recipefile))
> > > +checkvars = {}
> > > +checkvars['HOMEPAGE'] = '
> https://github.com/pydantic/pydantic-core'
> > > +checkvars['LICENSE'] = set(['MIT'])
> > > +checkvars['LIC_FILES_CHKSUM'] =
> 'file://LICENSE;md5=ab599c188b4a314d2856b3a55030c75c'
> > > +checkvars['SRC_URI[sha256sum]'] =
> '6d30226dfc816dd0fdf120cae611dd2215117e4f9b124af8c60ab9093b6e8e71'
> > > +inherits = ['python_maturin', 'pypi']
> > > +
> > > +self._test_recipe_contents(recipefile, checkvars, inherits)
> > > +
> > >  def test_recipetool_create_github_tarball(self):
> > >  # Basic test to ensure github URL mangling doesn't apply to
> release tarballs
> > >  temprecipe = os.path.join(self.tempdir, 'recipe')
> > > diff --git a/scripts/lib/recipetool/create_buildsys_python.py
> b/scripts/lib/recipetool/create_buildsys_python.py
> > > index a2af41fdda8..60c59034504 100644
> > > --- a/scripts/lib/recipetool/create_buildsys_python.py
> > > +++ b/scripts/lib/recipetool/create_buildsys_python.py
> > > @@ -735,6 +735,7 @@ class
> PythonPyprojectTomlRecipeHandler(PythonRecipeHandler):
> > >  "poetry.core.masonry.api": "python_poetry_core",
> > >  "flit_core.buildapi": "python_flit_core",
> > >  "hatchling.build": "python_hatchling",
> > > +"maturin": "python_maturin",
> > >  }
> > >
> > >  # setuptools.build_meta and flit declare project metadata into
> the "project" section of pyproject.toml
> > > --
> > 

Re: [OE-core] [PATCH 1/3] systemtap: upgrade 4.9 -> 5.0

2023-12-13 Thread Martin Jansa
Hi Victor,

no problem, at least it forced me to enable debuginfod in our builds as
well (where it wasn't intentionally disabled). Just didn't get enabled when
it was added to default DISTRO_FEATUREs as we define our own and it wasn't
using BACKFILL mechanism to enable it in such setups.

Removing debuginfod from DISTRO_FEATURES should be enough to reproduce the
issue (as it will disable both *debuginfod PACKAGECONFIG options from
elfutils as well).

I haven't tried, but removing the PACKAGECONFIG just from elfutils will
probably reproduce it as well (with possibly fewer recipes needing to
rebuilt). There are 2 PACKAGECONFIGs for this, not sure which one is
needed, but you can just disable both.

Cheers,

On Wed, Dec 13, 2023 at 10:27 PM Victor Kamensky 
wrote:

> Hi Martin,
>
> Sorry about that. I am looking at it now.
>
> Do I understand it correctly to reproduce the issue: I need to remove
> debuginfod (as it is currently on
> by default) from DISTO_FEATURES and remove debuginfod from elfutils
> PACKAGECONFIG defaults?
>
> Thanks,
> Victor
>
> On Sun, Dec 10, 2023 at 3:16 AM Martin Jansa 
> wrote:
> >
> > This seems to be causing:
> > ../git/util.cxx:51:10: fatal error: elfutils/debuginfod.h: No such file
> or directory
> >51 | #include 
> >   |  ^~~
> > compilation terminated.
> > make[2]: *** [Makefile:1389: stap-util.o] Error 1
> >
> > on some systems.
> >
> > Looks like with
> https://sourceware.org/git/?p=systemtap.git;a=commit;h=2e67b053e3796ee7cf29a39f9698729b52078406
> it now enables debuginfod ("AC_MSG_RESULT([yes])" _after_ the
> PKG_CHECK_MODULES now seems wrong).
> >
> > log.do_configure:
> > checking whether to use debuginfod... checking for debuginfod... no
> > yes
> > checking for debuginfod_find_metadata in -ldebuginfod... no
> >
> > build $ grep DEBUGINFO config.h
> > #define HAVE_LIBDEBUGINFOD 1
> >
> > config.log (see the strange result yes):
> > configure:12213: checking whether to use debuginfod
> > configure:12228: checking for debuginfod
> > configure:12235: $PKG_CONFIG --exists --print-errors "libdebuginfod >=
> 0.179"
> > Package libdebuginfod was not found in the pkg-config search path.
> > Perhaps you should add the directory containing `libdebuginfod.pc'
> > to the PKG_CONFIG_PATH environment variable
> > No package 'libdebuginfod' found
> > configure:12238: $? = 1
> > configure:12252: $PKG_CONFIG --exists --print-errors "libdebuginfod >=
> 0.179"
> > Package libdebuginfod was not found in the pkg-config search path.
> > Perhaps you should add the directory containing `libdebuginfod.pc'
> > to the PKG_CONFIG_PATH environment variable
> > No package 'libdebuginfod' found
> > configure:12255: $? = 1
> > configure:12269: result: no
> > No package 'libdebuginfod' found
> > configure:12304: result: yes
> > configure:12315: checking for debuginfod_find_metadata in -ldebuginfod
> > configure:12344: ccache aarch64-webos-linux-gcc  -mcpu=cortex-a72
> -march=armv8-a+crc -mbranch-protection=standard -fstack-protector-strong
> -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security
> -Werror=return-type
> --sysroot=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot
> -o conftest  -O2 -pipe -g -feliminate-unused-debug-types
> -fcanon-prefix-map
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot-native=
>   -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fcanon-prefix-map
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
> 

[OE-core] [PATCH] sstate: Fix dir ownership issues in SSTATE_DIR

2023-12-13 Thread Richard Purdie
We currently use mkdir -p to create missing parent directories within 
SSTATE_DIR.
Reading the man page for mkdir mentions that parent directories are created with
the current umask, *not* the mode passed upon the commandline.

We could fix this by setting and resetting the umask but since we already have
decent python code able to do this, move to using that injecting a python 
function
into the chain of functions already present.

This should help fix the occasional sstate directory creation with the wrong
permissions.

[YOCTO #14385]

Signed-off-by: Richard Purdie 
---
 meta/classes-global/sstate.bbclass | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/meta/classes-global/sstate.bbclass 
b/meta/classes-global/sstate.bbclass
index 95d5803f17d..9330433bb2d 100644
--- a/meta/classes-global/sstate.bbclass
+++ b/meta/classes-global/sstate.bbclass
@@ -703,7 +703,7 @@ def sstate_package(ss, d):
 if d.getVar('SSTATE_SKIP_CREATION') == '1':
 return
 
-sstate_create_package = ['sstate_report_unihash', 'sstate_create_package']
+sstate_create_package = ['sstate_report_unihash', 'sstate_create_pkgdirs', 
'sstate_create_package']
 if d.getVar('SSTATE_SIG_KEY'):
 sstate_create_package.append('sstate_sign_package')
 
@@ -810,6 +810,12 @@ python sstate_task_postfunc () {
 }
 sstate_task_postfunc[dirs] = "${WORKDIR}"
 
+python sstate_create_pkgdirs () {
+# report_unihash can change SSTATE_PKG and mkdir -p in shell doesn't own 
intermediate directories
+# correctly so do this in an intermediate python task
+with bb.utils.umask(0o002):
+bb.utils.mkdirhier(os.path.dirname(d.getVar('SSTATE_PKG')))
+}
 
 #
 # Shell function to generate a sstate package from a directory
@@ -822,7 +828,6 @@ sstate_create_package () {
return
fi
 
-   mkdir --mode=0775 -p `dirname ${SSTATE_PKG}`
TFILE=`mktemp ${SSTATE_PKG}.`
 
OPT="-cS"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192331): 
https://lists.openembedded.org/g/openembedded-core/message/192331
Mute This Topic: https://lists.openembedded.org/mt/103159534/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] dtc: pass version as parameter instead of querying git

2023-12-13 Thread Richard Purdie
On Wed, 2023-12-13 at 21:53 +, Marko, Peter wrote:
> -Original Message-
> From: Richard Purdie  
> Sent: Wednesday, December 13, 2023 22:11
> To: Marko, Peter (ADV D EU SK BFS1) ; 
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH] dtc: pass version as parameter instead of 
> querying git
> 
> > On Wed, 2023-12-13 at 22:07 +0100, Peter Marko via lists.openembedded.org 
> > wrote:
> > > From: Peter Marko 
> > > 
> > > Since switch from Makefile to meson based build, the version is no 
> > > longer hardcoded but queried from git tag.
> > > 
> > > This works only if git history is available.
> > > When shallow tarballs are used, tag is not available.
> > > 
> > > Example error for trusted-firmware-a from meta-arm:
> > > dtc version too old (039a994), you need at least version 1.4.4
> > > 
> > > Signed-off-by: Peter Marko 
> > > ---
> > >  ...n-as-parameter-instead-of-querying-g.patch | 49 +++
> > >  meta/recipes-kernel/dtc/dtc_1.7.0.bb  |  7 ++-
> > >  2 files changed, 54 insertions(+), 2 deletions(-)  create mode 100644 
> > > meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instea
> > > d-of-querying-g.patch
> > > 
> > > diff --git 
> > > a/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-inst
> > > ead-of-querying-g.patch 
> > > b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-inst
> > > ead-of-querying-g.patch
> > > new file mode 100644
> > > index 00..d7906bd6f9
> > > --- /dev/null
> > > +++ b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-
> > > +++ instead-of-querying-g.patch
> > > @@ -0,0 +1,49 @@
> > > +From f32056f825b926b5820d43478d11e92eee1ec91f Mon Sep 17 00:00:00 
> > > +2001
> > > +From: Peter Marko 
> > > +Date: Wed, 13 Dec 2023 21:18:14 +0100
> > > +Subject: [PATCH] meson: get version as parameter instead of querying 
> > > +git
> > > +
> > > +When using shallow tarballs, git tag is not available.
> > > +This causes version to be git hash.
> > > +This prevents application from checking minimal required version.
> > > +
> > > +Example error for trusted-firmware-a from meta-arm:
> > > +dtc version too old (039a994), you need at least version 1.4.4
> > > +
> > > +Upstream-Status: Inappropriate [oe specific]
> > > +
> > > +Signed-off-by: Peter Marko 
> > > +---
> > > + meson.build   | 3 ++-
> > > + meson_options.txt | 2 ++
> > > + 2 files changed, 4 insertions(+), 1 deletion(-)
> > > +
> > 
> > I'm not sure that is inappropriate. Has anyone talked to upstream about 
> > builds failing from shallow clones?
> > 
> > Cheers,
> > 
> > Richard
> > 
> 
> I actually think that building from shallow clones is very non-standard 
> scenario.
> Usual builds are either from full clones or from release tarballs.
> And meson nicely handles these two scenarios.
> Shallow tarball is an incomplete thing which has storage benefits but also 
> misses things that buildsystems are relying on.
> And I don't think I can win a discussion with meson maintainers about this.
> The vcs functions are standard and have good fallbacks (e.g. to hash)
> I could maybe convince them to add option to disable fall back to git hash, 
> but that would be a long-runner.

They might be more receptive to adding an argument to allow the value
to be forced though, particularly if you can explain scenarios where
this is the only option and the code get it wrong?

I do think we need to raise these issues with the upstreams and only
carry patches if we can't convince them of these challenges.

> Maybe I could add an option to bitbake git fetcher to remove .git folder if 
> needed?

I'm not sure we want to encourage it. That is actually more
maintainable even in the recipe though.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192330): 
https://lists.openembedded.org/g/openembedded-core/message/192330
Mute This Topic: https://lists.openembedded.org/mt/103158226/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] dtc: pass version as parameter instead of querying git

2023-12-13 Thread Peter Marko via lists.openembedded.org
-Original Message-
From: Richard Purdie  
Sent: Wednesday, December 13, 2023 22:11
To: Marko, Peter (ADV D EU SK BFS1) ; 
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] dtc: pass version as parameter instead of 
querying git

> On Wed, 2023-12-13 at 22:07 +0100, Peter Marko via lists.openembedded.org 
> wrote:
> > From: Peter Marko 
> > 
> > Since switch from Makefile to meson based build, the version is no 
> > longer hardcoded but queried from git tag.
> > 
> > This works only if git history is available.
> > When shallow tarballs are used, tag is not available.
> > 
> > Example error for trusted-firmware-a from meta-arm:
> > dtc version too old (039a994), you need at least version 1.4.4
> > 
> > Signed-off-by: Peter Marko 
> > ---
> >  ...n-as-parameter-instead-of-querying-g.patch | 49 +++
> >  meta/recipes-kernel/dtc/dtc_1.7.0.bb  |  7 ++-
> >  2 files changed, 54 insertions(+), 2 deletions(-)  create mode 100644 
> > meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instea
> > d-of-querying-g.patch
> > 
> > diff --git 
> > a/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-inst
> > ead-of-querying-g.patch 
> > b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-inst
> > ead-of-querying-g.patch
> > new file mode 100644
> > index 00..d7906bd6f9
> > --- /dev/null
> > +++ b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-
> > +++ instead-of-querying-g.patch
> > @@ -0,0 +1,49 @@
> > +From f32056f825b926b5820d43478d11e92eee1ec91f Mon Sep 17 00:00:00 
> > +2001
> > +From: Peter Marko 
> > +Date: Wed, 13 Dec 2023 21:18:14 +0100
> > +Subject: [PATCH] meson: get version as parameter instead of querying 
> > +git
> > +
> > +When using shallow tarballs, git tag is not available.
> > +This causes version to be git hash.
> > +This prevents application from checking minimal required version.
> > +
> > +Example error for trusted-firmware-a from meta-arm:
> > +dtc version too old (039a994), you need at least version 1.4.4
> > +
> > +Upstream-Status: Inappropriate [oe specific]
> > +
> > +Signed-off-by: Peter Marko 
> > +---
> > + meson.build   | 3 ++-
> > + meson_options.txt | 2 ++
> > + 2 files changed, 4 insertions(+), 1 deletion(-)
> > +
>
> I'm not sure that is inappropriate. Has anyone talked to upstream about 
> builds failing from shallow clones?
>
> Cheers,
>
> Richard
> 

I actually think that building from shallow clones is very non-standard 
scenario.
Usual builds are either from full clones or from release tarballs.
And meson nicely handles these two scenarios.
Shallow tarball is an incomplete thing which has storage benefits but also 
misses things that buildsystems are relying on.
And I don't think I can win a discussion with meson maintainers about this.
The vcs functions are standard and have good fallbacks (e.g. to hash)
I could maybe convince them to add option to disable fall back to git hash, but 
that would be a long-runner.

Maybe I could add an option to bitbake git fetcher to remove .git folder if 
needed?

Thanks for review,
Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192329): 
https://lists.openembedded.org/g/openembedded-core/message/192329
Mute This Topic: https://lists.openembedded.org/mt/103158226/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/3] systemtap: upgrade 4.9 -> 5.0

2023-12-13 Thread Victor Kamensky
Hi Martin,

Sorry about that. I am looking at it now.

Do I understand it correctly to reproduce the issue: I need to remove
debuginfod (as it is currently on
by default) from DISTO_FEATURES and remove debuginfod from elfutils
PACKAGECONFIG defaults?

Thanks,
Victor

On Sun, Dec 10, 2023 at 3:16 AM Martin Jansa  wrote:
>
> This seems to be causing:
> ../git/util.cxx:51:10: fatal error: elfutils/debuginfod.h: No such file or 
> directory
>51 | #include 
>   |  ^~~
> compilation terminated.
> make[2]: *** [Makefile:1389: stap-util.o] Error 1
>
> on some systems.
>
> Looks like with 
> https://sourceware.org/git/?p=systemtap.git;a=commit;h=2e67b053e3796ee7cf29a39f9698729b52078406
>  it now enables debuginfod ("AC_MSG_RESULT([yes])" _after_ the 
> PKG_CHECK_MODULES now seems wrong).
>
> log.do_configure:
> checking whether to use debuginfod... checking for debuginfod... no
> yes
> checking for debuginfod_find_metadata in -ldebuginfod... no
>
> build $ grep DEBUGINFO config.h
> #define HAVE_LIBDEBUGINFOD 1
>
> config.log (see the strange result yes):
> configure:12213: checking whether to use debuginfod
> configure:12228: checking for debuginfod
> configure:12235: $PKG_CONFIG --exists --print-errors "libdebuginfod >= 0.179"
> Package libdebuginfod was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libdebuginfod.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'libdebuginfod' found
> configure:12238: $? = 1
> configure:12252: $PKG_CONFIG --exists --print-errors "libdebuginfod >= 0.179"
> Package libdebuginfod was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libdebuginfod.pc'
> to the PKG_CONFIG_PATH environment variable
> No package 'libdebuginfod' found
> configure:12255: $? = 1
> configure:12269: result: no
> No package 'libdebuginfod' found
> configure:12304: result: yes
> configure:12315: checking for debuginfod_find_metadata in -ldebuginfod
> configure:12344: ccache aarch64-webos-linux-gcc  -mcpu=cortex-a72 
> -march=armv8-a+crc -mbranch-protection=standard -fstack-protector-strong  -O2 
> -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security 
> -Werror=return-type 
> --sysroot=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot
>  -o conftest  -O2 -pipe -g -feliminate-unused-debug-types -fcanon-prefix-map  
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
>   
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
>   
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot-native=
> -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fcanon-prefix-map  
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/git=/usr/src/debug/systemtap/5.0
>   
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/build=/usr/src/debug/systemtap/5.0
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
>   
> -fmacro-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot=
>   
> -fdebug-prefix-map=/OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot-native=
>   -Wl,-z,relro,-z,now  conftest.c -ldebuginfod   >&5
> /OE/lge/build/webos/scarthgap/BUILD/work/raspberrypi4_64-webos-linux/systemtap/5.0/recipe-sysroot-native/usr/bin/aarch64-webos-linux/../../libexec/aarch64-webos-linux/gcc/aarch64-webos-linux/13.2.0/ld:
>  cannot find -ldebuginfod: No such file or directory
> collect2: error: ld returned 1 exit status
>
> With debuginfod in DISTRO_FEATURES (which is included by default) and 
> *debuginfod PACKAGECONFIG enabled in elfutils (also by default based on 
> DISTRO_FEAUTRES) this builds OK.
>
> Regards,
>
>
> On Tue, Dec 

Re: [OE-core][PATCH] dtc: pass version as parameter instead of querying git

2023-12-13 Thread Richard Purdie
On Wed, 2023-12-13 at 22:07 +0100, Peter Marko via
lists.openembedded.org wrote:
> From: Peter Marko 
> 
> Since switch from Makefile to meson based build,
> the version is no longer hardcoded but queried from git tag.
> 
> This works only if git history is available.
> When shallow tarballs are used, tag is not available.
> 
> Example error for trusted-firmware-a from meta-arm:
> dtc version too old (039a994), you need at least version 1.4.4
> 
> Signed-off-by: Peter Marko 
> ---
>  ...n-as-parameter-instead-of-querying-g.patch | 49 +++
>  meta/recipes-kernel/dtc/dtc_1.7.0.bb  |  7 ++-
>  2 files changed, 54 insertions(+), 2 deletions(-)
>  create mode 100644 
> meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
> 
> diff --git 
> a/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
>  
> b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
> new file mode 100644
> index 00..d7906bd6f9
> --- /dev/null
> +++ 
> b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
> @@ -0,0 +1,49 @@
> +From f32056f825b926b5820d43478d11e92eee1ec91f Mon Sep 17 00:00:00 2001
> +From: Peter Marko 
> +Date: Wed, 13 Dec 2023 21:18:14 +0100
> +Subject: [PATCH] meson: get version as parameter instead of querying git
> +
> +When using shallow tarballs, git tag is not available.
> +This causes version to be git hash.
> +This prevents application from checking minimal required version.
> +
> +Example error for trusted-firmware-a from meta-arm:
> +dtc version too old (039a994), you need at least version 1.4.4
> +
> +Upstream-Status: Inappropriate [oe specific]
> +
> +Signed-off-by: Peter Marko 
> +---
> + meson.build   | 3 ++-
> + meson_options.txt | 2 ++
> + 2 files changed, 4 insertions(+), 1 deletion(-)
> +

I'm not sure that is inappropriate. Has anyone talked to upstream about
builds failing from shallow clones?

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192327): 
https://lists.openembedded.org/g/openembedded-core/message/192327
Mute This Topic: https://lists.openembedded.org/mt/103158226/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] dtc: pass version as parameter instead of querying git

2023-12-13 Thread Alexander Kanavin
On Wed, 13 Dec 2023 at 22:07, Peter Marko via lists.openembedded.org
 wrote:
> +From f32056f825b926b5820d43478d11e92eee1ec91f Mon Sep 17 00:00:00 2001
> +From: Peter Marko 
> +Date: Wed, 13 Dec 2023 21:18:14 +0100
> +Subject: [PATCH] meson: get version as parameter instead of querying git
> +
> +When using shallow tarballs, git tag is not available.
> +This causes version to be git hash.
> +This prevents application from checking minimal required version.
> +
> +Example error for trusted-firmware-a from meta-arm:
> +dtc version too old (039a994), you need at least version 1.4.4
> +
> +Upstream-Status: Inappropriate [oe specific]

This is not really oe-specific, please submit upstream first.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192326): 
https://lists.openembedded.org/g/openembedded-core/message/192326
Mute This Topic: https://lists.openembedded.org/mt/103158226/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH] dtc: pass version as parameter instead of querying git

2023-12-13 Thread Peter Marko via lists.openembedded.org
From: Peter Marko 

Since switch from Makefile to meson based build,
the version is no longer hardcoded but queried from git tag.

This works only if git history is available.
When shallow tarballs are used, tag is not available.

Example error for trusted-firmware-a from meta-arm:
dtc version too old (039a994), you need at least version 1.4.4

Signed-off-by: Peter Marko 
---
 ...n-as-parameter-instead-of-querying-g.patch | 49 +++
 meta/recipes-kernel/dtc/dtc_1.7.0.bb  |  7 ++-
 2 files changed, 54 insertions(+), 2 deletions(-)
 create mode 100644 
meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch

diff --git 
a/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
 
b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
new file mode 100644
index 00..d7906bd6f9
--- /dev/null
+++ 
b/meta/recipes-kernel/dtc/dtc/0001-meson-get-version-as-parameter-instead-of-querying-g.patch
@@ -0,0 +1,49 @@
+From f32056f825b926b5820d43478d11e92eee1ec91f Mon Sep 17 00:00:00 2001
+From: Peter Marko 
+Date: Wed, 13 Dec 2023 21:18:14 +0100
+Subject: [PATCH] meson: get version as parameter instead of querying git
+
+When using shallow tarballs, git tag is not available.
+This causes version to be git hash.
+This prevents application from checking minimal required version.
+
+Example error for trusted-firmware-a from meta-arm:
+dtc version too old (039a994), you need at least version 1.4.4
+
+Upstream-Status: Inappropriate [oe specific]
+
+Signed-off-by: Peter Marko 
+---
+ meson.build   | 3 ++-
+ meson_options.txt | 2 ++
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 78251eb..8a25163 100644
+--- a/meson.build
 b/meson.build
+@@ -55,9 +55,10 @@ py = import('python')
+ py = py.find_installation(required: get_option('python'))
+ swig = find_program('swig', required: get_option('python'))
+ 
+-version_gen_h = vcs_tag(
++version_gen_h = configure_file(
+   input: 'version_gen.h.in',
+   output: 'version_gen.h',
++  configuration: { 'VCS_TAG': get_option('PV')},
+ )
+ 
+ subdir('libfdt')
+diff --git a/meson_options.txt b/meson_options.txt
+index 82621c3..c313d32 100644
+--- a/meson_options.txt
 b/meson_options.txt
+@@ -10,3 +10,5 @@ option('python', type: 'feature', value: 'auto',
+description: 'Build pylibfdt Python library')
+ option('static-build', type: 'boolean', value: false,
+description: 'Build static binaries')
++option('PV', type: 'string', value: 'undefined',
++   description: 'version string to be used instead of getting it from 
git')
+-- 
+2.30.2
+
diff --git a/meta/recipes-kernel/dtc/dtc_1.7.0.bb 
b/meta/recipes-kernel/dtc/dtc_1.7.0.bb
index 1a78a0c079..586a5f91bd 100644
--- a/meta/recipes-kernel/dtc/dtc_1.7.0.bb
+++ b/meta/recipes-kernel/dtc/dtc_1.7.0.bb
@@ -8,7 +8,10 @@ LIC_FILES_CHKSUM = 
"file://GPL;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
 file://BSD-2-Clause;md5=5d6306d1b08f8df623178dfd81880927 \
 file://README.license;md5=a1eb22e37f09df5b5511b8a278992d0e"
 
-SRC_URI = 
"git://git.kernel.org/pub/scm/utils/dtc/dtc.git;branch=main;protocol=https" 
+SRC_URI = " \
+git://git.kernel.org/pub/scm/utils/dtc/dtc.git;branch=main;protocol=https \
+file://0001-meson-get-version-as-parameter-instead-of-querying-g.patch \
+"
 SRCREV = "039a99414e778332d8f9c04cbd3072e1dcc62798"
 
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P\d+(\.\d+)+)"
@@ -17,7 +20,7 @@ S = "${WORKDIR}/git"
 
 inherit meson pkgconfig
 
-EXTRA_OEMESON = "-Dpython=disabled -Dvalgrind=disabled"
+EXTRA_OEMESON = "-Dpython=disabled -Dvalgrind=disabled -DPV=v${PV}"
 
 PACKAGECONFIG ??= "tools"
 PACKAGECONFIG[tools] = "-Dtools=true,-Dtools=false,flex-native bison-native"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192325): 
https://lists.openembedded.org/g/openembedded-core/message/192325
Mute This Topic: https://lists.openembedded.org/mt/103158226/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCHv2 2/4] python3-qemu-qmp: Add recipe

2023-12-13 Thread Richard Purdie
On Wed, 2023-12-13 at 20:30 +, Eilís 'pidge' Ní Fhlannagáin wrote:
> From: Ross Burton 
> 
> Add a recipe for python QEMU Monitor Protocol. This will be needed for
> qemu screendumps for qemu screendump testing.
> 
> Signed-off-by: Ross Burton 
> Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
> ---
>  .../python/python3-qemu-qmp_0.0.2.bb   | 14 ++
>  1 file changed, 14 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb
> 
> diff --git a/meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb 
> b/meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb
> new file mode 100644
> index 000..faa0cc69738
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb
> @@ -0,0 +1,14 @@
> +SUMMARY = "asyncio library for communicating with QEMU Monitor Protocol 
> (QMP) servers"
> +LICENSE = "LGPLv2+ & GPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=4cf66a4984120007c9881cc871cf49db \
> +file://LICENSE_GPL2;md5=441c28d2cf86e15a37fa47e15a72fbac"
> +
> +SRC_URI[sha256sum] = 
> "c918e9e3ae09abdf70c7ece67637a93ac4583d940bbf48d24ff77987f74f1b8b"
> +
> +inherit pypi python_setuptools_build_meta
> +
> +PYPI_PACKAGE = "qemu.qmp"
> +
> +DEPENDS += "python3-setuptools-scm-native"
> +
> +BBCLASSEXTEND = "native nativesdk"

None of the errors Alexandre reported originally from the autobuilder
have been fixed here :(

(HOMEPAGE, missing maintainer entry and so on)

Also, I'm not sure what qmp is doing on the target with this recipe?
Does qmp trigger remote command execution inside the guest? I'd
previously assumed the framedump was from the external presentation
rather than internal to the guest.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192324): 
https://lists.openembedded.org/g/openembedded-core/message/192324
Mute This Topic: https://lists.openembedded.org/mt/103157568/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] openssl: mark assembler sections as call targets for PAC/BTI support on aarch64

2023-12-13 Thread Khem Raj
On Wed, Dec 13, 2023 at 2:48 AM Ross Burton  wrote:
>
> From: Ross Burton 
>
> The assembler sections in OpenSSL were not marked as valid call targets,
> so branch protection could not be enabled for libcrypto.so.
>
> Signed-off-by: Ross Burton 
> ---
>  .../openssl/openssl/aarch64-bti.patch | 35 +++
>  .../openssl/openssl_3.2.0.bb  |  1 +
>  2 files changed, 36 insertions(+)
>  create mode 100644 
> meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
>
> diff --git a/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch 
> b/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
> new file mode 100644
> index 000..2a16debb76e
> --- /dev/null
> +++ b/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
> @@ -0,0 +1,35 @@
> +From ad347c9ff0fd93bdd2fa2085611c65b88e94829f Mon Sep 17 00:00:00 2001
> +From: "fangming.fang" 
> +Date: Thu, 7 Dec 2023 06:17:51 +
> +Subject: [PATCH] Enable BTI feature for md5 on aarch64
> +
> +Fixes: #22959
> +
> +Reviewed-by: Tom Cosgrove 
> +Reviewed-by: Tomas Mraz 
> +(Merged from https://github.com/openssl/openssl/pull/22971)
> +
> +Upstream-Status: Backport
> +Signed-off-by: Ross Burton 
> +---
> + crypto/md5/asm/md5-aarch64.pl | 3 +++
> + 1 file changed, 3 insertions(+)
> +
> +diff --git a/crypto/md5/asm/md5-aarch64.pl b/crypto/md5/asm/md5-aarch64.pl
> +index 3200a0fa9bff0..5a8608069691d 100755
> +--- a/crypto/md5/asm/md5-aarch64.pl
>  b/crypto/md5/asm/md5-aarch64.pl
> +@@ -28,10 +28,13 @@
> + *STDOUT=*OUT;
> +
> + $code .= < ++#include "arm_arch.h"
> ++
> + .text
> + .globl  ossl_md5_block_asm_data_order
> + .type   ossl_md5_block_asm_data_order,\@function
> + ossl_md5_block_asm_data_order:
> ++AARCH64_VALID_CALL_TARGET
> + // Save all callee-saved registers
> + stp x19,x20,[sp,#-80]!
> + stp x21,x22,[sp,#16]
> diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb 
> b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> index ab0562bd730..1c97d853f11 100644
> --- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> @@ -12,6 +12,7 @@ SRC_URI = 
> "http://www.openssl.org/source/openssl-${PV}.tar.gz \
> 
> file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \
> file://0001-Configure-do-not-tweak-mips-cflags.patch \
> 
> file://0001-Added-handshake-history-reporting-when-test-fails.patch \
> +  file://aarch64-bti.patch \

it looks funnily indented :)

> "
>
>  SRC_URI:append:class-nativesdk = " \
> --
> 2.34.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192323): 
https://lists.openembedded.org/g/openembedded-core/message/192323
Mute This Topic: https://lists.openembedded.org/mt/103147125/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCHv2 4/4] login.py: Proof of concept for screenshot testcases

2023-12-13 Thread Richard Purdie
On Wed, 2023-12-13 at 20:30 +, Eilís 'pidge' Ní Fhlannagáin wrote:
> This takes the work rburton did on image screenshot testing and
> expands it.
> 
> Right now this only works for qemux86-64. Some standardization
> of screensize/resolution needs to happen with runqemu params for other
> machines. There is an issue in qemux86-64 (and possibly others) where
> the screenswitch icon is only half present. This causes the test to
> fail.
> 
> This test takes a screendump of a qemu image (for now, just
> core-image-sato for qemux86-64), and compares it to an image we
> have on record. Some normalisation of the different qemu configs
> need to happen to be able to support all machines. Example, the
> qemuarm64 screen size is much larger than the qemux86-64.
> 
> The image we have on record contains a blanked out clock. We do
> the same blanking out process for the screenshot, so the images should
> have zero differences. If they do, we fail.
> 
> In order to enable this test, you will need meta-openembedded/meta-oe in
> your bblayers.conf and the following in local.conf:
> 
> IMAGE_CLASSES += "testimage"
> TEST_SUITES = "login"
> IMAGE_INSTALL:append = " python3-qemu-qmp "
> TESTIMAGEDEPENDS:append:qemuall = " imagemagick-native:do_populate_sysroot "
> 
> Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
> Co-authored-by: Ross Burton 
> Co-authored-by: Eilís 'pidge' Ní Fhlannagáin 
> ---
>  .../core-image-sato-qemux86-64.png| Bin 0 -> 46986 bytes
>  meta/lib/oeqa/runtime/cases/login.py  |  34 ++
>  2 files changed, 34 insertions(+)
>  create mode 100644 meta/files/image-tests/core-image-sato-qemux86-64.png
>  create mode 100644 meta/lib/oeqa/runtime/cases/login.py
> 
> diff --git a/meta/lib/oeqa/runtime/cases/login.py 
> b/meta/lib/oeqa/runtime/cases/login.py
> new file mode 100644
> index 000..9e351fdeb29
> --- /dev/null
> +++ b/meta/lib/oeqa/runtime/cases/login.py
> @@ -0,0 +1,34 @@
> +#
> +# Copyright OpenEmbedded Contributors
> +#
> +# SPDX-License-Identifier: MIT
> +#
> +
> +import subprocess
> +from oeqa.runtime.case import OERuntimeTestCase
> +import tempfile
> +from oeqa.runtime.decorator.package import OEHasPackage
> +
> +class LoginTest(OERuntimeTestCase):
> +
> +@OEHasPackage(['python3-qemu-qmp'])

This only works if we have python3-qemu-qmp in the target? I thought
the monitor was external?

> +def test_screenshot(self):
> +if self.td.get('MACHINE') != "qemux86-64":
> +self.fail

So we're going to throw failures on all other machines? Wouldn't a skip
be more appropriate? Can we provide images for other machines?

Have a look at things like:
   @skipIfNotMachine("qemux86-64", "tests are qemux86-64 specific currently")

> +
> +if bb.utils.which(os.getenv('PATH'), "convert") is not None and 
> bb.utils.which(os.getenv('PATH'), "compare") is not None:

This works for nativesdk-imagemagick but it would need convert+compare
in HOSTTOOLS to work for a host binary. I'm torn on the best way to
find that otherwise.

> +with tempfile.NamedTemporaryFile(prefix="oeqa-screenshot-login", 
> suffix=".png") as t:
> +ret = self.target.runner.run_monitor("screendump", 
> args={"filename": t.name, "format":"png"})
> +# Use the meta-oe version of convert, along with it's suffix
> +cmd = "convert.im7 {0} -fill white -draw 'rectangle 600,10 
> 640,22' {1}".format(t.name, t.name)
> +proc = subprocess.Popen(cmd, shell=True, 
> stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> +output, error = proc.communicate()

You probably want subprocess.check_result() 

> +
> +# Use the meta-oe version of compare, along with it's suffix
> +cmd = "compare.im7 -metric MSE {0} 
> {1}/meta/files/image-tests/core-image-sato-{2}.png /dev/null".format(t.name, 
> self.td.get('COREBASE'), self.td.get('MACHINE'))
> +proc = subprocess.Popen(cmd, shell=True, 
> stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> +output, error = proc.communicate()

and check_output()

> +diff=float(error.decode('utf-8').replace("(", 
> "").replace(")","").split()[1])
> +self.assertEqual(0, diff, "Screenshot diff is %s." % 
> (str(diff)))
> +else:
> +self.fail

Wouldn't:

self.skipTest("could not find convert tool from imagemagick")

be better?

Right now I can't merge this. With skip()s I can at least merge whilst
we sort the other pieces.

Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192322): 
https://lists.openembedded.org/g/openembedded-core/message/192322
Mute This Topic: https://lists.openembedded.org/mt/103157570/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 1/2] systemd-boot: Add recipe to compile native

2023-12-13 Thread Khem Raj
On Wed, Dec 13, 2023 at 3:58 AM Viswanath Kraleti
 wrote:
>
> systemd-boot native recipe provides ukify tool to build
> UKI images for systemd-boot
>
> Signed-off-by: Viswanath Kraleti 
> ---
>  .../systemd/systemd-boot-native_254.4.bb  | 15 +++
>  1 file changed, 15 insertions(+)
>  create mode 100644 meta/recipes-core/systemd/systemd-boot-native_254.4.bb
>
> diff --git a/meta/recipes-core/systemd/systemd-boot-native_254.4.bb 
> b/meta/recipes-core/systemd/systemd-boot-native_254.4.bb
> new file mode 100644
> index 00..0cdd7e7045
> --- /dev/null
> +++ b/meta/recipes-core/systemd/systemd-boot-native_254.4.bb
> @@ -0,0 +1,15 @@
> +require systemd.inc
> +
> +inherit native
> +
> +RRECOMMENDS:${PN} += "python3-pefile-native"
> +
> +COMPATIBLE_HOST = "(aarch64.*|arm.*|x86_64.*|i.86.*)-linux"

this is a native recipe, so I wonder why do we need COMPATIBLE_HOST

> +
> +do_configure[noexec] = "1"
> +do_compile[noexec] = "1"

should these tasks be simply deleted using deltask

> +
> +do_install () {
> +   install -d ${D}${bindir}
> +   install -m 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify

you can make it one liner

install -Dm 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify

> +}
> --
> 2.25.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192321): 
https://lists.openembedded.org/g/openembedded-core/message/192321
Mute This Topic: https://lists.openembedded.org/mt/103147679/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 2/3] lib/oe/package: add LOCALEEXTRADIRS to define extra locations for locales

2023-12-13 Thread Khem Raj
On Wed, Dec 13, 2023 at 7:07 AM Jonathan GUILLOT  wrote:
>
> Some packages may contain localized files not located in
> /usr/share/locale. This new variables allows to add these directories in
> dedicated locale packages.

I think using _ to separate the words would make it more readable so
call it LOCALE_EXTRA_PATHS or something.
secondly, it needs to be documented as well.

>
> Signed-off-by: Jonathan GUILLOT 
> ---
>  meta/lib/oe/package.py | 23 ++-
>  1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
> index 2f7a50e144..fc8b20324e 100644
> --- a/meta/lib/oe/package.py
> +++ b/meta/lib/oe/package.py
> @@ -653,24 +653,37 @@ def split_locales(d):
>  except ValueError:
>  locale_index = len(packages)
>
> -localedir = os.path.join(dvar + datadir, 'locale')
> +localedirs = [os.path.join(dvar + datadir, 'locale')]
>
> -if not cpath.isdir(localedir):
> +for localedir in (d.getVar('LOCALEEXTRADIRS') or "").split():
> +localedirs.append(dvar + localedir)
> +
> +locales = set()
> +locale_found = False
> +for localedir in localedirs:
> +if cpath.isdir(localedir):
> +locale_found = True
> +locales.update(os.listdir(localedir))
> +
> +if not locale_found:
>  bb.debug(1, "No locale files in this package")
>  return
>
> -locales = os.listdir(localedir)
> -
>  summary = d.getVar('SUMMARY') or pn
>  description = d.getVar('DESCRIPTION') or ""
>  locale_section = d.getVar('LOCALE_SECTION')
>  mlprefix = d.getVar('MLPREFIX') or ""
> +dvar_len = len(dvar)
>  for l in sorted(locales):
>  ln = legitimize_package_name(l)
>  pkg = pn + '-locale-' + ln
>  packages.insert(locale_index, pkg)
>  locale_index += 1
> -d.setVar('FILES:' + pkg, os.path.join(datadir, 'locale', l))
> +files = []
> +for localedir in localedirs:
> +# Remove dvar prefix
> +files.append(os.path.join(localedir[dvar_len:], l))
> +d.setVar('FILES:' + pkg, " ".join(files))
>  d.setVar('RRECOMMENDS:' + pkg, '%svirtual-locale-%s' % (mlprefix, 
> ln))
>  d.setVar('RPROVIDES:' + pkg, '%s-locale %s%s-translation' % (pn, 
> mlprefix, ln))
>  d.setVar('SUMMARY:' + pkg, '%s - %s translations' % (summary, l))
> --
> 2.43.0
>
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192320): 
https://lists.openembedded.org/g/openembedded-core/message/192320
Mute This Topic: https://lists.openembedded.org/mt/103150560/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 3/3] qemu: Add packageconfig knob to enable pipewire support

2023-12-13 Thread Khem Raj
This gets into a quessing mode if not specified and it it probelamactic
for native version since it maybe built on a machine having pipewire
  installed and used on another where pipewire is not installed (
  minimal CI builder ) it ends up with

runqemu - ERROR - Failed to run qemu: 
/mnt/b/yoe/master/build/tmp/work/x86_64-linux/qemu-helper-native/1.0/recipe-sysroot-native/usr/bin/qemu-system-x86_64:
 error while loading shared libraries: libpipewire-0.3.so.0: cannot open shared 
object file: No such file or directory

Signed-off-by: Khem Raj 
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/qemu/qemu.inc 
b/meta/recipes-devtools/qemu/qemu.inc
index cc508d961dd..58284ef9937 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -233,6 +233,7 @@ PACKAGECONFIG[slirp] = 
"--enable-slirp,--disable-slirp,libslirp"
 PACKAGECONFIG[brlapi] = "--enable-brlapi,--disable-brlapi"
 PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack,"
 PACKAGECONFIG[debuginfo] = "--enable-libdw,--disable-libdw,elfutils"
+PACKAGECONFIG[pipewire] = "--enable-pipewire,--disable-pipewire,pipewire"
 
 INSANE_SKIP:${PN}-common = "arch"
 
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192319): 
https://lists.openembedded.org/g/openembedded-core/message/192319
Mute This Topic: https://lists.openembedded.org/mt/103157738/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/3] qemu: Fix build with latest musl

2023-12-13 Thread Khem Raj
musl dropped basename() from string.h, adjust for that

Signed-off-by: Khem Raj 
---
 meta/recipes-devtools/qemu/qemu.inc   |  1 +
 ...io-Include-libgen.h-for-basename-API.patch | 57 +++
 2 files changed, 58 insertions(+)
 create mode 100644 
meta/recipes-devtools/qemu/qemu/0001-vfio-Include-libgen.h-for-basename-API.patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc 
b/meta/recipes-devtools/qemu/qemu.inc
index 5ab2cb83b4d..cc508d961dd 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -31,6 +31,7 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \

file://0002-linux-user-Replace-use-of-lfs64-related-functions-an.patch \
file://fixedmeson.patch \
file://fixmips.patch \
+   file://0001-vfio-Include-libgen.h-for-basename-API.patch \
file://qemu-guest-agent.init \
file://qemu-guest-agent.udev \
"
diff --git 
a/meta/recipes-devtools/qemu/qemu/0001-vfio-Include-libgen.h-for-basename-API.patch
 
b/meta/recipes-devtools/qemu/qemu/0001-vfio-Include-libgen.h-for-basename-API.patch
new file mode 100644
index 000..5b8b638736a
--- /dev/null
+++ 
b/meta/recipes-devtools/qemu/qemu/0001-vfio-Include-libgen.h-for-basename-API.patch
@@ -0,0 +1,57 @@
+From e31c67ef65a4217f35f6cd40926251054094dff9 Mon Sep 17 00:00:00 2001
+From: Khem Raj 
+Date: Mon, 11 Dec 2023 16:44:16 -0800
+Subject: [PATCH v2] vfio: Include libgen.h for basename API
+
+Glibc has two implementation one based on POSIX which is used when
+libgen.h is included and second implementation is GNU implementation
+which is used when string.h is included. The functions are no identical
+in behavior. Musl C library does not implement the GNU version, but it
+has provided a declaration in string.h but this has been corrected in
+latest musl [1] which exposes places where it was being used from
+string.h to error out especially when -Wimplicit-function-declaration is
+treated as error.
+
+| ../qemu-8.1.2/hw/vfio/pci.c:3030:18: error: call to undeclared function 
'basename'; ISO C99 and later do not support implicit function declarations 
[-Wimplicit-function-declaration]
+|  3030 | group_name = basename(group_path);
+
+clang-17 treats this warning as error by default
+
+[1] 
https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7
+
+Upstream-Status: Submitted 
[https://lists.nongnu.org/archive/html/qemu-devel/2023-12/msg01438.html]
+Signed-off-by: Khem Raj 
+---
+v2: Add missing link for [1]
+
+ hw/vfio/pci.c  | 1 +
+ hw/vfio/platform.c | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
+index c62c02f7b6..f043c93b9e 100644
+--- a/hw/vfio/pci.c
 b/hw/vfio/pci.c
+@@ -19,6 +19,7 @@
+  */
+ 
+ #include "qemu/osdep.h"
++#include 
+ #include 
+ #include 
+ 
+diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
+index 8e3d4ac458..a835ab03be 100644
+--- a/hw/vfio/platform.c
 b/hw/vfio/platform.c
+@@ -16,6 +16,7 @@
+ 
+ #include "qemu/osdep.h"
+ #include "qapi/error.h"
++#include 
+ #include 
+ #include 
+ 
+-- 
+2.43.0
+
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192318): 
https://lists.openembedded.org/g/openembedded-core/message/192318
Mute This Topic: https://lists.openembedded.org/mt/103157737/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/3] systemd: Fix build with latest musl

2023-12-13 Thread Khem Raj
musl has removed basename from string.h [1] which leads to build
failures now as declaration is gone and it should be coming from
libgen.h

[1] 
https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7

Signed-off-by: Khem Raj 
---
 ...patible-basename-for-non-glibc-syste.patch | 22 +++
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git 
a/meta/recipes-core/systemd/systemd/0017-Define-glibc-compatible-basename-for-non-glibc-syste.patch
 
b/meta/recipes-core/systemd/systemd/0017-Define-glibc-compatible-basename-for-non-glibc-syste.patch
index 7d74cfcc245..24dd6b0df17 100644
--- 
a/meta/recipes-core/systemd/systemd/0017-Define-glibc-compatible-basename-for-non-glibc-syste.patch
+++ 
b/meta/recipes-core/systemd/systemd/0017-Define-glibc-compatible-basename-for-non-glibc-syste.patch
@@ -13,22 +13,16 @@ Signed-off-by: Khem Raj 
  src/machine/machine-dbus.c | 5 +
  1 file changed, 5 insertions(+)
 
-diff --git a/src/machine/machine-dbus.c b/src/machine/machine-dbus.c
-index 45bc056326..aee51d5da5 100644
 a/src/machine/machine-dbus.c
-+++ b/src/machine/machine-dbus.c
-@@ -4,6 +4,11 @@
- #include 
- #include 
+--- a/src/basic/string-util.h
 b/src/basic/string-util.h
+@@ -26,6 +26,10 @@
+ #define URI_UNRESERVED  ALPHANUMERICAL "-._~"   /* [RFC3986] */
+ #define URI_VALID   URI_RESERVED URI_UNRESERVED /* [RFC3986] */
  
 +#if !defined(__GLIBC__)
-+#include 
 +#define basename(src) (strrchr(src,'/') ? strrchr(src,'/')+1 : src)
 +#endif
 +
- #include "alloc-util.h"
- #include "bus-common-errors.h"
- #include "bus-get-properties.h"
--- 
-2.39.2
-
+ static inline char* strstr_ptr(const char *haystack, const char *needle) {
+ if (!haystack || !needle)
+ return NULL;
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192317): 
https://lists.openembedded.org/g/openembedded-core/message/192317
Mute This Topic: https://lists.openembedded.org/mt/103157735/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCHv2 4/4] login.py: Proof of concept for screenshot testcases

2023-12-13 Thread Eilís 'pidge' Ní Fhlannagáin
This takes the work rburton did on image screenshot testing and
expands it.

Right now this only works for qemux86-64. Some standardization
of screensize/resolution needs to happen with runqemu params for other
machines. There is an issue in qemux86-64 (and possibly others) where
the screenswitch icon is only half present. This causes the test to
fail.

This test takes a screendump of a qemu image (for now, just
core-image-sato for qemux86-64), and compares it to an image we
have on record. Some normalisation of the different qemu configs
need to happen to be able to support all machines. Example, the
qemuarm64 screen size is much larger than the qemux86-64.

The image we have on record contains a blanked out clock. We do
the same blanking out process for the screenshot, so the images should
have zero differences. If they do, we fail.

In order to enable this test, you will need meta-openembedded/meta-oe in
your bblayers.conf and the following in local.conf:

IMAGE_CLASSES += "testimage"
TEST_SUITES = "login"
IMAGE_INSTALL:append = " python3-qemu-qmp "
TESTIMAGEDEPENDS:append:qemuall = " imagemagick-native:do_populate_sysroot "

Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
Co-authored-by: Ross Burton 
Co-authored-by: Eilís 'pidge' Ní Fhlannagáin 
---
 .../core-image-sato-qemux86-64.png| Bin 0 -> 46986 bytes
 meta/lib/oeqa/runtime/cases/login.py  |  34 ++
 2 files changed, 34 insertions(+)
 create mode 100644 meta/files/image-tests/core-image-sato-qemux86-64.png
 create mode 100644 meta/lib/oeqa/runtime/cases/login.py

diff --git a/meta/files/image-tests/core-image-sato-qemux86-64.png 
b/meta/files/image-tests/core-image-sato-qemux86-64.png
new file mode 100644
index 
..5a3e46169dca6d118c003d29a59c59588cee7463
GIT binary patch
literal 46986
zcmbTdb8w_x*FM^@ZDS_3CYspx#I|kQnAo;$+sULSw(SWf{Ppub@AuEC`p&7}sjjZ>
z-o5L-_geSDwXU^yq@uh85oDcxe
z5RdR?2nG60YAmTN2LO0c0ssLa0Kf}qDBuJDaAgJn|wmo^${J$055@={x8TXd@X3
zQNZUvul$~}B+yKNl$J#}Xdp4%nT0kCh(zolzt_w!VSs^D>MNA0la$II}g*jel
zE`j~c3_f6vmzmhKIe>zOG+vgHyXt?^lqU-#%$oyNq<+pxD#rVFTIk}lSG)pGS{
zBYkhyAEGaFL{e3$HGujMsDR3qK~<4P>t%UNv5H2bTSrHillj2HL2^QQs;I(*loY9>
zUiwse)CNN!rE+4D<$5WDulExL4NZm6E5$!TMv6LdNyq}ed)xppdb9f1T&-CU
zAp$t8m-p^HJI?N^gw!-zU1-8Ane(>+tgNi~e}unMQvPa^Kw|=hBrgEG$
z!jjRr*lI!`gA5b|46%>T@=KbTQJyc=n65wCW(%BwFJzT+SZx1SG-;J<@O;ZmoAuV%
zYfAsIQ8|JJ`YI1?wFpvzZ+0dZVY6NrKL{0<-fQHf9j(H
z*~h1*zI>w$yO+=vR5n6~P~Z;T>~dqXAJ9py(+IT0*YUc=RZdjFZ}$K1(=$9%17Hf*
z`|W%6X0iXgTyIN3`xwlFxL9e(@qKNCg$`=xv&(lJE?jcKk^@@(ArezkRFssH+TC!T
z8#;7JOkGP(Wzf3$MMcu!HDk5bVmY^Jp0hc>ne-q1DI>w45FhLe1Q(Z;?caJRs-+k(
zM=YOHaB`+KH?!+7s*7+o~;P=^>yEzQK_G3V-bxusxyOeVKLZjsxcAjOJ`?p
z`_AcF2^JR@GynNrVDsuiH>FOW_FqGb*CzuyhtKUuB9DW#ZaM;c-tpP4aze|fOk
zZjI%=YUd*do5#Qct*Ii>3k?uFKsuGiWWJYtz0&2*B$%?*Tp|Du4PkP*9=?5TuNbKX
zt3*dOe`P+RZ{w%zjE;f6+Ujc^{2=omvzK~+3>Ko4{0>lq&(H~4t_3sMw>9B_Pk
zS`^6s;k2G7B`a%lQo4lTiVcthn*2%>lYRGte|@~JQ@*K!t(zO0US(6l3@s=_8rii-
zpQn)!hO0Q|kxxUYn_DLJP5h76(D8WPE{2cqfwj84es8xDZkHPqH)umra#Cd9zNJ2|
zXgu0%O_SUoCC-1%X#Qp!5fx>1Vz!*g0~ZixSnsmRN-3W^J`fCJP5%~HBed>sAfV!x
z9#w0Ni04Dw=_gtQRNaWviV7+3Fr#~-$lK5A)157L|a5vR>B!X`{4kxmiT#=M=
zne$!V?st7zf>$pO2cA7Hwo5TBzOO8QdS4?V>OL3VU-$9>Ly3uH`>iP&6~rIg#gRz2qyQkPe*k%HI!Crl)cN5;oXC}BD|
zIZ4XPAN2=9h>D3dINzI1fBH)M=<$mk$L;-zW+Hc=!QWsrW4?~0;(D(ryAkEI^X`i(
zca@GKDfONEeO;F5ObufgiEbXJ)f+-VJpMpH$6Fd;0msfXi_<)X>
z`7BLB_n@qnQk`sX(=>i}#}k#+(!%HF=JvUt;nYYKOQMvEh>N4-;|v#d$JCOg
zub@laXP`G4=6lN5^G2F!wKcvBfk*mVJb%_+Xz5Hj)-
zOAz-G${Ym!ibCA48QEG}Umk%cFiXlL(D$5P59$4MWq7@{*}jpx$A8jEBt6P12OdZ&
zm_Wp11LFbk)OEMshm^=Q$$QVb==Y>i@Ftvts?tsFZ)LyH*`nhIp()SnIdEe;N
zd)K1(^Tc?8(fUm
zEZueM!ecdoeSdwT;^ob{_+4r9mSG0bO-xK2))Igbku>)H?VuRa*o2apm?*4f
z8NJDf@)1Dd-ybiSkd-H+C$yz>9sjS@Wd16Zv{dDkPSy3X3!Zw)Auhq
zP9S^B`z-L`io0rP;No@v$33Dty{VF053Axk@gqpg-^Zn96bjwzwuaSreid2b
zQ@QhIG|hfTD4~VBVSWn)XnL~|)EfUABFT-0BhcQMZ98q(uOHB{u*ACV#S?oh&|q@C
z!)74l2T~FTKaOTjdY!4Ny4-dX2Z9MYS6d2a!ShkUWi@>IH7o{Lspf4<
z^uzwZZxjQ_wQ#|kZR7l6ROz!}cl^TLs4yUol}xva$OT=}Q5

[OE-core] [PATCHv2 2/4] python3-qemu-qmp: Add recipe

2023-12-13 Thread Eilís 'pidge' Ní Fhlannagáin
From: Ross Burton 

Add a recipe for python QEMU Monitor Protocol. This will be needed for
qemu screendumps for qemu screendump testing.

Signed-off-by: Ross Burton 
Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
---
 .../python/python3-qemu-qmp_0.0.2.bb   | 14 ++
 1 file changed, 14 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb

diff --git a/meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb 
b/meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb
new file mode 100644
index 000..faa0cc69738
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb
@@ -0,0 +1,14 @@
+SUMMARY = "asyncio library for communicating with QEMU Monitor Protocol (QMP) 
servers"
+LICENSE = "LGPLv2+ & GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=4cf66a4984120007c9881cc871cf49db \
+file://LICENSE_GPL2;md5=441c28d2cf86e15a37fa47e15a72fbac"
+
+SRC_URI[sha256sum] = 
"c918e9e3ae09abdf70c7ece67637a93ac4583d940bbf48d24ff77987f74f1b8b"
+
+inherit pypi python_setuptools_build_meta
+
+PYPI_PACKAGE = "qemu.qmp"
+
+DEPENDS += "python3-setuptools-scm-native"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192314): 
https://lists.openembedded.org/g/openembedded-core/message/192314
Mute This Topic: https://lists.openembedded.org/mt/103157568/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCHv2 3/4] runqemu: add qmp socket support

2023-12-13 Thread Eilís 'pidge' Ní Fhlannagáin
From: Ross Burton 

Add support for qmp sockets and defaults to unix:qmp.sock if unspecified

Signed-off-by: Ross Burton 
Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
---
 scripts/runqemu | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/scripts/runqemu b/scripts/runqemu
index 18aeb7f5f0c..6a5a6451daf 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -84,6 +84,7 @@ of the following environment variables (in any order):
 publicvnc - enable a VNC server open to all hosts
 audio - enable audio
 guestagent - enable guest agent communication
+qmp= - create a QMP socket (defaults to unix:qmp.sock if unspecified)
 [*/]ovmf* - OVMF firmware file or base name for booting with UEFI
   tcpserial= - specify tcp serial port number
   qemuparams= - specify custom parameters to QEMU
@@ -221,6 +222,7 @@ class BaseConfig(object):
 self.cleaned = False
 # Files to cleanup after run
 self.cleanup_files = []
+self.qmp = None
 self.guest_agent = False
 self.guest_agent_sockpath = '/tmp/qga.sock'
 
@@ -536,6 +538,10 @@ to your build configuration.
 self.qemu_opt_script += ' -vnc :0'
 elif arg == 'guestagent':
 self.guest_agent = True
+elif arg == "qmp":
+self.qmp = "unix:qmp.sock"
+elif arg.startswith("qmp="):
+self.qmp = arg[len('qmp='):]
 elif arg.startswith('guestagent-sockpath='):
 self.guest_agent_sockpath = '%s' % 
arg[len('guestagent-sockpath='):]
 elif arg.startswith('tcpserial='):
@@ -1406,6 +1412,10 @@ to your build configuration.
 self.qemu_opt += ' -device virtio-serial '
 self.qemu_opt += ' -device 
virtserialport,chardev=qga0,name=org.qemu.guest_agent.0 '
 
+def setup_qmp(self):
+if self.qmp:
+self.qemu_opt += " -qmp %s,server,nowait" % self.qmp
+
 def setup_vga(self):
 if self.nographic == True:
 if self.sdl == True:
@@ -1547,6 +1557,7 @@ to your build configuration.
 self.qemu_opt += " -snapshot"
 
 self.setup_guest_agent()
+self.setup_qmp()
 self.setup_serial()
 self.setup_vga()
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192315): 
https://lists.openembedded.org/g/openembedded-core/message/192315
Mute This Topic: https://lists.openembedded.org/mt/103157569/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCHv2 0/4] Proof of concept for screenshot testcases

2023-12-13 Thread Eilís 'pidge' Ní Fhlannagáin
This takes the work rburton did on image screenshot testing and
expands it.

Right now this only works for qemux86-64. Some standardization
of screensize/resolution needs to happen with runqemu params for other
machines. There is an issue in qemux86-64 (and possibly others) where
the screenswitch icon is only half present. This causes the test to
fail.

This test takes a screendump of a qemu image (for now, just
core-image-sato for qemux86-64), and compares it to an image we
have on record. Some normalisation of the different qemu configs
need to happen to be able to support all machines. Example, the
qemuarm64 screen size is much larger than the qemux86-64.

The image we have on record contains a blanked out clock. We do
the same blanking out process for the screenshot, so the images should
have zero differences. If they do, we fail.

In order to enable this test, you will need meta-openembedded/meta-oe in
your bblayers.conf and the following in local.conf:

IMAGE_CLASSES += "testimage"
TEST_SUITES = "login"
IMAGE_INSTALL:append = " python3-qemu-qmp "
TESTIMAGEDEPENDS:append:qemuall = " imagemagick-native:do_populate_sysroot "

Eilís 'pidge' Ní Fhlannagáin (1):
  login.py: Proof of concept for screenshot testcases

Ross Burton (3):
  qemurunner: remove unused import
  python3-qemu-qmp: Add recipe
  runqemu: add qmp socket support

 .../core-image-sato-qemux86-64.png| Bin 0 -> 46986 bytes
 meta/lib/oeqa/runtime/cases/login.py  |  34 ++
 meta/lib/oeqa/utils/qemurunner.py |   1 -
 .../python/python3-qemu-qmp_0.0.2.bb  |  14 
 scripts/runqemu   |  11 ++
 5 files changed, 59 insertions(+), 1 deletion(-)
 create mode 100644 meta/files/image-tests/core-image-sato-qemux86-64.png
 create mode 100644 meta/lib/oeqa/runtime/cases/login.py
 create mode 100644 meta/recipes-devtools/python/python3-qemu-qmp_0.0.2.bb

-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192312): 
https://lists.openembedded.org/g/openembedded-core/message/192312
Mute This Topic: https://lists.openembedded.org/mt/103157566/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCHv2 1/4] qemurunner: remove unused import

2023-12-13 Thread Eilís 'pidge' Ní Fhlannagáin
From: Ross Burton 

Removes unused logging import

Signed-off-by: Ross Burton 
Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
---
 meta/lib/oeqa/utils/qemurunner.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/lib/oeqa/utils/qemurunner.py 
b/meta/lib/oeqa/utils/qemurunner.py
index 29fe2719762..ee367078000 100644
--- a/meta/lib/oeqa/utils/qemurunner.py
+++ b/meta/lib/oeqa/utils/qemurunner.py
@@ -19,7 +19,6 @@ import errno
 import string
 import threading
 import codecs
-import logging
 import tempfile
 from collections import defaultdict
 import importlib
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192313): 
https://lists.openembedded.org/g/openembedded-core/message/192313
Mute This Topic: https://lists.openembedded.org/mt/103157567/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/4] oe-selftest: add a cpp-example recipe

2023-12-13 Thread Adrian Freihofer
On Wed, 2023-12-13 at 11:10 +, Ross Burton wrote:
> 
> 
> > On 7 Dec 2023, at 20:52, Adrian Freihofer via
> > lists.openembedded.org
> >  wrote:
> > 
> > +do_run_tests () {
> > +    meson test -C "${B}" --no-rebuild
> > +}
> 
> Somewhere in  is a
> partial implementation of a generic “run the test suite at build time
> in qemu-user” which failed miserably because qemu-user is pretty
> limited.  I suspect it was _too_ generic, by trying to run the tests
> via ‘qemu-user make check’.

Maybe you mean this one which is older:
https://lists.openembedded.org/g/openembedded-core/topic/89289917

And here is a more recent discussion related to my patches:
https://lists.openembedded.org/g/openembedded-core/topic/102708283#190925

> 
> Have you had success with non-trivial test suites managed by
> cmake/meson where the tooling invokes qemu directly? Generalising
> this would be very interesting.
> 
I probably haven't run some non-trivial test suites yet. But the simple
examples I tried worked very well. Running the tests is also
transparently supported by IDEs with support for cmake and meson
(because cmake and meson integrate qemu). Debugging doesn't work yet,
but as far as I know qemu-usermode would also provide a gdbstub, which
would at least theoretically allow seamless debugger integration.
Especially for the SDK use case with IDE integration I see some
potential in this approach. It allows to develop some unit tests on the
host and finally test and deploy the application and the test binaries
on the remote target device. At least in theory, this could hide the
additional complexity of Cross as much as possible.

However, since there are some corner cases where it does not work, it
is fully optionally integrated. cmake recipes that are known to benefit
from qemu-usermode and work reliably with it can inherit cmake-qemu
instead of cmake. Also the new oe-selftests can be seen as tests for
qemu-usermode, which is a dependency of the kernel anyway and should
therefore be tested somehow.

My intention is to introduce this feature in a very limited scope, at
least in this first step.

Adrian



> Ross


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192311): 
https://lists.openembedded.org/g/openembedded-core/message/192311
Mute This Topic: https://lists.openembedded.org/mt/103042533/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] images: add core-image-initramfs-boot

2023-12-13 Thread Ross Burton
From: Ross Burton 

Add a minimal initramfs image recipe that just contains enough initramfs
to find the real root filesystem and pivot to it.

BSPs can use MACHINE_EXTRA_RRECOMMENDS to pull in any kernel module
packages that are required to bring up the hardware so that the rootfs
can be found.

Signed-off-by: Ross Burton 
---
 meta/conf/distro/include/maintainers.inc  |  1 +
 .../images/core-image-initramfs-boot.bb   | 22 +++
 2 files changed, 23 insertions(+)
 create mode 100644 meta/recipes-core/images/core-image-initramfs-boot.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 445f797bcb7..de68b32192f 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -101,6 +101,7 @@ RECIPE_MAINTAINER:pn-connman-conf = "Ross Burton 
"
 RECIPE_MAINTAINER:pn-connman-gnome = "Ross Burton "
 RECIPE_MAINTAINER:pn-consolekit = "Chen Qi "
 RECIPE_MAINTAINER:pn-core-image-base = "Richard Purdie 
"
+RECIPE_MAINTAINER:pn-core-image-initramfs-boot = "Ross Burton 
"
 RECIPE_MAINTAINER:pn-core-image-minimal = "Richard Purdie 
"
 RECIPE_MAINTAINER:pn-core-image-minimal-dev = "Richard Purdie 
"
 RECIPE_MAINTAINER:pn-core-image-minimal-initramfs = "Richard Purdie 
"
diff --git a/meta/recipes-core/images/core-image-initramfs-boot.bb 
b/meta/recipes-core/images/core-image-initramfs-boot.bb
new file mode 100644
index 000..72589447513
--- /dev/null
+++ b/meta/recipes-core/images/core-image-initramfs-boot.bb
@@ -0,0 +1,22 @@
+SUMMARY = "Basic initramfs to boot a fully-featured rootfs"
+DESCRIPTION = "Small initramfs that contains just udev and init, to find the 
real rootfs."
+LICENSE = "MIT"
+
+INITRAMFS_SCRIPTS ?= "initramfs-framework-base initramfs-module-udev"
+
+PACKAGE_INSTALL = "${INITRAMFS_SCRIPTS} ${VIRTUAL-RUNTIME_base-utils} 
base-passwd"
+
+# Ensure the initramfs only contains the bare minimum
+IMAGE_FEATURES = ""
+IMAGE_LINGUAS = ""
+
+# Don't allow the initramfs to contain a kernel, as kernel modules will depend
+# on the kernel image.
+PACKAGE_EXCLUDE = "kernel-image-*"
+
+IMAGE_FSTYPES = "${INITRAMFS_FSTYPES}"
+IMAGE_NAME_SUFFIX ?= ""
+IMAGE_ROOTFS_SIZE = "8192"
+IMAGE_ROOTFS_EXTRA_SPACE = "0"
+
+inherit image
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192310): 
https://lists.openembedded.org/g/openembedded-core/message/192310
Mute This Topic: https://lists.openembedded.org/mt/103155160/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] python3-license-expression: Fix the ptest failure

2023-12-13 Thread Ross Burton
On 13 Dec 2023, at 10:21, Yu, Mingli via lists.openembedded.org 
 wrote:
> -pytest
> +pytest -o log_cli=true -o log_cli_level=INFO | sed -e 's/\[...%\]//g'| sed 
> -e 's/PASSED/PASS/g'| sed -e 's/FAILED/FAIL/g'|sed -e 's/SKIPED/SKIP/g'| awk 
> '{if ($NF=="PASS" || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || 
> $NF=="XPASS"){printf "%s: %s\n", $NF, $0}else{print}}'| awk '{if ($NF=="PASS" 
> || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || $NF=="XPASS") {$NF="";print 
> $0}else{print}}’

python3-unittest-automake-output has a helper class to do this for you, so you 
just need to "pytest —automake”.

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192309): 
https://lists.openembedded.org/g/openembedded-core/message/192309
Mute This Topic: https://lists.openembedded.org/mt/103146950/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] why does using ${AUTOREV} with kernel recipe rebuild every time?

2023-12-13 Thread Martin Jansa
You didn't say which Yocto release that WRL build was using, maybe your
deploy artifacts are changing due to package_get_auto_pr calls or not
excluded DATETIME in your filenames as described in:
https://patchwork.yoctoproject.org/project/oe-core/patch/932d980fb4fcfd3b78183d5bd51adb4f038eee47.1700600804.git.martin.ja...@gmail.com/

unfortunately this whole series
https://patchwork.yoctoproject.org/project/oe-core/list/?series=19541 was
rejected:
https://lists.openembedded.org/g/openembedded-core/message/191101

On Wed, Dec 13, 2023 at 4:54 PM Robert P. J. Day 
wrote:

>
>   i *know* i should know the answer to this, but someone just showed
> me a build (WRLinux-based, but still relevant) where the linux kernel
> recipe uses:
>
>   SRCREV_machine = ${AUTOREV}
>
> which is what one reads in the WRL version of linux-yocto-custom.bb,
> but also makes it clear in that recipe file that that is discouraged.
>
>   in any event, this appears to be forcing an entire rebuild of the
> kernel every time, even in the presence of sstate-cache, so the
> obvious question is, what is it about using ${AUTOREV} that defeats
> the use of sstate-cache? apologies if this should be obvious.
>
> rday
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192308): 
https://lists.openembedded.org/g/openembedded-core/message/192308
Mute This Topic: https://lists.openembedded.org/mt/103151800/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] python3-license-expression: Fix the ptest failure

2023-12-13 Thread Alexander Kanavin
I see that run-ptest consists of a single pytest command; does that
command return a zero exit code even it fails?

Alex

On Wed, 13 Dec 2023 at 17:38, Alexander Kanavin  wrote:
>
> Why isn't the ptest failure reported by the autobuilder? Shouldn't we
> first fix the ptest so that the failure is reported correctly, if it
> starts occurring again?
>
> Alex
>
> On Wed, 13 Dec 2023 at 11:21, Yu, Mingli  wrote:
> >
> > From: Mingli Yu 
> >
> > Fix the below ptest failure:
> >  self =  > testMethod=test_skeleton_codestyle>
> >  def test_skeleton_codestyle(self):
> >  """
> >  This test shouldn't run in proliferated repositories.
> >  """
> >  setup_cfg = configparser.ConfigParser()
> >  setup_cfg.read("setup.cfg")
> >  > if setup_cfg["metadata"]["name"] != "skeleton":
> >  tests/test_skeleton_codestyle.py:22:
> >  self = , key = 
> > 'metadata'
> >  def _getitem_(self, key):
> >  if key != self.default_section and not self.has_section(key):
> >  > raise KeyError(key)
> >  E KeyError: 'metadata'
> >
> > After the patch:
> >  # ./run-ptest
> >  [snip]
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_bad_syntax
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_as_regular_key
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_with_choice
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception_strict_false
> >  PASS: 
> > tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_key
> >  PASS: tests/test_license_expression.py::UtilTest::test_build_licensing
> >  PASS: tests/test_license_expression.py::UtilTest::test_build_spdx_licensing
> >  PASS: tests/test_license_expression.py::UtilTest::test_get_license_key_info
> >  PASS: 
> > tests/test_license_expression.py::UtilTest::test_get_license_key_info_vendored
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_duplicated_elements
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_empty_input
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_or_relationship
> >  PASS: 
> > tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_regular
> >  PASS: tests/test_skeleton_codestyle.py::BaseTests::test_skeleton_codestyle
> >
> >  = 175 passed in 10.36s 
> > =
> >
> > Signed-off-by: Mingli Yu 
> > ---
> >  .../python/python3-license-expression/run-ptest | 2 +-
> >  .../python/python3-license-expression_30.1.1.bb | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git 
> > a/meta/recipes-devtools/python/python3-license-expression/run-ptest 
> > b/meta/recipes-devtools/python/python3-license-expression/run-ptest
> > index 5cec711696..3385d68939 100644
> > --- a/meta/recipes-devtools/python/python3-license-expression/run-ptest
> > +++ b/meta/recipes-devtools/python/python3-license-expression/run-ptest
> > @@ -1,3 +1,3 @@
> >  #!/bin/sh
> >
> > -pytest
> > +pytest -o log_cli=true -o log_cli_level=INFO | sed -e 's/\[...%\]//g'| sed 
> > -e 's/PASSED/PASS/g'| sed -e 's/FAILED/FAIL/g'|sed -e 's/SKIPED/SKIP/g'| 
> > awk '{if ($NF=="PASS" || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || 
> > $NF=="XPASS"){printf "%s: %s\n", $NF, $0}else{print}}'| awk '{if 
> > ($NF=="PASS" || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || $NF=="XPASS") 
> > {$NF="";print $0}else{print}}'
> > diff --git 
> > a/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb 
> > b/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
> > index 31fb88d6e5..5d3923d487 100644
> > --- a/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
> > +++ b/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
> > @@ -33,4 +33,5 @@ do_install_ptest() {
> >  install -d ${D}${PTEST_PATH}/src
> >  cp -rf ${S}/tests/* ${D}${PTEST_PATH}/tests/
> >  cp -rf ${S}/src/* ${D}${PTEST_PATH}/src/
> > +cp -rf ${S}/setup.cfg ${D}${PTEST_PATH}/
> >  }
> > --
> > 2.25.1
> >
> >
> > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192307): 
https://lists.openembedded.org/g/openembedded-core/message/192307
Mute This Topic: https://lists.openembedded.org/mt/103146950/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] python3-license-expression: Fix the ptest failure

2023-12-13 Thread Alexander Kanavin
Why isn't the ptest failure reported by the autobuilder? Shouldn't we
first fix the ptest so that the failure is reported correctly, if it
starts occurring again?

Alex

On Wed, 13 Dec 2023 at 11:21, Yu, Mingli  wrote:
>
> From: Mingli Yu 
>
> Fix the below ptest failure:
>  self = 
>  def test_skeleton_codestyle(self):
>  """
>  This test shouldn't run in proliferated repositories.
>  """
>  setup_cfg = configparser.ConfigParser()
>  setup_cfg.read("setup.cfg")
>  > if setup_cfg["metadata"]["name"] != "skeleton":
>  tests/test_skeleton_codestyle.py:22:
>  self = , key = 'metadata'
>  def _getitem_(self, key):
>  if key != self.default_section and not self.has_section(key):
>  > raise KeyError(key)
>  E KeyError: 'metadata'
>
> After the patch:
>  # ./run-ptest
>  [snip]
>  PASS: 
> tests/test_license_expression.py::LicensingValidateTest::test_validation_bad_syntax
>  PASS: 
> tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_as_regular_key
>  PASS: 
> tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_with_choice
>  PASS: 
> tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception
>  PASS: 
> tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception_strict_false
>  PASS: 
> tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_key
>  PASS: tests/test_license_expression.py::UtilTest::test_build_licensing
>  PASS: tests/test_license_expression.py::UtilTest::test_build_spdx_licensing
>  PASS: tests/test_license_expression.py::UtilTest::test_get_license_key_info
>  PASS: 
> tests/test_license_expression.py::UtilTest::test_get_license_key_info_vendored
>  PASS: 
> tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_duplicated_elements
>  PASS: 
> tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_empty_input
>  PASS: 
> tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_or_relationship
>  PASS: 
> tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_regular
>  PASS: tests/test_skeleton_codestyle.py::BaseTests::test_skeleton_codestyle
>
>  = 175 passed in 10.36s 
> =
>
> Signed-off-by: Mingli Yu 
> ---
>  .../python/python3-license-expression/run-ptest | 2 +-
>  .../python/python3-license-expression_30.1.1.bb | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git 
> a/meta/recipes-devtools/python/python3-license-expression/run-ptest 
> b/meta/recipes-devtools/python/python3-license-expression/run-ptest
> index 5cec711696..3385d68939 100644
> --- a/meta/recipes-devtools/python/python3-license-expression/run-ptest
> +++ b/meta/recipes-devtools/python/python3-license-expression/run-ptest
> @@ -1,3 +1,3 @@
>  #!/bin/sh
>
> -pytest
> +pytest -o log_cli=true -o log_cli_level=INFO | sed -e 's/\[...%\]//g'| sed 
> -e 's/PASSED/PASS/g'| sed -e 's/FAILED/FAIL/g'|sed -e 's/SKIPED/SKIP/g'| awk 
> '{if ($NF=="PASS" || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || 
> $NF=="XPASS"){printf "%s: %s\n", $NF, $0}else{print}}'| awk '{if ($NF=="PASS" 
> || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || $NF=="XPASS") {$NF="";print 
> $0}else{print}}'
> diff --git 
> a/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb 
> b/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
> index 31fb88d6e5..5d3923d487 100644
> --- a/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
> +++ b/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
> @@ -33,4 +33,5 @@ do_install_ptest() {
>  install -d ${D}${PTEST_PATH}/src
>  cp -rf ${S}/tests/* ${D}${PTEST_PATH}/tests/
>  cp -rf ${S}/src/* ${D}${PTEST_PATH}/src/
> +cp -rf ${S}/setup.cfg ${D}${PTEST_PATH}/
>  }
> --
> 2.25.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192306): 
https://lists.openembedded.org/g/openembedded-core/message/192306
Mute This Topic: https://lists.openembedded.org/mt/103146950/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] rxvt-unicode: set correct outdir for tic

2023-12-13 Thread Alexander Kanavin
On Wed, 13 Dec 2023 at 09:30, Changqing Li
 wrote:
> +From 1b7d547453fc57806ef86f64c86706530a23e62e Mon Sep 17 00:00:00 2001
> +From: Changqing Li 
> +Date: Wed, 13 Dec 2023 11:53:18 +0800
> +Subject: [PATCH] Makefile.in: set outdir for tic
> +
> +tic is from ncurses-native, and set TERMINFO as
> +${RECIPE_SYSROOT_NATIVE}/${datadir}/terminfo of ncurses-native, so the
> +rxvt-unicode terminfo will be wrongly installed in there.  set the
> +outdir explicitly to install them to correct dir.
> +
> +Upstream-Status: Inappropriate [oe specific]
> +
> +Signed-off-by: Changqing Li 
> +---
> + doc/Makefile.in | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/doc/Makefile.in b/doc/Makefile.in
> +index e3d1fe8..1de56d3 100644
> +--- a/doc/Makefile.in
>  b/doc/Makefile.in
> +@@ -100,8 +100,8 @@ install: all
> +   $(INSTALL_DATA) rxvtd.1.man   
> $(DESTDIR)$(man1dir)/$(RXVTNAME)d.$(man1ext)
> +   $(INSTALL_DATA) rxvt.7.man
> $(DESTDIR)$(man7dir)/$(RXVTNAME).$(man7ext)
> +   $(INSTALL_DATA) rclock.1.man  $(DESTDIR)$(man1dir)/urclock.$(man1ext)
> +-  @TIC@ -x $(srcdir)/etc/rxvt-unicode.terminfo || \
> +-   @TIC@ $(srcdir)/etc/rxvt-unicode.terminfo
> ++  @TIC@ -x $(srcdir)/etc/rxvt-unicode.terminfo -o 
> $(DESTDIR)$(datadir)/terminfo || \
> ++   @TIC@ $(srcdir)/etc/rxvt-unicode.terminfo -o 
> $(DESTDIR)$(datadir)/terminfo

This does look like a suitable change for upstream submission, and
should not be marked Inappropriate. Please do so first.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192305): 
https://lists.openembedded.org/g/openembedded-core/message/192305
Mute This Topic: https://lists.openembedded.org/mt/103146260/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] openssl: mark assembler sections as call targets for PAC/BTI support on aarch64

2023-12-13 Thread Ross Burton
From: Ross Burton 

The assembler sections in OpenSSL were not marked as valid call targets,
so branch protection could not be enabled for libcrypto.so.

Signed-off-by: Ross Burton 
---
 .../openssl/openssl/aarch64-bti.patch | 35 +++
 .../openssl/openssl_3.2.0.bb  |  1 +
 2 files changed, 36 insertions(+)
 create mode 100644 meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch

diff --git a/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch 
b/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
new file mode 100644
index 000..2a16debb76e
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
@@ -0,0 +1,35 @@
+From ad347c9ff0fd93bdd2fa2085611c65b88e94829f Mon Sep 17 00:00:00 2001
+From: "fangming.fang" 
+Date: Thu, 7 Dec 2023 06:17:51 +
+Subject: [PATCH] Enable BTI feature for md5 on aarch64
+
+Fixes: #22959
+
+Reviewed-by: Tom Cosgrove 
+Reviewed-by: Tomas Mraz 
+(Merged from https://github.com/openssl/openssl/pull/22971)
+
+Upstream-Status: Backport
+Signed-off-by: Ross Burton 
+---
+ crypto/md5/asm/md5-aarch64.pl | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/crypto/md5/asm/md5-aarch64.pl b/crypto/md5/asm/md5-aarch64.pl
+index 3200a0fa9bff0..5a8608069691d 100755
+--- a/crypto/md5/asm/md5-aarch64.pl
 b/crypto/md5/asm/md5-aarch64.pl
+@@ -28,10 +28,13 @@
+ *STDOUT=*OUT;
+ 
+ $code .= [OE-core] why does using ${AUTOREV} with kernel recipe rebuild every time?


  i *know* i should know the answer to this, but someone just showed
me a build (WRLinux-based, but still relevant) where the linux kernel
recipe uses:

  SRCREV_machine = ${AUTOREV}

which is what one reads in the WRL version of linux-yocto-custom.bb,
but also makes it clear in that recipe file that that is discouraged.

  in any event, this appears to be forcing an entire rebuild of the
kernel every time, even in the presence of sstate-cache, so the
obvious question is, what is it about using ${AUTOREV} that defeats
the use of sstate-cache? apologies if this should be obvious.

rday

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192303): 
https://lists.openembedded.org/g/openembedded-core/message/192303
Mute This Topic: https://lists.openembedded.org/mt/103151800/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 0/3] lib/oe/package: allow to scan extra directories for locale files

Ok, let's try it one more time with suggestions proposed:
- Add "Signed-off-by" to the commits ;
- Fix the subject of the cover letter.



Just playing with cups and observe the main packages includes localized HTML 
templates in /usr/share/cups/templates. Locale packages were only looking for 
files in /usr/locale. This serie of patches allows to add extra directories to 
be scanned.
For a next patch, I would also like possible FILES:${PN}-locale-* variables 
defined in recipe not to be overriden by the split_locales() function.

It is my first patch proposal on this project. Thanks in advance for your 
feedbacks.

Regards,
Jonathan GUILLOT

Jonathan GUILLOT (3):
  lib/oe/package: replace in place PN-locale-* packages in PACKAGES
  lib/oe/package: add LOCALEEXTRADIRS to define extra locations for
locales
  cups: use LOCALEEXTRADIRS to split localized HTML templates

 meta/lib/oe/package.py  | 33 ++---
 meta/recipes-extended/cups/cups.inc |  2 ++
 2 files changed, 27 insertions(+), 8 deletions(-)


base-commit: 41390f5202a6ee7472cb82d12c7c32f89d6e52ff
-- 
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192300): 
https://lists.openembedded.org/g/openembedded-core/message/192300
Mute This Topic: https://lists.openembedded.org/mt/103150558/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 2/3] lib/oe/package: add LOCALEEXTRADIRS to define extra locations for locales

Some packages may contain localized files not located in
/usr/share/locale. This new variables allows to add these directories in
dedicated locale packages.

Signed-off-by: Jonathan GUILLOT 
---
 meta/lib/oe/package.py | 23 ++-
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 2f7a50e144..fc8b20324e 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -653,24 +653,37 @@ def split_locales(d):
 except ValueError:
 locale_index = len(packages)
 
-localedir = os.path.join(dvar + datadir, 'locale')
+localedirs = [os.path.join(dvar + datadir, 'locale')]
 
-if not cpath.isdir(localedir):
+for localedir in (d.getVar('LOCALEEXTRADIRS') or "").split():
+localedirs.append(dvar + localedir)
+
+locales = set()
+locale_found = False
+for localedir in localedirs:
+if cpath.isdir(localedir):
+locale_found = True
+locales.update(os.listdir(localedir))
+
+if not locale_found:
 bb.debug(1, "No locale files in this package")
 return
 
-locales = os.listdir(localedir)
-
 summary = d.getVar('SUMMARY') or pn
 description = d.getVar('DESCRIPTION') or ""
 locale_section = d.getVar('LOCALE_SECTION')
 mlprefix = d.getVar('MLPREFIX') or ""
+dvar_len = len(dvar)
 for l in sorted(locales):
 ln = legitimize_package_name(l)
 pkg = pn + '-locale-' + ln
 packages.insert(locale_index, pkg)
 locale_index += 1
-d.setVar('FILES:' + pkg, os.path.join(datadir, 'locale', l))
+files = []
+for localedir in localedirs:
+# Remove dvar prefix
+files.append(os.path.join(localedir[dvar_len:], l))
+d.setVar('FILES:' + pkg, " ".join(files))
 d.setVar('RRECOMMENDS:' + pkg, '%svirtual-locale-%s' % (mlprefix, ln))
 d.setVar('RPROVIDES:' + pkg, '%s-locale %s%s-translation' % (pn, 
mlprefix, ln))
 d.setVar('SUMMARY:' + pkg, '%s - %s translations' % (summary, l))
-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192302): 
https://lists.openembedded.org/g/openembedded-core/message/192302
Mute This Topic: https://lists.openembedded.org/mt/103150560/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 1/3] lib/oe/package: replace in place PN-locale-* packages in PACKAGES

split_locales() removes PN-locale from PACKAGES and adds PN-locale-* to the end.
As the PN-locale package typically appears before PN base package, it may result
in paths not installed in PN-locale-* packages if already catched by PN. Now
insert PN-locale-* exactly where PN-locale was existing in list to avoid such
an issue.

Signed-off-by: Jonathan GUILLOT 
---
 meta/lib/oe/package.py | 10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 9a465eaa09..2f7a50e144 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -647,8 +647,11 @@ def split_locales(d):
 dvar = d.getVar('PKGD')
 pn = d.getVar('LOCALEBASEPN')
 
-if pn + '-locale' in packages:
-packages.remove(pn + '-locale')
+try:
+locale_index = packages.index(pn + '-locale')
+packages.pop(locale_index)
+except ValueError:
+locale_index = len(packages)
 
 localedir = os.path.join(dvar + datadir, 'locale')
 
@@ -665,7 +668,8 @@ def split_locales(d):
 for l in sorted(locales):
 ln = legitimize_package_name(l)
 pkg = pn + '-locale-' + ln
-packages.append(pkg)
+packages.insert(locale_index, pkg)
+locale_index += 1
 d.setVar('FILES:' + pkg, os.path.join(datadir, 'locale', l))
 d.setVar('RRECOMMENDS:' + pkg, '%svirtual-locale-%s' % (mlprefix, ln))
 d.setVar('RPROVIDES:' + pkg, '%s-locale %s%s-translation' % (pn, 
mlprefix, ln))
-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192299): 
https://lists.openembedded.org/g/openembedded-core/message/192299
Mute This Topic: https://lists.openembedded.org/mt/103150557/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 3/3] cups: use LOCALEEXTRADIRS to split localized HTML templates

Localized HTML templates in /usr/share/cups/templates are now part of
locale packages.

Signed-off-by: Jonathan GUILLOT 
---
 meta/recipes-extended/cups/cups.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/cups/cups.inc 
b/meta/recipes-extended/cups/cups.inc
index 31f686cdfd..560bd67cf6 100644
--- a/meta/recipes-extended/cups/cups.inc
+++ b/meta/recipes-extended/cups/cups.inc
@@ -110,6 +110,8 @@ CONFFILES:${PN} += "${sysconfdir}/cups/cupsd.conf"
 
 MULTILIB_SCRIPTS = "${PN}-dev:${bindir}/cups-config"
 
+LOCALEEXTRADIRS = "${datadir}/cups/templates/"
+
 SYSROOT_PREPROCESS_FUNCS += "cups_sysroot_preprocess"
 cups_sysroot_preprocess () {
sed -i ${SYSROOT_DESTDIR}${bindir_crossscripts}/cups-config -e 
's:cups_datadir=.*:cups_datadir=${datadir}/cups:' -e 
's:cups_serverbin=.*:cups_serverbin=${libexecdir}/cups:'
-- 
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192301): 
https://lists.openembedded.org/g/openembedded-core/message/192301
Mute This Topic: https://lists.openembedded.org/mt/103150559/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 0/3] Hi,

Thanks Yoann,
I will resubmit these patches with your suggestions.

Le mer. 13 déc. 2023 à 15:47, Yoann Congal  a écrit :
>
> Hi Jonathan,
>
> Le 13/12/2023 à 15:15, Jonathan GUILLOT a écrit :
> > Just playing with cups and observe the main packages includes localized 
> > HTML templates in /usr/share/cups/templates. Locale packages were only 
> > looking for files in /usr/locale. This serie of patches allows to add extra 
> > directories to be scanned.
> > For a next patch, I would also like possible FILES:${PN}-locale-* variables 
> > defined in recipe not to be overriden by the split_locales() function.
> >
> > It is my first patch proposal on this project. Thanks in advance for your 
> > feedbacks.
>
> First, welcome! (If I'm not mistaken, we did work together some time ago :) )
>
> Rapidly glancing at your patches, I noticed they miss the "Signed-off-by:" 
> tag.
> Try to follow instructions at 
> https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#implement-and-commit-changes.
> Basically, you'll need to rebase your commits and using "git commit --amend 
> -s".
>
> Another thing, the subject of your coverletter mail is "Hi," (you may want to 
> use a subject that provide some info on the content of your series)
>
> Regards,
>
> > Regards,
> > Jonathan GUILLOT
> >
> > Jonathan GUILLOT (3):
> >   lib/oe/package: replace in place PN-locale-* packages in PACKAGES
> >   lib/oe/package: add LOCALEEXTRADIRS to define extra locations for
> > locales
> >   cups: use LOCALEEXTRADIRS to split localized HTML templates
> >
> >  meta/lib/oe/package.py  | 33 ++---
> >  meta/recipes-extended/cups/cups.inc |  2 ++
> >  2 files changed, 27 insertions(+), 8 deletions(-)
> >
> >
> > base-commit: 564339afb73fc52a66c1a08437587cad1c4d46e7
> >
> >
> >
> > 
> >
>
> --
> Yoann Congal
> Smile ECS - Tech Expert

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192298): 
https://lists.openembedded.org/g/openembedded-core/message/192298
Mute This Topic: https://lists.openembedded.org/mt/103149509/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] patchtest: Add test for deprecated CVE_CHECK_IGNORE



On 2023-12-13 06:27, Ross Burton wrote:

On 11 Dec 2023, at 16:45, simone.p.weiss via lists.openembedded.org 
 wrote:

From: Simone Weiß 

If a recipes was modified recommand the use of `CVE_STATUS` instead if
`CVE_CHECK_IGNORE` is used. This is a depreacted variable and will
result in a warning from the cve-check.class and should hence not be
used anymore. [YOCTO #15311]

It feels like this shouldn’t be CVE_CHECK_IGNORE-specific but a general 
deprecated variable check.  Can you rename so we can easily add more variables 
later?

Relatedly, BB_RENAMED_VARIABLES is a map of variables which got deprecated but 
the solution is a simple rename, the same check should look for those too.


I agree,  this would be a good change to make for long-term 
maintainability. LGTM otherwise.


- Trevor



Ross




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192297): 
https://lists.openembedded.org/g/openembedded-core/message/192297
Mute This Topic: https://lists.openembedded.org/mt/103112424/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 0/3] Hi,

Hi Jonathan,

Le 13/12/2023 à 15:15, Jonathan GUILLOT a écrit :
> Just playing with cups and observe the main packages includes localized HTML 
> templates in /usr/share/cups/templates. Locale packages were only looking for 
> files in /usr/locale. This serie of patches allows to add extra directories 
> to be scanned.
> For a next patch, I would also like possible FILES:${PN}-locale-* variables 
> defined in recipe not to be overriden by the split_locales() function.
> 
> It is my first patch proposal on this project. Thanks in advance for your 
> feedbacks.

First, welcome! (If I'm not mistaken, we did work together some time ago :) )

Rapidly glancing at your patches, I noticed they miss the "Signed-off-by:" tag.
Try to follow instructions at 
https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#implement-and-commit-changes.
Basically, you'll need to rebase your commits and using "git commit --amend -s".

Another thing, the subject of your coverletter mail is "Hi," (you may want to 
use a subject that provide some info on the content of your series)

Regards,

> Regards,
> Jonathan GUILLOT
> 
> Jonathan GUILLOT (3):
>   lib/oe/package: replace in place PN-locale-* packages in PACKAGES
>   lib/oe/package: add LOCALEEXTRADIRS to define extra locations for
> locales
>   cups: use LOCALEEXTRADIRS to split localized HTML templates
> 
>  meta/lib/oe/package.py  | 33 ++---
>  meta/recipes-extended/cups/cups.inc |  2 ++
>  2 files changed, 27 insertions(+), 8 deletions(-)
> 
> 
> base-commit: 564339afb73fc52a66c1a08437587cad1c4d46e7
> 
> 
> 
> 
> 

-- 
Yoann Congal
Smile ECS - Tech Expert

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192296): 
https://lists.openembedded.org/g/openembedded-core/message/192296
Mute This Topic: https://lists.openembedded.org/mt/103149509/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/3] lib/oe/package: add LOCALEEXTRADIRS to define extra locations for locales

Some packages may contain localized files not located in
/usr/share/locale. This new variables allows to add these directories in
dedicated locale packages.
---
 meta/lib/oe/package.py | 23 ++-
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 2f7a50e144..fc8b20324e 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -653,24 +653,37 @@ def split_locales(d):
 except ValueError:
 locale_index = len(packages)
 
-localedir = os.path.join(dvar + datadir, 'locale')
+localedirs = [os.path.join(dvar + datadir, 'locale')]
 
-if not cpath.isdir(localedir):
+for localedir in (d.getVar('LOCALEEXTRADIRS') or "").split():
+localedirs.append(dvar + localedir)
+
+locales = set()
+locale_found = False
+for localedir in localedirs:
+if cpath.isdir(localedir):
+locale_found = True
+locales.update(os.listdir(localedir))
+
+if not locale_found:
 bb.debug(1, "No locale files in this package")
 return
 
-locales = os.listdir(localedir)
-
 summary = d.getVar('SUMMARY') or pn
 description = d.getVar('DESCRIPTION') or ""
 locale_section = d.getVar('LOCALE_SECTION')
 mlprefix = d.getVar('MLPREFIX') or ""
+dvar_len = len(dvar)
 for l in sorted(locales):
 ln = legitimize_package_name(l)
 pkg = pn + '-locale-' + ln
 packages.insert(locale_index, pkg)
 locale_index += 1
-d.setVar('FILES:' + pkg, os.path.join(datadir, 'locale', l))
+files = []
+for localedir in localedirs:
+# Remove dvar prefix
+files.append(os.path.join(localedir[dvar_len:], l))
+d.setVar('FILES:' + pkg, " ".join(files))
 d.setVar('RRECOMMENDS:' + pkg, '%svirtual-locale-%s' % (mlprefix, ln))
 d.setVar('RPROVIDES:' + pkg, '%s-locale %s%s-translation' % (pn, 
mlprefix, ln))
 d.setVar('SUMMARY:' + pkg, '%s - %s translations' % (summary, l))
-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192294): 
https://lists.openembedded.org/g/openembedded-core/message/192294
Mute This Topic: https://lists.openembedded.org/mt/103149511/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/3] lib/oe/package: replace in place PN-locale-* packages in PACKAGES

split_locales() removes PN-locale from PACKAGES and adds PN-locale-* to the end.
As the PN-locale package typically appears before PN base package, it may result
in paths not installed in PN-locale-* packages if already catched by PN. Now
insert PN-locale-* exactly where PN-locale was existing in list to avoid such
an issue.
---
 meta/lib/oe/package.py | 10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 9a465eaa09..2f7a50e144 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -647,8 +647,11 @@ def split_locales(d):
 dvar = d.getVar('PKGD')
 pn = d.getVar('LOCALEBASEPN')
 
-if pn + '-locale' in packages:
-packages.remove(pn + '-locale')
+try:
+locale_index = packages.index(pn + '-locale')
+packages.pop(locale_index)
+except ValueError:
+locale_index = len(packages)
 
 localedir = os.path.join(dvar + datadir, 'locale')
 
@@ -665,7 +668,8 @@ def split_locales(d):
 for l in sorted(locales):
 ln = legitimize_package_name(l)
 pkg = pn + '-locale-' + ln
-packages.append(pkg)
+packages.insert(locale_index, pkg)
+locale_index += 1
 d.setVar('FILES:' + pkg, os.path.join(datadir, 'locale', l))
 d.setVar('RRECOMMENDS:' + pkg, '%svirtual-locale-%s' % (mlprefix, ln))
 d.setVar('RPROVIDES:' + pkg, '%s-locale %s%s-translation' % (pn, 
mlprefix, ln))
-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192293): 
https://lists.openembedded.org/g/openembedded-core/message/192293
Mute This Topic: https://lists.openembedded.org/mt/103149510/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 3/3] cups: use LOCALEEXTRADIRS to split localized HTML templates

Localized HTML templates in /usr/share/cups/templates are now part of
locale packages.
---
 meta/recipes-extended/cups/cups.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-extended/cups/cups.inc 
b/meta/recipes-extended/cups/cups.inc
index 31f686cdfd..560bd67cf6 100644
--- a/meta/recipes-extended/cups/cups.inc
+++ b/meta/recipes-extended/cups/cups.inc
@@ -110,6 +110,8 @@ CONFFILES:${PN} += "${sysconfdir}/cups/cupsd.conf"
 
 MULTILIB_SCRIPTS = "${PN}-dev:${bindir}/cups-config"
 
+LOCALEEXTRADIRS = "${datadir}/cups/templates/"
+
 SYSROOT_PREPROCESS_FUNCS += "cups_sysroot_preprocess"
 cups_sysroot_preprocess () {
sed -i ${SYSROOT_DESTDIR}${bindir_crossscripts}/cups-config -e 
's:cups_datadir=.*:cups_datadir=${datadir}/cups:' -e 
's:cups_serverbin=.*:cups_serverbin=${libexecdir}/cups:'
-- 
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192295): 
https://lists.openembedded.org/g/openembedded-core/message/192295
Mute This Topic: https://lists.openembedded.org/mt/103149512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 0/3] Hi,

Just playing with cups and observe the main packages includes localized HTML 
templates in /usr/share/cups/templates. Locale packages were only looking for 
files in /usr/locale. This serie of patches allows to add extra directories to 
be scanned.
For a next patch, I would also like possible FILES:${PN}-locale-* variables 
defined in recipe not to be overriden by the split_locales() function.

It is my first patch proposal on this project. Thanks in advance for your 
feedbacks.

Regards,
Jonathan GUILLOT

Jonathan GUILLOT (3):
  lib/oe/package: replace in place PN-locale-* packages in PACKAGES
  lib/oe/package: add LOCALEEXTRADIRS to define extra locations for
locales
  cups: use LOCALEEXTRADIRS to split localized HTML templates

 meta/lib/oe/package.py  | 33 ++---
 meta/recipes-extended/cups/cups.inc |  2 ++
 2 files changed, 27 insertions(+), 8 deletions(-)


base-commit: 564339afb73fc52a66c1a08437587cad1c4d46e7
-- 
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192292): 
https://lists.openembedded.org/g/openembedded-core/message/192292
Mute This Topic: https://lists.openembedded.org/mt/103149509/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-Core][PATCH] rust: Upgrade 1.71.1 -> 1.74.1

On Wed, 2023-12-13 at 09:41 +, Alex Kiernan wrote:
> Drop getrandom-open64.patch (merged upstream), replace musl fixes with
> backports from upstream.
> 
> Add sysconfdir to config.toml to fix:
> 
> > thread 'main' panicked at install.rs:92:9:
> > User doesn't have write access on `install.sysconfdir` path in 
> > `config.toml`.
> 
> https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html
> https://blog.rust-lang.org/2023/09/19/Rust-1.72.1.html
> https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html
> https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html
> https://blog.rust-lang.org/2023/12/07/Rust-1.74.1.html
> 
> Signed-off-by: Alex Kiernan 
> ---
> Short of trying this through the autobuilders, I don't think I've any
> real way of understanding whether 1.74.1 is actually any better from a
> reproducibility point of view. This is basically my previous series
> squashed with the 1.74.1 patch rebased on top of master-next.

I've run this with this patch included:

https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4082

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192291): 
https://lists.openembedded.org/g/openembedded-core/message/192291
Mute This Topic: https://lists.openembedded.org/mt/103146651/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 2/2] systemd-boot: Add efi stubs to systemd-boot-stubs PACKAGE

Place efi stubs generated by systemd-boot in systemd-boot-stubs package.
Currently these are only installed in DEPLOY_DIR, making it difficult to
consume from other recipes.

Signed-off-by: Viswanath Kraleti 
---
 meta/recipes-core/systemd/systemd-boot_254.4.bb | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-core/systemd/systemd-boot_254.4.bb 
b/meta/recipes-core/systemd/systemd-boot_254.4.bb
index 2b43ccf243..45c08dcb31 100644
--- a/meta/recipes-core/systemd/systemd-boot_254.4.bb
+++ b/meta/recipes-core/systemd/systemd-boot_254.4.bb
@@ -59,6 +59,8 @@ COMPATIBLE_HOST:x86-x32 = "null"
 do_install() {
install -d ${D}${EFI_FILES_PATH}
install ${B}/src/boot/efi/systemd-boot*.efi 
${D}${EFI_FILES_PATH}/${SYSTEMD_BOOT_IMAGE}
+   install ${B}/src/boot/efi/linux*.efi.stub ${D}
+   install ${B}/src/boot/efi/addon*.efi.stub ${D}
 }
 
 do_deploy () {
@@ -69,3 +71,5 @@ do_deploy () {
 
 addtask deploy before do_build after do_compile
 
+PACKAGES += "${PN}-stubs"
+FILES:${PN}-stubs = "*.efi.stub"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192290): 
https://lists.openembedded.org/g/openembedded-core/message/192290
Mute This Topic: https://lists.openembedded.org/mt/103147681/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 1/2] systemd-boot: Add recipe to compile native

systemd-boot native recipe provides ukify tool to build
UKI images for systemd-boot

Signed-off-by: Viswanath Kraleti 
---
 .../systemd/systemd-boot-native_254.4.bb  | 15 +++
 1 file changed, 15 insertions(+)
 create mode 100644 meta/recipes-core/systemd/systemd-boot-native_254.4.bb

diff --git a/meta/recipes-core/systemd/systemd-boot-native_254.4.bb 
b/meta/recipes-core/systemd/systemd-boot-native_254.4.bb
new file mode 100644
index 00..0cdd7e7045
--- /dev/null
+++ b/meta/recipes-core/systemd/systemd-boot-native_254.4.bb
@@ -0,0 +1,15 @@
+require systemd.inc
+
+inherit native
+
+RRECOMMENDS:${PN} += "python3-pefile-native"
+
+COMPATIBLE_HOST = "(aarch64.*|arm.*|x86_64.*|i.86.*)-linux"
+
+do_configure[noexec] = "1"
+do_compile[noexec] = "1"
+
+do_install () {
+   install -d ${D}${bindir}
+   install -m 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192289): 
https://lists.openembedded.org/g/openembedded-core/message/192289
Mute This Topic: https://lists.openembedded.org/mt/103147679/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/2] staging: ensure postinst-useradd is run in order

> -Original Message-
> From: openembedded-core@lists.openembedded.org 
>  On Behalf Of Eilís 'pidge' Ní 
> Fhlannagáin
> Sent: den 12 december 2023 18:17
> To: openembedded-core@lists.openembedded.org
> Cc: Eilís 'pidge' Ní Fhlannagáin 
> Subject: [OE-core] [PATCH 2/2] staging: ensure postinst-useradd is run in 
> order
> 
> This patch is based off the work of Piotr Łobacz found here:
> https://bugzilla.yoctoproject.org/attachment.cgi?id=4972=diff
> 
> The one issue with this is I'm not entirely certain that errors are
> filtering up from postinsts, as the test for base-passwd's postinst
> declares that if it's not found, we'll just call it later, but if so,
> I'm not seeing where exactly that's happening.
> 
> Signed-off-by: Eilís 'pidge' Ní Fhlannagáin 
> ---
>  meta/classes-global/staging.bbclass |  6 +--
>  meta/classes/useradd.bbclass| 74 ++---
>  2 files changed, 49 insertions(+), 31 deletions(-)
> 
> diff --git a/meta/classes-global/staging.bbclass 
> b/meta/classes-global/staging.bbclass
> index cf1e4600fd6..e879333aeb9 100644
> --- a/meta/classes-global/staging.bbclass
> +++ b/meta/classes-global/staging.bbclass
> @@ -245,7 +245,7 @@ def staging_populate_sysroot_dir(targetsysroot, 
> nativesysroot, native, d):
>  continue
> 
>  staging_processfixme(fixme, targetdir, targetsysroot, nativesysroot, d)
> -for p in postinsts:
> +for p in sorted(postinsts):
>  subprocess.check_output(p, shell=True, stderr=subprocess.STDOUT)
> 
>  #
> @@ -629,9 +629,9 @@ python extend_recipe_sysroot() {
>  for f in fixme:
>  staging_processfixme(fixme[f], f, recipesysroot, 
> recipesysrootnative, d)
> 
> -for p in postinsts:
> +for p in sorted(postinsts):
>  subprocess.check_output(p, shell=True, stderr=subprocess.STDOUT)
> -
> +

This introduces trailing whitespace.

>  for dep in manifests:
>  c = setscenedeps[dep][0]
>  os.symlink(manifests[dep], depdir + "/" + c + ".complete")
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index 0997b3da7a5..b044b926d99 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -103,6 +103,18 @@ fi
>  }
> 
>  useradd_sysroot () {
> + user_group_groupmems_add_sysroot user
> +}
> +
> +groupadd_sysroot () {
> + user_group_groupmems_add_sysroot group
> +}
> +
> +groupmemsadd_sysroot () {
> + user_group_groupmems_add_sysroot groupmems
> +}
> +
> +user_group_groupmems_add_sysroot () {
>   # Pseudo may (do_prepare_recipe_sysroot) or may not 
> (do_populate_sysroot_setscene) be running
>   # at this point so we're explicit about the environment so pseudo can 
> load if
>   # not already present.
> @@ -130,10 +142,19 @@ useradd_sysroot () {
>   exit 0
>   fi
> 
> - # Add groups and users defined for all recipe packages
> - GROUPADD_PARAM="${@get_all_cmd_params(d, 'groupadd')}"
> - USERADD_PARAM="${@get_all_cmd_params(d, 'useradd')}"
> - GROUPMEMS_PARAM="${@get_all_cmd_params(d, 'groupmems')}"
> + if test "x$1" = "xgroup"; then
> + GROUPADD_PARAM="${@get_all_cmd_params(d, 'groupadd')}"
> + fi
> + if test "x$1" = "xuser"; then
> + USERADD_PARAM="${@get_all_cmd_params(d, 'useradd')}"
> + fi
> + if test "x$1" = "xgroupmems"; then
> + GROUPMEMS_PARAM="${@get_all_cmd_params(d, 'groupmems')}"
> + fi
> + if test "x$1" = "x"; then
> + bbwarn "missing type of passwd db action"
> + exit 0
> + fi

Use a case statement instead:

case $1 in
group) GROUPADD_PARAM="${@get_all_cmd_params(d, 
'groupadd')}";;
user)  USERADD_PARAM="${@get_all_cmd_params(d, 
'useradd')}";;
groupmems) GROUPMEMS_PARAM="${@get_all_cmd_params(d, 
'groupmems')}";;
*) bbfatal "Unknown/missing type of passwd db action: 
$1";;
esac

> 
>   # Tell the system to use the environment vars
>   UA_SYSROOT=1
> @@ -148,29 +169,26 @@ useradd_sysroot () {
>  EXTRA_STAGING_FIXMES += "PSEUDO_SYSROOT PSEUDO_LOCALSTATEDIR LOGFIFO"
> 
>  python useradd_sysroot_sstate () {
> -scriptfile = None
> -task = d.getVar("BB_CURRENTTASK")
> -if task == "package_setscene":
> -bb.build.exec_func("useradd_sysroot", d)
> -elif task == "prepare_recipe_sysroot":
> -# Used to update this recipe's own sysroot so the user/groups are 
> available to do_install
> -
> -# If do_populate_sysroot is triggered and we write the file here, 
> there would be an overlapping
> -# files. See 
> usergrouptests.UserGroupTests.test_add_task_between_p_sysroot_and_package
> -scriptfile = 
> d.expand("${RECIPE_SYSROOT}${bindir}/postinst-useradd-${PN}-recipedebug")
> -
> -bb.build.exec_func("useradd_sysroot", d)
> -elif task == "populate_sysroot":
> -# Used when installed in 

Re: [OE-core] [PATCH] patchtest: Add test for deprecated CVE_CHECK_IGNORE

On 11 Dec 2023, at 16:45, simone.p.weiss via lists.openembedded.org 
 wrote:
> 
> From: Simone Weiß 
> 
> If a recipes was modified recommand the use of `CVE_STATUS` instead if
> `CVE_CHECK_IGNORE` is used. This is a depreacted variable and will
> result in a warning from the cve-check.class and should hence not be
> used anymore. [YOCTO #15311]

It feels like this shouldn’t be CVE_CHECK_IGNORE-specific but a general 
deprecated variable check.  Can you rename so we can easily add more variables 
later?

Relatedly, BB_RENAMED_VARIABLES is a map of variables which got deprecated but 
the solution is a simple rename, the same check should look for those too.

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192287): 
https://lists.openembedded.org/g/openembedded-core/message/192287
Mute This Topic: https://lists.openembedded.org/mt/103112424/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/4] oe-selftest: add a cpp-example recipe



> On 7 Dec 2023, at 20:52, Adrian Freihofer via lists.openembedded.org 
>  wrote:
> 
> +do_run_tests () {
> +meson test -C "${B}" --no-rebuild
> +}

Somewhere in  is a partial 
implementation of a generic “run the test suite at build time in qemu-user” 
which failed miserably because qemu-user is pretty limited.  I suspect it was 
_too_ generic, by trying to run the tests via ‘qemu-user make check’.

Have you had success with non-trivial test suites managed by cmake/meson where 
the tooling invokes qemu directly? Generalising this would be very interesting.

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192286): 
https://lists.openembedded.org/g/openembedded-core/message/192286
Mute This Topic: https://lists.openembedded.org/mt/103042533/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v3 1/1] nfs-utils: Upgrade 2.6.3 -> 2.6.4

On 11 Dec 2023, at 14:49, Robert Yang via lists.openembedded.org 
 wrote:
> 
> +++ 
> b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-reexport.h-Include-unistd.h-to-compile-with-musl.patch
> @@ -0,0 +1,34 @@
> +From 45597a58e98f351b18db8444292b1cf6dd0cd810 Mon Sep 17 00:00:00 2001
> +From: Robert Yang 
> +Date: Sat, 9 Dec 2023 23:34:08 -0800
> +Subject: [PATCH] reexport.h: Include unistd.h to compile with musl
> +
> +Fixed error when compile with musl
> +reexport.c: In function 'reexpdb_init':
> +reexport.c:62:17: error: implicit declaration of function 'sleep' 
> [-Werror=implicit-function-declaration]
> +   62 | sleep(1);
> +
> +
> +Upstream-Status: Pending

Can you upstream this please?

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192285): 
https://lists.openembedded.org/g/openembedded-core/message/192285
Mute This Topic: https://lists.openembedded.org/mt/103109787/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][dunfell][PATCH] glibc: Fix CVE-2023-4813

From: Bhabu Bindu 

Add patch to fix CVE-2023-4813

Link: https://security-tracker.debian.org/tracker/CVE-2023-4813

Signed-off-by: Bhabu Bindu 
Signed-off-by: Poonam Jadhav 
---
 .../glibc/glibc/CVE-2023-4813.patch   | 986 ++
 meta/recipes-core/glibc/glibc_2.31.bb |   1 +
 2 files changed, 987 insertions(+)
 create mode 100644 meta/recipes-core/glibc/glibc/CVE-2023-4813.patch

diff --git a/meta/recipes-core/glibc/glibc/CVE-2023-4813.patch 
b/meta/recipes-core/glibc/glibc/CVE-2023-4813.patch
new file mode 100644
index 00..c7db4038c2
--- /dev/null
+++ b/meta/recipes-core/glibc/glibc/CVE-2023-4813.patch
@@ -0,0 +1,986 @@
+From 1c37b8022e8763fedbb3f79c02e05c6acfe5a215 Mon Sep 17 00:00:00 2001
+From: Siddhesh Poyarekar 
+Date: Thu, 17 Mar 2022 11:44:34 +0530
+Subject: [PATCH] Simplify allocations and fix merge and continue actions [BZ
+ #28931]
+
+Allocations for address tuples is currently a bit confusing because of
+the pointer chasing through PAT, making it hard to observe the sequence
+in which allocations have been made.  Narrow scope of the pointer
+chasing through PAT so that it is only used where necessary.
+
+This also tightens actions behaviour with the hosts database in
+getaddrinfo to comply with the manual text.  The "continue" action
+discards previous results and the "merge" action results in an immedate
+lookup failure.  Consequently, chaining of allocations across modules is
+no longer necessary, thus opening up cleanup opportunities.
+
+A test has been added that checks some combinations to ensure that they
+work correctly.
+
+Resolves: BZ #28931
+
+CVE: CVE-2023-4813
+Upstream-Status: Backport 
[https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=1c37b8022e8763fedbb3f79c02e05c6acfe5a215]
+Comments: Hunks refreshed
+
+Signed-off-by: Siddhesh Poyarekar 
+Reviewed-by: DJ Delorie 
+Signed-off-by: Bhabu Bindu 
+---
+ nss/Makefile   |   1 +
+ nss/tst-nss-gai-actions.c  | 149 ++
+ nss/tst-nss-gai-actions.root/etc/host.conf |   1 +
+ nss/tst-nss-gai-actions.root/etc/hosts | 508 +
+ sysdeps/posix/getaddrinfo.c| 143 +++---
+ 5 files changed, 750 insertions(+), 52 deletions(-)
+ create mode 100644 nss/tst-nss-gai-actions.c
+ create mode 100644 nss/tst-nss-gai-actions.root/etc/host.conf
+ create mode 100644 nss/tst-nss-gai-actions.root/etc/hosts
+
+diff --git a/nss/Makefile b/nss/Makefile
+index 42a59535cb..d8b06b44fb 100644
+--- a/nss/Makefile
 b/nss/Makefile
+@@ -61,6 +61,7 @@
+ 
+ tests-container = \
+ tst-nss-test3 \
++tst-nss-gai-actions \
+ tst-nss-files-hosts-long \
+ tst-nss-db-endpwent \
+ tst-nss-db-endgrent
+diff --git a/nss/tst-nss-gai-actions.c b/nss/tst-nss-gai-actions.c
+new file mode 100644
+index 00..efca6cd183
+--- /dev/null
 b/nss/tst-nss-gai-actions.c
+@@ -0,0 +1,149 @@
++/* Test continue and merge NSS actions for getaddrinfo.
++   Copyright The GNU Toolchain Authors.
++   This file is part of the GNU C Library.
++
++   The GNU C Library is free software; you can redistribute it and/or
++   modify it under the terms of the GNU Lesser General Public
++   License as published by the Free Software Foundation; either
++   version 2.1 of the License, or (at your option) any later version.
++
++   The GNU C Library is distributed in the hope that it will be useful,
++   but WITHOUT ANY WARRANTY; without even the implied warranty of
++   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
++   Lesser General Public License for more details.
++
++   You should have received a copy of the GNU Lesser General Public
++   License along with the GNU C Library; if not, see
++   .  */
++
++#include 
++#include 
++#include 
++#include 
++#include 
++#include 
++
++#include 
++#include 
++#include 
++#include 
++#include 
++
++enum
++{
++  ACTION_MERGE = 0,
++  ACTION_CONTINUE,
++};
++
++static const char *
++family_str (int family)
++{
++  switch (family)
++{
++case AF_UNSPEC:
++  return "AF_UNSPEC";
++case AF_INET:
++  return "AF_INET";
++default:
++  __builtin_unreachable ();
++}
++}
++
++static const char *
++action_str (int action)
++{
++  switch (action)
++{
++case ACTION_MERGE:
++  return "merge";
++case ACTION_CONTINUE:
++  return "continue";
++default:
++  __builtin_unreachable ();
++}
++}
++
++static void
++do_one_test (int action, int family, bool canon)
++{
++  struct addrinfo hints =
++{
++  .ai_family = family,
++};
++
++  struct addrinfo *ai;
++
++  if (canon)
++hints.ai_flags = AI_CANONNAME;
++
++  printf ("* Testing \"files [SUCCESS=%s] files\" for family %s, %s\n",
++action_str (action), family_str (family),
++canon ? "AI_CANONNAME" : "");
++
++  int ret = getaddrinfo 

[OE-core] Issue with relative DEPLOY_DIR in meta/lib/oeqa/runtime/cases/rpm.py


Greetings,

Using the latest poky master branch, I'm running:
bitbake -c testimage core-image-full-cmdline

I'm getting errors in the RPM tests:
AttributeError: 'RpmInstallRemoveTest' object has no attribute 'test_file'

Tracing the code, this happens because the code in rpm.py is trying to 
access DEPLOY_DIR/rpm, which is a relative path (tmp/deploy/rpm), and 
this path doesn't exist because I'm not running BitBake from TOPDIR. Of 
course, if I'm running BitBake from TOPDIR, the test works.


Why doesn't this module see an absolute path for DEPLOY_DIR, like the 
value I get from "bitbake-getvar"?


This would make the test modules more robust.

Thanks in advance
Cheers
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192283): 
https://lists.openembedded.org/g/openembedded-core/message/192283
Mute This Topic: https://lists.openembedded.org/mt/103147277/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] ldconfig-native: Add usrmerge support

On 6 Dec 2023, at 07:40, Johannes Pointner via lists.openembedded.org 
 wrote:
> 
> From: Johannes Pointner 
> 
> If DISTRO_FEATURE usrmerge is enabled, SLIBDIR is just a symlink to LIBDIR.
> ldconfig-native uses hardcoded paths for SLIBDIR and LIBDIR that are fine for
> the not usrmerge case. But if usrmerge is enabled ldconfig-native generates a
> ld.so.cache, which is done in rootfs.py, that looks like this:
> 236 libs found in cache `/etc/ld.so.cache'
>   libzstd.so.1 (libc6) => /lib/libzstd.so.1
>   libz.so.1 (libc6) => /lib/libz.so.1
>   libxtables.so.12 (libc6) => /lib/libxtables.so.12
>   libxslt.so.1 (libc6) => /lib/libxslt.so.1
>   libxml2.so.2 (libc6) => /lib/libxml2.so.2
> 
> This breaks for example the Qt QLibraryInfo paths if Qt is configured
> 'relocatable' and leads to the issue that the QtWebEngine can find the
> QtWebEngineProcess, Qt WebEngine resources,...
> 
> Therefore don't let ldconfig-native parse SLIBDIR if it is a symlink.

This still doesn’t explain *why* ldconfig is broken, why the workaround is a 
yocto-specific fix in ldconfig and not a general fix that other distros have, 
and why this isn’t a problem with Qt.

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192282): 
https://lists.openembedded.org/g/openembedded-core/message/192282
Mute This Topic: https://lists.openembedded.org/mt/103009101/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] lttng-tools: add a flag to test the userspace only

On 1 Dec 2023, at 14:04, Xiangyu Chen via lists.openembedded.org 
 wrote:
> If running the userspace test, just raise an environment variant
> "export SKIP_KERNEL_TEST=1" before running the ptest, it would skip
> lttng modules related test. Without SKIP_KERNEL_TEST=1, the ptest
> would run all test cases.

Is this something we want to automatically do?  Checking if the module can be 
loaded before running the ptest, or something.

Cheers,
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192281): 
https://lists.openembedded.org/g/openembedded-core/message/192281
Mute This Topic: https://lists.openembedded.org/mt/102914659/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] openssl: mark assembler sections as call targets for PAC/BTI support on aarch64

From: Ross Burton 

The assembler sections in OpenSSL were not marked as valid call targets,
so branch protection could not be enabled for libcrypto.so.

Signed-off-by: Ross Burton 
---
 .../openssl/openssl/aarch64-bti.patch | 35 +++
 .../openssl/openssl_3.2.0.bb  |  1 +
 2 files changed, 36 insertions(+)
 create mode 100644 meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch

diff --git a/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch 
b/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
new file mode 100644
index 000..2a16debb76e
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/aarch64-bti.patch
@@ -0,0 +1,35 @@
+From ad347c9ff0fd93bdd2fa2085611c65b88e94829f Mon Sep 17 00:00:00 2001
+From: "fangming.fang" 
+Date: Thu, 7 Dec 2023 06:17:51 +
+Subject: [PATCH] Enable BTI feature for md5 on aarch64
+
+Fixes: #22959
+
+Reviewed-by: Tom Cosgrove 
+Reviewed-by: Tomas Mraz 
+(Merged from https://github.com/openssl/openssl/pull/22971)
+
+Upstream-Status: Backport
+Signed-off-by: Ross Burton 
+---
+ crypto/md5/asm/md5-aarch64.pl | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/crypto/md5/asm/md5-aarch64.pl b/crypto/md5/asm/md5-aarch64.pl
+index 3200a0fa9bff0..5a8608069691d 100755
+--- a/crypto/md5/asm/md5-aarch64.pl
 b/crypto/md5/asm/md5-aarch64.pl
+@@ -28,10 +28,13 @@
+ *STDOUT=*OUT;
+ 
+ $code .= Re: [OE-core] [PATCH] rust-cross-canadian: Fix file conflicts for 32 and 64 bit target architectures

On 30 Nov 2023, at 09:07, Hemraj, Deepthi via lists.openembedded.org 
 wrote:
> +if echo "${TARGET_ARCH}" | grep -q "64"; then
> +RUST_ENV_SETUP_SH="${ENV_SETUP_DIR}/rust.sh"
> +else
> +RUST_ENV_SETUP_SH="${ENV_SETUP_DIR}/rust-32.sh"
> +fi

If you really must look at the host word size then inherit siteinfo and use 
SITEINFO_BITS.

However, the usual solution here is for multilib recipes to use ${MLPREFIX}.

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192279): 
https://lists.openembedded.org/g/openembedded-core/message/192279
Mute This Topic: https://lists.openembedded.org/mt/102890612/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] python3-license-expression: Fix the ptest failure

From: Mingli Yu 

Fix the below ptest failure:
 self = 
 def test_skeleton_codestyle(self):
 """
 This test shouldn't run in proliferated repositories.
 """
 setup_cfg = configparser.ConfigParser()
 setup_cfg.read("setup.cfg")
 > if setup_cfg["metadata"]["name"] != "skeleton":
 tests/test_skeleton_codestyle.py:22:
 self = , key = 'metadata'
 def _getitem_(self, key):
 if key != self.default_section and not self.has_section(key):
 > raise KeyError(key)
 E KeyError: 'metadata'

After the patch:
 # ./run-ptest
 [snip]
 PASS: 
tests/test_license_expression.py::LicensingValidateTest::test_validation_bad_syntax
 PASS: 
tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_as_regular_key
 PASS: 
tests/test_license_expression.py::LicensingValidateTest::test_validation_exception_with_choice
 PASS: 
tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception
 PASS: 
tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_exception_strict_false
 PASS: 
tests/test_license_expression.py::LicensingValidateTest::test_validation_invalid_license_key
 PASS: tests/test_license_expression.py::UtilTest::test_build_licensing
 PASS: tests/test_license_expression.py::UtilTest::test_build_spdx_licensing
 PASS: tests/test_license_expression.py::UtilTest::test_get_license_key_info
 PASS: 
tests/test_license_expression.py::UtilTest::test_get_license_key_info_vendored
 PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_duplicated_elements
 PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_empty_input
 PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_or_relationship
 PASS: 
tests/test_license_expression.py::CombineExpressionTest::test_combine_expressions_with_regular
 PASS: tests/test_skeleton_codestyle.py::BaseTests::test_skeleton_codestyle

 = 175 passed in 10.36s 
=

Signed-off-by: Mingli Yu 
---
 .../python/python3-license-expression/run-ptest | 2 +-
 .../python/python3-license-expression_30.1.1.bb | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python3-license-expression/run-ptest 
b/meta/recipes-devtools/python/python3-license-expression/run-ptest
index 5cec711696..3385d68939 100644
--- a/meta/recipes-devtools/python/python3-license-expression/run-ptest
+++ b/meta/recipes-devtools/python/python3-license-expression/run-ptest
@@ -1,3 +1,3 @@
 #!/bin/sh
 
-pytest
+pytest -o log_cli=true -o log_cli_level=INFO | sed -e 's/\[...%\]//g'| sed -e 
's/PASSED/PASS/g'| sed -e 's/FAILED/FAIL/g'|sed -e 's/SKIPED/SKIP/g'| awk '{if 
($NF=="PASS" || $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || 
$NF=="XPASS"){printf "%s: %s\n", $NF, $0}else{print}}'| awk '{if ($NF=="PASS" 
|| $NF=="FAIL" || $NF=="SKIP" || $NF=="XFAIL" || $NF=="XPASS") {$NF="";print 
$0}else{print}}'
diff --git a/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb 
b/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
index 31fb88d6e5..5d3923d487 100644
--- a/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
+++ b/meta/recipes-devtools/python/python3-license-expression_30.1.1.bb
@@ -33,4 +33,5 @@ do_install_ptest() {
 install -d ${D}${PTEST_PATH}/src
 cp -rf ${S}/tests/* ${D}${PTEST_PATH}/tests/
 cp -rf ${S}/src/* ${D}${PTEST_PATH}/src/
+cp -rf ${S}/setup.cfg ${D}${PTEST_PATH}/
 }
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192278): 
https://lists.openembedded.org/g/openembedded-core/message/192278
Mute This Topic: https://lists.openembedded.org/mt/103146950/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [kirkstone][PATCH 1/2] python3-urllib3: update to v1.26.18

ping

> -Original Message-
> From: openembedded-core@lists.openembedded.org  c...@lists.openembedded.org> On Behalf Of Lee Chee Yang
> Sent: Thursday, November 30, 2023 8:28 PM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [kirkstone][PATCH 1/2] python3-urllib3: update to
> v1.26.18
> 
> From: Tan Wen Yan 
> 
> https://github.com/urllib3/urllib3/releases/tag/1.26.18
> 
> Major changes in python3-urllib3 1.26.18:
> - Made body stripped from HTTP requests changing the request method to
> GET after HTTP 303 "See Other" redirect responses. (CVE-2023-45803)
> 
> ( cherry picked from commit
> 74da05b63634c248910594456dae286947f33da5 )
> 
> Signed-off-by: Tan Wen Yan 
> Signed-off-by: Steve Sakoman 
> Signed-off-by: Lee Chee Yang 
> ---
>  .../{python3-urllib3_1.26.17.bb => python3-urllib3_1.26.18.bb}  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)  rename meta/recipes-
> devtools/python/{python3-urllib3_1.26.17.bb => python3-
> urllib3_1.26.18.bb} (86%)
> 
> diff --git a/meta/recipes-devtools/python/python3-urllib3_1.26.17.bb
> b/meta/recipes-devtools/python/python3-urllib3_1.26.18.bb
> similarity index 86%
> rename from meta/recipes-devtools/python/python3-urllib3_1.26.17.bb
> rename to meta/recipes-devtools/python/python3-urllib3_1.26.18.bb
> index 57b166870aa..d384b5eb2f7 100644
> --- a/meta/recipes-devtools/python/python3-urllib3_1.26.17.bb
> +++ b/meta/recipes-devtools/python/python3-urllib3_1.26.18.bb
> @@ -3,7 +3,7 @@ HOMEPAGE = "https://github.com/shazow/urllib3;
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=c2823cb995439c984fd62a973d79815c"
> 
> -SRC_URI[sha256sum] =
> "24d6a242c28d29af46c3fae832c36db3bbebcc533dd1bb549172cd739c82d
> f21"
> +SRC_URI[sha256sum] =
> "f8ecc1bba5667413457c529ab955bf8c67b45db799d159066261719e3285
> 80a0"
> 
>  inherit pypi setuptools3
> 
> --
> 2.37.3


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192276): 
https://lists.openembedded.org/g/openembedded-core/message/192276
Mute This Topic: https://lists.openembedded.org/mt/102892565/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] strace: Disable bluetooth support by default

Le 13/12/2023 à 09:35, Martin Jansa a écrit :
> There is missing leading space in suggested:
> PACKAGECONFIG:append:pn-strace = "bluez"

V3 sent. Thanks! 

> On Wed, Dec 13, 2023 at 8:43 AM Yoann Congal  > wrote:
> 
> The bluetooth support adds a bluez5 dependency (and,recursively, a lot
> of other stuff). Disable it by default to avoid having to build all of
> this when it is not needed.
> 
> This decrease the number of tasks run for a core-image-minimal build by
> ~1000 (-21%).
> 
> To re-enable bluetooth support in strace, add "bluez" to strace
> PACKAGECONFIG. For example, in local.conf:
>   PACKAGECONFIG:append:pn-strace = "bluez"
> 
> Fixes [YOCTO #15323]
> 
> Signed-off-by: Yoann Congal  >
> Suggested-by: Ross Burton  >
> ---
> v1->v2:
> * Fixed local.conf example (thanks Tim)
> * Added Suggested-by: Ross (thanks Ross)
> * Removed an extra empty line
> ---
>  meta/recipes-devtools/strace/strace_6.6.bb  | 4 
> 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/meta/recipes-devtools/strace/strace_6.6.bb 
>  b/meta/recipes-devtools/strace/strace_6.6.bb 
> 
> index a3de7941cf..eeffe477b3 100644
> --- a/meta/recipes-devtools/strace/strace_6.6.bb 
> +++ b/meta/recipes-devtools/strace/strace_6.6.bb 
> @@ -22,10 +22,6 @@ inherit autotools ptest
>  # Not yet ported to rv32
>  COMPATIBLE_HOST:riscv32 = "null"
> 
> -PACKAGECONFIG:class-target ??= "\
> -    ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', 
> d)} \
> -"
> -
>  PACKAGECONFIG[bluez] = 
> "ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,bluez5"
>  PACKAGECONFIG[libunwind] = 
> "--with-libunwind,--without-libunwind,libunwind"
> 
> -- 
> 2.30.2
> 
> 
> 
> 

-- 
Yoann Congal
Smile ECS - Tech Expert

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192275): 
https://lists.openembedded.org/g/openembedded-core/message/192275
Mute This Topic: https://lists.openembedded.org/mt/103145986/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v3] strace: Disable bluetooth support by default

The bluetooth support adds a bluez5 dependency (and,recursively, a lot
of other stuff). Disable it by default to avoid having to build all of
this when it is not needed.

This decrease the number of tasks run for a core-image-minimal build by
~1000 (-21%).

To re-enable bluetooth support in strace, add "bluez" to strace
PACKAGECONFIG. For example, in local.conf:
  PACKAGECONFIG:append:pn-strace = " bluez"

Fixes [YOCTO #15323]

Signed-off-by: Yoann Congal 
Suggested-by: Ross Burton 
---
v1->v2:
* Fixed local.conf example (thanks Tim)
* Added Suggested-by: Ross (thanks Ross)
* Removed an extra empty line
v2->v3:
* Added missing leading space in local.conf suggestion (thanks Martin)
---
 meta/recipes-devtools/strace/strace_6.6.bb | 4 
 1 file changed, 4 deletions(-)

diff --git a/meta/recipes-devtools/strace/strace_6.6.bb 
b/meta/recipes-devtools/strace/strace_6.6.bb
index a3de7941cf..eeffe477b3 100644
--- a/meta/recipes-devtools/strace/strace_6.6.bb
+++ b/meta/recipes-devtools/strace/strace_6.6.bb
@@ -22,10 +22,6 @@ inherit autotools ptest
 # Not yet ported to rv32
 COMPATIBLE_HOST:riscv32 = "null"
 
-PACKAGECONFIG:class-target ??= "\
-${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-"
-
 PACKAGECONFIG[bluez] = 
"ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,bluez5"
 PACKAGECONFIG[libunwind] = "--with-libunwind,--without-libunwind,libunwind"
 
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192274): 
https://lists.openembedded.org/g/openembedded-core/message/192274
Mute This Topic: https://lists.openembedded.org/mt/103146402/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [PATCH] [OE-Core] tzdata: only the timezone subpackage tzdata-core is retained

I don't think that this is a good idea.
Currently you have a possibility to add to your IMAGE_INSTALL either tzdata (to 
install all data) or tzdata-core (to install minimal subset),
After this change, you can add tzdata or tzdata-core to install minimal subset 
(these packages will be now equal) or dozens of packages to install all without 
a good way to track changes in packages.

Also, this change would require analyzing all components in all layers which 
depend just on tzdata if their dependencies need to be adapted.

Much more reasonable is that you install tzdata-core in your images and let the 
option to install all via just one package to the others.
Or alternatively change the depends to rrecommends and exclude the 
recommendations in your images.
Or add RDEPENDS:${PN}:pn-tzdata = "tzdata-core" to your distro config.

Peter

-Original Message-
From: openembedded-core@lists.openembedded.org 
 On Behalf Of Xu, Lizhi via 
lists.openembedded.org
Sent: Monday, December 11, 2023 4:39
To: openembedded-core@lists.openembedded.org
Cc: anca.mihala...@windriver.com
Subject: [PATCH] [OE-Core] tzdata: only the timezone subpackage tzdata-core is 
retained

> To reduce the size of rootfs, the subpackages contained in tzdata.bb will now 
> default to only retaining tzdata-core.
>
> tzdata.bb by default pulls in all possible timezone data packages which 
> increases size of the final root filesystem considerably.
> The customer would like to have extra timezones configurable so that only 
> tzdata-core is chosen by default and rest of the zones are optional.
>
> Signed-off-by: Lizhi Xu 
> ---
>  meta/recipes-extended/timezone/tzdata.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/timezone/tzdata.bb 
> b/meta/recipes-extended/timezone/tzdata.bb
> index dd1960ffa7..7b1d4fd460 100644
> --- a/meta/recipes-extended/timezone/tzdata.bb
> +++ b/meta/recipes-extended/timezone/tzdata.bb
> @@ -201,4 +201,4 @@ CONFFILES:tzdata-core = "${sysconfdir}/localtime 
> ${sysconfdir}/timezone"
>  
>  ALLOW_EMPTY:${PN} = "1"
>  
> -RDEPENDS:${PN} = "${TZ_PACKAGES}"
> +RDEPENDS:${PN} = "tzdata-core"
> --
> 2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192273): 
https://lists.openembedded.org/g/openembedded-core/message/192273
Mute This Topic: https://lists.openembedded.org/mt/103102817/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [PATCH] [OE-Core] tzdata: only the timezone subpackage tzdata-core is retained

On Mon, 11 Dec 2023 12:02:47 +0100, Alexandre Belloni wrote:
> Please follow 
> https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#fixing-your-from-identity
Yes, I followed the rules in this document.

Lizhi

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192272): 
https://lists.openembedded.org/g/openembedded-core/message/192272
Mute This Topic: https://lists.openembedded.org/mt/103102817/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] strace: Disable bluetooth support by default

There is missing leading space in suggested:
PACKAGECONFIG:append:pn-strace = "bluez"

On Wed, Dec 13, 2023 at 8:43 AM Yoann Congal  wrote:

> The bluetooth support adds a bluez5 dependency (and,recursively, a lot
> of other stuff). Disable it by default to avoid having to build all of
> this when it is not needed.
>
> This decrease the number of tasks run for a core-image-minimal build by
> ~1000 (-21%).
>
> To re-enable bluetooth support in strace, add "bluez" to strace
> PACKAGECONFIG. For example, in local.conf:
>   PACKAGECONFIG:append:pn-strace = "bluez"
>
> Fixes [YOCTO #15323]
>
> Signed-off-by: Yoann Congal 
> Suggested-by: Ross Burton 
> ---
> v1->v2:
> * Fixed local.conf example (thanks Tim)
> * Added Suggested-by: Ross (thanks Ross)
> * Removed an extra empty line
> ---
>  meta/recipes-devtools/strace/strace_6.6.bb | 4 
>  1 file changed, 4 deletions(-)
>
> diff --git a/meta/recipes-devtools/strace/strace_6.6.bb
> b/meta/recipes-devtools/strace/strace_6.6.bb
> index a3de7941cf..eeffe477b3 100644
> --- a/meta/recipes-devtools/strace/strace_6.6.bb
> +++ b/meta/recipes-devtools/strace/strace_6.6.bb
> @@ -22,10 +22,6 @@ inherit autotools ptest
>  # Not yet ported to rv32
>  COMPATIBLE_HOST:riscv32 = "null"
>
> -PACKAGECONFIG:class-target ??= "\
> -${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)}
> \
> -"
> -
>  PACKAGECONFIG[bluez] =
> "ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,bluez5"
>  PACKAGECONFIG[libunwind] =
> "--with-libunwind,--without-libunwind,libunwind"
>
> --
> 2.30.2
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192271): 
https://lists.openembedded.org/g/openembedded-core/message/192271
Mute This Topic: https://lists.openembedded.org/mt/103145986/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] rxvt-unicode: set correct outdir for tic

From: Changqing Li 

tic is from ncurses-native, and set TERMINFO as
${RECIPE_SYSROOT_NATIVE}/${datadir}/terminfo of ncurses-native, so the
rxvt-unicode terminfo will be wrongly installed in there.  set the
outdir explicitly to install them to correct dir.

Signed-off-by: Changqing Li 
---
 .../rxvt-unicode/rxvt-unicode.inc |  5 +--
 .../0001-Makefile.in-set-outdir-for-tic.patch | 35 +++
 2 files changed, 38 insertions(+), 2 deletions(-)
 create mode 100644 
meta/recipes-sato/rxvt-unicode/rxvt-unicode/0001-Makefile.in-set-outdir-for-tic.patch

diff --git a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc 
b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
index e7d520ebef..2f01f54305 100644
--- a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
+++ b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
@@ -11,7 +11,8 @@ DEPENDS = "virtual/libx11 libxt libxft gdk-pixbuf libxmu 
libptytty"
 SRC_URI = 
"http://dist.schmorp.de/rxvt-unicode/Attic/rxvt-unicode-${PV}.tar.bz2 \
   file://xwc.patch \
   file://rxvt.desktop \
-  file://rxvt.png"
+  file://rxvt.png \
+  file://0001-Makefile.in-set-outdir-for-tic.patch "
 
 inherit autotools pkgconfig update-alternatives
 
@@ -55,4 +56,4 @@ do_install:append () {
install -m 0644 ${WORKDIR}/rxvt.desktop ${D}/${datadir}/applications
 }
 
-FILES:${PN} += "${datadir}/applications/rxvt.desktop 
${datadir}/pixmaps/rxvt.png"
+FILES:${PN} += "${datadir}/applications/rxvt.desktop 
${datadir}/pixmaps/rxvt.png ${datadir}/terminfo"
diff --git 
a/meta/recipes-sato/rxvt-unicode/rxvt-unicode/0001-Makefile.in-set-outdir-for-tic.patch
 
b/meta/recipes-sato/rxvt-unicode/rxvt-unicode/0001-Makefile.in-set-outdir-for-tic.patch
new file mode 100644
index 00..7ba0e668dc
--- /dev/null
+++ 
b/meta/recipes-sato/rxvt-unicode/rxvt-unicode/0001-Makefile.in-set-outdir-for-tic.patch
@@ -0,0 +1,35 @@
+From 1b7d547453fc57806ef86f64c86706530a23e62e Mon Sep 17 00:00:00 2001
+From: Changqing Li 
+Date: Wed, 13 Dec 2023 11:53:18 +0800
+Subject: [PATCH] Makefile.in: set outdir for tic
+
+tic is from ncurses-native, and set TERMINFO as
+${RECIPE_SYSROOT_NATIVE}/${datadir}/terminfo of ncurses-native, so the
+rxvt-unicode terminfo will be wrongly installed in there.  set the
+outdir explicitly to install them to correct dir.
+
+Upstream-Status: Inappropriate [oe specific]
+
+Signed-off-by: Changqing Li 
+---
+ doc/Makefile.in | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/doc/Makefile.in b/doc/Makefile.in
+index e3d1fe8..1de56d3 100644
+--- a/doc/Makefile.in
 b/doc/Makefile.in
+@@ -100,8 +100,8 @@ install: all
+   $(INSTALL_DATA) rxvtd.1.man   
$(DESTDIR)$(man1dir)/$(RXVTNAME)d.$(man1ext)
+   $(INSTALL_DATA) rxvt.7.man
$(DESTDIR)$(man7dir)/$(RXVTNAME).$(man7ext)
+   $(INSTALL_DATA) rclock.1.man  $(DESTDIR)$(man1dir)/urclock.$(man1ext)
+-  @TIC@ -x $(srcdir)/etc/rxvt-unicode.terminfo || \
+-   @TIC@ $(srcdir)/etc/rxvt-unicode.terminfo
++  @TIC@ -x $(srcdir)/etc/rxvt-unicode.terminfo -o 
$(DESTDIR)$(datadir)/terminfo || \
++   @TIC@ $(srcdir)/etc/rxvt-unicode.terminfo -o 
$(DESTDIR)$(datadir)/terminfo
+ 
+ distdepend: alldoc
+ 
+-- 
+2.25.1
+
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192270): 
https://lists.openembedded.org/g/openembedded-core/message/192270
Mute This Topic: https://lists.openembedded.org/mt/103146260/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-