On Thu, May 23, 2019 at 02:56:11PM +0100, André Draszik wrote:
>...
> Also, in connman's gweb.c 'addr' is initialised to NULL. Again,
> NULL isn't anything 'returned by getaddrinfo()', so even in glibc
> it only works by pure luck.
>...
Not pure luck, free(NULL) is valid but passing random
On Thu, 2019-05-23 at 12:06 +0100, nick83ola wrote:
> Hi Andre,
>
> in glibc freeaddrinfo is checking for null
>
> https://github.molgen.mpg.de/git-mirror/glibc/blob/20003c49884422da7ffbc459cdeee768a6fee07b/sysdeps/posix/getaddrinfo.c#L2663-L2674
>
> void
> freeaddrinfo (struct addrinfo *ai)
>
On Thu, 23 May 2019 at 12:07, nick83ola wrote:
> that is why I put it into the musl specific patches.
> But ok I will repost it putting it in the generic SRC_URI.
Rule of thumb is to only apply patches in an override if they break
other cases outside of the override. In this case, it's just an
Hi Andre,
in glibc freeaddrinfo is checking for null
https://github.molgen.mpg.de/git-mirror/glibc/blob/20003c49884422da7ffbc459cdeee768a6fee07b/sysdeps/posix/getaddrinfo.c#L2663-L2674
void
freeaddrinfo (struct addrinfo *ai)
{
struct addrinfo *p;
while (ai != NULL)
{
p =
On Thu, 2019-05-23 at 08:47 +0100, Nicola Lunghi wrote:
> musl > 2.21 changed the implementation of the freeaddrinfo() function
I think you mean 1.1.21 here and in the commit subject.
A.
> not allowing anymore to pass null pointers to it.
> This was causing a segmentation fault
On Thu, 2019-05-23 at 08:47 +0100, Nicola Lunghi wrote:
> musl > 2.21 changed the implementation of the freeaddrinfo() function
> not allowing anymore to pass null pointers to it.
> This was causing a segmentation fault in connman.
> ---
> ...-gweb-fix-segfault-with-musl-v1.1.21.patch | 34
musl > 2.21 changed the implementation of the freeaddrinfo() function
not allowing anymore to pass null pointers to it.
This was causing a segmentation fault in connman.
---
...-gweb-fix-segfault-with-musl-v1.1.21.patch | 34 +++
.../connman/connman_1.37.bb | 5
