Re: Patchtest results for [OE-core][kirkstone 5/7] cve-check: slightly more verbose warning when adding the same package twice
On Fri, 2023-11-10 at 22:17 +, Peter Kjellerstedt wrote: > > -Original Message- > > From: openembedded-core@lists.openembedded.org > > On Behalf Of Patchtest > > Sent: den 9 november 2023 00:10 > > To: Steve Sakoman > > Cc: openembedded-core@lists.openembedded.org > > Subject: Patchtest results for [OE-core][kirkstone 5/7] cve-check: > > slightly more verbose warning when adding the same package twice > > > > Thank you for your submission. Patchtest identified one > > or more issues with the patch. Please see the log below for > > more information: > > > > --- > > Testing patch /home/patchtest/share/mboxes/kirkstone-5-7-cve-check- > > slightly-more-verbose-warning-when-adding-the-same-package- > > twice.patch > > > > FAIL: test shortlog length: Edit shortlog so that it is 90 > > characters or less (currently 91 characters) > > (test_mbox.TestMbox.test_shortlog_length) > > I find it extremely confusing that this test refers to "shortlog". > I had to go check the code to see what it was actually testing. > It seems it is actually the "commit subject" that is being tested. > > Can we please change this and other tests that refer to "shortlog" > to either use "commit subject" (in messages) or "subject" (in > names)? > > Also, it seems the test incorrectly includes the "[kirkstone 5/7]" > part in the tested length. The code is here: https://git.yoctoproject.org/poky/tree/meta/lib/patchtest/tests/test_mbox.py#n83 so patches very welcome. Part of the work was to make these tests more accessible so we can all work on and improve them. shortlog is technically correct since this does become the shortlog in the git commit so I'd prefer to keep that but we can mention message subject as well. We should also definitely strip off the [] sections before calculating the length. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190411): https://lists.openembedded.org/g/openembedded-core/message/190411 Mute This Topic: https://lists.openembedded.org/mt/102475465/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: Patchtest results for [OE-core][kirkstone 5/7] cve-check: slightly more verbose warning when adding the same package twice
> -Original Message- > From: openembedded-core@lists.openembedded.org > On Behalf Of Patchtest > Sent: den 9 november 2023 00:10 > To: Steve Sakoman > Cc: openembedded-core@lists.openembedded.org > Subject: Patchtest results for [OE-core][kirkstone 5/7] cve-check: slightly > more verbose warning when adding the same package twice > > Thank you for your submission. Patchtest identified one > or more issues with the patch. Please see the log below for > more information: > > --- > Testing patch > /home/patchtest/share/mboxes/kirkstone-5-7-cve-check-slightly-more-verbose-warning-when-adding-the-same-package-twice.patch > > FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less > (currently 91 characters) (test_mbox.TestMbox.test_shortlog_length) I find it extremely confusing that this test refers to "shortlog". I had to go check the code to see what it was actually testing. It seems it is actually the "commit subject" that is being tested. Can we please change this and other tests that refer to "shortlog" to either use "commit subject" (in messages) or "subject" (in names)? Also, it seems the test incorrectly includes the "[kirkstone 5/7]" part in the tested length. //Peter -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190410): https://lists.openembedded.org/g/openembedded-core/message/190410 Mute This Topic: https://lists.openembedded.org/mt/102475465/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Patchtest results for [OE-core][kirkstone 5/7] cve-check: slightly more verbose warning when adding the same package twice
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/kirkstone-5-7-cve-check-slightly-more-verbose-warning-when-adding-the-same-package-twice.patch FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less (currently 91 characters) (test_mbox.TestMbox.test_shortlog_length) PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test pylint (test_python_pylint.PyLint.test_pylint) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you! -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190366): https://lists.openembedded.org/g/openembedded-core/message/190366 Mute This Topic: https://lists.openembedded.org/mt/102475465/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
