Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-21 Thread Cal Sullivan
Yes, the PV is set incorrectly here. In b5e7625, the kernel's source was updated to 4.1.32 for genericx86-64, but the LINUX_VERSION variable (which is used to set PV) was not. --- Cal On 09/20/2016 08:11 PM, Robert Yang wrote: Hi, There is an error on autobuilder related to this patch:

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-20 Thread Robert Yang
Hi, There is an error on autobuilder related to this patch: http://autobuilder.yocto.io:8010/builders/nightly-x86-64-lsb/builds/60/steps/BuildImages_1/logs/stdio // Robert On 09/17/2016 07:48 AM, California Sullivan wrote: The kernel being built should match what the recipe claims it is

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Bruce Ashfield
On Mon, Sep 19, 2016 at 8:03 PM, Bruce Ashfield wrote: > > > On Mon, Sep 19, 2016 at 7:02 PM, Cal Sullivan < > california.l.sulli...@intel.com> wrote: > >> >> >> On 09/19/2016 03:55 PM, Bruce Ashfield wrote: >> >> >> >> On Mon, Sep 19, 2016 at 6:02 PM, Cal Sullivan < >>

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Bruce Ashfield
On Mon, Sep 19, 2016 at 7:02 PM, Cal Sullivan < california.l.sulli...@intel.com> wrote: > > > On 09/19/2016 03:55 PM, Bruce Ashfield wrote: > > > > On Mon, Sep 19, 2016 at 6:02 PM, Cal Sullivan < > california.l.sulli...@intel.com> wrote: > >> I don't have time to smoke test a SRCREV update for so

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Cal Sullivan
On 09/19/2016 03:55 PM, Bruce Ashfield wrote: On Mon, Sep 19, 2016 at 6:02 PM, Cal Sullivan > wrote: I don't have time to smoke test a SRCREV update for so many machines right now, so I think for now I will

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Bruce Ashfield
On Mon, Sep 19, 2016 at 6:02 PM, Cal Sullivan < california.l.sulli...@intel.com> wrote: > I don't have time to smoke test a SRCREV update for so many machines right > now, so I think for now I will just set the correct PV in the various > linux-yocto recipes so we don't block master-next builds.

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Cal Sullivan
I don't have time to smoke test a SRCREV update for so many machines right now, so I think for now I will just set the correct PV in the various linux-yocto recipes so we don't block master-next builds. Is this acceptable? Thanks, Cal On 09/19/2016 01:49 PM, Saul Wold wrote: On Mon,

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Saul Wold
On Mon, 2016-09-19 at 15:55 -0400, Bruce Ashfield wrote: > On 2016-09-19 03:53 PM, Cal Sullivan wrote: > > > > Yep, these all have incorrect PVs. > > 628bf62756 Merge tag 'v4.4.11' into standard/base > > The problem seems fairly wide spread. > > > > Bruce, do you suggest updating PVs or updating

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Bruce Ashfield
On 2016-09-19 03:53 PM, Cal Sullivan wrote: Yep, these all have incorrect PVs. 628bf62756 Merge tag 'v4.4.11' into standard/base The problem seems fairly wide spread. Bruce, do you suggest updating PVs or updating the SRCREVs (is there a good reason to keep using old SRCREVs?)? Updating the

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Cal Sullivan
Yep, these all have incorrect PVs. 628bf62756 Merge tag 'v4.4.11' into standard/base The problem seems fairly wide spread. Bruce, do you suggest updating PVs or updating the SRCREVs (is there a good reason to keep using old SRCREVs?)? --- Cal On 09/19/2016 11:54 AM, Burton, Ross wrote: On

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Burton, Ross
On 19 September 2016 at 18:05, Cal Sullivan wrote: > It looks like the function is doing as its supposed to, and we need to > update some PVs or SRCREVs to match PVs. > > E.g., on the error below, SRCREV d6237b3b24 is indeed 4.1.31. > And some more builders

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Cal Sullivan
It looks like the function is doing as its supposed to, and we need to update some PVs or SRCREVs to match PVs. E.g., on the error below, SRCREV d6237b3b24 is indeed 4.1.31. --- Cal On 09/19/2016 09:22 AM, Burton, Ross wrote: On 19 September 2016 at 16:09, Burton, Ross

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Burton, Ross
On 19 September 2016 at 16:09, Burton, Ross wrote: > This is being fired on the AB: > > ERROR: linux-yocto-4.1.32+gitAUTOINC+b30b6b9ef2_d6237b3b24-r0 > do_kernel_version_sanity_check: Package Version > (4.1.32+gitAUTOINC+b30b6b9ef2_d6237b3b24) does not match of kernel

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Burton, Ross
On 19 September 2016 at 16:04, Bruce Ashfield wrote: > Otherwise, I don't see anything obviously wrong (I looked at the regexs > but didn't study them in detail) .. and it looks sane to me. A good > balance between checking and not needing the entire kernel to be

Re: [OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-19 Thread Bruce Ashfield
On 2016-09-16 07:48 PM, California Sullivan wrote: The kernel being built should match what the recipe claims it is building. This function ensures that happens by comparing the version information in the kernel's Makefile to the PV the recipe is using. v2 changes: * Match against PV instead of

[OE-core] [PATCH V2 1/1] kernel.bbclass: Add kernel_version_sanity_check function

2016-09-16 Thread California Sullivan
The kernel being built should match what the recipe claims it is building. This function ensures that happens by comparing the version information in the kernel's Makefile to the PV the recipe is using. v2 changes: * Match against PV instead of LINUX_VERSION * Match against EXTRAVERSION as well