Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-20 Thread Richard Purdie
On Mon, 2015-05-18 at 15:40 +0300, Tanu Kaskinen wrote:
 When PulseAudio is installed, alsa-plugins is needed to provide
 compatibility for ALSA applications.
 
 The dependencies are set up so that pulseaudio-server depends on
 alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
 on the PulseAudio plugins. This should make the ALSA-PulseAudio
 compatibility configuration work out of the box, while leaving the
 PulseAudio specific configuration out on systems that don't have
 pulseaudio-server installed.
 
 Signed-off-by: Tanu Kaskinen tanu.kaski...@linux.intel.com
 ---
  .../recipes-multimedia/alsa/alsa-plugins_1.0.29.bb | 81 
 ++
  meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |  5 ++
  2 files changed, 86 insertions(+)
  create mode 100644 meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb

Running this through the autobuilder revealed:
https://autobuilder.yoctoproject.org/main/builders/nightly-ipk/builds/303/steps/BuildImages/logs/stdio
which I'm guessing comes from this patch but I haven't bisected.

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-20 Thread Tanu Kaskinen
On Tue, 2015-05-19 at 18:06 +0300, Tanu Kaskinen wrote:
 On Tue, 2015-05-19 at 15:42 +0100, Burton, Ross wrote:
  
  On 19 May 2015 at 15:31, Burton, Ross ross.bur...@intel.com wrote:
  On 18 May 2015 at 13:40, Tanu Kaskinen
  tanu.kaski...@linux.intel.com wrote:
  +# The resampler plugins create some symlinks, which
  have to be added to FILES
  +# manually, since do_split_packages() rejects
  symlinks. The symlinks also cause
  +# QA errors, but those errors are false positives, so
  we disable the QA checks.
  
  
  Not true, there's an allow_symlink (default False) option to
  do_split_packages, so this can be cleaned up.
  
  
  Assuming that those symlinks are versioning (and so pointless
  for loadable modules), a neater fix might be to patch in
  libtool -avoid-version.
  
  Investigate *before* sending, Ross.
  
  
  Just pass allow_links=True to do_split_packages() and all of this can
  be deleted.
 
 Thanks, I'll do that.

Actually, no, I won't do that. I don't want the symlinks to go to
separate packages, they should be shipped in the same package that
contains the real plugin file.

-- 
Tanu

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-20 Thread Tanu Kaskinen
On Wed, 2015-05-20 at 10:00 +0100, Burton, Ross wrote:
 
 On 18 May 2015 at 13:40, Tanu Kaskinen tanu.kaski...@linux.intel.com
 wrote:
 When PulseAudio is installed, alsa-plugins is needed to
 provide
 compatibility for ALSA applications.
 
 The dependencies are set up so that pulseaudio-server depends
 on
 alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf
 depends
 on the PulseAudio plugins. This should make the
 ALSA-PulseAudio
 compatibility configuration work out of the box, while leaving
 the
 PulseAudio specific configuration out on systems that don't
 have
 pulseaudio-server installed.
 
  * satisfy_dependencies_for: Cannot satisfy the following dependencies
 for alsa-plugins-dev:
  * alsa-plugins (= 1.0.29-r0) * 
  * opkg_install_cmd: Cannot install package alsa-plugins-dev.

Oops! In the future, when adding any new packages, I probably should try
building images with those packages installed.

 There's a default RDEPENDS_${PN}-dev = ${PN}, but as alsa-plugins
 doesn't exist that isn't very useful.  Then again shipping the .la
 files for the loadable modules isn't very useful either (Linux doesn't
 need them to load modules, and nothing will link against them).  
 
 
 So, instead of:
 
 
 +FILES_${PN}-dev += ${libdir}/alsa-lib/*.la
 
 
 
 we should just delete the .la files in the do_install_append().

Right, the -dev package is obviously pointless in this case. I could
have realized that just by thinking a bit more while writing the
recipe...

-- 
Tanu

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-20 Thread Burton, Ross
On 18 May 2015 at 13:40, Tanu Kaskinen tanu.kaski...@linux.intel.com
wrote:

 When PulseAudio is installed, alsa-plugins is needed to provide
 compatibility for ALSA applications.

 The dependencies are set up so that pulseaudio-server depends on
 alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
 on the PulseAudio plugins. This should make the ALSA-PulseAudio
 compatibility configuration work out of the box, while leaving the
 PulseAudio specific configuration out on systems that don't have
 pulseaudio-server installed.


 * satisfy_dependencies_for: Cannot satisfy the following dependencies for
alsa-plugins-dev:
 * alsa-plugins (= 1.0.29-r0) *
 * opkg_install_cmd: Cannot install package alsa-plugins-dev.

There's a default RDEPENDS_${PN}-dev = ${PN}, but as alsa-plugins doesn't
exist that isn't very useful.  Then again shipping the .la files for the
loadable modules isn't very useful either (Linux doesn't need them to load
modules, and nothing will link against them).

So, instead of:

+FILES_${PN}-dev += ${libdir}/alsa-lib/*.la

we should just delete the .la files in the do_install_append().

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-20 Thread Tanu Kaskinen
On Wed, 2015-05-20 at 13:07 +0100, Richard Purdie wrote:
 On Mon, 2015-05-18 at 15:40 +0300, Tanu Kaskinen wrote:
  When PulseAudio is installed, alsa-plugins is needed to provide
  compatibility for ALSA applications.
  
  The dependencies are set up so that pulseaudio-server depends on
  alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
  on the PulseAudio plugins. This should make the ALSA-PulseAudio
  compatibility configuration work out of the box, while leaving the
  PulseAudio specific configuration out on systems that don't have
  pulseaudio-server installed.
  
  Signed-off-by: Tanu Kaskinen tanu.kaski...@linux.intel.com
  ---
   .../recipes-multimedia/alsa/alsa-plugins_1.0.29.bb | 81 
  ++
   meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |  5 ++
   2 files changed, 86 insertions(+)
   create mode 100644 meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb
 
 Running this through the autobuilder revealed:
 https://autobuilder.yoctoproject.org/main/builders/nightly-ipk/builds/303/steps/BuildImages/logs/stdio
 which I'm guessing comes from this patch but I haven't bisected.

Yep, Ross already complained about the same thing. A fix is forthcoming.

-- 
Tanu

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-19 Thread Burton, Ross
On 19 May 2015 at 15:31, Burton, Ross ross.bur...@intel.com wrote:

 On 18 May 2015 at 13:40, Tanu Kaskinen tanu.kaski...@linux.intel.com
 wrote:

 +# The resampler plugins create some symlinks, which have to be added to
 FILES
 +# manually, since do_split_packages() rejects symlinks. The symlinks
 also cause
 +# QA errors, but those errors are false positives, so we disable the QA
 checks.


 Not true, there's an allow_symlink (default False) option to
 do_split_packages, so this can be cleaned up.

 Assuming that those symlinks are versioning (and so pointless for loadable
 modules), a neater fix might be to patch in libtool -avoid-version.


Investigate *before* sending, Ross.

Just pass allow_links=True to do_split_packages() and all of this can be
deleted.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-19 Thread Burton, Ross
On 18 May 2015 at 13:40, Tanu Kaskinen tanu.kaski...@linux.intel.com
wrote:

 +# The resampler plugins create some symlinks, which have to be added to
 FILES
 +# manually, since do_split_packages() rejects symlinks. The symlinks also
 cause
 +# QA errors, but those errors are false positives, so we disable the QA
 checks.


Not true, there's an allow_symlink (default False) option to
do_split_packages, so this can be cleaned up.

Assuming that those symlinks are versioning (and so pointless for loadable
modules), a neater fix might be to patch in libtool -avoid-version.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-19 Thread Burton, Ross
On 19 May 2015 at 16:01, Tanu Kaskinen tanu.kaski...@linux.intel.com
wrote:

 meta-guacamayo and meta-webos were used as references when writing the
 recipe. It's not a straight copy of either.


I was hoping you'd say that.  :)  Please mention that in the commit.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-19 Thread Tanu Kaskinen
On Tue, 2015-05-19 at 15:27 +0100, Burton, Ross wrote:
 
 On 18 May 2015 at 13:40, Tanu Kaskinen tanu.kaski...@linux.intel.com
 wrote:
 When PulseAudio is installed, alsa-plugins is needed to
 provide
 compatibility for ALSA applications.
 
 The dependencies are set up so that pulseaudio-server depends
 on
 alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf
 depends
 on the PulseAudio plugins. This should make the
 ALSA-PulseAudio
 compatibility configuration work out of the box, while leaving
 the
 PulseAudio specific configuration out on systems that don't
 have
 pulseaudio-server installed.
 
 What layer did this recipe originally come from?

meta-guacamayo and meta-webos were used as references when writing the
recipe. It's not a straight copy of either.

-- 
Tanu

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-19 Thread Burton, Ross
On 18 May 2015 at 13:40, Tanu Kaskinen tanu.kaski...@linux.intel.com
wrote:

 When PulseAudio is installed, alsa-plugins is needed to provide
 compatibility for ALSA applications.

 The dependencies are set up so that pulseaudio-server depends on
 alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
 on the PulseAudio plugins. This should make the ALSA-PulseAudio
 compatibility configuration work out of the box, while leaving the
 PulseAudio specific configuration out on systems that don't have
 pulseaudio-server installed.


What layer did this recipe originally come from?

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 1/5] alsa-plugins: initial recipe

2015-05-19 Thread Tanu Kaskinen
On Tue, 2015-05-19 at 15:42 +0100, Burton, Ross wrote:
 
 On 19 May 2015 at 15:31, Burton, Ross ross.bur...@intel.com wrote:
 On 18 May 2015 at 13:40, Tanu Kaskinen
 tanu.kaski...@linux.intel.com wrote:
 +# The resampler plugins create some symlinks, which
 have to be added to FILES
 +# manually, since do_split_packages() rejects
 symlinks. The symlinks also cause
 +# QA errors, but those errors are false positives, so
 we disable the QA checks.
 
 
 Not true, there's an allow_symlink (default False) option to
 do_split_packages, so this can be cleaned up.
 
 
 Assuming that those symlinks are versioning (and so pointless
 for loadable modules), a neater fix might be to patch in
 libtool -avoid-version.
 
 Investigate *before* sending, Ross.
 
 
 Just pass allow_links=True to do_split_packages() and all of this can
 be deleted.

Thanks, I'll do that.

-- 
Tanu


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core