Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Andre McCurdy]

On Fri, Mar 26, 2021 at 11:12 AM Richard Purdie
 wrote:
>
> On Fri, 2021-03-26 at 18:06 +, Peter Kjellerstedt wrote:
> > > -Original Message-
> > > From: Richard Purdie 
> > > Sent: den 25 mars 2021 17:52
> > > To: Peter Kjellerstedt ; Oleksiy Obitotskyi -
> > > X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca Bocassi
> > > ; openembedded-core@lists.openembedded.org
> > > Cc: bluelightn...@bluelightning.org; Khem Raj 
> > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > recipe to allow bootstrapping
> > >
> > > On Thu, 2021-03-25 at 16:19 +, Peter Kjellerstedt wrote:
> > > > > -Original Message-
> > > > > From: Richard Purdie 
> > > > > Sent: den 25 mars 2021 15:27
> > > > > To: Peter Kjellerstedt ; Oleksiy
> > > Obitotskyi -
> > > > > X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca
> > > Bocassi
> > > > > ; openembedded-core@lists.openembedded.org
> > > > > Cc: bluelightn...@bluelightning.org; Khem Raj 
> > > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > > > recipe to allow bootstrapping
> > > > >
> > > > > On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > > > > > -Original Message-
> > > > > > > From: Richard Purdie 
> > > > > > > Sent: den 25 mars 2021 10:34
> > > > > > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > > > > > ; Luca Bocassi ;
> > > > > > > openembedded-core@lists.openembedded.org
> > > > > > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > > > > > ; Khem Raj 
> > > > > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in
> > > separate
> > > > > > > recipe to allow bootstrapping
> > > > > > >
> > > > > > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots
> > > -
> > > > > > > GLOBALLOGIC INC at Cisco) wrote:
> > > > > > > > Could you look into this warning.
> > > > > > > >
> > > > > > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-
> > > linux-
> > > > > dev
> > > > > > > rdepends on util-linux-libuuid-dev, but it isn't a build
> > > dependency?
> > > > > > > [build-deps]
> > > > > > > >
> > > > > > > >
> > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > > > > > >
> > > > > > > That failure was my fault when testing some fixes.
> > > > > > >
> > > > > > > I've sent out a patch which renames util-linux-uuid to util-linux-
> > > > > libuuid
> > > > > > > and sorts out the license issue Peter reported.
> > > > > >
> > > > > > I don't mind the recipe being renamed and cleaned up, but I would
> > > prefer
> > > > > > to see my entire patch for the license parts being either integrated
> > > > > before
> > > > > > this or squashed into it, whichever you prefer. It does not make
> > > sense
> > > > > to
> > > > > > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-
> > > linux,
> > > > > > and setting the other LICENSE variables in util-linux.inc no longer
> > > > > makes
> > > > > > sense as they are only relevant for util-linux.
> > > > >
> > > > > I'm torn on that. Code with the other licenses is present, just not
> > > used
> > > > > in the final output and I personally suspect that having one
> > > LIC_FILES_CHKSUM
> > > > > is going to be easier to maintain in the future rather than two
> > > separate
> > > > > ones.
> > > >
> > > > I actually checked all the files that go into -dev and -src before
> > > suggesting
> > > > this change, and all files are either marked as public domain or use a
> > > > BSD-3-Clause license.
> > >
> > > There is a difference between what ends up in ${S} and what ends up in the
> > > binary packages. LICENSE clearly governs the latter. Its the 

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Fri, 2021-03-26 at 18:06 +, Peter Kjellerstedt wrote:
> > -Original Message-
> > From: Richard Purdie 
> > Sent: den 25 mars 2021 17:52
> > To: Peter Kjellerstedt ; Oleksiy Obitotskyi -
> > X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca Bocassi
> > ; openembedded-core@lists.openembedded.org
> > Cc: bluelightn...@bluelightning.org; Khem Raj 
> > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > recipe to allow bootstrapping
> > 
> > On Thu, 2021-03-25 at 16:19 +, Peter Kjellerstedt wrote:
> > > > -Original Message-
> > > > From: Richard Purdie 
> > > > Sent: den 25 mars 2021 15:27
> > > > To: Peter Kjellerstedt ; Oleksiy
> > Obitotskyi -
> > > > X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca
> > Bocassi
> > > > ; openembedded-core@lists.openembedded.org
> > > > Cc: bluelightn...@bluelightning.org; Khem Raj 
> > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > > recipe to allow bootstrapping
> > > > 
> > > > On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > > > > -Original Message-
> > > > > > From: Richard Purdie 
> > > > > > Sent: den 25 mars 2021 10:34
> > > > > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > > > > ; Luca Bocassi ;
> > > > > > openembedded-core@lists.openembedded.org
> > > > > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > > > > ; Khem Raj 
> > > > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in
> > separate
> > > > > > recipe to allow bootstrapping
> > > > > > 
> > > > > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots
> > -
> > > > > > GLOBALLOGIC INC at Cisco) wrote:
> > > > > > > Could you look into this warning.
> > > > > > > 
> > > > > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-
> > linux-
> > > > dev
> > > > > > rdepends on util-linux-libuuid-dev, but it isn't a build
> > dependency?
> > > > > > [build-deps]
> > > > > > > 
> > > > > > > 
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > > > > > 
> > > > > > That failure was my fault when testing some fixes.
> > > > > > 
> > > > > > I've sent out a patch which renames util-linux-uuid to util-linux-
> > > > libuuid
> > > > > > and sorts out the license issue Peter reported.
> > > > > 
> > > > > I don't mind the recipe being renamed and cleaned up, but I would
> > prefer
> > > > > to see my entire patch for the license parts being either integrated
> > > > before
> > > > > this or squashed into it, whichever you prefer. It does not make
> > sense
> > > > to
> > > > > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-
> > linux,
> > > > > and setting the other LICENSE variables in util-linux.inc no longer
> > > > makes
> > > > > sense as they are only relevant for util-linux.
> > > > 
> > > > I'm torn on that. Code with the other licenses is present, just not
> > used
> > > > in the final output and I personally suspect that having one
> > LIC_FILES_CHKSUM
> > > > is going to be easier to maintain in the future rather than two
> > separate
> > > > ones.
> > > 
> > > I actually checked all the files that go into -dev and -src before
> > suggesting
> > > this change, and all files are either marked as public domain or use a
> > > BSD-3-Clause license.
> > 
> > There is a difference between what ends up in ${S} and what ends up in the
> > binary packages. LICENSE clearly governs the latter. Its the scope of
> > LIC_FILES_CHECKSUM which there are differences of opinion on.
> 
> Well, the latter governs what ends up in ${PN}-lic, so having a lot of 
> unrelated (to the installed packages) license files in LIC_FILES_CHECKSUM 
> does not make sense (to me). If everything that is built and (possibly) 
> installed and thus distributed is covered by BSD-3-Clause licenses, why 
> should ${PN}-lic include a lot of license files for unrelated code?

I hadn't considered ${PN}-lic :(.

We can't win. If we change LIC_FILES_CHKSUM we'll see complaints from
people scanning the code that there are licenses present in WORKDIR that
are not in LIC_FILES_CHKSUM. If we don't change it, ${PN}-lic does give
more information than necessary. I still think the latter is probably
safer and makes recipe upgrades easier.

Licensing in general needs a step back and an overhaul. Sadly people are 
generally only prepared to do this piecemeal solving their specific
issue rather than the general case and big picture.

Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149990): 
https://lists.openembedded.org/g/openembedded-core/message/149990
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Peter Kjellerstedt]

> -Original Message-
> From: Richard Purdie 
> Sent: den 25 mars 2021 17:52
> To: Peter Kjellerstedt ; Oleksiy Obitotskyi -
> X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca Bocassi
> ; openembedded-core@lists.openembedded.org
> Cc: bluelightn...@bluelightning.org; Khem Raj 
> Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> recipe to allow bootstrapping
> 
> On Thu, 2021-03-25 at 16:19 +, Peter Kjellerstedt wrote:
> > > -Original Message-
> > > From: Richard Purdie 
> > > Sent: den 25 mars 2021 15:27
> > > To: Peter Kjellerstedt ; Oleksiy
> Obitotskyi -
> > > X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca
> Bocassi
> > > ; openembedded-core@lists.openembedded.org
> > > Cc: bluelightn...@bluelightning.org; Khem Raj 
> > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > recipe to allow bootstrapping
> > >
> > > On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > > > -Original Message-
> > > > > From: Richard Purdie 
> > > > > Sent: den 25 mars 2021 10:34
> > > > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > > > ; Luca Bocassi ;
> > > > > openembedded-core@lists.openembedded.org
> > > > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > > > ; Khem Raj 
> > > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in
> separate
> > > > > recipe to allow bootstrapping
> > > > >
> > > > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots
> -
> > > > > GLOBALLOGIC INC at Cisco) wrote:
> > > > > > Could you look into this warning.
> > > > > >
> > > > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-
> linux-
> > > dev
> > > > > rdepends on util-linux-libuuid-dev, but it isn't a build
> dependency?
> > > > > [build-deps]
> > > > > >
> > > > > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > > > >
> > > > > That failure was my fault when testing some fixes.
> > > > >
> > > > > I've sent out a patch which renames util-linux-uuid to util-linux-
> > > libuuid
> > > > > and sorts out the license issue Peter reported.
> > > >
> > > > I don't mind the recipe being renamed and cleaned up, but I would
> prefer
> > > > to see my entire patch for the license parts being either integrated
> > > before
> > > > this or squashed into it, whichever you prefer. It does not make
> sense
> > > to
> > > > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-
> linux,
> > > > and setting the other LICENSE variables in util-linux.inc no longer
> > > makes
> > > > sense as they are only relevant for util-linux.
> > >
> > > I'm torn on that. Code with the other licenses is present, just not
> used
> > > in the final output and I personally suspect that having one
> LIC_FILES_CHKSUM
> > > is going to be easier to maintain in the future rather than two
> separate
> > > ones.
> >
> > I actually checked all the files that go into -dev and -src before
> suggesting
> > this change, and all files are either marked as public domain or use a
> > BSD-3-Clause license.
> 
> There is a difference between what ends up in ${S} and what ends up in the
> binary packages. LICENSE clearly governs the latter. Its the scope of
> LIC_FILES_CHECKSUM which there are differences of opinion on.

Well, the latter governs what ends up in ${PN}-lic, so having a lot of 
unrelated (to the installed packages) license files in LIC_FILES_CHECKSUM 
does not make sense (to me). If everything that is built and (possibly) 
installed and thus distributed is covered by BSD-3-Clause licenses, why 
should ${PN}-lic include a lot of license files for unrelated code?

> Cheers,
> 
> Richard

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149989): 
https://lists.openembedded.org/g/openembedded-core/message/149989
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Thu, 2021-03-25 at 16:19 +, Peter Kjellerstedt wrote:
> > -Original Message-
> > From: Richard Purdie 
> > Sent: den 25 mars 2021 15:27
> > To: Peter Kjellerstedt ; Oleksiy Obitotskyi -
> > X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca Bocassi
> > ; openembedded-core@lists.openembedded.org
> > Cc: bluelightn...@bluelightning.org; Khem Raj 
> > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > recipe to allow bootstrapping
> > 
> > On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > > -Original Message-
> > > > From: Richard Purdie 
> > > > Sent: den 25 mars 2021 10:34
> > > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > > ; Luca Bocassi ;
> > > > openembedded-core@lists.openembedded.org
> > > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > > ; Khem Raj 
> > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > > recipe to allow bootstrapping
> > > > 
> > > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots -
> > > > GLOBALLOGIC INC at Cisco) wrote:
> > > > > Could you look into this warning.
> > > > > 
> > > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-
> > dev
> > > > rdepends on util-linux-libuuid-dev, but it isn't a build dependency?
> > > > [build-deps]
> > > > > 
> > > > > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > > > 
> > > > That failure was my fault when testing some fixes.
> > > > 
> > > > I've sent out a patch which renames util-linux-uuid to util-linux-
> > libuuid
> > > > and sorts out the license issue Peter reported.
> > > 
> > > I don't mind the recipe being renamed and cleaned up, but I would prefer
> > > to see my entire patch for the license parts being either integrated
> > before
> > > this or squashed into it, whichever you prefer. It does not make sense
> > to
> > > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-linux,
> > > and setting the other LICENSE variables in util-linux.inc no longer
> > makes
> > > sense as they are only relevant for util-linux.
> > 
> > I'm torn on that. Code with the other licenses is present, just not used
> > in the final output and I personally suspect that having one 
> > LIC_FILES_CHKSUM
> > is going to be easier to maintain in the future rather than two separate
> > ones.
> 
> I actually checked all the files that go into -dev and -src before suggesting 
> this change, and all files are either marked as public domain or use a 
> BSD-3-Clause license.

There is a difference between what ends up in ${S} and what ends up in the 
binary packages. LICENSE clearly governs the latter. Its the scope of 
LIC_FILES_CHECKSUM which there are differences of opinion on.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149941): 
https://lists.openembedded.org/g/openembedded-core/message/149941
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Peter Kjellerstedt]

> -Original Message-
> From: Richard Purdie 
> Sent: den 25 mars 2021 15:27
> To: Peter Kjellerstedt ; Oleksiy Obitotskyi -
> X (oobitots - GLOBALLOGIC INC at Cisco) ; Luca Bocassi
> ; openembedded-core@lists.openembedded.org
> Cc: bluelightn...@bluelightning.org; Khem Raj 
> Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> recipe to allow bootstrapping
> 
> On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > -Original Message-
> > > From: Richard Purdie 
> > > Sent: den 25 mars 2021 10:34
> > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > ; Luca Bocassi ;
> > > openembedded-core@lists.openembedded.org
> > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > ; Khem Raj 
> > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > recipe to allow bootstrapping
> > >
> > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots -
> > > GLOBALLOGIC INC at Cisco) wrote:
> > > > Could you look into this warning.
> > > >
> > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-
> dev
> > > rdepends on util-linux-libuuid-dev, but it isn't a build dependency?
> > > [build-deps]
> > > >
> > > >
> https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > >
> > > That failure was my fault when testing some fixes.
> > >
> > > I've sent out a patch which renames util-linux-uuid to util-linux-
> libuuid
> > > and sorts out the license issue Peter reported.
> >
> > I don't mind the recipe being renamed and cleaned up, but I would prefer
> > to see my entire patch for the license parts being either integrated
> before
> > this or squashed into it, whichever you prefer. It does not make sense
> to
> > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-linux,
> > and setting the other LICENSE variables in util-linux.inc no longer
> makes
> > sense as they are only relevant for util-linux.
> 
> I'm torn on that. Code with the other licenses is present, just not used
> in the final output and I personally suspect that having one LIC_FILES_CHKSUM
> is going to be easier to maintain in the future rather than two separate
> ones.

I actually checked all the files that go into -dev and -src before suggesting 
this change, and all files are either marked as public domain or use a 
BSD-3-Clause license.

> Cheers,
> 
> Richard

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149940): 
https://lists.openembedded.org/g/openembedded-core/message/149940
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Khem Raj]

On Thu, Mar 25, 2021 at 8:45 AM Luca Boccassi  wrote:
>
> On Thu, 2021-03-25 at 14:27 +, Richard Purdie wrote:
> > On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > > -Original Message-
> > > > From: Richard Purdie 
> > > > Sent: den 25 mars 2021 10:34
> > > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > > ; Luca Bocassi ;
> > > > openembedded-core@lists.openembedded.org
> > > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > > ; Khem Raj 
> > > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > > recipe to allow bootstrapping
> > > >
> > > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots -
> > > > GLOBALLOGIC INC at Cisco) wrote:
> > > > > Could you look into this warning.
> > > > >
> > > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev
> > > > rdepends on util-linux-libuuid-dev, but it isn't a build dependency?
> > > > [build-deps]
> > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > > >
> > > > That failure was my fault when testing some fixes.
> > > >
> > > > I've sent out a patch which renames util-linux-uuid to 
> > > > util-linux-libuuid
> > > > and sorts out the license issue Peter reported.
> > >
> > > I don't mind the recipe being renamed and cleaned up, but I would prefer
> > > to see my entire patch for the license parts being either integrated 
> > > before
> > > this or squashed into it, whichever you prefer. It does not make sense to
> > > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-linux,
> > > and setting the other LICENSE variables in util-linux.inc no longer makes
> > > sense as they are only relevant for util-linux.
> >
> > I'm torn on that. Code with the other licenses is present, just not used
> > in the final output and I personally suspect that having one 
> > LIC_FILES_CHKSUM
> > is going to be easier to maintain in the future rather than two separate 
> > ones.
>
> FWIW, in Debian the license definitions always cover the _sources_, not
> the built binaries. IOW: even if you don't build and distribute a
> subtool, the license metadata must cover it. I'd think this would be
> even more important for Yocto since you exclusively distribute sources,
> not binaries.

ideally, it would be good to have both expressed distinctly since we also have
tooling for end users to create manifests for whats strictly on target
images. we perhaps
need source license which is perhaps at recipe level and then target
license which is at package level.

>
> --
> Kind regards,
> Luca Boccassi
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149937): 
https://lists.openembedded.org/g/openembedded-core/message/149937
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Bocassi]

On Thu, 2021-03-25 at 14:27 +, Richard Purdie wrote:
> On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > > -Original Message-
> > > From: Richard Purdie 
> > > Sent: den 25 mars 2021 10:34
> > > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > > ; Luca Bocassi ;
> > > openembedded-core@lists.openembedded.org
> > > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > > ; Khem Raj 
> > > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > > recipe to allow bootstrapping
> > > 
> > > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots -
> > > GLOBALLOGIC INC at Cisco) wrote:
> > > > Could you look into this warning.
> > > > 
> > > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev
> > > rdepends on util-linux-libuuid-dev, but it isn't a build dependency?
> > > [build-deps]
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > > 
> > > That failure was my fault when testing some fixes.
> > > 
> > > I've sent out a patch which renames util-linux-uuid to util-linux-libuuid
> > > and sorts out the license issue Peter reported.
> > 
> > I don't mind the recipe being renamed and cleaned up, but I would prefer 
> > to see my entire patch for the license parts being either integrated before 
> > this or squashed into it, whichever you prefer. It does not make sense to 
> > use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-linux, 
> > and setting the other LICENSE variables in util-linux.inc no longer makes 
> > sense as they are only relevant for util-linux.
> 
> I'm torn on that. Code with the other licenses is present, just not used
> in the final output and I personally suspect that having one LIC_FILES_CHKSUM 
> is going to be easier to maintain in the future rather than two separate ones.

FWIW, in Debian the license definitions always cover the _sources_, not
the built binaries. IOW: even if you don't build and distribute a
subtool, the license metadata must cover it. I'd think this would be
even more important for Yocto since you exclusively distribute sources,
not binaries.

-- 
Kind regards,
Luca Boccassi


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149936): 
https://lists.openembedded.org/g/openembedded-core/message/149936
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Thu, 2021-03-25 at 14:22 +, Peter Kjellerstedt wrote:
> > -Original Message-
> > From: Richard Purdie 
> > Sent: den 25 mars 2021 10:34
> > To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> > ; Luca Bocassi ;
> > openembedded-core@lists.openembedded.org
> > Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> > ; Khem Raj 
> > Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> > recipe to allow bootstrapping
> > 
> > On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots -
> > GLOBALLOGIC INC at Cisco) wrote:
> > > Could you look into this warning.
> > > 
> > > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev
> > rdepends on util-linux-libuuid-dev, but it isn't a build dependency?
> > [build-deps]
> > > 
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> > 
> > That failure was my fault when testing some fixes.
> > 
> > I've sent out a patch which renames util-linux-uuid to util-linux-libuuid
> > and sorts out the license issue Peter reported.
> 
> I don't mind the recipe being renamed and cleaned up, but I would prefer 
> to see my entire patch for the license parts being either integrated before 
> this or squashed into it, whichever you prefer. It does not make sense to 
> use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-linux, 
> and setting the other LICENSE variables in util-linux.inc no longer makes 
> sense as they are only relevant for util-linux.

I'm torn on that. Code with the other licenses is present, just not used
in the final output and I personally suspect that having one LIC_FILES_CHKSUM 
is going to be easier to maintain in the future rather than two separate ones.

Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149930): 
https://lists.openembedded.org/g/openembedded-core/message/149930
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Peter Kjellerstedt]

> -Original Message-
> From: Richard Purdie 
> Sent: den 25 mars 2021 10:34
> To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco)
> ; Luca Bocassi ;
> openembedded-core@lists.openembedded.org
> Cc: bluelightn...@bluelightning.org; Peter Kjellerstedt
> ; Khem Raj 
> Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate
> recipe to allow bootstrapping
> 
> On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots -
> GLOBALLOGIC INC at Cisco) wrote:
> > Could you look into this warning.
> >
> > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev
> rdepends on util-linux-libuuid-dev, but it isn't a build dependency?
> [build-deps]
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> 
> That failure was my fault when testing some fixes.
> 
> I've sent out a patch which renames util-linux-uuid to util-linux-libuuid
> and sorts out the license issue Peter reported.

I don't mind the recipe being renamed and cleaned up, but I would prefer 
to see my entire patch for the license parts being either integrated before 
this or squashed into it, whichever you prefer. It does not make sense to 
use the same LIC_FILES_CHKSUM for util-linux-libuuid as for util-linux, 
and setting the other LICENSE variables in util-linux.inc no longer makes 
sense as they are only relevant for util-linux.

> I'm optimistic this fixes the various issues people have been having
> and simplifies the recipe a bit as an added bonus.
> 
> The patch has already tested cleanly on the autobuilder (the above warning
> was from an earlier aborted build before I opted to rename the recipe).
> 
> Khem: Thanks for the related meta-oe tweak, I think the rename whilst
> slightly painful now is the best way forward overall.
> 
> Cheers,
> 
> Richard

//Peter


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149929): 
https://lists.openembedded.org/g/openembedded-core/message/149929
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Bocassi]

On Thu, 2021-03-25 at 09:34 +, Richard Purdie wrote:
> On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots - 
> GLOBALLOGIC INC at Cisco) wrote:
> > Could you look into this warning.
> > 
> > WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev 
> > rdepends on util-linux-libuuid-dev, but it isn't a build dependency? 
> > [build-deps]
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226
> 
> That failure was my fault when testing some fixes.
> 
> I've sent out a patch which renames util-linux-uuid to util-linux-libuuid
> and sorts out the license issue Peter reported.
> 
> I'm optimistic this fixes the various issues people have been having
> and simplifies the recipe a bit as an added bonus.
> 
> The patch has already tested cleanly on the autobuilder (the above warning
> was from an earlier aborted build before I opted to rename the recipe).
> 
> Khem: Thanks for the related meta-oe tweak, I think the rename whilst 
> slightly painful now is the best way forward overall.
> 
> Cheers,
> 
> Richard

Looks good to me, thanks!

-- 
Kind regards,
Luca Boccassi


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149922): 
https://lists.openembedded.org/g/openembedded-core/message/149922
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Thu, 2021-03-25 at 09:17 +, Oleksiy Obitotskyi -X (oobitots - 
GLOBALLOGIC INC at Cisco) wrote:
> Could you look into this warning.
> 
> WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev 
> rdepends on util-linux-libuuid-dev, but it isn't a build dependency? 
> [build-deps]
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226

That failure was my fault when testing some fixes.

I've sent out a patch which renames util-linux-uuid to util-linux-libuuid
and sorts out the license issue Peter reported.

I'm optimistic this fixes the various issues people have been having
and simplifies the recipe a bit as an added bonus.

The patch has already tested cleanly on the autobuilder (the above warning
was from an earlier aborted build before I opted to rename the recipe).

Khem: Thanks for the related meta-oe tweak, I think the rename whilst 
slightly painful now is the best way forward overall.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149921): 
https://lists.openembedded.org/g/openembedded-core/message/149921
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Oleksiy Obitotskyy via lists.openembedded.org]

Could you look into this warning.

WARNING: util-linux-2.36.2-r0 do_package_qa: QA Issue: util-linux-dev rdepends 
on util-linux-libuuid-dev, but it isn't a build dependency? [build-deps]

https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/3226

Regards,
Oleksiy


From: openembedded-core@lists.openembedded.org 
 on behalf of Luca Bocassi 

Sent: Thursday, March 11, 2021 17:09
To: openembedded-core@lists.openembedded.org
Cc: richard.pur...@linuxfoundation.org; bluelightn...@bluelightning.org
Subject: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to 
allow bootstrapping

From: Luca Boccassi 

Recently util-linux gained an (optional) build dependency on libcryptsetup.
But libcryptsetup build-depends on util-linux for blkid (optional, can be 
disabled)
and uuid (mandatory).
Split out util-linux-uuid in a different recipe to break the cycle.

https://github.com/karelzak/util-linux/pull/898

Signed-off-by: Luca Boccassi 
---
v1: util-linux 2.35 is not out yet, but I'd like to get the preparatory work
underway as I'm not sure if this is the best approach or if there are
alternatives. Suggestions and comments very welcome. Thanks!
v2: changed packages names to reflect old ones (eg: libuuid1 -> 
util-linux-libuuid)
and leave uuid build enable in main recipe to allow for uuidgen build to 
happen,
as it does not have its own autoconf switch. Delete the library manualy from
the main recipe after build instead, and add dependency.
Might help to break loop python3 -> util-linux -> libselinux -> python3, as 
it's
only libuuid that is needed, see 
https://lists.yoctoproject.org/g/yocto/message/47570
v3: rebased and refactored to have a common util-linux.inc file
v4: added RDEPENDS on util-linux-libuuid on various packages to fix QA warnings
v5: remove RDEPENDS and instead have util-linux RDEPEND on util-linux-uuid.
Removed PACKAGES_remove and instead filter out libuuid via the package 
generation
regex.
Rebased on util-linux 2.36.2.
v6: install libuuid.a in libuuid-dev
change rdepends on uuid to use binary package rather than source
add rdepends on uuid-dev to libuuid-dev
remove rprovides of libuuid-dev from uuid-dev
v7: do not use '_append' for RDEPENDS, as it is not supported by BBCLASSEXTEND, 
use
simply '+='
v8: added missing libuuid-staticdev package
remove libx32/libuuid* too
v9: set RECIPE_MAINTAINER_pn-util-linux-uuid, same value as 
RECIPE_MAINTAINER_pn-util-linux
v10: removed DEBIAN_NOAUTONAME
 remove lib64/libuuid* too
v11: use ${D}${base_libdir}/libuuid* instead of manually specifying 
/lib|/libx32|/lib64

 meta/conf/distro/include/maintainers.inc  |  1 +
 .../util-linux/util-linux-uuid_2.36.2.bb  | 20 +++
 meta/recipes-core/util-linux/util-linux.inc   | 41 +
 .../util-linux/util-linux_2.36.2.bb   | 57 +--
 4 files changed, 77 insertions(+), 42 deletions(-)
 create mode 100644 meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb
 create mode 100644 meta/recipes-core/util-linux/util-linux.inc

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 3d8e3d5de0..c6a97bc280 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -720,6 +720,7 @@ RECIPE_MAINTAINER_pn-update-rc.d = "Ross Burton 
"
 RECIPE_MAINTAINER_pn-usbinit = "Alexander Kanavin "
 RECIPE_MAINTAINER_pn-usbutils = "Alexander Kanavin "
 RECIPE_MAINTAINER_pn-util-linux = "Chen Qi "
+RECIPE_MAINTAINER_pn-util-linux-uuid = "Chen Qi "
 RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster "
 RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin "
 RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin "
diff --git a/meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb 
b/meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb
new file mode 100644
index 00..65e4d23b7e
--- /dev/null
+++ b/meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb
@@ -0,0 +1,20 @@
+# To allow util-linux to optionally build-depend on cryptsetup, libuuid is
+# split out of the main recipe, as it's needed by cryptsetup
+
+require util-linux.inc
+
+inherit autotools gettext pkgconfig
+
+S = "${WORKDIR}/util-linux-${PV}"
+EXTRA_OECONF += "--disable-all-programs --enable-libuuid"
+PACKAGES = "util-linux-libuuid util-linux-libuuid-dev 
util-linux-libuuid-staticdev util-linux-libuuid-dbg"
+FILES_util-linux-libuuid = "${libdir}/libuuid.so.*"
+FILES_util-linux-libuuid-dev = "${libdir}/libuuid.so ${includedir} 
${libdir}/pkgconfig"
+FILES_util-linux-libuuid-staticdev = "${libdir}/libuuid.a"
+FILES_util-linux-libuuid-dbg = "/usr/src ${libdir}/.debug"
+
+do_install_append() {
+   rm -rf ${D}${datadir} ${D}${bindir} ${D}${base_bindir} ${D}${sbindir} 
${D}${base_sbindir} ${D}${exec_prefix}/sbin
+}
+
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-core/util-linux/util-linux.inc 

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Bocassi]

On Wed, 2021-03-24 at 17:37 +, Richard Purdie wrote:
> On Wed, 2021-03-24 at 17:03 +, Luca Boccassi wrote:
> > On Wed, 2021-03-24 at 09:52 -0700, Scott Branden wrote:
> > > I have not debugged yet, but I suspect this change is causing the 
> > > following failure if I merge the latest poky into our builds:
> > > 
> > > ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: QA Issue: 
> > > util-linux-uuid: Files/directories were installed but not shipped in any 
> > > package:
> > >   /usr/lib/debug
> > >   /usr/lib/debug/usr
> > >   /usr/lib/debug/usr/lib
> > >   /usr/lib/debug/usr/lib/libuuid.so.1.3.0.debug
> > > Please set FILES such that these items are packaged. Alternatively if 
> > > they are unneeded, avoid installing them or delete them within do_install.
> > > util-linux-uuid: 4 installed and not shipped files. [installed-vs-shipped]
> > > ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: Fatal QA errors 
> > > found, failing task.
> > > ERROR: Logfile of failure stored in: 
> > > /hdd/yocto/genx/poky/build/tmp/work/core2-64-poky-linux/util-linux-uuid/2.36.2-r0/temp/log.do_package.31753
> > > ERROR: Task 
> > > (mc:host:/hdd/yocto/genx/poky/build/../meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb:do_package)
> > >  failed with exit code '1'
> > 
> > It most certainly is - is /usr/lib/debug configurable or supported?
> > Currently we have:
> > 
> > FILES_util-linux-libuuid-dbg = "/usr/src ${libdir}/.debug"
> 
> Does it need to be set at all or will the default not cover this?
> 
> Cheers,
> 
> Richard

IIRC there were QA failures without it, but I cannot remember exactly.

-- 
Kind regards,
Luca Boccassi


signature.asc
Description: This is a digitally signed message part

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149898): 
https://lists.openembedded.org/g/openembedded-core/message/149898
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Wed, 2021-03-24 at 17:03 +, Luca Boccassi wrote:
> On Wed, 2021-03-24 at 09:52 -0700, Scott Branden wrote:
> > I have not debugged yet, but I suspect this change is causing the following 
> > failure if I merge the latest poky into our builds:
> > 
> > ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: QA Issue: 
> > util-linux-uuid: Files/directories were installed but not shipped in any 
> > package:
> >   /usr/lib/debug
> >   /usr/lib/debug/usr
> >   /usr/lib/debug/usr/lib
> >   /usr/lib/debug/usr/lib/libuuid.so.1.3.0.debug
> > Please set FILES such that these items are packaged. Alternatively if they 
> > are unneeded, avoid installing them or delete them within do_install.
> > util-linux-uuid: 4 installed and not shipped files. [installed-vs-shipped]
> > ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: Fatal QA errors found, 
> > failing task.
> > ERROR: Logfile of failure stored in: 
> > /hdd/yocto/genx/poky/build/tmp/work/core2-64-poky-linux/util-linux-uuid/2.36.2-r0/temp/log.do_package.31753
> > ERROR: Task 
> > (mc:host:/hdd/yocto/genx/poky/build/../meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb:do_package)
> >  failed with exit code '1'
> 
> It most certainly is - is /usr/lib/debug configurable or supported?
> Currently we have:
> 
> FILES_util-linux-libuuid-dbg = "/usr/src ${libdir}/.debug"

Does it need to be set at all or will the default not cover this?

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149897): 
https://lists.openembedded.org/g/openembedded-core/message/149897
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Boccassi via lists.openembedded.org]

On Wed, 2021-03-24 at 09:52 -0700, Scott Branden wrote:
> I have not debugged yet, but I suspect this change is causing the following 
> failure if I merge the latest poky into our builds:
> 
> ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: QA Issue: 
> util-linux-uuid: Files/directories were installed but not shipped in any 
> package:
>   /usr/lib/debug
>   /usr/lib/debug/usr
>   /usr/lib/debug/usr/lib
>   /usr/lib/debug/usr/lib/libuuid.so.1.3.0.debug
> Please set FILES such that these items are packaged. Alternatively if they 
> are unneeded, avoid installing them or delete them within do_install.
> util-linux-uuid: 4 installed and not shipped files. [installed-vs-shipped]
> ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: Fatal QA errors found, 
> failing task.
> ERROR: Logfile of failure stored in: 
> /hdd/yocto/genx/poky/build/tmp/work/core2-64-poky-linux/util-linux-uuid/2.36.2-r0/temp/log.do_package.31753
> ERROR: Task 
> (mc:host:/hdd/yocto/genx/poky/build/../meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb:do_package)
>  failed with exit code '1'

It most certainly is - is /usr/lib/debug configurable or supported?
Currently we have:

FILES_util-linux-libuuid-dbg = "/usr/src ${libdir}/.debug"

I'll send a patch to extend it and include /usr/lib/debug too

> On 2021-03-15 2:51 p.m., Richard Purdie wrote:
> > On Mon, 2021-03-15 at 13:57 +, Richard Purdie via 
> > lists.openembedded.org wrote:
> > > On Mon, 2021-03-15 at 14:55 +0100, Martin Jansa wrote:
> > > > On Mon, Mar 15, 2021 at 12:21:37PM +, Richard Purdie wrote:
> > > > > On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> > > > > > On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> > > > > > > On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > > > > > > > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > > > > > > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com 
> > > > > > > > > wrote:
> > > > > > > > > > From: Luca Boccassi 
> > > > > > > > > > 
> > > > > > > > > > Recently util-linux gained an (optional) build dependency 
> > > > > > > > > > on libcryptsetup.
> > > > > > > > > > But libcryptsetup build-depends on util-linux for blkid 
> > > > > > > > > > (optional, can be disabled)
> > > > > > > > > > and uuid (mandatory).
> > > > > > > > > > Split out util-linux-uuid in a different recipe to break 
> > > > > > > > > > the cycle.
> > > > > > > > > > 
> > > > > > > > > > https://github.com/karelzak/util-linux/pull/898
> > > > > > > > > > 
> > > > > > > > > > Signed-off-by: Luca Boccassi 
> > > > > > > > > 
> > > > > > > > > Unfortunately I noticed we had a performance regression in 
> > > > > > > > > buildtimes in 
> > > > > > > > > recent changes. The closest I have this narrowed down to so 
> > > > > > > > > far:
> > > > > > > > > 
> > > > > > > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > > > > > > > 
> > > > > > > > > suggests it may be this change. I have more tests queued to 
> > > > > > > > > confirm
> > > > > > > > > that definitively, if so we'll have to figure out why as this 
> > > > > > > > > shouldn't
> > > > > > > > > really happen, its an 8% regression :(.
> > > > > > > > 
> > > > > > > > Very strange that a single recipe could do that - is there 
> > > > > > > > something
> > > > > > > > wrong in the new .bb that I missed and could cause this?
> > > > > > > 
> > > > > > > I'm wondering if it is because we're building util-linux twice 
> > > > > > > now and
> > > > > > > there is some key choke point in the dependency chain. I have no 
> > > > > > > evidence
> > > > > > > for that yet, it is just speculation though.
> > > > > > 
> > > > > > With the autoconf options I've set, on my laptop it takes 32s to do
> > > > > > configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
> > > > > > 
> > > > > > Only 3 libraries are built with this combination: libcommon.a,
> > > > > > libtcolors.a, and libuuid.a/so. No executables or anything else is
> > > > > > built. It doesn't look like libtcolors is actually needed, I'll see 
> > > > > > if
> > > > > > I can prepare a patch to skip it, but I don't think it will buy more
> > > > > > than 1s, it's just two object files.
> > > > > > 
> > > > > > The good news is that meson support is about to land upstream, which
> > > > > > should be significantly faster than autoconf + make:
> > > > > > 
> > > > > > https://github.com/karelzak/util-linux/commits/topic/meson
> > > > > 
> > > > > Meson definitely improves the speed! I was wondering if it was from
> > > > > configure for example.
> > > > > 
> > > > > I now have more performance test results in (takes time to interleave 
> > > > > them with testing of master):
> > > > > 
> > > > > https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html
> > > > > 
> > > > > and I 

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Scott Branden via lists.openembedded.org]

I have not debugged yet, but I suspect this change is causing the following 
failure if I merge the latest poky into our builds:

ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: QA Issue: util-linux-uuid: 
Files/directories were installed but not shipped in any package:
  /usr/lib/debug
  /usr/lib/debug/usr
  /usr/lib/debug/usr/lib
  /usr/lib/debug/usr/lib/libuuid.so.1.3.0.debug
Please set FILES such that these items are packaged. Alternatively if they are 
unneeded, avoid installing them or delete them within do_install.
util-linux-uuid: 4 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:host:util-linux-uuid-2.36.2-r0 do_package: Fatal QA errors found, 
failing task.
ERROR: Logfile of failure stored in: 
/hdd/yocto/genx/poky/build/tmp/work/core2-64-poky-linux/util-linux-uuid/2.36.2-r0/temp/log.do_package.31753
ERROR: Task 
(mc:host:/hdd/yocto/genx/poky/build/../meta/recipes-core/util-linux/util-linux-uuid_2.36.2.bb:do_package)
 failed with exit code '1'

On 2021-03-15 2:51 p.m., Richard Purdie wrote:
> On Mon, 2021-03-15 at 13:57 +, Richard Purdie via lists.openembedded.org 
> wrote:
>> On Mon, 2021-03-15 at 14:55 +0100, Martin Jansa wrote:
>>> On Mon, Mar 15, 2021 at 12:21:37PM +, Richard Purdie wrote:
 On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
>> On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
>>> On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
 On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> From: Luca Boccassi 
>
> Recently util-linux gained an (optional) build dependency on 
> libcryptsetup.
> But libcryptsetup build-depends on util-linux for blkid (optional, 
> can be disabled)
> and uuid (mandatory).
> Split out util-linux-uuid in a different recipe to break the cycle.
>
> https://github.com/karelzak/util-linux/pull/898
>
> Signed-off-by: Luca Boccassi 

 Unfortunately I noticed we had a performance regression in buildtimes 
 in 
 recent changes. The closest I have this narrowed down to so far:

 https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html

 suggests it may be this change. I have more tests queued to confirm
 that definitively, if so we'll have to figure out why as this shouldn't
 really happen, its an 8% regression :(.
>>>
>>> Very strange that a single recipe could do that - is there something
>>> wrong in the new .bb that I missed and could cause this?
>>
>> I'm wondering if it is because we're building util-linux twice now and
>> there is some key choke point in the dependency chain. I have no evidence
>> for that yet, it is just speculation though.
>
> With the autoconf options I've set, on my laptop it takes 32s to do
> configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
>
> Only 3 libraries are built with this combination: libcommon.a,
> libtcolors.a, and libuuid.a/so. No executables or anything else is
> built. It doesn't look like libtcolors is actually needed, I'll see if
> I can prepare a patch to skip it, but I don't think it will buy more
> than 1s, it's just two object files.
>
> The good news is that meson support is about to land upstream, which
> should be significantly faster than autoconf + make:
>
> https://github.com/karelzak/util-linux/commits/topic/meson

 Meson definitely improves the speed! I was wondering if it was from
 configure for example.

 I now have more performance test results in (takes time to interleave 
 them with testing of master):

 https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html

 and I think this means it isn't from the util-linux change but one of 
 another three. I'm not entirely convinced those changes could do this
 but it is what the data says. 

 I've queued more bisection to narrow it down from there...
>>>
>>> BTW: this split also needs manual cleanup in the TMPDIR, right?
>>
>> It shouldn't. The system should spot that util-linux has changed and 
>> uninstall
>> it from the sysroots as it goes. There is something not working right there 
>> :(
> 
> I was wrong about that, the system doesn't have code for this, it has code for
> the sysroots but not for other sstate tasks.
> 
> I think this is an oversight and we need to simplify things and make this 
> cleanup
> happen pre-build, much like the "unreachable" tasks cleanup happens today. If 
> we
> do make this happen, we probably need to add parallelism as the number of 
> stale
> sstate tasks being cleaned could be 

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Mon, 2021-03-15 at 13:57 +, Richard Purdie via lists.openembedded.org 
wrote:
> On Mon, 2021-03-15 at 14:55 +0100, Martin Jansa wrote:
> > On Mon, Mar 15, 2021 at 12:21:37PM +, Richard Purdie wrote:
> > > On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> > > > On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> > > > > On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > > > > > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > > > > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > > > > > > From: Luca Boccassi 
> > > > > > > > 
> > > > > > > > Recently util-linux gained an (optional) build dependency on 
> > > > > > > > libcryptsetup.
> > > > > > > > But libcryptsetup build-depends on util-linux for blkid 
> > > > > > > > (optional, can be disabled)
> > > > > > > > and uuid (mandatory).
> > > > > > > > Split out util-linux-uuid in a different recipe to break the 
> > > > > > > > cycle.
> > > > > > > > 
> > > > > > > > https://github.com/karelzak/util-linux/pull/898
> > > > > > > > 
> > > > > > > > Signed-off-by: Luca Boccassi 
> > > > > > > 
> > > > > > > Unfortunately I noticed we had a performance regression in 
> > > > > > > buildtimes in 
> > > > > > > recent changes. The closest I have this narrowed down to so far:
> > > > > > > 
> > > > > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > > > > > 
> > > > > > > suggests it may be this change. I have more tests queued to 
> > > > > > > confirm
> > > > > > > that definitively, if so we'll have to figure out why as this 
> > > > > > > shouldn't
> > > > > > > really happen, its an 8% regression :(.
> > > > > > 
> > > > > > Very strange that a single recipe could do that - is there something
> > > > > > wrong in the new .bb that I missed and could cause this?
> > > > > 
> > > > > I'm wondering if it is because we're building util-linux twice now and
> > > > > there is some key choke point in the dependency chain. I have no 
> > > > > evidence
> > > > > for that yet, it is just speculation though.
> > > > 
> > > > With the autoconf options I've set, on my laptop it takes 32s to do
> > > > configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
> > > > 
> > > > Only 3 libraries are built with this combination: libcommon.a,
> > > > libtcolors.a, and libuuid.a/so. No executables or anything else is
> > > > built. It doesn't look like libtcolors is actually needed, I'll see if
> > > > I can prepare a patch to skip it, but I don't think it will buy more
> > > > than 1s, it's just two object files.
> > > > 
> > > > The good news is that meson support is about to land upstream, which
> > > > should be significantly faster than autoconf + make:
> > > > 
> > > > https://github.com/karelzak/util-linux/commits/topic/meson
> > > 
> > > Meson definitely improves the speed! I was wondering if it was from
> > > configure for example.
> > > 
> > > I now have more performance test results in (takes time to interleave 
> > > them with testing of master):
> > > 
> > > https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html
> > > 
> > > and I think this means it isn't from the util-linux change but one of 
> > > another three. I'm not entirely convinced those changes could do this
> > > but it is what the data says. 
> > > 
> > > I've queued more bisection to narrow it down from there...
> > 
> > BTW: this split also needs manual cleanup in the TMPDIR, right?
> 
> It shouldn't. The system should spot that util-linux has changed and uninstall
> it from the sysroots as it goes. There is something not working right there :(

I was wrong about that, the system doesn't have code for this, it has code for
the sysroots but not for other sstate tasks.

I think this is an oversight and we need to simplify things and make this 
cleanup
happen pre-build, much like the "unreachable" tasks cleanup happens today. If we
do make this happen, we probably need to add parallelism as the number of stale
sstate tasks being cleaned could be substantial.

Cheers,

Richard








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149541): 
https://lists.openembedded.org/g/openembedded-core/message/149541
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Mon, 2021-03-15 at 14:55 +0100, Martin Jansa wrote:
> On Mon, Mar 15, 2021 at 12:21:37PM +, Richard Purdie wrote:
> > On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> > > On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> > > > On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > > > > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > > > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > > > > > From: Luca Boccassi 
> > > > > > > 
> > > > > > > Recently util-linux gained an (optional) build dependency on 
> > > > > > > libcryptsetup.
> > > > > > > But libcryptsetup build-depends on util-linux for blkid 
> > > > > > > (optional, can be disabled)
> > > > > > > and uuid (mandatory).
> > > > > > > Split out util-linux-uuid in a different recipe to break the 
> > > > > > > cycle.
> > > > > > > 
> > > > > > > https://github.com/karelzak/util-linux/pull/898
> > > > > > > 
> > > > > > > Signed-off-by: Luca Boccassi 
> > > > > > 
> > > > > > Unfortunately I noticed we had a performance regression in 
> > > > > > buildtimes in 
> > > > > > recent changes. The closest I have this narrowed down to so far:
> > > > > > 
> > > > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > > > > 
> > > > > > suggests it may be this change. I have more tests queued to confirm
> > > > > > that definitively, if so we'll have to figure out why as this 
> > > > > > shouldn't
> > > > > > really happen, its an 8% regression :(.
> > > > > 
> > > > > Very strange that a single recipe could do that - is there something
> > > > > wrong in the new .bb that I missed and could cause this?
> > > > 
> > > > I'm wondering if it is because we're building util-linux twice now and
> > > > there is some key choke point in the dependency chain. I have no 
> > > > evidence
> > > > for that yet, it is just speculation though.
> > > 
> > > With the autoconf options I've set, on my laptop it takes 32s to do
> > > configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
> > > 
> > > Only 3 libraries are built with this combination: libcommon.a,
> > > libtcolors.a, and libuuid.a/so. No executables or anything else is
> > > built. It doesn't look like libtcolors is actually needed, I'll see if
> > > I can prepare a patch to skip it, but I don't think it will buy more
> > > than 1s, it's just two object files.
> > > 
> > > The good news is that meson support is about to land upstream, which
> > > should be significantly faster than autoconf + make:
> > > 
> > > https://github.com/karelzak/util-linux/commits/topic/meson
> > 
> > Meson definitely improves the speed! I was wondering if it was from
> > configure for example.
> > 
> > I now have more performance test results in (takes time to interleave 
> > them with testing of master):
> > 
> > https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html
> > 
> > and I think this means it isn't from the util-linux change but one of 
> > another three. I'm not entirely convinced those changes could do this
> > but it is what the data says. 
> > 
> > I've queued more bisection to narrow it down from there...
> 
> BTW: this split also needs manual cleanup in the TMPDIR, right?

It shouldn't. The system should spot that util-linux has changed and uninstall
it from the sysroots as it goes. There is something not working right there :(

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149462): 
https://lists.openembedded.org/g/openembedded-core/message/149462
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Martin Jansa]

On Mon, Mar 15, 2021 at 12:21:37PM +, Richard Purdie wrote:
> On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> > On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> > > On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > > > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > > > > From: Luca Boccassi 
> > > > > > 
> > > > > > Recently util-linux gained an (optional) build dependency on 
> > > > > > libcryptsetup.
> > > > > > But libcryptsetup build-depends on util-linux for blkid (optional, 
> > > > > > can be disabled)
> > > > > > and uuid (mandatory).
> > > > > > Split out util-linux-uuid in a different recipe to break the cycle.
> > > > > > 
> > > > > > https://github.com/karelzak/util-linux/pull/898
> > > > > > 
> > > > > > Signed-off-by: Luca Boccassi 
> > > > > 
> > > > > Unfortunately I noticed we had a performance regression in buildtimes 
> > > > > in 
> > > > > recent changes. The closest I have this narrowed down to so far:
> > > > > 
> > > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > > > 
> > > > > suggests it may be this change. I have more tests queued to confirm
> > > > > that definitively, if so we'll have to figure out why as this 
> > > > > shouldn't
> > > > > really happen, its an 8% regression :(.
> > > > 
> > > > Very strange that a single recipe could do that - is there something
> > > > wrong in the new .bb that I missed and could cause this?
> > > 
> > > I'm wondering if it is because we're building util-linux twice now and
> > > there is some key choke point in the dependency chain. I have no evidence
> > > for that yet, it is just speculation though.
> > 
> > With the autoconf options I've set, on my laptop it takes 32s to do
> > configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
> > 
> > Only 3 libraries are built with this combination: libcommon.a,
> > libtcolors.a, and libuuid.a/so. No executables or anything else is
> > built. It doesn't look like libtcolors is actually needed, I'll see if
> > I can prepare a patch to skip it, but I don't think it will buy more
> > than 1s, it's just two object files.
> > 
> > The good news is that meson support is about to land upstream, which
> > should be significantly faster than autoconf + make:
> > 
> > https://github.com/karelzak/util-linux/commits/topic/meson
> 
> Meson definitely improves the speed! I was wondering if it was from
> configure for example.
> 
> I now have more performance test results in (takes time to interleave 
> them with testing of master):
> 
> https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html
> 
> and I think this means it isn't from the util-linux change but one of 
> another three. I'm not entirely convinced those changes could do this
> but it is what the data says. 
> 
> I've queued more bisection to narrow it down from there...

BTW: this split also needs manual cleanup in the TMPDIR, right?

Incremental build fails with:
ERROR: util-linux-uuid-2.36.2-r0 do_packagedata: The recipe util-linux-uuid is 
trying to install files into a shared area when those files already exist. 
Those files and their manifest location are:
  /OE/build/oe-core/tmp-glibc/pkgdata/qemux86-64/shlibs2/util-linux-libuuid.list
(matched in manifest-qemux86_64-util-linux.packagedata)
  
/OE/build/oe-core/tmp-glibc/pkgdata/qemux86-64/runtime/util-linux-libuuid.packaged
(matched in manifest-qemux86_64-util-linux.packagedata)
  /OE/build/oe-core/tmp-glibc/pkgdata/qemux86-64/runtime/util-linux-libuuid
(matched in manifest-qemux86_64-util-linux.packagedata)
Please verify which recipe should provide the above files.

The build has stopped, as continuing in this scenario WILL break things - if 
not now, possibly in the future (we've seen builds fail several months later). 
If the system knew how to recover from this automatically it would, however 
there are several different scenarios which can result in this and we don't 
know which one this is. It may be you have switched providers of something like 
virtual/kernel (e.g. from linux-yocto to linux-yocto-dev), in that case you 
need to execute the clean task for both recipes and it will resolve this error. 
It may be you changed DISTRO_FEATURES from systemd to udev or vice versa. 
Cleaning those recipes should again resolve this error, however switching 
DISTRO_FEATURES on an existing build directory is not supported - you should 
really clean out tmp and rebuild (reusing sstate should be safe). It could be 
the overlapping files detected are harmless in which case adding them to 
SSTATE_DUPWHITELIST may be the correct solution. It could also be your build is 
including two different conflicting versions of things (e.g. bluez 4 and bluez 
5 and the 

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Bocassi]

On Mon, 2021-03-15 at 12:21 +, Richard Purdie wrote:
> On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> > On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> > > On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > > > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > > > > From: Luca Boccassi 
> > > > > > 
> > > > > > Recently util-linux gained an (optional) build dependency on 
> > > > > > libcryptsetup.
> > > > > > But libcryptsetup build-depends on util-linux for blkid (optional, 
> > > > > > can be disabled)
> > > > > > and uuid (mandatory).
> > > > > > Split out util-linux-uuid in a different recipe to break the cycle.
> > > > > > 
> > > > > > https://github.com/karelzak/util-linux/pull/898
> > > > > > 
> > > > > > Signed-off-by: Luca Boccassi 
> > > > > 
> > > > > Unfortunately I noticed we had a performance regression in buildtimes 
> > > > > in 
> > > > > recent changes. The closest I have this narrowed down to so far:
> > > > > 
> > > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > > > 
> > > > > suggests it may be this change. I have more tests queued to confirm
> > > > > that definitively, if so we'll have to figure out why as this 
> > > > > shouldn't
> > > > > really happen, its an 8% regression :(.
> > > > 
> > > > Very strange that a single recipe could do that - is there something
> > > > wrong in the new .bb that I missed and could cause this?
> > > 
> > > I'm wondering if it is because we're building util-linux twice now and
> > > there is some key choke point in the dependency chain. I have no evidence
> > > for that yet, it is just speculation though.
> > 
> > With the autoconf options I've set, on my laptop it takes 32s to do
> > configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
> > 
> > Only 3 libraries are built with this combination: libcommon.a,
> > libtcolors.a, and libuuid.a/so. No executables or anything else is
> > built. It doesn't look like libtcolors is actually needed, I'll see if
> > I can prepare a patch to skip it, but I don't think it will buy more
> > than 1s, it's just two object files.
> > 
> > The good news is that meson support is about to land upstream, which
> > should be significantly faster than autoconf + make:
> > 
> > https://github.com/karelzak/util-linux/commits/topic/meson
> 
> Meson definitely improves the speed! I was wondering if it was from
> configure for example.
> 
> I now have more performance test results in (takes time to interleave 
> them with testing of master):
> 
> https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html
> 
> and I think this means it isn't from the util-linux change but one of 
> another three. I'm not entirely convinced those changes could do this
> but it is what the data says. 
> 
> I've queued more bisection to narrow it down from there...
> 
> Cheers,
> 
> Richard

Ok, that's good news then (at least for me!) - in the meanwhile I had a
look at automake anyway, and found out the compile time can be halved
since libcommon and libtcolors are not needed by libuuid:

https://github.com/karelzak/util-linux/pull/1262

Not sure if worth backporting, as it's just a dozen object files, the
big time chunk is from autoconf anyway.

-- 
Kind regards,
Luca Boccassi


signature.asc
Description: This is a digitally signed message part

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149457): 
https://lists.openembedded.org/g/openembedded-core/message/149457
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Mon, 2021-03-15 at 11:50 +, Luca Boccassi wrote:
> On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> > On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > > > From: Luca Boccassi 
> > > > > 
> > > > > Recently util-linux gained an (optional) build dependency on 
> > > > > libcryptsetup.
> > > > > But libcryptsetup build-depends on util-linux for blkid (optional, 
> > > > > can be disabled)
> > > > > and uuid (mandatory).
> > > > > Split out util-linux-uuid in a different recipe to break the cycle.
> > > > > 
> > > > > https://github.com/karelzak/util-linux/pull/898
> > > > > 
> > > > > Signed-off-by: Luca Boccassi 
> > > > 
> > > > Unfortunately I noticed we had a performance regression in buildtimes 
> > > > in 
> > > > recent changes. The closest I have this narrowed down to so far:
> > > > 
> > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > > 
> > > > suggests it may be this change. I have more tests queued to confirm
> > > > that definitively, if so we'll have to figure out why as this shouldn't
> > > > really happen, its an 8% regression :(.
> > > 
> > > Very strange that a single recipe could do that - is there something
> > > wrong in the new .bb that I missed and could cause this?
> > 
> > I'm wondering if it is because we're building util-linux twice now and
> > there is some key choke point in the dependency chain. I have no evidence
> > for that yet, it is just speculation though.
> 
> With the autoconf options I've set, on my laptop it takes 32s to do
> configure + make -j2. Most of that is autoconf - make -j2 takes 8s.
> 
> Only 3 libraries are built with this combination: libcommon.a,
> libtcolors.a, and libuuid.a/so. No executables or anything else is
> built. It doesn't look like libtcolors is actually needed, I'll see if
> I can prepare a patch to skip it, but I don't think it will buy more
> than 1s, it's just two object files.
> 
> The good news is that meson support is about to land upstream, which
> should be significantly faster than autoconf + make:
> 
> https://github.com/karelzak/util-linux/commits/topic/meson

Meson definitely improves the speed! I was wondering if it was from
configure for example.

I now have more performance test results in (takes time to interleave 
them with testing of master):

https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html

and I think this means it isn't from the util-linux change but one of 
another three. I'm not entirely convinced those changes could do this
but it is what the data says. 

I've queued more bisection to narrow it down from there...

Cheers,

Richard





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149454): 
https://lists.openembedded.org/g/openembedded-core/message/149454
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Bocassi]

On Mon, 2021-03-15 at 10:49 +, Richard Purdie wrote:
> On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> > On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > > From: Luca Boccassi 
> > > > 
> > > > Recently util-linux gained an (optional) build dependency on 
> > > > libcryptsetup.
> > > > But libcryptsetup build-depends on util-linux for blkid (optional, can 
> > > > be disabled)
> > > > and uuid (mandatory).
> > > > Split out util-linux-uuid in a different recipe to break the cycle.
> > > > 
> > > > https://github.com/karelzak/util-linux/pull/898
> > > > 
> > > > Signed-off-by: Luca Boccassi 
> > > 
> > > Unfortunately I noticed we had a performance regression in buildtimes in 
> > > recent changes. The closest I have this narrowed down to so far:
> > > 
> > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > > 
> > > suggests it may be this change. I have more tests queued to confirm
> > > that definitively, if so we'll have to figure out why as this shouldn't
> > > really happen, its an 8% regression :(.
> > 
> > Very strange that a single recipe could do that - is there something
> > wrong in the new .bb that I missed and could cause this?
> 
> I'm wondering if it is because we're building util-linux twice now and
> there is some key choke point in the dependency chain. I have no evidence
> for that yet, it is just speculation though.

With the autoconf options I've set, on my laptop it takes 32s to do
configure + make -j2. Most of that is autoconf - make -j2 takes 8s.

Only 3 libraries are built with this combination: libcommon.a,
libtcolors.a, and libuuid.a/so. No executables or anything else is
built. It doesn't look like libtcolors is actually needed, I'll see if
I can prepare a patch to skip it, but I don't think it will buy more
than 1s, it's just two object files.

The good news is that meson support is about to land upstream, which
should be significantly faster than autoconf + make:

https://github.com/karelzak/util-linux/commits/topic/meson

-- 
Kind regards,
Luca Boccassi


signature.asc
Description: This is a digitally signed message part

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149453): 
https://lists.openembedded.org/g/openembedded-core/message/149453
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Mon, 2021-03-15 at 10:44 +, Luca Boccassi wrote:
> On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> > On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > > From: Luca Boccassi 
> > > 
> > > Recently util-linux gained an (optional) build dependency on 
> > > libcryptsetup.
> > > But libcryptsetup build-depends on util-linux for blkid (optional, can be 
> > > disabled)
> > > and uuid (mandatory).
> > > Split out util-linux-uuid in a different recipe to break the cycle.
> > > 
> > > https://github.com/karelzak/util-linux/pull/898
> > > 
> > > Signed-off-by: Luca Boccassi 
> > 
> > Unfortunately I noticed we had a performance regression in buildtimes in 
> > recent changes. The closest I have this narrowed down to so far:
> > 
> > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> > 
> > suggests it may be this change. I have more tests queued to confirm
> > that definitively, if so we'll have to figure out why as this shouldn't
> > really happen, its an 8% regression :(.
> 
> Very strange that a single recipe could do that - is there something
> wrong in the new .bb that I missed and could cause this?

I'm wondering if it is because we're building util-linux twice now and
there is some key choke point in the dependency chain. I have no evidence
for that yet, it is just speculation though.

Cheers,

Richard



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149451): 
https://lists.openembedded.org/g/openembedded-core/message/149451
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Luca Bocassi]

On Sun, 2021-03-14 at 22:10 +, Richard Purdie wrote:
> On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> > From: Luca Boccassi 
> > 
> > Recently util-linux gained an (optional) build dependency on libcryptsetup.
> > But libcryptsetup build-depends on util-linux for blkid (optional, can be 
> > disabled)
> > and uuid (mandatory).
> > Split out util-linux-uuid in a different recipe to break the cycle.
> > 
> > https://github.com/karelzak/util-linux/pull/898
> > 
> > Signed-off-by: Luca Boccassi 
> 
> Unfortunately I noticed we had a performance regression in buildtimes in 
> recent changes. The closest I have this narrowed down to so far:
> 
> https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html
> 
> suggests it may be this change. I have more tests queued to confirm
> that definitively, if so we'll have to figure out why as this shouldn't
> really happen, its an 8% regression :(.
> 
> Cheers,
> 
> Richard

Hi,

Very strange that a single recipe could do that - is there something
wrong in the new .bb that I missed and could cause this?

-- 
Kind regards,
Luca Boccassi


signature.asc
Description: This is a digitally signed message part

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149450): 
https://lists.openembedded.org/g/openembedded-core/message/149450
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping

[Richard Purdie]

On Thu, 2021-03-11 at 15:09 +, luca.bocca...@gmail.com wrote:
> From: Luca Boccassi 
> 
> Recently util-linux gained an (optional) build dependency on libcryptsetup.
> But libcryptsetup build-depends on util-linux for blkid (optional, can be 
> disabled)
> and uuid (mandatory).
> Split out util-linux-uuid in a different recipe to break the cycle.
> 
> https://github.com/karelzak/util-linux/pull/898
> 
> Signed-off-by: Luca Boccassi 

Unfortunately I noticed we had a performance regression in buildtimes in 
recent changes. The closest I have this narrowed down to so far:

https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html

suggests it may be this change. I have more tests queued to confirm
that definitively, if so we'll have to figure out why as this shouldn't
really happen, its an 8% regression :(.

Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#149439): 
https://lists.openembedded.org/g/openembedded-core/message/149439
Mute This Topic: https://lists.openembedded.org/mt/81254724/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-