Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-15 Thread Mike Looijmans
Okay on that. Mike. On 09/14/2014 06:13 AM, Robert Yang wrote: Hi Mike, I've updated the patch in the repo: git://git.openembedded.org/meta-openembedded-contrib rbt/rdeps And used a patch rather than sed command since patch is preferred, here is the patch with your signed off: diff --git

Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-13 Thread Robert Yang
Hi Mike, I've updated the patch in the repo: git://git.openembedded.org/meta-openembedded-contrib rbt/rdeps And used a patch rather than sed command since patch is preferred, here is the patch with your signed off: diff --git

Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-12 Thread Mike Looijmans
On 09/11/2014 05:28 PM, Robert Yang wrote: On 09/11/2014 01:08 AM, Mike Looijmans wrote: Wouldn't it be a LOT more constructive to fix the bashism. I fail to see the virtue in adding 2MB of bash to an embedded system just for a text echo statement that no-one will actually read unless they

Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-12 Thread Robert Yang
On 09/12/2014 08:57 PM, Mike wrote: On 09/11/2014 05:28 PM, Robert Yang wrote: On 09/11/2014 01:08 AM, Mike Looijmans wrote: Wouldn't it be a LOT more constructive to fix the bashism. I fail to see the virtue in adding 2MB of bash to an embedded system just for a text echo statement that

Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-11 Thread Robert Yang
On 09/11/2014 01:08 AM, Mike Looijmans wrote: Wouldn't it be a LOT more constructive to fix the bashism. I fail to see the virtue in adding 2MB of bash to an embedded system just for a text echo statement that no-one will actually read unless they hook up a serial console to their TV set or

Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-11 Thread Enrico Scholz
Robert Yang liezhi.y...@windriver.com writes: possible bashism in autofs/etc/init.d/autofs line 116 ($foo should be eval_gettext foo): +RDEPENDS_${PN} += bash Is this bashism only in the initscript, or somewhere else too? If it is only in the initscript, the RDEPENDS should be a

Re: [oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-10 Thread Mike Looijmans
Wouldn't it be a LOT more constructive to fix the bashism. I fail to see the virtue in adding 2MB of bash to an embedded system just for a text echo statement that no-one will actually read unless they hook up a serial console to their TV set or so. On 9-9-2014 18:27, Robert Yang wrote:

[oe] [PATCH 02/14] autofs: add bash to RDEPENDS_autofs

2014-09-09 Thread Robert Yang
Bashism: [snip] possible bashism in autofs/etc/init.d/autofs line 116 ($foo should be eval_gettext foo): echo $$prog not running possible bashism in autofs/etc/init.d/autofs line 120 ($foo should be eval_gettext foo): echo $Reloading maps possible bashism in