Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-16 Thread Leon Anavi
Hi Khem, Ross, On 15.11.19 г. 22:49 ч., Khem Raj wrote: On Fri, Nov 15, 2019 at 11:25 AM Ross Burton wrote: On 15/11/2019 17:30, Khem Raj wrote: On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: meta-browser would be more appropriate. I was contemplating that as well. but these

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Khem Raj
On Fri, Nov 15, 2019 at 11:25 AM Ross Burton wrote: > > On 15/11/2019 17:30, Khem Raj wrote: > > On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: > >> meta-browser would be more appropriate. > > > > I was contemplating that as well. but these layer has more chromium and > > firefox

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Ross Burton
On 15/11/2019 13:30, Leon Anavi wrote: +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" Why? These two lines prevent already-stripped QA errors. The correct fix is to stop the recipe from forcibly stripping, or tell it to include debug information in the first place. The

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Ross Burton
On 15/11/2019 17:30, Khem Raj wrote: On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: meta-browser would be more appropriate. I was contemplating that as well. but these layer has more chromium and firefox lineage But it's called meta-browser and not meta-firefox-and-chromium.

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Khem Raj
On Fri, 2019-11-15 at 16:09 +0100, Carlos Rafael Giani wrote: > meta-browser would be more appropriate. I was contemplating that as well. but these layer has more chromium and firefox lineage > > On 14.11.19 19:52, akuster808 wrote: > > On 11/14/19 9:20 AM, Leon Anavi wrote: > > > Add a recipe

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Carlos Rafael Giani
meta-browser would be more appropriate. On 14.11.19 19:52, akuster808 wrote: On 11/14/19 9:20 AM, Leon Anavi wrote: Add a recipe for surf, a simple web browser based on WebKit2/GTK+. shouldn't this go into the meta-webserver layer ? Signed-off-by: Leon Anavi ---

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Khem Raj
On Fri, Nov 15, 2019 at 5:30 AM Leon Anavi wrote: > Hi Ross, Martin, Khem, > > Thanks you for the feedback and for helping me. I've just submitted an > updated version of the patch for a review. Now the recipe inherits > distro_features_check. > > On 15.11.19 г. 1:22 ч., Ross Burton wrote: > >

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-15 Thread Leon Anavi
Hi Ross, Martin, Khem, Thanks you for the feedback and for helping me. I've just submitted an updated version of the patch for a review. Now the recipe inherits distro_features_check. On 15.11.19 г. 1:22 ч., Ross Burton wrote: On 14/11/2019 17:20, Leon Anavi wrote: +DEPENDS = "webkitgtk

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread Ross Burton
On 14/11/2019 17:20, Leon Anavi wrote: +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0 xserver-nodm-init" Are you sure it *build* depends on the X init scripts? +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" +INHIBIT_PACKAGE_STRIP = "1" Why? Ross -- ___

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread Martin Jansa
REQUIRED_DISTRO_FEATURES = "x11" doesn't do anything unless you inherit the distro_features_check.bbclass which I don't see in the recipe. On Thu, Nov 14, 2019 at 11:34 PM Khem Raj wrote: > On Thu, Nov 14, 2019 at 10:04 AM Leon Anavi > wrote: > > > > Add a recipe for surf, a simple web

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread Khem Raj
On Thu, Nov 14, 2019 at 10:04 AM Leon Anavi wrote: > > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. > > Signed-off-by: Leon Anavi > --- > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > ++ > meta-oe/recipes-graphics/surf/surf_2.0.bb

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread akuster808
On 11/14/19 11:10 AM, Khem Raj wrote: > On Thu, Nov 14, 2019 at 10:53 AM akuster808 wrote: >> >> >> On 11/14/19 9:20 AM, Leon Anavi wrote: >>> Add a recipe for surf, a simple web browser based on WebKit2/GTK+. >> shouldn't this go into the meta-webserver layer ? > perhaps but its the browser

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread Leon Anavi
Hi Armin, Khem, On 14.11.19 г. 21:10 ч., Khem Raj wrote: On Thu, Nov 14, 2019 at 10:53 AM akuster808 wrote: On 11/14/19 9:20 AM, Leon Anavi wrote: Add a recipe for surf, a simple web browser based on WebKit2/GTK+. shouldn't this go into the meta-webserver layer ? perhaps but its the

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread Khem Raj
On Thu, Nov 14, 2019 at 10:53 AM akuster808 wrote: > > > > On 11/14/19 9:20 AM, Leon Anavi wrote: > > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. > > shouldn't this go into the meta-webserver layer ? perhaps but its the browser > > > > Signed-off-by: Leon Anavi > > --- >

Re: [oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread akuster808
On 11/14/19 9:20 AM, Leon Anavi wrote: > Add a recipe for surf, a simple web browser based on WebKit2/GTK+. shouldn't this go into the meta-webserver layer ? > > Signed-off-by: Leon Anavi > --- > .../0001-config.mk-Fix-compiler-and-linker.patch | 36 > ++ >

[oe] [meta-oe][PATCH] surf: Add simple web browser

2019-11-14 Thread Leon Anavi
Add a recipe for surf, a simple web browser based on WebKit2/GTK+. Signed-off-by: Leon Anavi --- .../0001-config.mk-Fix-compiler-and-linker.patch | 36 ++ meta-oe/recipes-graphics/surf/surf_2.0.bb | 30 ++ 2 files changed, 66 insertions(+) create