Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-17 Thread Marek Vasut
On 3/17/24 8:46 AM, Martin Jansa wrote: The extra -I flag won't harm even when libdrm isn't there. lvgl-demo-fb also doesn't do it conditionally based on drm PACKAGECONFIG. If someone want's to fix this properly then should also use pkg-config (and tests/FindLibDRM.cmake in the lvgl repo), but

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-17 Thread Martin Jansa
The extra -I flag won't harm even when libdrm isn't there. lvgl-demo-fb also doesn't do it conditionally based on drm PACKAGECONFIG. If someone want's to fix this properly then should also use pkg-config (and tests/FindLibDRM.cmake in the lvgl repo), but lets not block this fix based on that.

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Marek Vasut
On 3/16/24 10:55 PM, Christophe Chapuis wrote: It could be conditional eventually; I just took the line from lvgl-demo-fb, where it wasn't. Ideally, both should be moved in lv-conf.inc, where the lvgl drm setting is activated. But I didn't want to expand again the scope of this patchset,

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Tofe
It could be conditional eventually; I just took the line from lvgl-demo-fb, where it wasn't. Ideally, both should be moved in lv-conf.inc, where the lvgl drm setting is activated. But I didn't want to expand again the scope of this patchset, initially focused simply on adding some variables to

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Marek Vasut
On 3/16/24 11:00 AM, Christophe Chapuis wrote: When DRM is activated for LVGL, it adds a dependency on drm.h. As for lvgl-demo-fb, add an include path to fix this usecase. Signed-off-by: Christophe Chapuis --- meta-oe/recipes-graphics/lvgl/lvgl_9.0.0.bb | 2 ++ 1 file changed, 2

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Khem Raj
Ok thx On Sat, Mar 16, 2024 at 9:18 AM Christophe Chapuis wrote: > Yes, it fixes exactly this issue. > > On Sat, Mar 16, 2024 at 5:09 PM Khem Raj wrote: > >> does this fix >> >> https://errors.yoctoproject.org/Errors/Details/758522/ >> >> On Sat, Mar 16, 2024 at 3:01 AM Christophe Chapuis >>

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Tofe
Yes, it fixes exactly this issue. On Sat, Mar 16, 2024 at 5:09 PM Khem Raj wrote: > does this fix > > https://errors.yoctoproject.org/Errors/Details/758522/ > > On Sat, Mar 16, 2024 at 3:01 AM Christophe Chapuis > wrote: > > > > When DRM is activated for LVGL, it adds a dependency on drm.h. >

Re: [oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Khem Raj
does this fix https://errors.yoctoproject.org/Errors/Details/758522/ On Sat, Mar 16, 2024 at 3:01 AM Christophe Chapuis wrote: > > When DRM is activated for LVGL, it adds a dependency on drm.h. > As for lvgl-demo-fb, add an include path to fix this usecase. > > Signed-off-by: Christophe Chapuis

[oe] [meta-oe][PATCH v4 6/7] lvgl: fix libdrm include

2024-03-16 Thread Tofe
When DRM is activated for LVGL, it adds a dependency on drm.h. As for lvgl-demo-fb, add an include path to fix this usecase. Signed-off-by: Christophe Chapuis --- meta-oe/recipes-graphics/lvgl/lvgl_9.0.0.bb | 2 ++ 1 file changed, 2 insertions(+) diff --git