Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-05-06 Thread Priyesh (Open ERP)
Review: Resubmit Added new field for percentage, Improved create_analytic_lines and Improved function for amount currency -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-717198-pso/+merge/57623 Your team OpenERP RD Team is subscribed to branch

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-05-05 Thread Mustufa Rangwala (Open ERP)
As per the discussion with qdp no need to call super() as it is related field on parent class and here we define it fields.function. just add percentage field on analytic line and return total_in_currency * percentage .. Thanks to qdp for suggestion. mra --

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-05-04 Thread qdp (OpenERP)
Review: Needs Fixing for this bug, i'm not sure this is the god way to solve the problem. I would have prefer to have a new fields.float to save the percentage used t compute the amount in company currency, then in the _get_amount function we can just call super() and apply this percentage to

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-04-15 Thread Priyesh (Open ERP)
Review: Resubmit Removed Extra spaces and Declared self.pool.get('res.currency') outside loop. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-717198-pso/+merge/57623 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso.

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-04-15 Thread Mustufa Rangwala (Open ERP)
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-717198-pso/+merge/57623 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso. ___ Mailing list:

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-04-14 Thread Priyesh (Open ERP)
Review: Resubmit Moved amount currency function from account to analytic plans. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-717198-pso/+merge/57623 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso.

[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-04-14 Thread Priyesh (Open ERP)
Priyesh (Open ERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons. Requested reviews: OpenERP Core Team (openerp) Related bugs: Bug #717198 in OpenERP Addons: Wrong computation of amount currency in analytic entry

Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons

2011-04-14 Thread Mustufa Rangwala (Open ERP)
Review: Needs Fixing account/account_analytic_line.py = remove unused changes. self.pool.get('res.currency') = declare outside loop -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-717198-pso/+merge/57623 Your team OpenERP RD Team is subscribed to branch