** Project changed: openobject-addons = openobject-client-web
** Changed in: openobject-client-web
Assignee: (unassigned) = OpenERP SA's Web Client RD (openerp-dev-web)
--
customer payment doesn't work in web version
https://bugs.launchpad.net/bugs/671608
You received this bug notification
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-dev-addons_decimal_precision into
lp:openobject-addons has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-dev-addons_decimal_precision into
lp:openobject-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-dev-addons_decimal_precision/+merge/37594
The proposal to merge lp:~openerp-dev/openobject-addons/jam-dev-addons2 into
lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/jam-dev-addons2/+merge/44027
--
as discussed with xmo, i'm rejcting this merge prop becazuse it was already
done by the dev2 team.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/xmo-reformat-cleanup-partial-pickings/+merge/46147
Your team OpenERP RD Team is subscribed to branch
The proposal to merge
lp:~openerp-dev/openobject-addons/xmo-reformat-cleanup-partial-pickings into
lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
qdp (OpenERP) has proposed merging
lp:~vmt-openerp/openobject-addons/vmt-traceability-action into
lp:openobject-addons.
Requested reviews:
OpenERP RD Team (openerp-dev)
Related bugs:
#695024 Upstream / Downstream traceability does not work
https://bugs.launchpad.net/bugs/695024
For more
i improved:
1) _('Supplier Invoices') for translability
2)
-'view_mode': 'form',
+'view_mode': 'form,tree',
to allwo to switch in tree view after processing that invoice
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-720629-ara/+merge/50335
Your
Review: Disapprove
for me, the bug isn't a bug but a whishlist, and currently this fix isn't good
because it will create bigger problems while hole in the numbering cause each
time we will cancel a voucher we will lsot the number. So i'm rejecting that
merge prop
--
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728943-mra
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728943-mra/+merge/52653
--
Review: Disapprove
in accounting, we should keep in mind that a user can see the objects belonging
to
*its company
*a child of its company
but never to a company parent than its company. So you should remove that part
of the domain:
('company_id.child_ids','child_of',[user.company_id.id])
--
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-724059-rha
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724059-rha/+merge/51493
--
Review: Disapprove
rejected: the rules shouldn't allow the users to see objects belonging to
parent company
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724059-rha/+merge/51493
Your team OpenERP RD Team is subscribed to branch
Review: Needs Information
i don't see the point with the linked bug. Could someone explain?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718722-rha/+merge/52161
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-718722-rha.
Review: Abstain
need to double-check
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-725908-ksa/+merge/52519
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-725908-ksa.
___
Mailing
Review: Disapprove
Should have been set as wishlist... i do not share the view of Ferdinand
because i've a doubt on the utility of such improvement. Moreover, if i merge
the branch as it, in less than 2 weeks we will have another bug report for
'subtotal in form view of SO line is only updated
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-730313-aag
into lp:openobject-addons has been updated.
Status: Approved = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730313-aag/+merge/52373
--
already fixed in revno: 4493
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728382-aag/+merge/52514
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-728382-aag.
___
Mailing list:
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728382-aag
into lp:openobject-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728382-aag/+merge/52514
--
fix already there as the bug was a duplicated one of
https://bugs.launchpad.net/openobject-addons/+bug/713177. I'm closing this
merge prop for the sake of clarity
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-723713-ara/+merge/51515
Your team OpenERP RD Team is
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-723713-ara
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-723713-ara/+merge/51515
--
patch was working, but by luck only.
Actually, the way to use the store = {} feature wasn't good but the orm was
bugged and the priorities of functions wasn't working at all. So i just
commited the right way to fix the issue in the addons, a patch is under testing
server side and if it
Review: Disapprove
rejected, for me it is not really a bug and adding those fields in the list
view is against the principle of usability/ease of use: users that will encode
their timesheets don't have a clue of what are those fields! they should be
invisible but pre-configured with default
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-724201-ara
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724201-ara/+merge/52406
--
Review: Disapprove
rejected, for the reason depicted on the bug report
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728858-ara/+merge/52806
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-728858-ara.
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728858-ara
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728858-ara/+merge/52806
--
Review: Needs Fixing
seems really a weird fix...
you should try by doing res = {} at the beginning of the function and doing
-return res
+return res
at the end (decrease the indentation of last line of this function)
--
i agree with Bogdan Stanciu. Please update your merge proposal accordingly.
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-729602-ara/+merge/52684
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-729602-ara.
Review: Needs Fixing
it's not working. I guess my suggestion wasn't good. Did you test at your side?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660
Your team OpenERP RD Team is subscribed to branch
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660
--
as discussed with xrg, i'm rejecting this merge proposal that have been done
only for testing purpose.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730562-xrg/+merge/52419
Your team OpenERP RD Team is subscribed to branch
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-730562-xrg
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730562-xrg/+merge/52419
--
i'm rejecting for the sake of clarity in my merge proposal list although i
didn't found any mistake (yet :p), but i have several other improvements to
discuss with you, Rucha.
In particular, our specifications weren't good when saying: on the module list,
one click = one installed module.
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-configuration-rework into
lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework/+merge/53208
--
i commited in that branch how to properly use the set type. Please have a look
Ashvin. By the way, why don't i see Mustufa as reviewer?
Anyway, i merged this branch with my fix
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-740353-ara/+merge/54669
Your team OpenERP RD
qdp (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/qdp-l10n_us into
lp:~openerp-dev/openobject-addons/dsh-l10n_us.
Requested reviews:
dsh (Open ERP) (dsh-openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/qdp-l10n_us/+merge/55141
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa
into lp:openobject-addons has been updated.
Status: Merged = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695
--
bugfix was invalid
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa.
___
Mailing list:
Review: Disapprove
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa.
___
Mailing list:
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa
into lp:openobject-addons has been updated.
Status: Merged = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739181-rpa/+merge/54812
--
Review: Disapprove
actually, the bug was invalid.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739181-rpa/+merge/54812
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa.
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa
into lp:openobject-addons has been updated.
Status: Merged = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691
--
Review: Disapprove
fix reverted, ass the bug was invalid.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa.
Review: Approve
after a fast review it seems correct
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-demo-data-mtr/+merge/57161
Your team OpenERP RD Team is requested to review the proposed merge of
lp:~openerp-dev/openobject-addons/trunk-payroll-demo-data-mtr into
qdp (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into
lp:openobject-addons.
Requested reviews:
Olivier Dony (OpenERP) (odo)
Related bugs:
Bug #744789 in OpenERP Addons: [V6] Third party ledger : Initial Balance
https://bugs.launchpad.net/openobject
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-746422-pso
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-746422-pso/+merge/55896
--
Review: Approve
don't forget to include the context in the browse next time ;-)
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739562-skh/+merge/56343
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-739562-skh.
Review: Disapprove
it's not the proper way to fix. The bug purpose is about: we shouldn't see
computed fields when going in list view of leave types in configuration.
So we should define a new list view without the fields:
field name=max_leaves/
field
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/56516
--
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-755609-pso
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-755609-pso/+merge/57140
--
Review: Needs Information
what's the link with the bug report?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-716300-ara/+merge/57670
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-716300-ara.
Review: Needs Fixing
not a good idea, set ondelete=cascade on the field move_id of
aaccount.analytic.line please
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-746544-ara/+merge/55924
Your team OpenERP RD Team is subscribed to branch
what is that???
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-configuration-rework.
___
Mailing list:
wtf?
can someone exaplin me what this have to do with config-rework?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59019
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-configuration-rework.
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp
into lp:openobject-addons has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334
--
Review: Needs Information
i'm waiting the validation by the bug reporter that your patch is doing the
trick, Panos. :-)
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-749958-xrg/+merge/58487
Your team OpenERP RD Team is subscribed to branch
Review: Needs Information
having just a fast look, i'm wondering about those lines:
6 def sum_cr(self):
7 if self.res_bl['type'] == _('Net Loss'):
8 - self.result_sum_cr += self.res_bl['balance']
9 + self.result_sum_dr += self.res_bl['balance']
we are in sum_cr method and
Review: Needs Fixing
patch for payroll is wrong: HR / Officer should be able to see all the payslips
of him or of employess for which he's the manager. But this will be addressed
in the RD project related to hr_payroll, so you can simply remove that hunk.
second path for timesheet is correct,
The proposal to merge
lp:~openerp-dev/openobject-server/trunk-configuration-rework into
lp:openobject-server has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework/+merge/53209
--
it's not yet ready and even not fully tested, so i reject it for the sake of
clarity ^^
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework/+merge/53209
Your team OpenERP RD Team is subscribed to branch
Review: Disapprove
i think this branch isn't stacked on the good one (should be the main project
branch, not the trunk-addons) and thus it's giving here a wrong diff.
Please Sudhir resubmit a correct branch so that we can see the diff directly.
Thanks
--
The proposal to merge
lp:~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus into
lp:~openerp-dev/openobject-server/trunk-configuration-rework has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Needs Fixing
ha yes, i didn't though to you could do it with simply a col=2. Great!
but not exatly what they want as usability :-s, as they want something i could
summary like this:
*The list of application is col=4 and each application name has a colspan of 2.
*under each installed
Review: Needs Fixing
cfr my comment in same proposal for server side
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59165
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-configuration-rework.
qdp (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into
lp:openobject-addons.
Requested reviews:
Purnendu Singh (OpenERP) (psi-tinyerp)
Olivier Dony (OpenERP) (odo)
Related bugs:
Bug #744789 in OpenERP Addons: [V6] Third party ledger : Initial
Review: Needs Fixing
it's not really meaningfull i think.
i'd prefer something like: The code of salary rules can be used as reference
in computation of other rules. In that case, it is case sensitive.
--
Review: Needs Fixing
few points to correct:
1) [2011-04-28 15:14:35,238][payroll_avr_28] WARNING:init:object
hr.payslip.groups (hr.payslip.groups) has no access rules!
2) when selecting a category, i should search for employees in that category
but also for employees in a category child of
Review: Approve
FYI: append() is twice as fast as list concatenation :-)
Well done!
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-rpa/+merge/59450
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-temporal-db.
similar patch already landed in trunk. SO i reject for the sake of clarity.
thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron.
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325
--
Review: Needs Information
i cannot reproduce this bug. Am i missing something?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-768430-ron/+merge/59170
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron.
Review: Needs Information
bug has been passed back into confirmed status. Please check it
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron.
i fixed this: priority of new view set to 35 in order to low its priority
(should only be seen when in configuration\holidays\leave type
it's merged now
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/58634
Your team OpenERP RD Team is subscribed to
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh
into lp:openobject-addons has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/58634
--
Review: Needs Fixing
you cannot use voucher.account_id as this account is already used for the
counter part (its meaningless to use the same account for both the debit the
credit of the same operation).
Instead, use the default accounts defined on the journal accordingly if the
move will be a
next time: don't forget to encapsulate your strings with _(my string) in
order to enable the translation for it.
I fixed and merged it.
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-759444-skh/+merge/59458
Your team OpenERP RD Team is subscribed to branch
Review: Needs Fixing
for this bug, i'm not sure this is the god way to solve the problem. I would
have prefer to have a new fields.float to save the percentage used t compute
the amount in company currency, then in the _get_amount function we can just
call super() and apply this percentage to
don't you find it's really confusing to use a variable named stock_dest_id for
the source or stock move??
i made my own fix for that (and it's already merged so this branch is rejected
although it contains a working fix), which is similar but with better variable
names.
Think about that
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-753835-ara
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-753835-ara/+merge/56884
--
Review: Needs Fixing
i checked and for me it's solving all the known problems of the partner ledger.
The only problem with this merge proposal is that it is creating error in yaml
test because of the new constraint we've added.
[2011-05-04 14:46:25,524][trunk_mai_03] INFO:init:module account:
while testing i found out that there was another bug: if i select the periods
from 01/2011 - 05/2011 it was displaying also the opening entries though it
should have been added in the initial balance.
So i used this branch to fix that too. ;-)
It will be merged into the trunk as soon as the
a last thought: we should replace the boolean 'include reconciled entries' by a
fourth option in the filter selection box Unreconciled Entries.
So, the 4 options would be:
filter by: No filter
filter by: Date
filter by: Periods
filter by: Unreconciled Entries
so that we will be sure that the
Review: Approve
i aproove and set Olivier as reviewer (in order to clean my merge proposal
list) and as we are waiting for his patch server side.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-715470-ara/+merge/51288
Your team OpenERP RD Team is subscribed to branch
why did you removed average_price from view?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-748178-pso/+merge/57449
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-748178-pso.
___
Review: Approve
i remember the problem, :-)
it's cool like this
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-748178-pso/+merge/57449
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-748178-pso.
Review: Needs Fixing
in hr_payroll/wizard/hr_payroll_payslips_by_employees.py, abuot lines 335-346:
the behavior seems really weird to me: you call the onchange with [] as ids,
then create the payslip, then create the input lines...
you can do everything in one operation in you pass the good
Review: Needs Fixing
no, it needs fixing: we need to take into account also if the payslip is a
credite note or not: in that case it should subtract pl.total
so i didn't merged it, and thus you will be very nice to include in your next
try the change i proposed above. ;-)
Thanks,
Quentin
--
Review: Needs Fixing
i just realized: we should take care to rename it into salary rule category
instead of salary category :-s
sorry for the double-work
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr/+merge/60498
Your team OpenERP RD Team is
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr into
lp:~openerp-dev/openobject-addons/trunk-payroll has been updated.
Status: Merged = Rejected
For more details, see:
Review: Needs Fixing
few comments, just by reading the diff:
line 21-22 of the diff are useless as context isn't used later in the code of
the function. Can be removed for better readability.
line 24: why this ids.reverse()? is it to treat the case where we have records
A,B,C respectively in
Review: Needs Information
i don't know the tempfile python module.
+ tempfileid, tempfilename= tempfile.mkstemp('.rml', 'openerp_')
will it work with any Operating System?
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-server-ksa/+merge/59346
Your team OpenERP
i merged another branch that i made but which is based on this one. so i'm
rejecting this merge proposal to clear my pending merge to do list
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-mtr/+merge/60745
Your team OpenERP RD Team is subscribed to
The proposal to merge
lp:~openerp-dev/openobject-addons/trunk-payroll-account-mtr into
lp:~openerp-dev/openobject-addons/trunk-payroll has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Needs Fixing
use multi='address' in every new functional fields that could be computed in
the same time.
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa/+merge/60784
Your team OpenERP RD Team is subscribed to branch
Review: Needs Fixing
another enhancement: use the first _default_ address instead of the first
address. For that, use the address_get function defined on res.partner object.
Thanks
--
it's merged, the res_model had to be changed as well
thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa/+merge/60783
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-configuration-rework.
Review: Needs Fixing
67 + # avoid creating history records when writing on a reocrd that is
already an history record
68 + if record.temporal_parent_id:
69 + return False
replace the return False statement with continue
--
Review: Needs Fixing
i do not agree: when you holiday request is refused, you want to know who
(which manager) refused it. So we need to save the user that press the refuse
button.
Moreover, previously it was saving the refusing manager always in the same
field whatever if it was already
Review: Needs Information
i should already have fixed that 2 weeks ago, so i'm rejecting this merge prop
for the sake of clarity in LP. Please resubmit if the bug is confirmed again.
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730885-skh/+merge/55318
Your team
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-730885-skh
into lp:openobject-addons has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730885-skh/+merge/55318
--
1 - 100 of 128 matches
Mail list logo
