This patch adds support for of_platform_driver to the ipmi_si module.
When loading the module, the driver will be registered to of_platform.
The driver will be probed for all devices with the type ipmi. It's supporting
devices with compatible settings ipmi-kcs, ipmi-smic and ipmi-bt.
Only ipmi-kcs
+static int __devexit ipmi_of_remove(struct of_device *dev)
+{
+/* should call
+ * cleanup_one_si(dev-dev.driver_data); */
+return 0;
+}
If your remove doesn't work, don't implement one.
As explained before, it's the underlying thing that doesn't
work. Yeah someone should fix
Hi,
I just recognized, that the forward declaration is in the tree, so I'll send an
updated version with the cleanup call.
Tschuss,
ck
On Thu, 25 Jan 2007 01:29:48 +0100
Segher Boessenkool [EMAIL PROTECTED] wrote:
+static int __devexit ipmi_of_remove(struct of_device *dev)
+{
+ /*
On Thu, 2007-01-25 at 01:29 +0100, Segher Boessenkool wrote:
+static int __devexit ipmi_of_remove(struct of_device *dev)
+{
+ /* should call
+ * cleanup_one_si(dev-dev.driver_data); */
+ return 0;
+}
If your remove doesn't work, don't implement one.
As explained before, it's
+static int __devexit ipmi_of_remove(struct of_device *dev)
+{
+ /* should call
+ * cleanup_one_si(dev-dev.driver_data); */
+ return 0;
+}
If your remove doesn't work, don't implement one.
As explained before, it's the underlying thing that doesn't
work. Yeah someone should fix it
On Thursday 25 January 2007 01:45, Benjamin Herrenschmidt wrote:
If the underlying ipmi stuff cannot cleanup, then the driver should not
have a module_exit() so the module cannot be removed.
It can do the cleanup, but it won't go through the driver's remove
function currently, because it also
