[Openipmi-developer] [PATCH 2/3] ipmi: kcs: Finish configuring ASPEED KCS device before enable

2019-12-03 Thread Andrew Jeffery
The currently interrupts are configured after the channel was enabled. Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley Reviewed-by: Haiyue Wang --- drivers/char/ipmi/kcs_bmc_aspeed.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/char/ipmi/kcs_bmc_as

[Openipmi-developer] [PATCH 3/3] ipmi: kcs: aspeed: Implement v2 bindings

2019-12-03 Thread Andrew Jeffery
The v2 bindings allow us to extract the resources from the devicetree. The table in the driver is retained to derive the channel index, which removes the need for kcs_chan property from the v1 bindings. The v2 bindings allow us to reduce the number of warnings generated by the existing devicetree n

[Openipmi-developer] [PATCH 0/3] ipmi: kcs-bmc: Rework bindings to clean up DT warnings

2019-12-03 Thread Andrew Jeffery
Hello, This is a short series reworking the devicetree binding and driver for the ASPEED BMC KCS devices. With the number of supported ASPEED BMC devicetrees the changes enable removal of more than 100 lines of warning output from dtc. These changes are extracted from an RFC series posted previou

[Openipmi-developer] [PATCH 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS

2019-12-03 Thread Andrew Jeffery
The v2 binding utilises reg and renames some of the v1 properties. Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt | 20 +--- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt

Re: [Openipmi-developer] [PATCH 2/3] ipmi: kcs: Finish configuring ASPEED KCS device before enable

2019-12-03 Thread Corey Minyard
On Tue, Dec 03, 2019 at 11:08:24PM +1030, Andrew Jeffery wrote: > The currently interrupts are configured after the channel was enabled. How about: The interrupts were configured after the channel was enabled, configure them before so they will work. -corey > > Signed-off-by: Andrew Jeffery >

Re: [Openipmi-developer] [PATCH 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS

2019-12-03 Thread Rob Herring
On Tue, Dec 3, 2019 at 6:36 AM Andrew Jeffery wrote: > > The v2 binding utilises reg and renames some of the v1 properties. > > Signed-off-by: Andrew Jeffery > --- > Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt | 20 +--- > 1 file changed, 14 insertions(+), 6 deletions(-) > > di