[10] Review request: 8186642: Assertion error if output application already exists

Kevin, Please review the changes about fixing "AssertionError: Duplicate entry". JIRA: https://bugs.openjdk.java.net/browse/JDK-8186642 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8186642/webrev.00/ --Victor

[10] Review request for 8191515: Add ToolProvider support for Java Packager

Hi Victor, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8191515 Added ToolProvider for Java Packager. Thanks, Alexander

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

Correction: Adding ""--add-exports javafx.graphics/javafx.scene.robot=ALL-UNNAMED" to buildSrc/addExports. For posterity :) On Mon, Dec 4, 2017 at 6:08 PM, Michael Ennen wrote: > Ah, indeed, missed adding "--add-opens > javafx.graphics/javafx.scene.robot=ALL-UNNAMED" >

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

Ah, indeed, missed adding "--add-opens javafx.graphics/javafx.scene.robot=ALL-UNNAMED" to buildSrc/addExports. Thanks for the guidance on that. I will continue to work on this in the GitHub repo and polish it up (add javadocs, better method signatures, etc.) and even plan on maybe improving the

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

This is a limitation of the the way --patch-modules works. You will need to add an entry in: buildSrc/addExports Btw, as for the proposal itself, this might need to be a JEP depending on the scope. In any case, it could be considered in the JDK 11 time frame, but there are several things

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

Currently I am stuck with tests not being able to see the new "javafx.scene.robot" module: > Task :systemTests:compileTestJava C:\Users\brcolow\dev\openjfx\tests\system\src\test\java\test\robot\com\sun\glass\ui\monocle\ModalDialogTest.java:34: error: package javafx.scene.robot is not visible

[10] Review request: 8192874: Update location of Oracle modifications to third-party LGPL source code

Hi Phil, Can you please review the following: https://bugs.openjdk.java.net/browse/JDK-8192874 http://cr.openjdk.java.net/~kcr/8192874/webrev.00/ Thanks. -- Kevin

PLEASE READ: New OpenJFX dev repo is open for business

All, The new OpenJFX developer repo, jfx-dev/rt, is now open. Effective immediately, changesets for FX 10 (and beyond) should be pushed to: http://hg.openjdk.java.net/openjfx/jfx-dev/rt You can edit your .hg/hgrc files to point to this new repo (no need to reclone your repo, although you

Re: javapackager feedback and questions

Hi Victor, I have raised an issue on JBS via http://bugreport.java.com/ for this (ID given to me *9051766*): > Looks like there is a bug when you specify systemWide=true on the MacOSX in non-gui mode. I don't have an account on it, so I might not be able to amend or add new details to it. If I

Re: [10] Review request: 8179033: javapackager fails to create Mac Application Bundle

> On Dec 3, 2017, at 11:12 PM, victor.droz...@oracle.com wrote: > >> >> >> > writeEntry() is supposed to be used for the operations where we need to > create a directory and then do Files.copy(). I see no reason to avoid using > it here. Linux bundler is also implemented this way. > This