Re: Building OpenJFX.

2017-12-19 Thread Kevin Rushforth
So making gradlew optional seems best then, if added. -- Kevin Mario Torre wrote: 2017-12-19 23:04 GMT+01:00 Scott Palmer : The project should be configured to use the Gradle Wrapper, so the correct version of Gradle is used automatically. This is not an option for Linux distributi

Re: Building OpenJFX.

2017-12-19 Thread Tom Schindl
Hi Phil, As I've went through the (painful) process of getting OpenJFX build on Windows (without the Webkit part) for a Build-Dummy like myself I've documented those steps 1 by 1 - https://github.com/BestSolution-at/openjfx-build/blob/master/README.md Tom Am 2017-12-19 21:11, schrieb Phil R

Re: Building OpenJFX.

2017-12-19 Thread Kevin Rushforth
Yes, if I do nothing else before Christmas I will update the per-platform instructions for the three platforms (especially Windows) to be current. For Windows, the current compiler is VS 2017. -- Kevin Chris Newland wrote: Hi Phil, Would it be possible to update the Windows build instructio

Re: Building OpenJFX.

2017-12-19 Thread Scott Palmer
> On Dec 19, 2017, at 5:13 PM, Mario Torre > wrote: > > 2017-12-19 23:04 GMT+01:00 Scott Palmer : >> The project should be configured to use the Gradle Wrapper, so the correct >> version of Gradle is used automatically. > > This is not an option for Linux distributions and is not an option f

Re: Building OpenJFX.

2017-12-19 Thread Kevin Rushforth
While I doubt such issues are “real” I understand that you have to deal with Oracle lawyers. It might be worth asking again to see whether there are any concerns. If we can address them, then maybe this is the way to go. Perhaps a solution then is to configure the wrapper via a setup step

Re: Building OpenJFX.

2017-12-19 Thread Chris Newland
Hi Phil, Would it be possible to update the Windows build instructions? Getting VS10 and SDKs from 2010 to work on a Windows 10 build machine isn't much fun. Thanks, Chris On Tue, December 19, 2017 20:11, Phil Race wrote: > In the "innovation" email thread it was suggested that one obstacle t

Re: Building OpenJFX.

2017-12-19 Thread Mario Torre
2017-12-19 23:04 GMT+01:00 Scott Palmer : > The project should be configured to use the Gradle Wrapper, so the correct > version of Gradle is used automatically. This is not an option for Linux distributions and is not an option for many people using them. We need to be able to produce a build wi

Re: Building OpenJFX.

2017-12-19 Thread Scott Palmer
The project should be configured to use the Gradle Wrapper, so the correct version of Gradle is used automatically. https://docs.gradle.org/current/userguide/gradle_wrapper.html There was some concern about checking in the gradle-wr

Re: Building OpenJFX.

2017-12-19 Thread Johan Vos
To be honest, building OpenJFX is the least of my worries. Compared with other frameworks, building OpenJFX is extremely easy and well-documented. The wiki pages are still mostly accurate. I agree with Mario about the webkit: that is the biggest pain imho. The fact that a bunch of code is dropped

Re: Building OpenJFX.

2017-12-19 Thread Kevin Rushforth
Building WebKit is challenging, to be sure. I hope to enlist the help of some of our WebKit team members to review (and contribute to) update build instructions to help make it a little less painful, but it is still a challenge. As for the moving version of gradle, we so far have settled on a

Re: Building OpenJFX.

2017-12-19 Thread Mario Torre
For me the most intricate part is about building the webkit based code, especially on RHEL/CentOS. I admit I didn't try with the very latest code drop though. The moving version of Gradle is also an issue, since we try to use a stable toolchain on those OSes. Cheers, Mario 2017-12-19 21:11 GMT+01

Re: Building OpenJFX.

2017-12-19 Thread Laurent Bourgès
Phil, I am using ubuntu 17.4 (soon will upgrade to 17.10) and gcc 6 is the default compiler. I submitted a jfx bug as I had to fix some c code (wait call) and ignore warnings (as error) to build OpenJFX / JDK 10 on gcc6. I may help fixing some warnings but I am not an expert of javafx native code

Building OpenJFX.

2017-12-19 Thread Phil Race
In the "innovation" email thread it was suggested that one obstacle to getting involved and contributing to OpenJFX is just building it. So what are the top one or two pain points with building OpenJFX today ? - Insufficient or out-dated build docs ? - Tool-chain configuration problems - platfor

[10] Review request: 8193823: gradle test fails to run when using jdk-10+36 as boot JDK

2017-12-19 Thread Kevin Rushforth
Phil, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8193823 http://cr.openjdk.java.net/~kcr/8193823/webrev.00/ This will allow us to continue to build with the latest JDK and works around a gradle bug that was exposed with the time-based version string changes for JEP-