[openjfx11] Review request for 8203294: [Linux] Link libgcc and libstdc++ statically to support gcc-7.x

2018-05-21 Thread Arunprasad Rajkumar
Hi, Please review the following fix: http://cr.openjdk.java.net/~arajkumar/8203294/webrev Root cause: Currently C and C++ standard libraries are linked dynamically(except javafx.web), it may restrict the usage of javafx on old Linux distros when we upgrade to latest compiler(GCC 7.3?)

RFR: JDK-8090763/CSR JDK-8203409 - Make JavaFX Robot Part of JavaFX Public API

2018-05-21 Thread Michael Ennen
Hello all, Please review an enhancement to move the private Robot API into a new public javafx.scene.robot package. The internal com.sun.glass.ui.Robot class is removed as a result. Applications and test frameworks that reference this internal class will need to adapt to the new public API.

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

2018-05-21 Thread Nir Lisker
Fine by me. - Nir On Tue, May 22, 2018 at 12:29 AM, Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: > In that case, why don't I revert my changes and let you remove the > references after j.u.l is removed. > > -- Kevin > > > > On 5/21/2018 2:13 PM, Nir Lisker wrote: > > Since the packager

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

2018-05-21 Thread Kevin Rushforth
In that case, why don't I revert my changes and let you remove the references after j.u.l is removed. -- Kevin On 5/21/2018 2:13 PM, Nir Lisker wrote: Since the packager is being removed I don't see a reason to keep any references to it. In any case, the Eclipse files are planned to be

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

2018-05-21 Thread Nir Lisker
Since the packager is being removed I don't see a reason to keep any references to it. In any case, the Eclipse files are planned to be updated [1] after j.u.l. is removed [2]. [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-April/021740.html [2]

[11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

2018-05-21 Thread Kevin Rushforth
Phil or Ajit, Please review the following simple fix: https://bugs.openjdk.java.net/browse/JDK-8203378 http://cr.openjdk.java.net/~kcr/8203378/webrev.00/ This removes one qualified export from javafx.graphics to the no-longer-built jdk.packager module. More details in JBS. Note to Eclipse

[11] JDK-8200285 : TabDragPolicy.REORDER prevents ContextMenu from showing

2018-05-21 Thread Ambarish Rapte
Hi Kevin & Ajit, Please review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8200285/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8200285 Regards, Ambarish