Re: [11] RFR: Enhancement: JDK-8195811:Support FX Swing interop using public API

2018-07-06 Thread Kevin Rushforth
Most things are working with either mode (JDK 10 with qualified exports or JDK 11 without), although I do get a few test failures. There is a serious issue with leakage into the public API that needs to be addressed before worrying about the failures, but I'll list the test failures at the

Re: JavaFX 11 snapshots in maven sonatype

2018-07-06 Thread Michael Paus
Hi Johan, many thanks for the clarifications. Please find some more comments inline: Am 06.07.18 um 14:54 schrieb Johan Vos: Hi Michael, Thanks for testing this. You can avoid downloading all platform jars by specifying the javafx.platform with maven: mvn -Djavafx.platform=mac clean

Re: JavaFX 11 snapshots in maven sonatype

2018-07-06 Thread Johan Vos
Hi Michael, Thanks for testing this. You can avoid downloading all platform jars by specifying the javafx.platform with maven: mvn -Djavafx.platform=mac clean package exec:java There is a rationale behind this: maven would be able to detect the OS and make sure only the platform jars related

Re: JavaFX 11 snapshots in maven sonatype

2018-07-06 Thread Johan Vos
That is a known issue indeed, but I think it should be fixed in Gradle. We can't easily upload all platforms using the same snapshot version, unless I'm missing something? We ran into this before, when working with nd4j SNAPSHOT versions on gradle. We "fixed" it by applying own plugin code, e.g.

Re: [11] RFR: Enhancement: JDK-8195811:Support FX Swing interop using public API

2018-07-06 Thread Kevin Rushforth
Thanks. As a note to reviewers, if you want to test the new functionality, and be able to run JavaFX swing interop applications without adding qualified exports, you will need to use a recent OpenJDK 11 ea build as the boot JDK. If you use OpenJDK 10, it will work no better (and hopefully no

Re: JavaFX 11 snapshots in maven sonatype

2018-07-06 Thread Michael Paus
Hi, I tried the examples on my Mac with Maven and with a simple     mvn clean package exec:java on the command line they all compiled and worked out of the box. Great work! I used OpenJDK 11ea20 for this. I have a few questions though: 1. I observed that maven downloaded all dependencies for

Review Request JDK-8187100 [JavaFX] To make display Variation Selectors(SVS/IVS) on Win(VISTA-) and MacOS(10.6-)

2018-07-06 Thread Nakajima Akira
Hi All. patch: https://github.com/javafxports/openjdk-jfx/pull/126 This is separated from http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-June/022005.html and modified to simple patch for Win(VISTA or later) and MacOS(10.6 or later). I checked on Windows7 and Windows10. But I

Re: [11] RFR: Enhancement: JDK-8195811:Support FX Swing interop using public API

2018-07-06 Thread Prasanta Sadhukhan
My Bad. Please find modified webrev restoring the filter http://cr.openjdk.java.net/~psadhukhan/fxswinterop/webrev.4/ Regards Prasanta On 7/6/2018 6:47 AM, Kevin Rushforth wrote: One quick comment: This no longer compiles with OpenJDK10. It looks like the logic to optionally filter out