Review Request: JDK-8226850: Use an EnumSet for DirtyBits instead of an ordinal-based mask

2019-07-09 Thread Nir Lisker
Hi Kevin/Ambarish, Please review the simple fix for: https://bugs.openjdk.java.net/browse/JDK-8226850 http://cr.openjdk.java.net/~nlisker/8226850/webrev.00/ Thanks, Nir

Re: Javapackager 10 to bundle OpenJDK 11 runtime

2019-07-09 Thread Alan White
Apologies for the spam. This was my issue, I got confused renewing my certs, as to which one did what. Apple have not changed the prefix, and despite warnings about notarising, it seems to all work. Just wish there weren’t so many cert types flying around to sign an app! Meantime, crisis over

[14] RFR: JDK-8226365: Change JavaFX release version to 14

2019-07-09 Thread Kevin Rushforth
Please review the following to bump the JavaFX release version in jfx-dev to 14: https://bugs.openjdk.java.net/browse/JDK-8226365 https://github.com/javafxports/openjdk-jfx/pull/523 -- Kevin

OpenJFX 13 is in Rampdown Phase One (RDP1)

2019-07-09 Thread Kevin Rushforth
OpenJFX 13 is now in Rampdown Phase One RDP1 [1]. We have forked a new jfx-13/rt repo [2] for stabilizing the OpenJFX 13 release. Here is the short summary of what this means: - The openjfx/13-dev/rt repo is now open for pushing changesets for FX 13 that meet the RDP1 criteria as outlined

[RFR] JDK-8223760: allow to build static libs

2019-07-09 Thread Johan Vos
Hi Kevin, Please review the following PR: JBS: https://bugs.openjdk.java.net/browse/JDK-8223760 https://github.com/javafxports/openjdk-jfx/pull/470 Thanks, - Johan

Re: Windows (32bit) build problems

2019-07-09 Thread Robert Lichtenberger
After restarting from scratch (on a different machine) the build problems described below simply went away :-). So there was probably something in my environment or I changed something inadvertently. Best regards, Robert Am 08.07.19 um 08:13 schrieb Robert Lichtenberger: > Am 05.07.19 um 11:32

Re: Table data entry

2019-07-09 Thread Kevin Rushforth
The JBS bug is: https://bugs.openjdk.java.net/browse/JDK-8089514 The current status is still as Jonathan described it. This would be a very good enhancement to have, but it will require a fair bit of work to drive consensus on the best way to define and implement this, and then to finish it.

[RFR] [openjfx13] 8227431: [Windows] Fix assertion failure on X86 32-bit when enabling CLOOP based JavaScript interpreter

2019-07-09 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/525 Thanks, Arun

[RFR] [openjfx13] 8222912: Websocket client doesn't work in WebView

2019-07-09 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following PR, JBS: https://bugs.openjdk.java.net/browse/JDK-8222912 https://github.com/javafxports/openjdk-jfx/pull/524 Thanks, Arun

Re: Table data entry

2019-07-09 Thread Jonathan Giles
It was never merged. It exists somewhere in JBS as a patch file or webrev link. The API was decent (IMHO), but not completely implemented (and nor did everyone agree with my opinion). It worked for simple cases (i.e. ListCell, TreeCell, TableCell, and TreeTableCell), but probably needed more

Table data entry

2019-07-09 Thread Tom Eugelink
There is a chance that I may need to start a complete rewrite of a Swing client, of course I'm considering JavaFX, but only if I can do efficient data entry in tables. This means: enter commits value and moves focus to another (not necessarily the next) cell. AFAIK one of the requirements is