Re: genVSproperties.bat: why unset variables?

2019-10-07 Thread Michael Ennen
Ilya, I also had trouble with genVSproperties.bat (as did other historically) This led me to create a Powershell build script which was merged to upstream: https://github.com/openjdk/jfx/blob/master/tools/scripts/build.ps1 I strongly recommend using it when building locally on Windows. On

genVSproperties.bat: why unset variables?

2019-10-07 Thread Ilya Kazakevich
Hello. I was trying to build jfx for Windows using cygwin. I launched cygwin from VS prompt with all variables set, but when build failed, I realized that ``windows_tools.properties`` is almost empty. It happened because ``genVSproperties.bat`` failed to locate my toolchain and it explicitly

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-07 Thread Kenzie Togami
On Mon, 7 Oct 2019 17:30:11 GMT, Kevin Rushforth wrote: > On Mon, 7 Oct 2019 13:35:51 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> buildSrc/crosslibs-armv6hf.sh pulls down debian and raspbian packages to be >> able to cross compile javafx for arm hard float. Up

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-07 Thread Kevin Rushforth
On Mon, 7 Oct 2019 13:35:51 GMT, Dell Green <12861109+dellgr...@users.noreply.github.com> wrote: > buildSrc/crosslibs-armv6hf.sh pulls down debian and raspbian packages to be > able to cross compile javafx for arm hard float. Up to now the upstream > distribution versions have been debian and

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-07 Thread Kevin Rushforth
On Mon, 7 Oct 2019 13:35:52 GMT, Dell Green <12861109+dellgr...@users.noreply.github.com> wrote: > On Mon, 7 Oct 2019 13:35:51 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> buildSrc/crosslibs-armv6hf.sh pulls down debian and raspbian packages to be >> able to

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-07 Thread Kevin Rushforth
On Mon, 7 Oct 2019 17:22:29 GMT, Kevin Rushforth wrote: > On Mon, 7 Oct 2019 13:35:52 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> On Mon, 7 Oct 2019 13:35:51 GMT, Dell Green >> <12861109+dellgr...@users.noreply.github.com> wrote: >> >>>

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-07 Thread Jeanette Winzenburg
On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > Allright, this is a fix for JDK-8207957 > > > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-07 Thread Jeanette Winzenburg
On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > Allright, this is a fix for JDK-8207957 > > > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor