On Wed, 11 Dec 2019 01:04:15 GMT, Scott Palmer wrote:
>> As a follow-on point to the missing public method in TextFlow, can you add
>> unit tests for the API methods on both `Text` and `TextFlow`? A good way to
>> do that is to have a test for all combinations of setting the value via the
>> s
On Wed, 11 Dec 2019 01:18:55 GMT, Ambarish Rapte wrote:
>> Need for the change
>> [[JDK-8227808](https://bugs.openjdk.java.net/browse/JDK-8227808)]:
>> Currently GTK3 is the default on Linux. However, there is build logic that
>> will skip building glassgtk3 if the gtk3 development libraries ar
On Wed, 11 Dec 2019 01:18:42 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
>
This will also need a second review from @johanvos
-
PR: https://git.openjdk.java.net/jfx/pull/61
On Tue, 10 Dec 2019 23:51:48 GMT, Kevin Rushforth wrote:
>>> Should this PR also add a tabSize property to controls such as TextArea? Or
>>> should that be a different PR after this one is merged?
>>
>> This would need to be a new enhancement and would first need to be discussed
>> on the open
> https://bugs.openjdk.java.net/browse/JDK-8225571
>
> To run tests (on the root of the source tree):
> ./gradlew apps
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDropWithControls
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDr
> https://bugs.openjdk.java.net/browse/JDK-8225571
>
> To run tests (on the root of the source tree):
> ./gradlew apps
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDropWithControls
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDr
> https://bugs.openjdk.java.net/browse/JDK-8225571
>
> To run tests (on the root of the source tree):
> ./gradlew apps
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDropWithControls
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDr
On Mon, 9 Dec 2019 23:20:19 GMT, Hadzic Samir wrote:
>> I would like both @aghaisas and myself to review / approve this. I will
>> sponsor it.
>>
>> In addition, the CSR needs to be approved before this can be integrated.
>
> Thanks for the review. I do not have access to a computer right now,
On Wed, 27 Nov 2019 10:51:10 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1895:
>>
>>> 1894: }
>>> 1895: @Override public void set(int v) { super.set((v <
>>> 1) ? 1 : v); }
>>> 1896:
On Tue, 10 Dec 2019 23:53:27 GMT, Kevin Rushforth wrote:
>> @kevinrushforth I changed that behaviour. Since the drag does not complete i
>> find it counter-intuitive to send the DRAG_DONE event.
>>
>> Does it send the event on other platforms? I can test on Windows.
>>
>> Will look into the as
On Tue, 10 Dec 2019 19:41:05 GMT, Thiago Milczarek Sayao
wrote:
>> I'm starting to look at this. I see at least one behavioral difference that
>> will need to be addressed. With the existing implementation, if I drag /
>> drop onto a target that set up to receive the drop, the transfer complet
On Tue, 10 Dec 2019 18:54:08 GMT, Kevin Rushforth wrote:
>> Overall this looks good to me with one "must fix" API issue and one
>> additional minor comment.
>>
>> In addition to the automated unit test, it might be nice to have a simple
>> app (in `apps/toys`) with a slider to control the tab
As a reminder, RDP1 for JavaFX 14 starts on January 6, 2020 (at 23:59
Pacific time).
With the holidays approaching, please allow sufficient time for any
feature that needs a CSR. New features should be far enough along in the
review process so you can finalize the CSR before next Friday, Dec 2
On Tue, 10 Dec 2019 16:13:06 GMT, Kevin Rushforth wrote:
>> Just a reminder to take a look when time allows.
>
> I'm starting to look at this. I see at least one behavioral difference that
> will need to be addressed. With the existing implementation, if I drag / drop
> onto a target that set
On Tue, 10 Dec 2019 18:37:50 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> Overall this looks good to me with one "must fix" API issue and one
> additional minor comment.
>
> In addition to the automated unit test, it might be nice to have a sim
On Tue, 10 Dec 2019 18:38:04 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
Overall this looks good t
On Tue, 10 Dec 2019 07:00:50 GMT, Ambarish Rapte wrote:
> Issue: NPE in GlassScene.frameRendered().
>
> Cause: scenePaintListener is set in setTKScenePaintListener(), used in
> frameRendered() and
> set to null in dispose().
> setTKScenePaintListener() and dispose() are called on JavaFX Applic
On Mon, 2 Dec 2019 11:09:05 GMT, Thiago Milczarek Sayao
wrote:
>> Preliminary review was here:
>> [javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490)
>
> Just a reminder to take a look when time allows.
I'm starting to look at this. I see at least one behav
On Tue, 10 Dec 2019 13:01:15 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextInputControlBehavior.java
>> line 626:
>>
>>> 625: protected void fire(KeyEvent event) { } // TODO move to
>>> TextFieldBehavior
>>> 626: pro
On Tue, 10 Dec 2019 12:03:03 GMT, Ajit Ghaisas wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextInputControlBehavior.java
> line 626:
>
>> 625: protected void fire(KeyEvent event) { } /
Yes, I see that it was transferred to the JDK project yesterday evening
(or early morning today depending on your time zone). Usually it happens
within a day or so, but sometimes there is a delay. Btw, if there is one
that you or anyone else has submitted that you are ready to contribute a
fix
On Tue, 10 Dec 2019 12:26:27 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
>
Well yes, it is indeed my bug report, thanks!
I can't find a response in my mailbox, and searching for it it didn't yield any
result (bug was created in JBS 9 hours ago; might not be indexed yet).
Anyway, it doesn't matter; I can now go forward with my PR.
Thanks again.
Fred.
- Mail origi
Hi,
maybe you lost the response mail or it went into your trash.
I guess this is your bug report in the JBS.
https://bugs.openjdk.java.net/browse/JDK-8235627
--Michael
Am 10.12.19 um 11:33 schrieb thevenet.f...@free.fr:
Hi,
I've submitted bug report via https://bugreport.java.com/bugreport/ reg
Hi,
I've submitted bug report via https://bugreport.java.com/bugreport/ regarding
the issue below about a week ago but I haven't heard from it yet.
I understand this might not be the best place to inquire about it, but since
this prevents me from submitting a PR (as I don't have an issue number)
25 matches
Mail list logo
