Re: [Rev 18] RFR: 8236651: Simplify and update glass gtk backend

2020-02-03 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-02-03 Thread Thiago Milczarek Sayao
On Wed, 29 Jan 2020 12:16:49 GMT, Thiago Milczarek Sayao wrote: >> To anyone willing to test this, here is a binary test-release for linux: >> >> https://github.com/tsayao/jfx/releases/tag/test-glass-gtk > > It's ready for an initial look. > > If anyone has issues with Linux, I will fix it.

Re: [Integrated] RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

2020-02-03 Thread Kevin Rushforth
Changeset: 2ab40c1c Author:Kevin Rushforth Date: 2020-02-01 14:35:47 + URL: https://git.openjdk.java.net/jfx/commit/2ab40c1c 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina) Reviewed-by: prr, jvos !

Re: [Integrated] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-02-03 Thread Nir Lisker
Changeset: 1749e854 Author:Nir Lisker Date: 2020-02-03 12:29:43 + URL: https://git.openjdk.java.net/jfx/commit/1749e854 8237975: Non-embedded Animations do not play backwards after being paused Reviewed-by: kcr, arapte !

Re: [Integrated] RFR: 8237503: Update copyright header for files modified in 2020

2020-02-03 Thread Kevin Rushforth
Changeset: a4b9f24e Author:Kevin Rushforth Date: 2020-02-03 15:48:52 + URL: https://git.openjdk.java.net/jfx/commit/a4b9f24e 8237503: Update copyright header for files modified in 2020 Reviewed-by: arapte ! buildSrc/android.gradle !

Re: RFR: 8208761: Update constant collections to use the new immutable collections

2020-02-03 Thread Kevin Rushforth
On Sun, 2 Feb 2020 00:15:02 GMT, Nir Lisker wrote: > Resubmitting from before the transition to this repo. See linked issue for > details. Given the large number of changes, I'd like two reviewers to look it over for any possible typos. - PR:

Re: [Integrated] RFR: 8237503: Update copyright header for files modified in 2020

2020-02-03 Thread Kevin Rushforth
Changeset: a4b9f24e Author:Kevin Rushforth Date: 2020-02-03 15:48:52 + URL: https://git.openjdk.java.net/jfx/commit/a4b9f24e 8237503: Update copyright header for files modified in 2020 Reviewed-by: arapte ! buildSrc/android.gradle !

Re: RFR: 8237503: Update copyright header for files modified in 2020

2020-02-03 Thread Ambarish Rapte
On Fri, 31 Jan 2020 23:32:55 GMT, Kevin Rushforth wrote: > Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to > update the "last modified" year in the copyright header for all files > modified in 2020 in the `jfx14` branch. > > NOTE: I'll update this to pick up any

Re: Question ad creating a testcase that needs a jar on class- or module path

2020-02-03 Thread Rony G. Flatscher
Hi Kevin, On 31.01.2020 16:38, Kevin Rushforth wrote: > And if you need a modular jar, you might look at ModuleLauncherTest instead. thank you very much for this important hint as well! Having no knowledge about gradle it will take me a while to research and digest, but this definitely helps

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

2020-02-03 Thread Rony G. Flatscher
Hi Kevin, On 29.01.2020 13:24, Kevin Rushforth wrote: > The RFE you filed is now available here: > > https://bugs.openjdk.java.net/browse/JDK-8238080 thank you very much! Cheers ---rony P.S.: Have not received any automatic notification e-mail so far.

Re: RFR: 8237503: Update copyright header for files modified in 2020

2020-02-03 Thread Kevin Rushforth
On Fri, 31 Jan 2020 23:32:55 GMT, Kevin Rushforth wrote: > Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to > update the "last modified" year in the copyright header for all files > modified in 2020 in the `jfx14` branch. > > NOTE: I'll update this to pick up any

Re: RFR: 8237503: Update copyright header for files modified in 2020

2020-02-03 Thread Ambarish Rapte
On Fri, 31 Jan 2020 23:34:02 GMT, Kevin Rushforth wrote: >> Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to >> update the "last modified" year in the copyright header for all files >> modified in 2020 in the `jfx14` branch. >> >> NOTE: I'll update this to pick up

RFR: 8237503: Update copyright header for files modified in 2020

2020-02-03 Thread Kevin Rushforth
Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to update the "last modified" year in the copyright header for all files modified in 2020 in the `jfx14` branch. NOTE: I'll update this to pick up any last-minute changes integrated to `jfx14` and then remove the WIP.

Re: [Integrated] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-02-03 Thread Nir Lisker
Changeset: 1749e854 Author:Nir Lisker Date: 2020-02-03 12:29:43 + URL: https://git.openjdk.java.net/jfx/commit/1749e854 8237975: Non-embedded Animations do not play backwards after being paused Reviewed-by: kcr, arapte !

Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-02-03 Thread Ambarish Rapte
On Mon, 3 Feb 2020 10:16:13 GMT, Nir Lisker wrote: >> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do >> not play backwards after being paused) has been split to deal with >> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not >>

Re: [Integrated] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-02-03 Thread Guru Hb
Changeset: aa91ebbb Author:Guru Hb Date: 2020-02-03 08:51:25 + URL: https://git.openjdk.java.net/jfx/commit/aa91ebbb 8237944: webview native cl "-m32" unknown option for windows 32-bit build Reviewed-by: kcr ! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm