On Thu, 13 Feb 2020 23:13:06 GMT, Kevin Rushforth wrote:
>> This patch removes the `finalize` methods from the `Property` classes in the
>> `javafx.base` module.
>>
>> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
>> methods -- `asObject` and `xProperty` --
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward
Hi Kevin,
Thanks for your comments.
I am about to push some code for this. I have used a linkedHashMap which stores
the listener and a count.
I have also updated the unit tests to test for the addListener and
removeListener behaviour in the case you register the same listener more than
once.
Whether or not the specification of notifying a listener multiple times
was intentional or driven by the implementation, it is part of the spec,
and some applications could be relying on it. I do agree that there is
no guarantee as to the order, which might simplify things. I can think
of two
On Fri, 14 Feb 2020 14:06:28 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java
>> line 152:
>>
>>> 151:
>>> 152: new KeyMapping(LEFT, (rtl? e -> selectRightCell() : e
>>> ->
> This patch removes the `finalize` methods from the `Property` classes in the
> `javafx.base` module.
>
> The `{Boolean,Double,Float,Int,Long}Property` classes each have a pair of
> methods -- `asObject` and `xProperty` -- that create a `Property`
> object from a primitive `XProperty`
On Fri, 14 Feb 2020 11:26:14 GMT, Jeanette Winzenburg
wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Modified unit tests in TableViewKeyInputTest to take
Hi Ben,
Thank you. That does indeed reproduce the problem for me on the 100th
iteration. I've attached your test program to the bug report.
-- Kevin
On 2/13/2020 11:22 PM, Peter, Benjamin wrote:
Hello Kevin,
sure, will do :-).
BEGIN
import java.util.List;
import
On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a
On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a
Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
Fix : Added the missed out RTL checks to the key mappings in
TableViewBehaviorBase class.
Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a
parameter. The Left/Right key press tests have been modified to
11 matches
Mail list logo
