Re: [Rev 31] RFR: 8236651: Simplify and update glass gtk backend

2020-03-24 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Thiago Milczarek Sayao
On Tue, 24 Mar 2020 11:45:28 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains five

Re: [Rev 01] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Thiago Milczarek Sayao
> Simple fix to remove annoying warnings. Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last

Re: [Rev 01] RFR: 8234471: Canvas in webview displayed with wrong scale on Windows

2020-03-24 Thread Kevin Rushforth
On Tue, 25 Feb 2020 07:11:43 GMT, Arun Joseph wrote: >> This bug can be reproduced when the screen resolution is at 125%, 150% and >> 175% for Windows, which correpsonds to >> `pixelScale` values of 1.25, 1.5 and 1.75, respectively. >> Issue: The rectangle inside canvas is rendered on

Re: RFR: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.

2020-03-24 Thread Kevin Rushforth
On Mon, 23 Mar 2020 22:42:54 GMT, Kevin Rushforth wrote: >> **Bug :** >> https://bugs.openjdk.java.net/browse/JDK-8089828 >> >> **Root Cause :** >> RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position >> calculation. >> >> **Fix :** >> Corrected code to consider

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-03-24 Thread Thiago Milczarek Sayao
On Tue, 3 Mar 2020 11:10:07 GMT, Thiago Milczarek Sayao wrote: >> This is going to need further discussion on the mailing list as indicated >> above, so it is still premature to review it >> (i.e., it should still be considered effectively a "WIP" until that >> discussion happens).

Re: RFR: 8236840: Memory leak when switching ButtonSkin

2020-03-24 Thread Kevin Rushforth
On Mon, 23 Mar 2020 23:40:39 GMT, Kevin Rushforth wrote: >> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which >> results in leaking the `ButtonSkin` itself when >> the `Button`'s skin is changed to a new `ButtonSkin`. Using a >> `WeakChangeListener` instead of

Re: [Rev 02] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-24 Thread Rony G. Flatscher
Kevin and Ajit, thank you very much for your reviews! Will apply the changes (including changing CRLF to LF) ASAP. ---rony On 23.03.2020 22:45, Kevin Rushforth wrote: > On Sat, 21 Mar 2020 19:19:18 GMT, Kevin Rushforth wrote: > >>> Rony G. Flatscher has updated the pull request incrementally

Re: RFR: 8241474: Build failing on Ubuntu 20.04

2020-03-24 Thread Kevin Rushforth
On Tue, 24 Mar 2020 12:10:03 GMT, Kevin Rushforth wrote: >> Small fix for building on ubuntu 20.04. > > Looks good. Thanks for fixing. @tsayao I will sponsor this for you. - PR: https://git.openjdk.java.net/jfx/pull/149

Re: RFR: 8241474: Build failing on Ubuntu 20.04

2020-03-24 Thread Kevin Rushforth
On Tue, 24 Mar 2020 01:28:04 GMT, Thiago Milczarek Sayao wrote: > Small fix for building on ubuntu 20.04. Looks good. Thanks for fixing. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/149

Re: RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-24 Thread Kevin Rushforth
On Tue, 24 Mar 2020 01:36:29 GMT, Thiago Milczarek Sayao wrote: > Simple fix to remove annoying warnings. The problem is that gcc, for whatever reason, started issuing a (useless) warning if you pass the `-Werror=implicit-function-declaration` option to gcc for C++ files. I don't like the

Re: ComboBox keypress discrepancy

2020-03-24 Thread Abhinay Agarwal
Hi All, I have traced out the root cause responsible for the discrepancy between the behavior of ComboBox in JavaFX 8 vs later version. It turns out the change is in ListViewBehavior and was made under JEP-253[1]. ListView is used as the PopupContent Node in ComboBox. In JDK 8, ListView