Re: Testing JavaFX with Java14 preview features

2020-04-19 Thread Nir Lisker
I managed to get it working by adding "--enable-preview" in several places, I'm not sure if they are all needed. There will be a test branch in my fork with the working build.grade. On Tue, Apr 14, 2020 at 4:35 AM Nir Lisker wrote: > It contains: > -source > 14 > -target > 14 > > Looks like

Re: Re: Windows Installation Instructions, All DLL Files Missing

2020-04-19 Thread Eric Bresie
Would jdeps help to see what dependencies are needed? Eric Bresie ebre...@gmail.com > On April 18, 2020 at 1:44:43 PM CDT, Michael Paus wrote: > Hi Christopher, > I do not know what your specific problem is but maybe you just have to > shift your goals a little bit. > Continuing like you did in

mailing list invite

2020-04-19 Thread Apurwa Agrawal
Hello Please add me to mailing list: apurw...@gmail.com Thanks and Regards Apurwa Agrawal

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-19 Thread Jesper Skov
On Sun, 19 Apr 2020 12:44:23 GMT, Jesper Skov wrote: >> I have failed getting web:tests to work. >> Both with java 11.0.7 and 14.0.0 (adoptajdk 14.0.1 not ready yet), I get the >> error below. >> >> And that is with both a locally built webkit, and the one from >>

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-19 Thread Jesper Skov
On Sun, 19 Apr 2020 12:42:09 GMT, Jesper Skov wrote: >> @kevinrushforth I tested by: >> ` >> bash ./gradlew clean all test -x :web:test >> ` >> I assumed that would do it. >> But I see use of ToggleButton in javafx.web, so that was clearly a faulty >> assumption. >> >> I will try to get

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-19 Thread Jesper Skov
On Sun, 19 Apr 2020 09:56:27 GMT, Jesper Skov wrote: >> The fix looks correct to me. Have you run all tests to ensure no regressions? >> >> I left a couple inline comments. > > @kevinrushforth I tested by: > ` > bash ./gradlew clean all test -x :web:test > ` > I assumed that would do it. > But

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-19 Thread Craig Cavanaugh
On Fri, 17 Apr 2020 10:42:30 GMT, Jeanette Winzenburg wrote: > repeating my comment from the [previous pull > request](https://github.com/openjdk/jfx/pull/136#issuecomment-608401086): > I don't think this is yet ready for a technical review - there are some more > basic questions that are not

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-19 Thread Jesper Skov
On Sat, 18 Apr 2020 16:04:34 GMT, Kevin Rushforth wrote: >> Jesper Skov has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Fail instead of print message >> - addedToggles list is final >> - Leave unrelated file alone > > The fix

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-19 Thread Jesper Skov
> Make the two ways of associating a ToggleButton with a ToggleGroup interact > correctly. > > This fixes https://bugs.openjdk.java.net/browse/JDK-8198402 Jesper Skov has updated the pull request incrementally with three additional commits since the last revision: - Fail instead of print

Re: RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-19 Thread Jesper Skov
On Sat, 18 Apr 2020 15:50:55 GMT, Kevin Rushforth wrote: >> Make the two ways of associating a ToggleButton with a ToggleGroup interact >> correctly. >> >> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402 > >

RFR: 8242077: Add information about HTTP/2 and HttpClient usage in WebEngine

2020-04-19 Thread Abhinay Agarwal
Update WebEngine's Javadoc to add information on how it switches to HttpClient instead of URLConnection in JavaFX 14 when used with JDK 12 or later. Identification the correct client is important as both these clients may offer different ways to achieve a task. One such task can be bypassing