Re: RFR: 8254049: Update WebView to public suffix list 2020-04-24 [v2]

2020-11-16 Thread Arun Joseph
> We should use the public_suffix_list.dat file in the JDK instead. Reading the > public_suffix_list.dat file is modified to be similar to > [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java). > If the file is not present,

RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException

2020-11-16 Thread Florian Kirmaier
Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added a unit-test for it. ticket: https://bugs.openjdk.java.net/browse/JDK-8256397 run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests "*MultipleSelectionModelImplTest*"` - Commit messages: -

RFR: JDK-8256397 MultipleSelectionModel throws IndexOutOfBoundException

2020-11-16 Thread Florian Kirmaier
Hi everyone, I've developed a fix for an exception in the MultipleSelectionModel. Can someone look into it? https://github.com/openjdk/jfx/pull/353 Greetings Florian Kirmaier

Re: RFR: 8256184: Openjfx build broken (Eclipse)

2020-11-16 Thread Jeanette Winzenburg
On Mon, 16 Nov 2020 11:52:23 GMT, Nir Lisker wrote: > > > I think that it should be fixed as part of this patch since it addresses > exactly the same issue from the same cause. perfectly valid (and what I would say as well ;) - but then I'm out - no intention to further fiddle with tooling t

Re: RFR: 8256184: Openjfx build broken (Eclipse)

2020-11-16 Thread Nir Lisker
On Mon, 16 Nov 2020 09:34:17 GMT, Jeanette Winzenburg wrote: >> These changes look fine, but do you not get errors on the test module too? >> `test.javafx.scene.InitialNodesMemoryLeakTest` uses `import >> test.util.memory.JMemoryBuddy;`; so does `VirtualFlowMemoryLeakTest`. > >> >> >> These

Re: RFR: 8256184: Openjfx build broken (Eclipse)

2020-11-16 Thread Jeanette Winzenburg
On Mon, 16 Nov 2020 08:32:30 GMT, Nir Lisker wrote: > > > These changes look fine, but do you not get errors on the test module too? > `test.javafx.scene.InitialNodesMemoryLeakTest` uses `import > test.util.memory.JMemoryBuddy;`; so does `VirtualFlowMemoryLeakTest`. Good point .. didn't not

Re: RFR: 8256184: Openjfx build broken (Eclipse)

2020-11-16 Thread Nir Lisker
On Thu, 12 Nov 2020 13:50:41 GMT, Kevin Rushforth wrote: >> Issue was broken build in Eclipse after fix of >> [JDK-8244297](https://bugs.openjdk.java.net/browse/JDK-8244297): >> >> - the new memory test class requires jdk.management/java.management >> - users of the test class (in controls) ne