On Thu, 12 Nov 2020 13:50:41 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Issue was broken build in Eclipse after fix of >> [JDK-8244297](https://bugs.openjdk.java.net/browse/JDK-8244297): >> >> - the new memory test class requires jdk.management/java.management >> - users of the test class (in controls) need access to its package >> >> Changed .classpath files in base and controls to fix this. > > The change looks reasonable to me, but since I don't use Eclipse it would be > better for someone who does to review. > @nlisker can you review this? These changes look fine, but do you not get errors on the test module too? `test.javafx.scene.InitialNodesMemoryLeakTest` uses `import test.util.memory.JMemoryBuddy;`; so does `VirtualFlowMemoryLeakTest`. ------------- PR: https://git.openjdk.java.net/jfx/pull/352
