Re: RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button

2021-04-05 Thread Marius Hanl
On Mon, 5 Apr 2021 23:01:25 GMT, Kevin Rushforth wrote: > > > I have one question on the fix (see below). Also, have you run all of the > unit tests (not just the new one)? I did run all the normal tests and ever dialog related system test. Everything passed. Isn't jcheck running all the tes

Re: RFR: 8263169: [macos] JavaFX windows open as tabs when system preference for documents is set

2021-04-05 Thread Pankaj Bansal
On Wed, 24 Mar 2021 13:38:27 GMT, Kevin Rushforth wrote: > If the macOS system settings for opening documents as tabs is set to > "Always", then all JavaFX windows, including Dialogs, are opened as tabs, > unless they are child windows (that is, a Window with an owner). > > This is a real prob

Re: RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button

2021-04-05 Thread Marius Hanl
On Mon, 5 Apr 2021 22:58:47 GMT, Kevin Rushforth wrote: >> When DialogPane#getButtonTypes().setAll() is called twice with the same >> argument(s), DialogPane#lookupButton does not return the node which is shown >> inside the button bar. >> This is due DialogPane adding two list change listeners

Integrated: 8262366: Update glib to version 2.66.7

2021-04-05 Thread Alexander Matveev
On Wed, 31 Mar 2021 05:15:20 GMT, Alexander Matveev wrote: > - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 > - One bug was discovered in updated GStreamer which was causing deadlock or > infinite loop during seek on macOS. See gstsystemclock.c for changes between > ifde

Re: RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button

2021-04-05 Thread Kevin Rushforth
On Thu, 18 Mar 2021 14:38:18 GMT, Marius Hanl wrote: > When DialogPane#getButtonTypes().setAll() is called twice with the same > argument(s), DialogPane#lookupButton does not return the node which is shown > inside the button bar. > This is due DialogPane adding two list change listeners to 'b

Re: RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false

2021-04-05 Thread Kevin Rushforth
On Sat, 3 Apr 2021 15:35:19 GMT, Florian Kirmaier wrote: > Fixing leak in ProgressIndicator when treeShowing is false I haven't run it yet, but noticed a couple things during a quick code review. modules/javafx.controls/src/main/java/javafx/scene/control/skin/ProgressIndicatorSkin.java line 74

Re: RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false

2021-04-05 Thread Kevin Rushforth
On Sat, 3 Apr 2021 15:56:12 GMT, Florian Kirmaier wrote: >> I think it's failing since a long time. But i haven't tested it. >> It must be, because before the other leak should "shadow" this leak. > > Before, ProgressIndicator was basically leaking every time, this is a very > rare special case.

Re: RFR: 8217955: Problems with touch input and JavaFX 11

2021-04-05 Thread Kevin Rushforth
On Mon, 5 Apr 2021 18:59:52 GMT, Jose Pereda wrote: > This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to > prevent touch events from being used instead of regular mouse events on Linux > platforms. Note that the touch events will be delivered as mouse > pressed/dragged ev

RFR: 8217955: Problems with touch input and JavaFX 11

2021-04-05 Thread Jose Pereda
This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to prevent touch events from being used instead of regular mouse events on Linux platforms. Note that the touch events will be delivered as mouse pressed/dragged events. Since we still compile with GTK 2.x the bit flag (that

Re: RFR: 8263169: [macos] JavaFX windows open as tabs when system preference for documents is set

2021-04-05 Thread Ajit Ghaisas
On Wed, 24 Mar 2021 13:38:27 GMT, Kevin Rushforth wrote: > If the macOS system settings for opening documents as tabs is set to > "Always", then all JavaFX windows, including Dialogs, are opened as tabs, > unless they are child windows (that is, a Window with an owner). > > This is a real prob

Re: RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button

2021-04-05 Thread Ajit Ghaisas
On Thu, 18 Mar 2021 14:38:18 GMT, Marius Hanl wrote: > When DialogPane#getButtonTypes().setAll() is called twice with the same > argument(s), DialogPane#lookupButton does not return the node which is shown > inside the button bar. > This is due DialogPane adding two list change listeners to 'b