On Thu, 13 May 2021 00:07:15 GMT, Michael Strauß wrote:
> This PR fixes an issue when building OpenJFX on Windows and command-line
> arguments contain paths with spaces.
>
> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to
> quotes being interpreted twice. This can
> This PR fixes the gradle deprecation warnings described in
> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates
> the JavaFX build to use gradle 7.0.1 as described in
> [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760). The minimum
> version of gradle
On Wed, 12 May 2021 14:54:09 GMT, Kevin Rushforth wrote:
> This PR fixes the gradle deprecation warnings described in
> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates
> the JavaFX build to use gradle 7.0.1 as described in
>
On Tue, 11 May 2021 01:17:32 GMT, John Neffenger wrote:
>> The Windows build calls a series of batch files to get the Visual Studio
>> paths and environment variables. The batch files are a black box: any
>> messages they print are discarded. If anything goes wrong, the only signs
>> are a
No, I don't like this option at all. This would just duplicate a lot of
API methods that would end up delegating to Color. And it would be much
worse to duplicate the color constants. This just doesn't seem like a
clean API approach.
-- Kevin
On 5/13/2021 8:41 AM, Michael Strauß wrote:
Another option could be to mirror the `Color` API in both `Border` and
`Background`, like in the following examples:
Color.rgb(125, 100, 75)
Border.rgb(125, 100, 75)
Background.rgb(125, 100, 75)
Color.gray(127)
Border.gray(127)
Background.gray(127)
Color.web("orange", 0.5)
Border.web("orange",
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote:
> A typo in one of the labels of Bidi text has been corrected. This is located
> in Samples > Controls > Text > Bidi
This pull request has now been integrated.
Changeset: 9e8c617a
Author:Manukumar V S
Committer: Pankaj Bansal
URL:
On Thu, 13 May 2021 11:48:38 GMT, Kevin Rushforth wrote:
>> A typo in one of the labels of Bidi text has been corrected. This is located
>> in Samples > Controls > Text > Bidi
>
> @manukumarvs since you have an entry in the [OpenJDK
> Census](https://openjdk.java.net/census#mvs), you can
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote:
> A typo in one of the labels of Bidi text has been corrected. This is located
> in Samples > Controls > Text > Bidi
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/500
Doesn't seem like that are any more opinions. How do you want to proceed?
On Tue, Apr 27, 2021 at 2:45 AM Kevin Rushforth
wrote:
> I would lean towards the simpler solution that Nir has proposed. I would
> like to be informed by what application developers want.
>
> -- Kevin
>
>
> On 4/26/2021
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote:
> A typo in one of the labels of Bidi text has been corrected. This is located
> in Samples > Controls > Text > Bidi
Marked as reviewed by pbansal (Committer).
-
PR: https://git.openjdk.java.net/jfx/pull/500
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote:
> A typo in one of the labels of Bidi text has been corrected. This is located
> in Samples > Controls > Text > Bidi
@manukumarvs since you have an entry in the [OpenJDK
Census](https://openjdk.java.net/census#mvs), you can instead file a
A typo in one of the labels of Bidi text has been corrected. This is located in
Samples > Controls > Text > Bidi
-
Commit messages:
- 8266516: One label typo in the properties for bi-directional text
Changes: https://git.openjdk.java.net/jfx/pull/500/files
Webrev:
On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> we now use a try
fix is analogous to similar issues for Tree/TableCell (combined
[JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) and
[JDK-8265206](https://bugs.openjdk.java.net/browse/JDK-8265206))
added tests that failed before and passed after the fix
note: this PR also adds two asserts
On Thu, 13 May 2021 10:57:17 GMT, Ajit Ghaisas wrote:
>> This PR replaces Class.newInstance() deprecated method with
>> Contructor.newinstance().
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix review comments
Marked
> This PR replaces Class.newInstance() deprecated method with
> Contructor.newinstance().
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
fix review comments
-
Changes:
- all:
On Wed, 12 May 2021 23:36:01 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix apps and unit tests
>
>
18 matches
Mail list logo
