I'd like to try to move this proposal forward, so here's a JEP-like
summary of the proposal:
Summary
---
Add the `javafx.scene.Node.focusVisible` property, as well as the
"focus-visible" CSS pseudoclass.
Motivation
--
The W3C CSS Selectors Level 4 specification defines three
focus-
On Sat, 5 Jun 2021 16:12:36 GMT, Kevin Rushforth wrote:
>> `resource` is never `null` at this point, and it is already trimmed. Also,
>> contrary to the comment, I cannot see this method being used anywhere in
>> tests, so I made it private.
>
> If that is guaranteed by all callers of this meth
On Sat, 5 Jun 2021 17:31:17 GMT, Michael Strauß wrote:
>> This PR adds support for loading images from [inline data
>> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
>> supported by web browsers. This enables developers to package small images
>> in CSS files, rathe
On Thu, 3 Jun 2021 15:54:08 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
On Fri, 4 Jun 2021 22:00:03 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
On Sat, 5 Jun 2021 15:52:01 GMT, Kevin Rushforth wrote:
>> My idea was to avoid repeatedly allocating a new String with the data
>> contained in the URI. Since `matchScheme` is called at least twice (maybe
>> more), that would be a total of at least three copies of the URI data until
>> we par
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS file
On Sat, 5 Jun 2021 17:10:29 GMT, John Hendrikx wrote:
>> Maybe add a brief comment to that effect?
>
> Ok clear thanks
I added a comment that explains that.
-
PR: https://git.openjdk.java.net/jfx/pull/508
On Sat, 22 May 2021 02:27:41 GMT, Nir Lisker wrote:
> Did you test the different `computeSpotlightFactor` methods in the shader? I
> got some 4 fps difference between the best and worst cases.
Here are the performance numbers on my Mac (using the discrete `AMD Radeon Pro
5300M` graphics chipse
On Sat, 5 Jun 2021 16:10:59 GMT, Kevin Rushforth wrote:
>> In this specific case, image loading has failed for some reason. The call to
>> `DataURI.tryParse` is only there to potentially call `DataURI.toString()`
>> for a truncated log output, instead of logging the entire `url` String. If
>>
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS file
On Sat, 5 Jun 2021 15:42:22 GMT, Michael Strauß wrote:
>> This PR adds support for loading images from [inline data
>> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
>> supported by web browsers. This enables developers to package small images
>> in CSS files, rathe
On Sat, 5 Jun 2021 15:44:38 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/converter/URLConverter.java
>> line 98:
>>
>>> 96: }
>>> 97:
>>> 98: private URL resolve(String stylesheetUrl, String resource) {
>>
>> Why was this change done? It seems unneces
On Sat, 5 Jun 2021 15:49:16 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.java
>> line 776:
>>
>>> 774: } else {
>>> 775: logger.warning("Error loading
>>> image: " + url);
On Sat, 5 Jun 2021 15:42:22 GMT, Michael Strauß wrote:
>> This PR adds support for loading images from [inline data
>> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
>> supported by web browsers. This enables developers to package small images
>> in CSS files, rathe
On Sat, 5 Jun 2021 15:08:29 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/DataURI.java line
>> 185:
>>
>>> 183:
>>> 184: return originalUri.substring(0, originalUri.length() -
>>> originalData.length())
>>> 185: + originalData.subs
On Sat, 5 Jun 2021 15:17:09 GMT, Michael Strauß wrote:
>> In that case, it might be clearer and simpler to just call `trim()` on the
>> input String before doing anything with it, unless there is a reason not to.
>
> My idea was to avoid repeatedly allocating a new String with the data
> contai
On Sat, 5 Jun 2021 08:21:14 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>> mo
On Fri, 4 Jun 2021 22:09:09 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS file
On Fri, 4 Jun 2021 22:14:12 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
On Sat, 5 Jun 2021 14:00:38 GMT, Kevin Rushforth wrote:
> This is a clean backport of a GStreamer audio fix for a regression caused by
> the recent GStreamer 1.18.3 update in
> [JDK-8262365](https://bugs.openjdk.java.net/browse/JDK-8262365). I tested it
> on all three platforms.
This pull req
On Fri, 4 Jun 2021 22:06:31 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
On Sat, 5 Jun 2021 15:07:36 GMT, Kevin Rushforth wrote:
>> I implemented it in this way so that this requirement is not imposed onto
>> the caller, similar to `java.net.URL` does not impose this requirement onto
>> its callers. I can imagine that `DataURI` might be used in other places, so
>>
On Fri, 4 Jun 2021 22:03:26 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
On Sat, 5 Jun 2021 14:56:15 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/DataURI.java line
>> 47:
>>
>>> 45: }
>>> 46:
>>> 47: int firstNonWhitespace = 0, length = uri.length();
>>
>> Why do you need to trim leading spaces? The input
This is a clean backport of a GStreamer audio fix for a regression caused by
the recent GStreamer 1.18.3 update in
[JDK-8262365](https://bugs.openjdk.java.net/browse/JDK-8262365). I tested it on
all three platforms.
-
Commit messages:
- 8268152: gstmpegaudioparse does not provides
On Fri, 4 Jun 2021 21:59:28 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
On Fri, 4 Jun 2021 21:56:32 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
On Fri, 4 Jun 2021 21:54:12 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into feature/image-datauri
>>
>># Conflicts:
>>#
>>
That's a good question, and probably a valid approach.
However, while app developers are certainly used to depending on
third-party libraries for things like additional controls, I think
it's questionable whether it's a good developer experience to needing
to rely on the third-party ecosystem for
Oh, I see. Yes, it looks like you are right. Since Windows is the only
platform using platformWidth (and platformHeight), it might be possible
to refactor it, but only if we can guarantee that (width *
platformScaleX) == platformWidth, which would allow the Windows glass
code to compute it for
On Mon, 24 May 2021 11:56:35 GMT, Jose Pereda wrote:
> ListPropertyBase::bind, SetPropertyBase::bind, MapPropertyBase::bind have a
> check on whether a different instance of the observable is the same, and this
> PR changes that to check against identity.
>
> Tests are included.
This pull req
On Thu, 3 Jun 2021 11:23:25 GMT, Johan Vos wrote:
> Add EGL cursor implementation (Java + native) and the link to low-level
> drivers.
> Fix for JDK-8268120
This pull request has now been integrated.
Changeset: fe81b9cf
Author:Johan Vos
URL:
https://git.openjdk.java.net/jfx/commit/
On Wed, 26 May 2021 16:36:24 GMT, Michael Strauß wrote:
>> This PR adds support for loading images from [inline data
>> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
>> supported by web browsers. This enables developers to package small images
>> in CSS files, rath
I have a question about this.
Why would you make this part of JavaFX directly instead of offering it
as a dependency that people can include in their project?
As far as I know, it is possible to register custom URL handlers in
Java, which should be used automatically by JavaFX assuming it
co
36 matches
Mail list logo
