On Thu, 1 Jul 2021 00:38:25 GMT, Phil Race wrote:
>> This enhancement adds the String property outputFileProperty() to the
>> JobSettings class.
>> The value should be a string that references a local file encoded as a URL.
>> If this is non-null and set to a location that the user has
This PR fixes a long standing issue with the TreeTableView indentation.
In short:
**TreeTableCellSkin** overrides **leftLabelPadding()** to calculate the
indentation (the result of
On Tue, 6 Jul 2021 23:32:23 GMT, Kevin Rushforth wrote:
>> This fix restores the minimum macOS version needed to run JavaFX on x64
>> platforms to 10.10.
>>
>> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
>> bumped the minimum version for macOS on aarch64 to
> This fix restores the minimum macOS version needed to run JavaFX on x64
> platforms to 10.10.
>
> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
> bumped the minimum version for macOS on aarch64 to 11.0 and on x64 to 10.12.
> The change on aarch64 was necessary,
On Tue, 6 Jul 2021 22:33:47 GMT, Kevin Rushforth wrote:
> This fix restores the minimum macOS version needed to run JavaFX on x64
> platforms to 10.10.
>
> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
> bumped the minimum version for macOS on aarch64 to 11.0 and
> This fix restores the minimum macOS version needed to run JavaFX on x64
> platforms to 10.10.
>
> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
> bumped the minimum version for macOS on aarch64 to 11.0 and on x64 to 10.12.
> The change on aarch64 was necessary,
On Tue, 6 Jul 2021 22:01:04 GMT, Kevin Rushforth wrote:
> This fix restores the minimum macOS version needed to run JavaFX on x64
> platforms to 10.10.
>
> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
> bumped the minimum version for macOS on aarch64 to 11.0 and
On Tue, 6 Jul 2021 22:33:47 GMT, Kevin Rushforth wrote:
> This fix restores the minimum macOS version needed to run JavaFX on x64
> platforms to 10.10.
>
> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
> bumped the minimum version for macOS on aarch64 to 11.0 and
This fix restores the minimum macOS version needed to run JavaFX on x64
platforms to 10.10.
The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
bumped the minimum version for macOS on aarch64 to 11.0 and on x64 to 10.12.
The change on aarch64 was necessary, since that
On Tue, 6 Jul 2021 22:01:04 GMT, Kevin Rushforth wrote:
> This fix restores the minimum macOS version needed to run JavaFX on x64
> platforms to 10.10.
>
> The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
> bumped the minimum version for macOS on aarch64 to 11.0 and
This fix restores the minimum macOS version needed to run JavaFX on x64
platforms to 10.10.
The fix for [JDK-8265031](https://bugs.openjdk.java.net/browse/JDK-8265031)
bumped the minimum version for macOS on aarch64 to 11.0 and on x64 to 10.12.
The change on aarch64 was necessary, since that
On Thu, 1 Jul 2021 15:46:53 GMT, Ambarish Rapte wrote:
> We currently use libxml2 version 2.9.10. It should be updated to latest
> stable release, which is version 2.9.12.
> The steps to update libxml are documented in UPDATING.txt.
This pull request has now been integrated.
Changeset:
On Thu, 17 Jun 2021 12:41:56 GMT, Jeanette Winzenburg
wrote:
> The issue is about memory leaks and side-effects (like NPEs) when switching
> skins.
>
> Details (copied from issue for convenience):
>
> memory leak in TextInputControlBehavior:
> - listener accidentally added twice (removed
On Fri, 2 Jul 2021 22:58:02 GMT, Marius Hanl wrote:
>> Okay, went through listener registrations in all behaviors - and they are
>> indeed inconsistent:
>>
>> - some listen to control properties like focused (f.i. Button, Combo):
>> adding strong, often inline listeners
>> - some listen to
On Mon, 5 Jul 2021 13:06:48 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - removed now unused imports
>> - Review adjustments
>
>
> This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null.
>
> ChoiceBox:
> - Null check in **valueProperty()** listener
>
> ComboBox:
> - Null check in **valueProperty()** listener
> - Null check in **ComboBoxListViewSkin#updateValue()**
>
> The tests checks, that no NPE
On Fri, 2 Jul 2021 11:30:30 GMT, Ambarish Rapte wrote:
>> We currently use libxml2 version 2.9.10. It should be updated to latest
>> stable release, which is version 2.9.12.
>> The steps to update libxml are documented in UPDATING.txt.
>
> Ambarish Rapte has updated the pull request
On Tue, 29 Jun 2021 14:21:27 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 18. I will integrate this immediately
> after forking the `jfx17` stabilization branch, which is scheduled for
> Thursday, July 8, 2021 at 16:00 UTC.
>
> ~~Leaving it as `Draft` for now. I'll make
16 and 17-ea builds are already on maven central, e.g. see
https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/
- Johan
On Tue, Jul 6, 2021 at 3:47 PM Chuck Davis wrote:
> Anybody know if Maven central is ever going to be updated for 16 and 17?
>
> On Tue, Jul 6, 2021 at 5:58 AM Kevin
On Tue, 29 Jun 2021 14:21:27 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 18. I will integrate this immediately
> after forking the `jfx17` stabilization branch, which is scheduled for
> Thursday, July 8, 2021 at 16:00 UTC.
>
> ~~Leaving it as `Draft` for now. I'll make
On Tue, 6 Jul 2021 15:07:26 GMT, Florian Kirmaier wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 386:
>>
>>> 384: private GlyphList[] getRuns() {
>>> 385: if (textRuns != null) return textRuns;
>>> 386: if (!isSpan()) {
>>
>> Removing the
On Tue, 6 Jul 2021 14:58:49 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8269921
>> Added a copyright header
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java
> It's "a bit" complicated.
> In some situations, getRuns get's called because listeners on bounds are set.
> This causes TextFlow to layout to compute the runs.
> Afterward, the bounds of the parents get updated.
> This triggers a call to compute bounds - which cascades up to the children.
>
You mean TextFlow (not MultipleSelectionModel), right? This doesn't look
like it has anything to do with selection.
-- Kevin
On 7/6/2021 7:56 AM, Florian Kirmaier wrote:
Hi everyone,
I've developed a fix for an exception in the MultipleSelectionModel.
Can someone look into it?
On Tue, 6 Jul 2021 14:53:24 GMT, Florian Kirmaier wrote:
> It's "a bit" complicated.
> In some situations, getRuns get's called because listeners on bounds are set.
> This causes TextFlow to layout to compute the runs.
> Afterward, the bounds of the parents get updated.
> This triggers a call
It's "a bit" complicated.
In some situations, getRuns get's called because listeners on bounds are set.
This causes TextFlow to layout to compute the runs.
Afterward, the bounds of the parents get updated.
This triggers a call to compute bounds - which cascades up to the children.
When the
Hi everyone,
I've developed a fix for an exception in the MultipleSelectionModel.
Can someone look into it?
https://github.com/openjdk/jfx/pull/564
Greetings Florian Kirmaier
Maybe it's a Netbeans indexing problem then because Netbeans does not see
16GA or 17EA. Thanks for info. Last thing NB sees is 16-ea+6.
On Tue, Jul 6, 2021 at 6:58 AM Kevin Rushforth
wrote:
> [starting a new thread so this doesn't show up as a review comment in
> the PR]
>
> There already are
On Tue, 6 Jul 2021 10:39:40 GMT, Ambarish Rapte wrote:
>> Update JavaFX WebKit to GTK WebKit 2.32 (612.1).
>> There are two separate commits:
>> 1.
>> [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc)
>> : includes only native changes
>> 2.
>>
[starting a new thread so this doesn't show up as a review comment in
the PR]
There already are JavaFX 16 GA artifacts on maven central. Also, there
are JavaFX 17-ea artifacts.
-- Kevin
On 7/6/2021 6:45 AM, Chuck Davis wrote:
Anybody know if Maven central is ever going to be updated for
Anybody know if Maven central is ever going to be updated for 16 and 17?
On Tue, Jul 6, 2021 at 5:58 AM Kevin Rushforth wrote:
> Bump the version number of JavaFX to 18. I will integrate this immediately
> after forking the `jfx17` stabilization branch, which is scheduled for
> Thursday, July
Bump the version number of JavaFX to 18. I will integrate this immediately
after forking the `jfx17` stabilization branch, which is scheduled for
Thursday, July 8, 2021 at 16:00 UTC.
Leaving it as `Draft` for now. I'll make it `rfr` next week.
-
Commit messages:
- 8269597: Change
forgot: the null check for table might have been introduced at some
time due to (arguably illegal, at least unspecified, see
https://bugs.openjdk.java.net/browse/JDK-8269871) precondition of
CellEditEvent requiring a not-null table. If we decide to keep that
requirement (and solve the
fyi: the inconsistently must be resolved (back) to checking for column
!= null in all edit methods. The reason is that the event is fired
onto the column as target, which must be not null. Can be seen in the
test below (concededly very artificial):
@Test
public void
On Thu, 1 Jul 2021 22:03:48 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - remove unwanted file
>> - comment failing test code
>
>
> Update JavaFX WebKit to GTK WebKit 2.32 (612.1).
> There are two separate commits:
> 1.
> [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc)
> : includes only native changes
> 2.
>
Hi Jonathan,
thanks for quick reply :) Yeah, agree that inconsistency looks
unintentional - leaving the question which way to go.
Meanwhile I found the commit that changed the logic for cancel:
since RT-18513 (https://bugs.openjdk.java.net/browse/JDK-8116392 -
ListView stackoverflow) it
Seeing as I wrote the code, I wish I could remember why it is that way, but
I unfortunately can't. My initial instinct is that this was unintentional,
but I can't discount the possibility that a reason exists.
I probably have much earlier versions of the code lying around, so I could
research it
Just noticed an inconsistency in event firing pattern in tableCell's
xxEdit methods:
the pattern in cancel/commit:
if (table != null) {
// create and fire the event
in start:
if (column != null) {
// create and fire the event
usual question: bug or feature? Could
On Thu, 1 Jul 2021 12:38:06 GMT, Jeanette Winzenburg
wrote:
> the bug is an incorrect edit location (for Tree/Table: Tree/TablePosition) in
> edit cancel events - expected is the location at the time the cell edit was
> started, actual was the location of at the time the edit was cancelled.
On Mon, 5 Jul 2021 10:18:15 GMT, Jeanette Winzenburg
wrote:
>> the bug is an incorrect edit location (for Tree/Table: Tree/TablePosition)
>> in edit cancel events - expected is the location at the time the cell edit
>> was started, actual was the location of at the time the edit was
Hi everyone,
I was hunting for some memory leaks, but I think I need some
help/feedback/thoughts on this one.
ticket: https://bugs.openjdk.java.net/browse/JDK-8269907
A unit test can be found in the ticket.
Florian Kirmaier
On Mon, 5 Jul 2021 10:18:15 GMT, Jeanette Winzenburg
wrote:
>> the bug is an incorrect edit location (for Tree/Table: Tree/TablePosition)
>> in edit cancel events - expected is the location at the time the cell edit
>> was started, actual was the location of at the time the edit was
43 matches
Mail list logo
