Re: [External] : Re: Pivot properties [was: Enhancements for JavaFX 18]

2021-08-27 Thread Nir Lisker
The problem I have with additional booleans is that they are not reflected in the transitions, and to a lesser extent in the transforms. I'm going to have to write an implementation and test it out to know how well this works and how much trouble it really saves. And while we could use NaN as an

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-08-27 Thread Kevin Rushforth
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev wrote: > - Added FXMediaPlayer test application. > - This app uses all media APIs and very handy in verifying media builds > during development. > - It can be compiled and run by running "ant" and "ant run" in >

Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
On 8/27/2021 2:47 PM, Jeanette Winzenburg wrote: Zitat von Kevin Rushforth : Yes, it would be great to finally solve this one. It would need someone who is willing and able to to drive it, though. -- Kevin Well, I think myself being both - with a little help of my friends ;)

RFR: 8270107: Open source FXMediaPlayer test app

2021-08-27 Thread Alexander Matveev
- Added FXMediaPlayer test application. - This app uses all media APIs and very handy in verifying media builds during development. - It can be compiled and run by running "ant" and "ant run" in tests/manual/media/FXMediaPlayer. - Commit messages: - 8270107: Open source

Re: Enhancements for JavaFX 18

2021-08-27 Thread Jeanette Winzenburg
Zitat von Kevin Rushforth : Yes, it would be great to finally solve this one. It would need someone who is willing and able to to drive it, though. -- Kevin Well, I think myself being both - with a little help of my friends ;) -- Jeanette On 8/4/2021 2:58 AM, Jeanette Winzenburg

Re: [External] : Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
Btw, I filed the following Enhancement for deprecating GTK 2 for removal: https://bugs.openjdk.java.net/browse/JDK-8273089 And I dug up the bug I had previously filed to remove the unused applet implementation code: https://bugs.openjdk.java.net/browse/JDK-8201538 -- Kevin On 8/27/2021

Re: [External] : Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
Thanks. As a follow-on though, it seems possible that not having GTK 2 support might help in our efforts to support GTK 4 or Wayland, but maybe that's wishful thinking on my part. -- Kevin On 8/27/2021 11:27 AM, Johan Vos wrote: I agree with both suggestions (also with the Wayland one, but

Re: [External] : Re: Enhancements for JavaFX 18

2021-08-27 Thread Johan Vos
I agree with both suggestions (also with the Wayland one, but that indeed belongs in a different thread -- I'm working on that one locally). - Johan On Fri, Aug 27, 2021 at 7:07 PM Kevin Rushforth wrote: > Definitely agree with the first one. Getting rid of the vestigial applet > code in the

Re: RFR: 8272870: Add convenience factory methods for border and background [v2]

2021-08-27 Thread Nir Lisker
On Fri, 27 Aug 2021 14:15:06 GMT, Kevin Rushforth wrote: > I presume you will add some unit tests? Yes, when the implementation is settled upon. - PR: https://git.openjdk.java.net/jfx/pull/610

Re: RFR: 8272870: Add convenience factory methods for border and background [v2]

2021-08-27 Thread Nir Lisker
> Added convenience factory factory methods for Background and Border. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Corrected comment tags - Changes: - all: https://git.openjdk.java.net/jfx/pull/610/files - new:

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v4]

2021-08-27 Thread Jose Pereda
On Fri, 27 Aug 2021 13:05:24 GMT, Kevin Rushforth wrote: >> Initially, this was needed when there was some level of transparency: when >> scrolling the old content was not cleared and you could see it at its old >> position. >> >> For the full transparency case, this is still the case, but

Re: [External] : Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
Definitely agree with the first one. Getting rid of the vestigial applet code in the implementation would be good cleanup. As for the second, I like the idea of deprecating the gtk2 support "for removal" (it's not API, but conceptually it similar). Since gtk2 is no longer supported by any

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v6]

2021-08-27 Thread Jose Pereda
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but > the class is not public. Therefore, public API is needed in `WebView` to > allow developers access to it. > > In line with the `fontSmoothingType` property, this PR provides public > support for setting the

Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
That's an interesting idea, although it's not on our radar. This might be hard to do in a platform-independent way. It's not likely something we would do ourselves, so it would need an owner and we would need to discuss -- Kevin On 8/11/2021 1:10 PM, Dirk Lemmermann wrote: Frosted glas /

Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
We aren't currently planning to do this any time soon, although there does seem to be plenty of interest in the system tray support. -- Kevin On 8/4/2021 7:47 AM, Scott Palmer wrote: +1 to that. I would also like to see some progress with system tray support and microphone & webcam access.

Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
Yes, it would be great to finally solve this one. It would need someone who is willing and able to to drive it, though. -- Kevin On 8/4/2021 2:58 AM, Jeanette Winzenburg wrote: my suggestion would be the longstanding commit-edit-on-focus-lost - solved by an enhancement to the editing api

Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
This is a rather large addition to the properties API, but there seems to be enough interest in it that it might be worth getting to the point of a concrete proposal that we could discuss on the list. I wouldn't expect it for JavaFX 18, since it will almost certainly take longer than that.

Re: Enhancements for JavaFX 18

2021-08-27 Thread Kevin Rushforth
As more of a general comment (not just to you), I wasn't really asking for a laundry list of bugs or enhancements that people would like to see fixed. Rather, I was thinking about the things that were already "in flight" or "on the radar", so we could see about moving some of them forward.

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v4]

2021-08-27 Thread Jose Pereda
On Fri, 27 Aug 2021 13:06:18 GMT, Kevin Rushforth wrote: >> Yes, that makes total sense. >> >> In fact, there was also the need to add a new >> [method](https://github.com/openjdk/jfx/pull/563/files#diff-b80bc720bf639cde38c5197a7619561221abcd34fb9ff7a933f4b932a1f36735R2579) >> in `WebPage`

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v5]

2021-08-27 Thread Jose Pereda
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but > the class is not public. Therefore, public API is needed in `WebView` to > allow developers access to it. > > In line with the `fontSmoothingType` property, this PR provides public > support for setting the

Re: RFR: 8272870: Add convenience factory methods for border and background

2021-08-27 Thread Kevin Rushforth
On Tue, 24 Aug 2021 16:29:11 GMT, Nir Lisker wrote: > Added convenience factory factory methods for Background and Border. The API looks good. I left a couple comments on the javadoc. I presume you will add some unit tests?

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2021-08-27 Thread Kevin Rushforth
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v4]

2021-08-27 Thread Kevin Rushforth
On Fri, 27 Aug 2021 09:32:24 GMT, Jose Pereda wrote: >> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java >> line 459: >> >>> 457: public void setClip(WCRectangle c) { >>> 458: if (!isOpaque) { >>> 459: clearRect((int)c.getX(),

Re: Re-examine the risks of JDK-8264770 breaking third party libraries and applications.

2021-08-27 Thread Michael Strauß
I don't think this is a bug in either JavaFX or ReactFX. See my comment here: https://github.com/FXMisc/Flowless/pull/98#discussion_r697393606

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v4]

2021-08-27 Thread Jose Pereda
On Wed, 25 Aug 2021 23:24:35 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update cssref.html > > modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java line 615: > >> 613:

RFR: 8269081: Tree/ListViewSkin: must remove flow on dispose

2021-08-27 Thread Jeanette Winzenburg
left-over issue from cleanup of Tree/ListViewSkin: direct children that have been added by the skin must be removed in dispose fixed by removing the flow (which allowed to revert the previous cleanup of event handlers/cellfactory) added tests to verify - constant child count after replacing

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v4]

2021-08-27 Thread Jose Pereda
On Wed, 25 Aug 2021 23:23:00 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update cssref.html > > modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java >

Re: RFR: 8090547: Allow for transparent backgrounds in WebView [v4]

2021-08-27 Thread Jose Pereda
On Wed, 25 Aug 2021 23:49:10 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update cssref.html > > modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 733: > >> 731: